René's URL Explorer Experiment


Title: improvement(search): run Search MCP calls whose arguments have one reading, and log rejected ones by waleedlatif1 · Pull Request #9814 · simstudioai/sim · GitHub

Open Graph Title: improvement(search): run Search MCP calls whose arguments have one reading, and log rejected ones by waleedlatif1 · Pull Request #9814 · simstudioai/sim

X Title: improvement(search): run Search MCP calls whose arguments have one reading, and log rejected ones by waleedlatif1 · Pull Request #9814 · simstudioai/sim

Description: Summary The MCP SDK rejects a tool call whose arguments fail the input schema before the tool runs: the client gets MCP error -32602, spends another round, and nothing is logged on our side. The Search MCP route now rewrites search arguments that fail the schema but have exactly one reading, before the SDK validates them: nativeQueries: [] → omitted a null optional native query field (e.g. kind: null) → omitted a top-level provider that names a provider → the source filter (when source is absent or the same); any other value is still rejected a search filter (startDate, endDate, modifiedAfter, modifiedBefore, sortBy, topK) that every native query carries with the same value → the search's own filter Native queries that disagree on a filter (or where only some carry it) are still rejected, rather than guessing Arguments the schema already accepts reach the SDK unchanged, and tools/list is untouched (no schema or description change, so clients are not asked to re-approve the tools) Logs Knowledge MCP tool input repaired (which repairs) and Knowledge MCP tool input rejected (field paths and issue codes, no values), so rejected calls become visible Type of Change Improvement Testing MCP client bench (Sonnet 5.5, 83 cases): 1.5% of attempts (30 of 1,992) hit a schema rejection on the current code; 13 of the 30 have one reading and are repaired by this change. Paired run against staging: results to follow in a comment New lib/knowledge/mcp/route-handler.protocol.test.ts sends JSON-RPC through the real route, SDK transport and Search MCP server: each repair fails on the base and passes here (each guard reverted and watched go red), both ambiguous-filter cases and a provider value that names no provider stay rejected, and calls to inherited-name tools (constructor, toString, __proto__) get an MCP error, not a 500 bunx vitest run lib/knowledge/mcp (60 passed), biome on changed files; type-check and audits in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary The MCP SDK rejects a tool call whose arguments fail the input schema before the tool runs: the client gets MCP error -32602, spends another round, and nothing is logged on our side. The S...

X Description: Summary The MCP SDK rejects a tool call whose arguments fail the input schema before the tool runs: the client gets MCP error -32602, spends another round, and nothing is logged on our side. The S...

Opengraph URL: https://github.com/simstudioai/sim/pull/9814

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:70d7beef-a53e-e29e-fb34-ad110afb3e58
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CE6:37056B:1AACF8:242410:6AFB9BA8
html-safe-nonce504e0d47c85843030ad9f1749744fdbbb293153651174d20b52f7ef2218b6648
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0U2OjM3MDU2QjoxQUFDRjg6MjQyNDEwOjZBRkI5QkE4IiwidmlzaXRvcl9pZCI6IjkwNzQxODY5MTY1NTg3NzMxNjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf578e69ee712b8678b5601e25a24e36e746384f6b4bdcdecc01b6dafff4ede03
hovercard-subject-tagpull_request:5228399895
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9814/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The MCP SDK rejects a tool call whose arguments fail the input schema before the tool runs: the client gets MCP error -32602, spends another round, and nothing is logged on our side. The S...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3cefd19a936819d82cfb5279d50fb56fe79cb9ec30f0f807e04e89b0c58ffae1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release606800bdb1b81d125fc845bdcc262c9fe063fc8f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9814/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9814%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9814%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9814/files
Reloadhttps://github.com/simstudioai/sim/pull/9814/files
Reloadhttps://github.com/simstudioai/sim/pull/9814/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
improvement/search-mcp-rvt-gapshttps://github.com/simstudioai/sim/tree/improvement/search-mcp-rvt-gaps
Conversation 16 https://github.com/simstudioai/sim/pull/9814
Commits 3 https://github.com/simstudioai/sim/pull/9814/commits
Checks 81 https://github.com/simstudioai/sim/pull/9814/checks
Files changed https://github.com/simstudioai/sim/pull/9814/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9814/files
improvement(search): run Search MCP calls whose arguments have one reading, and log rejected ones https://github.com/simstudioai/sim/pull/9814/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9814/files
b5d32a2 improvement(search): run Search MCP calls whose arguments have one re… waleedlatif1 Nov 9, 2026 https://github.com/simstudioai/sim/pull/9814/commits/b5d32a2a17b026ca494b69aacda3b681cc15a357
4136625 test(search): use the default organization owner mock in the Search M… waleedlatif1 Nov 9, 2026 https://github.com/simstudioai/sim/pull/9814/commits/4136625888a5c91765b6f6a09110b1a063792bbb
50ae020 fix(search): look up tool schemas by own name and map only real provi… waleedlatif1 Nov 9, 2026 https://github.com/simstudioai/sim/pull/9814/commits/50ae0203cb3a7bbe01af06c1d5b508b859298c6d
Clear filters https://github.com/simstudioai/sim/pull/9814/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9814/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9814/files
route-handler.protocol.test.ts https://github.com/simstudioai/sim/pull/9814/files#diff-84f8e2274abce8a4c50884352ebd7ea55081f0dca77c49a8bf55d2215f953873
route-handler.ts https://github.com/simstudioai/sim/pull/9814/files#diff-a691a59c93177d557f8239038e9175f7bd2381c5386f258936c7b410d59b4b3b
tool-arguments.ts https://github.com/simstudioai/sim/pull/9814/files#diff-b4b8e6dc2d5649622aed478088aeb6bb6881ef39a747f0eab3e65d489918999f
apps/sim/lib/knowledge/mcp/route-handler.protocol.test.tshttps://github.com/simstudioai/sim/pull/9814/files#diff-84f8e2274abce8a4c50884352ebd7ea55081f0dca77c49a8bf55d2215f953873
View file https://github.com/simstudioai/sim/blob/50ae0203cb3a7bbe01af06c1d5b508b859298c6d/apps/sim/lib/knowledge/mcp/route-handler.protocol.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9814/{{ revealButtonHref }}
apps/sim/lib/knowledge/mcp/route-handler.tshttps://github.com/simstudioai/sim/pull/9814/files#diff-a691a59c93177d557f8239038e9175f7bd2381c5386f258936c7b410d59b4b3b
View file https://github.com/simstudioai/sim/blob/50ae0203cb3a7bbe01af06c1d5b508b859298c6d/apps/sim/lib/knowledge/mcp/route-handler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9814/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9814/files#diff-a691a59c93177d557f8239038e9175f7bd2381c5386f258936c7b410d59b4b3b
https://github.com/simstudioai/sim/pull/9814/files#diff-a691a59c93177d557f8239038e9175f7bd2381c5386f258936c7b410d59b4b3b
https://github.com/simstudioai/sim/pull/9814/files#diff-a691a59c93177d557f8239038e9175f7bd2381c5386f258936c7b410d59b4b3b
Please reload this pagehttps://github.com/simstudioai/sim/pull/9814/files
https://github.com/simstudioai/sim/pull/9814/files#diff-a691a59c93177d557f8239038e9175f7bd2381c5386f258936c7b410d59b4b3b
apps/sim/lib/knowledge/mcp/tool-arguments.tshttps://github.com/simstudioai/sim/pull/9814/files#diff-b4b8e6dc2d5649622aed478088aeb6bb6881ef39a747f0eab3e65d489918999f
View file https://github.com/simstudioai/sim/blob/50ae0203cb3a7bbe01af06c1d5b508b859298c6d/apps/sim/lib/knowledge/mcp/tool-arguments.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9814/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/9814/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9814/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.