René's URL Explorer Experiment


Title: fix(sandbox): drop in-flight fetches once the pool gives up or the time budget passes by waleedlatif1 · Pull Request #9793 · simstudioai/sim · GitHub

Open Graph Title: fix(sandbox): drop in-flight fetches once the pool gives up or the time budget passes by waleedlatif1 · Pull Request #9793 · simstudioai/sim

X Title: fix(sandbox): drop in-flight fetches once the pool gives up or the time budget passes by waleedlatif1 · Pull Request #9793 · simstudioai/sim

Description: Summary The pool brokers sandbox fetch() on the app side. When it gave up on an execution (host timeout, caller abort, worker loss), the outbound request kept running. The only limit was the script-settable idle timeout, which a slow-drip server keeps resetting. The owner's execution slot was already free, so per-owner limits didn't cover these requests Replace the cancelled flag on each pending execution with an abort controller that fires on every give-up path. Pass it into secureFetchWithValidation, which already honors signal through DNS validation and the pinned request Cap each fetch at the execution's own host time budget (timeoutMs + 1s grace), via AbortSignal.any([abort, AbortSignal.timeout(...)]). The pool gives up on the execution no later than that, so the cap never fires while the execution is alive. It only bounds a fetch the script left running after returning, whose response nothing can read Deliberately not aborted on a normal result: a fire-and-forget request (e.g. a webhook POST) is still sent. Only the wait for its unread response is bounded A per-fetch composite signal keeps abort listeners off the shared per-execution signal, so fan-out (Promise.all of many fetches) can't trip MaxListenersExceededWarning or pile up stale redirect-hop listeners on it Type of Change Bug fix (security / resource) Testing test-isolated-vm-remote-e2e.ts: 4 new checks against a server that never answers: timed-out execution: the fetch, started late in the run, is dropped within 400ms of the timeout cancelled execution worker killed mid-fetch script returns with a POST still in flight: the request reaches the server and is dropped after the time budget 25/25 pass. Removing each guard on its own turns exactly its own check red: timeout abort, cancel abort, worker-loss abort, time cap. All four new checks fail on staging AbortSignal.any + AbortSignal.timeout behave identically under Node 22 and Bun isolated-vm.test.ts + isolated-vm-worker-hardening.test.ts 28/28; biome, check:test-patterns, check:comment-hygiene, check:utils, check:boundaries, check:source-conventions; full gate left to CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary The pool brokers sandbox fetch() on the app side. When it gave up on an execution (host timeout, caller abort, worker loss), the outbound request kept running. The only limit was the scrip...

X Description: Summary The pool brokers sandbox fetch() on the app side. When it gave up on an execution (host timeout, caller abort, worker loss), the outbound request kept running. The only limit was the scrip...

Opengraph URL: https://github.com/simstudioai/sim/pull/9793

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:df964a9d-402d-a549-fe57-9063f5e9e13e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC31E:265430:A4EB88:E1E248:6AFBDCC7
html-safe-noncef0a83e70f09a98ed54866f287a8eae694be5d84d9ec533f5225a33e16db1865c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzFFOjI2NTQzMDpBNEVCODg6RTFFMjQ4OjZBRkJEQ0M3IiwidmlzaXRvcl9pZCI6IjU0MTk3NDE2ODE2NjE5NDM3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5165cf54bc437b39b782938314b6bd6a564b70bad394b903525e23ee2b10b2b4
hovercard-subject-tagpull_request:5206319952
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9793/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The pool brokers sandbox fetch() on the app side. When it gave up on an execution (host timeout, caller abort, worker loss), the outbound request kept running. The only limit was the scrip...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None18742cb872ec73544356e60359266b67aafece70c4ce008042e06227924cdd07
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release820be804f18e1ef3940bd74a00d41d73d02e2b91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9793/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9793%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9793%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9793/files
Reloadhttps://github.com/simstudioai/sim/pull/9793/files
Reloadhttps://github.com/simstudioai/sim/pull/9793/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/ivm-abort-abandoned-fetcheshttps://github.com/simstudioai/sim/tree/fix/ivm-abort-abandoned-fetches
Conversation 14 https://github.com/simstudioai/sim/pull/9793
Commits 4 https://github.com/simstudioai/sim/pull/9793/commits
Checks 80 https://github.com/simstudioai/sim/pull/9793/checks
Files changed https://github.com/simstudioai/sim/pull/9793/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9793/files
fix(sandbox): drop in-flight fetches once the pool gives up or the time budget passes https://github.com/simstudioai/sim/pull/9793/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/9793/files
de54b9a fix(sandbox): drop in-flight fetches once the pool gives up or the ti… waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9793/commits/de54b9a87071db4e56f4e7adc0d0ddd123b959c9
248c12b fix(sandbox): use manual resolvers in the stalled-server e2e helper waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9793/commits/248c12b322b36e0059e98dd1f99e7a2cd9746ddb
1bfe3f3 fix(sandbox): drop in-flight fetches when the isolate reports a timeout waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9793/commits/1bfe3f3d67bf822b9e0127f54e09f01a73814070
88442a2 test(sandbox): pin that a fire-and-forget fetch survives a normal return waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9793/commits/88442a212ea0fc3c0f173e1851123ec05edee0f4
Clear filters https://github.com/simstudioai/sim/pull/9793/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9793/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9793/files
isolated-vm.ts https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
test-isolated-vm-remote-e2e.ts https://github.com/simstudioai/sim/pull/9793/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
apps/sim/lib/execution/isolated-vm.tshttps://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
View file https://github.com/simstudioai/sim/blob/88442a212ea0fc3c0f173e1851123ec05edee0f4/apps/sim/lib/execution/isolated-vm.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9793/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
Please reload this pagehttps://github.com/simstudioai/sim/pull/9793/files
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9793/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
apps/sim/scripts/test-isolated-vm-remote-e2e.tshttps://github.com/simstudioai/sim/pull/9793/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
View file https://github.com/simstudioai/sim/blob/88442a212ea0fc3c0f173e1851123ec05edee0f4/apps/sim/scripts/test-isolated-vm-remote-e2e.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9793/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9793/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
Please reload this pagehttps://github.com/simstudioai/sim/pull/9793/files
https://github.com/simstudioai/sim/pull/9793/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
Please reload this pagehttps://github.com/simstudioai/sim/pull/9793/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.