René's URL Explorer Experiment


Title: fix(oauth): confirm workspace connect links before starting the connection by waleedlatif1 · Pull Request #9792 · simstudioai/sim · GitHub

Open Graph Title: fix(oauth): confirm workspace connect links before starting the connection by waleedlatif1 · Pull Request #9792 · simstudioai/sim

X Title: fix(oauth): confirm workspace connect links before starting the connection by waleedlatif1 · Pull Request #9792 · simstudioai/sim

Description: Summary A workspace connect link (/api/auth/oauth2/authorize?providerId=&workspaceId=[&credentialId=], and the Instagram equivalent) used to create the connection draft on the GET itself. Anyone can craft that link, and a same-origin hop launders it past the cross-site check from #9772: email sign-in navigating to callbackUrl, or client-side redirects such as /oauth/chat-complete?returnTo= The link now only redirects to a new /oauth/connect confirmation page, which shows the provider and the signed-in account. Continue POSTs to the new internal POST /api/credentials/connections route (session auth, existing createCredentialConnection use case), which creates the user-bound draft. The page then launches authorize?draftId= with the original callbackURL. This follows the gesture-gate pattern /desktop/auth uses The authorize route now only launches drafts. This removes the GET-time mutation, its error-code redirects (nothing reads them), the #9772/#9788 header checks, and a dead QuickBooks draft re-fetch A draft launch sends provider failures to the status page only when the caller didn't name its own return page. Chat chips keep landing on the provider error page they watch for Existing producers keep working unchanged: desktop chips, agent-generated links and chat chips. Signed-out links still continue after sign-in, now including social and SSO sign-in, which #9772 rejected Type of Change Bug fix Testing Authorize and Instagram route tests: a connect link redirects to the confirmation page without launching anything, even when same-origin. The error callback applies only without a caller return page. All three new tests are red on the pre-fix routes oauth2/authorize, instagram/authorize and proxy tests (92 passing), check:api-validation:strict, biome; the full audit suite and type-check run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary A workspace connect link (/api/auth/oauth2/authorize?providerId=&workspaceId=[&credentialId=], and the Instagram equivalent) used to create the connection draft on the GET itself. ...

X Description: Summary A workspace connect link (/api/auth/oauth2/authorize?providerId=&workspaceId=[&credentialId=], and the Instagram equivalent) used to create the connection draft on the GET ...

Opengraph URL: https://github.com/simstudioai/sim/pull/9792

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4c23582c-89a2-d142-6000-415fd08b2560
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA494:2833F1:1C28B86:262DCDC:6AFB94FF
html-safe-nonced37cfd4ab821a538336239ddc344ba09c019254d83d2262a05a13f55a15702f0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDk0OjI4MzNGMToxQzI4Qjg2OjI2MkRDREM6NkFGQjk0RkYiLCJ2aXNpdG9yX2lkIjoiNTU4NzU4MzIzNjQ3NDM3NzQ3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4cbb5cfff26da36d55e95e3a210f2de90af3d135ff29df2dc072f22f82defcea
hovercard-subject-tagpull_request:5206201296
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9792/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A workspace connect link (/api/auth/oauth2/authorize?providerId=&workspaceId=[&credentialId=], and the Instagram equivalent) used to create the connection draft on the GET itself. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4f01efe06174a5ba6342fd58e42d02295e0675bedbb465d6bef2dbaec8e46556
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea52db8866b6543b4e83730cd6a6b1360f1a9e4dc
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9792/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9792%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9792%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9792/files
Reloadhttps://github.com/simstudioai/sim/pull/9792/files
Reloadhttps://github.com/simstudioai/sim/pull/9792/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/oauth-launch-confirmhttps://github.com/simstudioai/sim/tree/fix/oauth-launch-confirm
Conversation 8 https://github.com/simstudioai/sim/pull/9792
Commits 2 https://github.com/simstudioai/sim/pull/9792/commits
Checks 83 https://github.com/simstudioai/sim/pull/9792/checks
Files changed https://github.com/simstudioai/sim/pull/9792/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9792/files
fix(oauth): confirm workspace connect links before starting the connection https://github.com/simstudioai/sim/pull/9792/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9792/files
47e785c fix(oauth): confirm workspace connect links before starting the conne… waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9792/commits/47e785c9c0b7f87359019648104adc6dc8495c40
77dc1ca fix(oauth): send an expired session back through sign-in from the con… waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9792/commits/77dc1cad15929cce402fa881cf3aec5a86f98094
Clear filters https://github.com/simstudioai/sim/pull/9792/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9792/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9792/files
auth-redirect.ts https://github.com/simstudioai/sim/pull/9792/files#diff-1dc3d272ca93026bf14d82421a5e2b9d8fc797dae991b503a34a5aef6510c5bc
route.test.ts https://github.com/simstudioai/sim/pull/9792/files#diff-a8151677ff731629dd2cb64b1d128df1972685d8957218ce7dd4c7bc7da26eef
route.ts https://github.com/simstudioai/sim/pull/9792/files#diff-2f45e04410a16b9f5c12cda9aaa3180b695c3a323fefd2b39ad1126783c9e38e
route.test.ts https://github.com/simstudioai/sim/pull/9792/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
route.ts https://github.com/simstudioai/sim/pull/9792/files#diff-690aef508a6cd9bcc0f70231e76cf03086632ee1cb21c3ab0cc75ac8bc984504
route.ts https://github.com/simstudioai/sim/pull/9792/files#diff-27be4eb443a891e0f1982bd9cc4b5408709d5f2f497ddf1b0a044a3782c1dbe4
connect-confirmation.tsx https://github.com/simstudioai/sim/pull/9792/files#diff-16b38e4ac5e81aeeb361b5e8e51c05450b91a059be44169375d6e6aa7241ee55
page.tsx https://github.com/simstudioai/sim/pull/9792/files#diff-2aabcfd9ab48681025ad7abdc58c904e896f5f9e699137cd601ef0425257765c
credentials.ts https://github.com/simstudioai/sim/pull/9792/files#diff-e20031e06ae36740789df42928e1b5c9ef18f4c8d600c332cedf178914269e52
connection-target.ts https://github.com/simstudioai/sim/pull/9792/files#diff-409fab8ff61d4349292a73e62a6cb7d3e4dfecb04d579dbd1e9a61f31a152fdd
check-test-types.baseline.json https://github.com/simstudioai/sim/pull/9792/files#diff-3f0e52298332b82e821be5c9210ddb89bb43ab248c2db79c27e6a783dbfe9e36
apps/sim/app/(auth)/auth-redirect.tshttps://github.com/simstudioai/sim/pull/9792/files#diff-1dc3d272ca93026bf14d82421a5e2b9d8fc797dae991b503a34a5aef6510c5bc
View file https://github.com/simstudioai/sim/blob/77dc1cad15929cce402fa881cf3aec5a86f98094/apps/sim/app/(auth)/auth-redirect.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9792/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9792/files#diff-1dc3d272ca93026bf14d82421a5e2b9d8fc797dae991b503a34a5aef6510c5bc
https://github.com/simstudioai/sim/pull/9792/files#diff-1dc3d272ca93026bf14d82421a5e2b9d8fc797dae991b503a34a5aef6510c5bc
apps/sim/app/api/auth/instagram/authorize/route.test.tshttps://github.com/simstudioai/sim/pull/9792/files#diff-a8151677ff731629dd2cb64b1d128df1972685d8957218ce7dd4c7bc7da26eef
View file https://github.com/simstudioai/sim/blob/77dc1cad15929cce402fa881cf3aec5a86f98094/apps/sim/app/api/auth/instagram/authorize/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9792/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9792/files#diff-a8151677ff731629dd2cb64b1d128df1972685d8957218ce7dd4c7bc7da26eef
https://github.com/simstudioai/sim/pull/9792/files#diff-a8151677ff731629dd2cb64b1d128df1972685d8957218ce7dd4c7bc7da26eef
https://github.com/simstudioai/sim/pull/9792/files#diff-a8151677ff731629dd2cb64b1d128df1972685d8957218ce7dd4c7bc7da26eef
apps/sim/app/api/auth/instagram/authorize/route.tshttps://github.com/simstudioai/sim/pull/9792/files#diff-2f45e04410a16b9f5c12cda9aaa3180b695c3a323fefd2b39ad1126783c9e38e
View file https://github.com/simstudioai/sim/blob/77dc1cad15929cce402fa881cf3aec5a86f98094/apps/sim/app/api/auth/instagram/authorize/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9792/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9792/files#diff-2f45e04410a16b9f5c12cda9aaa3180b695c3a323fefd2b39ad1126783c9e38e
https://github.com/simstudioai/sim/pull/9792/files#diff-2f45e04410a16b9f5c12cda9aaa3180b695c3a323fefd2b39ad1126783c9e38e
https://github.com/simstudioai/sim/pull/9792/files#diff-2f45e04410a16b9f5c12cda9aaa3180b695c3a323fefd2b39ad1126783c9e38e
https://github.com/simstudioai/sim/pull/9792/files#diff-2f45e04410a16b9f5c12cda9aaa3180b695c3a323fefd2b39ad1126783c9e38e
https://github.com/simstudioai/sim/pull/9792/files#diff-2f45e04410a16b9f5c12cda9aaa3180b695c3a323fefd2b39ad1126783c9e38e
apps/sim/app/api/auth/oauth2/authorize/route.test.tshttps://github.com/simstudioai/sim/pull/9792/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
View file https://github.com/simstudioai/sim/blob/77dc1cad15929cce402fa881cf3aec5a86f98094/apps/sim/app/api/auth/oauth2/authorize/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9792/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9792/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
https://github.com/simstudioai/sim/pull/9792/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
https://github.com/simstudioai/sim/pull/9792/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
https://github.com/simstudioai/sim/pull/9792/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
https://github.com/simstudioai/sim/pull/9792/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
https://github.com/simstudioai/sim/pull/9792/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
Please reload this pagehttps://github.com/simstudioai/sim/pull/9792/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9792/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.