René's URL Explorer Experiment


Title: fix(sandbox): cap task timer bridges and dispose isolates on host timeout by waleedlatif1 · Pull Request #9776 · simstudioai/sim · GitHub

Open Graph Title: fix(sandbox): cap task timer bridges and dispose isolates on host timeout by waleedlatif1 · Pull Request #9776 · simstudioai/sim

X Title: fix(sandbox): cap task timer bridges and dispose isolates on host timeout by waleedlatif1 · Pull Request #9776 · simstudioai/sim

Description: Summary Task-mode setTimeout/setInterval bridges in the isolated-vm worker kept a Node Timeout, a Map entry, and an ivm.Reference per call on the shared worker heap with no count limit — outside the isolate's 128 MB memoryLimit. One document-generation or workflow-test script could grow worker RSS without bound or starve the worker's event loop for every co-tenant execution on it Cap each task execution at 1000 pending timers and 50 active intervals; the bridge throws a RangeError back into the isolate (no host frames in the stack) and releases the callback reference On host timeout, send the existing cancel IPC to the worker. A never-settling promise escapes isolated-vm's script timeout, so the worker kept the isolate (and its live intervals) running until the worker retired — on both the task and Function-block paths Skipped the suggested interval period floor and firing-count cap: zero-delay setTimeout chains already reach the same rate, so the floor only changes behavior for legitimate setInterval(fn, 1) callers Type of Change Bug fix (security) Testing Verified against the real worker process before and after (scratch harness that forks isolated-vm-worker.cjs over IPC): Before: for (...) setTimeout(f, 60000) grew worker RSS ~80 MB/s, past 2.5 GB at 30s, well beyond the script timeout. 20k setInterval(f, 1) starved the worker — 20 trivial co-tenant executions did not finish within 60s After: the flood stops at the cap in <100ms; co-tenant latency median 4ms / max 6ms under the interval flood, 3ms / 3ms under the worst load the caps allow (1000 zero-delay chains + 50 intervals), same as idle Hung task with a busy interval, local pool: worker CPU in the 3s after timeout went from 2060ms to 0ms; the worker keeps serving Reverted each guard separately (timeout cap, interval cap, interval decrement on clear) and watched its case go red Real docx-generate (2000 paragraphs), pptx-generate (200 slides, JSZip setImmediate chains), pdf-generate (200 pages) through runSandboxTask: valid output, timings unchanged vs staging New isolated-vm.test.ts case (host sends cancel on timeout) red before / green after; isolated-vm.test.ts + isolated-vm-worker-hardening.test.ts 28/28 test-isolated-vm-remote-e2e.ts: new check "caps the timers a task may hold on the shared worker"; all 21 checks pass, new check fails on the staging worker biome, check:test-patterns, check:comment-hygiene, check:utils, check:boundaries; full gate left to CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary Task-mode setTimeout/setInterval bridges in the isolated-vm worker kept a Node Timeout, a Map entry, and an ivm.Reference per call on the shared worker heap with no count limit — outside t...

X Description: Summary Task-mode setTimeout/setInterval bridges in the isolated-vm worker kept a Node Timeout, a Map entry, and an ivm.Reference per call on the shared worker heap with no count limit — outside t...

Opengraph URL: https://github.com/simstudioai/sim/pull/9776

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ecb9e0f0-2b10-2d41-a03c-a4597db66239
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC96:210607:31BA65:45E641:6AFB714E
html-safe-nonced203048568dadcef77156b9c401ba3d4f725eb2af5c63f257fdb06250dceca18
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzk2OjIxMDYwNzozMUJBNjU6NDVFNjQxOjZBRkI3MTRFIiwidmlzaXRvcl9pZCI6IjI2MTMxNzg2MjU3NTg1NTY0OTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca68b288ab3db606e0e381933bd2d3968c8c1d9bfdf2fcdd7c46397730fcc3d7e
hovercard-subject-tagpull_request:5205455650
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9776/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Task-mode setTimeout/setInterval bridges in the isolated-vm worker kept a Node Timeout, a Map entry, and an ivm.Reference per call on the shared worker heap with no count limit — outside t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9776/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9776%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9776%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9776/files
Reloadhttps://github.com/simstudioai/sim/pull/9776/files
Reloadhttps://github.com/simstudioai/sim/pull/9776/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/ivm-task-timer-caphttps://github.com/simstudioai/sim/tree/fix/ivm-task-timer-cap
Conversation 8 https://github.com/simstudioai/sim/pull/9776
Commits 3 https://github.com/simstudioai/sim/pull/9776/commits
Checks 80 https://github.com/simstudioai/sim/pull/9776/checks
Files changed https://github.com/simstudioai/sim/pull/9776/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9776/files
fix(sandbox): cap task timer bridges and dispose isolates on host timeout https://github.com/simstudioai/sim/pull/9776/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9776/files
4944ed5 fix(sandbox): cap task timer bridges and dispose isolates on host tim… waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9776/commits/4944ed5b184200b0c6582aa99a5749160f710c85
d43ee2f improvement(sandbox): share timer admission and worker cancel helpers waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9776/commits/d43ee2fbbe06eaf5145dda5c530c489504cbbabb
4287ab2 improvement(sandbox): cover interval reuse in the timer cap e2e check waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9776/commits/4287ab28445925698cd8e20abb6173154d3f9897
Clear filters https://github.com/simstudioai/sim/pull/9776/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9776/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9776/files
isolated-vm-worker.cjs https://github.com/simstudioai/sim/pull/9776/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
isolated-vm.test.ts https://github.com/simstudioai/sim/pull/9776/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
isolated-vm.ts https://github.com/simstudioai/sim/pull/9776/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
test-isolated-vm-remote-e2e.ts https://github.com/simstudioai/sim/pull/9776/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
apps/sim/lib/execution/isolated-vm-worker.cjshttps://github.com/simstudioai/sim/pull/9776/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
View file https://github.com/simstudioai/sim/blob/4287ab28445925698cd8e20abb6173154d3f9897/apps/sim/lib/execution/isolated-vm-worker.cjs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9776/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9776/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
https://github.com/simstudioai/sim/pull/9776/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
https://github.com/simstudioai/sim/pull/9776/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
https://github.com/simstudioai/sim/pull/9776/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
https://github.com/simstudioai/sim/pull/9776/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
https://github.com/simstudioai/sim/pull/9776/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
apps/sim/lib/execution/isolated-vm.test.tshttps://github.com/simstudioai/sim/pull/9776/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
View file https://github.com/simstudioai/sim/blob/4287ab28445925698cd8e20abb6173154d3f9897/apps/sim/lib/execution/isolated-vm.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9776/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9776/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
https://github.com/simstudioai/sim/pull/9776/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
https://github.com/simstudioai/sim/pull/9776/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
https://github.com/simstudioai/sim/pull/9776/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
https://github.com/simstudioai/sim/pull/9776/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
https://github.com/simstudioai/sim/pull/9776/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
apps/sim/lib/execution/isolated-vm.tshttps://github.com/simstudioai/sim/pull/9776/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
View file https://github.com/simstudioai/sim/blob/4287ab28445925698cd8e20abb6173154d3f9897/apps/sim/lib/execution/isolated-vm.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9776/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9776/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9776/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9776/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9776/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9776/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/9776/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
apps/sim/scripts/test-isolated-vm-remote-e2e.tshttps://github.com/simstudioai/sim/pull/9776/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
View file https://github.com/simstudioai/sim/blob/4287ab28445925698cd8e20abb6173154d3f9897/apps/sim/scripts/test-isolated-vm-remote-e2e.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9776/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9776/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
https://github.com/simstudioai/sim/pull/9776/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
https://github.com/simstudioai/sim/pull/9776/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
https://github.com/simstudioai/sim/pull/9776/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
https://github.com/simstudioai/sim/pull/9776/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
https://github.com/simstudioai/sim/pull/9776/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
Please reload this pagehttps://github.com/simstudioai/sim/pull/9776/files
https://github.com/simstudioai/sim/pull/9776/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
Please reload this pagehttps://github.com/simstudioai/sim/pull/9776/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.