| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:21acd84a-700f-854e-4006-90887cf94078 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B1C4:BD772:1B46314:250ABEC:6AFB90C3 |
| html-safe-nonce | 95ee40cfa82a8d1f9c5f5b37b2cc52023fa740feb49eb196f29a586f4bc6bd67 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUM0OkJENzcyOjFCNDYzMTQ6MjUwQUJFQzo2QUZCOTBDMyIsInZpc2l0b3JfaWQiOiI5MDM1MjY1NTQwNjcwMzI5MDI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 86c93262ad436c1d078b0bfcf5581cea27f6ce56dea253a7d6adffe9285a24d5 |
| hovercard-subject-tag | pull_request:5205314367 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9774/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary
Chat and public file OTP verify read the attempt count, compared the guess, then incremented. Concurrent submissions all passed the limit check on the same stale count, so every in-flight ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4f01efe06174a5ba6342fd58e42d02295e0675bedbb465d6bef2dbaec8e46556 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a52db8866b6543b4e83730cd6a6b1360f1a9e4dc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/simstudioai/sim/pull/9774/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9774%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9774%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim |
| Reload | https://github.com/simstudioai/sim/pull/9774/files |
| Reload | https://github.com/simstudioai/sim/pull/9774/files |
| Reload | https://github.com/simstudioai/sim/pull/9774/files |
| simstudioai | https://github.com/simstudioai |
| sim | https://github.com/simstudioai/sim |
| Code | https://github.com/simstudioai/sim |
| Issues129 (129) | https://github.com/simstudioai/sim/issues |
| Pull requests198 (198) | https://github.com/simstudioai/sim/pulls |
| Actions | https://github.com/simstudioai/sim/actions |
| Projects | https://github.com/simstudioai/sim/projects |
| Security and quality | https://github.com/simstudioai/sim/security |
| Insights | https://github.com/simstudioai/sim/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose |
| waleedlatif1 | https://github.com/waleedlatif1 |
| staging | https://github.com/simstudioai/sim/tree/staging |
| fix/otp-verify-atomic-attempts | https://github.com/simstudioai/sim/tree/fix/otp-verify-atomic-attempts |
|
Conversation
24
| https://github.com/simstudioai/sim/pull/9774 |
|
Commits
4
| https://github.com/simstudioai/sim/pull/9774/commits |
|
Checks
81
| https://github.com/simstudioai/sim/pull/9774/checks |
|
Files changed
| https://github.com/simstudioai/sim/pull/9774/files |
| Please reload this page | https://github.com/simstudioai/sim/pull/9774/files |
|
fix(otp): reserve a verification attempt atomically before comparing the code
| https://github.com/simstudioai/sim/pull/9774/files#top |
|
Show all changes
4 commits
| https://github.com/simstudioai/sim/pull/9774/files |
|
5daef70
fix(otp): reserve a verification attempt atomically before comparing …
waleedlatif1 Nov 7, 2026
| https://github.com/simstudioai/sim/pull/9774/commits/5daef703ae7533e4d80a4ae7981e183a473eaa0e |
|
9615cb6
improvement(otp): centralize compare-and-consume in verifyOTP, tighte…
waleedlatif1 Nov 7, 2026
| https://github.com/simstudioai/sim/pull/9774/commits/9615cb65907d26b349539935104a8d479ccb2ee7 |
|
5c7a2ba
fix(otp): keep sub-second code lifetimes and drop unused deleteOTP ex…
waleedlatif1 Nov 7, 2026
| https://github.com/simstudioai/sim/pull/9774/commits/5c7a2badebf9795884970b174683b96a3402f403 |
|
5a003bb
test(otp): prove rejected verify requests never spend the code agains…
waleedlatif1 Nov 7, 2026
| https://github.com/simstudioai/sim/pull/9774/commits/5a003bba90b367215bf12aa49beb6611fedf389f |
|
Clear filters
| https://github.com/simstudioai/sim/pull/9774/files |
| Please reload this page | https://github.com/simstudioai/sim/pull/9774/files |
| Please reload this page | https://github.com/simstudioai/sim/pull/9774/files |
|
route.integration.ts
| https://github.com/simstudioai/sim/pull/9774/files#diff-c22fe4596b21f2eda0fb0adcced972aeb84adedb03cf168e0b746d2cc2648db5 |
|
route.test.ts
| https://github.com/simstudioai/sim/pull/9774/files#diff-426f0cc11fcb02d3b9ab0d35eaa6decce992f6cd5242e6d19a74df4a2029cf79 |
|
route.ts
| https://github.com/simstudioai/sim/pull/9774/files#diff-a13d9967f4a5ea9e418cd26f50714ea88964dd7a294e6781327e9a57fc4a5c36 |
|
otp.ts
| https://github.com/simstudioai/sim/pull/9774/files#diff-01e8b7bcdb38e55e7190dee29cc6b722cdb479541a2cc02ce34139f55de01270 |
|
content-sharing.integration.ts
| https://github.com/simstudioai/sim/pull/9774/files#diff-246a1d9cc5d6365f46fac496407977a11971d39e827252e64b7f475b020aa4fa |
|
credentials.ts
| https://github.com/simstudioai/sim/pull/9774/files#diff-4dd76c8ca98cf5952e6a9e55e619898764a7eb3e2e059eb003301ecc865fe62e |
| apps/sim/app/api/chat/[identifier]/otp/route.integration.ts | https://github.com/simstudioai/sim/pull/9774/files#diff-c22fe4596b21f2eda0fb0adcced972aeb84adedb03cf168e0b746d2cc2648db5 |
|
View file
| https://github.com/simstudioai/sim/blob/5a003bba90b367215bf12aa49beb6611fedf389f/apps/sim/app/api/chat/%5Bidentifier%5D/otp/route.integration.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/simstudioai/sim/pull/9774/{{ revealButtonHref }} |
| Please reload this page | https://github.com/simstudioai/sim/pull/9774/files |
| apps/sim/app/api/chat/[identifier]/otp/route.test.ts | https://github.com/simstudioai/sim/pull/9774/files#diff-426f0cc11fcb02d3b9ab0d35eaa6decce992f6cd5242e6d19a74df4a2029cf79 |
|
View file
| https://github.com/simstudioai/sim/blob/5a003bba90b367215bf12aa49beb6611fedf389f/apps/sim/app/api/chat/%5Bidentifier%5D/otp/route.test.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/simstudioai/sim/pull/9774/{{ revealButtonHref }} |
|
| https://github.com/simstudioai/sim/pull/9774/files#diff-426f0cc11fcb02d3b9ab0d35eaa6decce992f6cd5242e6d19a74df4a2029cf79 |
|
| https://github.com/simstudioai/sim/pull/9774/files#diff-426f0cc11fcb02d3b9ab0d35eaa6decce992f6cd5242e6d19a74df4a2029cf79 |
|
| https://github.com/simstudioai/sim/pull/9774/files#diff-426f0cc11fcb02d3b9ab0d35eaa6decce992f6cd5242e6d19a74df4a2029cf79 |
|
| https://github.com/simstudioai/sim/pull/9774/files#diff-426f0cc11fcb02d3b9ab0d35eaa6decce992f6cd5242e6d19a74df4a2029cf79 |
|
| https://github.com/simstudioai/sim/pull/9774/files#diff-426f0cc11fcb02d3b9ab0d35eaa6decce992f6cd5242e6d19a74df4a2029cf79 |
|
| https://github.com/simstudioai/sim/pull/9774/files#diff-426f0cc11fcb02d3b9ab0d35eaa6decce992f6cd5242e6d19a74df4a2029cf79 |
|
| https://github.com/simstudioai/sim/pull/9774/files#diff-426f0cc11fcb02d3b9ab0d35eaa6decce992f6cd5242e6d19a74df4a2029cf79 |
|
| https://github.com/simstudioai/sim/pull/9774/files#diff-426f0cc11fcb02d3b9ab0d35eaa6decce992f6cd5242e6d19a74df4a2029cf79 |
|
| https://github.com/simstudioai/sim/pull/9774/files#diff-426f0cc11fcb02d3b9ab0d35eaa6decce992f6cd5242e6d19a74df4a2029cf79 |
| Please reload this page | https://github.com/simstudioai/sim/pull/9774/files |
| Please reload this page | https://github.com/simstudioai/sim/pull/9774/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |