Title: fix(file-parsers): reject ZIP archives JSZip reads from outside the guarded region by waleedlatif1 · Pull Request #9773 · simstudioai/sim · GitHub
Open Graph Title: fix(file-parsers): reject ZIP archives JSZip reads from outside the guarded region by waleedlatif1 · Pull Request #9773 · simstudioai/sim
X Title: fix(file-parsers): reject ZIP archives JSZip reads from outside the guarded region by waleedlatif1 · Pull Request #9773 · simstudioai/sim
Description: Summary assertOoxmlArchiveWithinLimits anchored on the tail EOCD, assumed the archive starts at offset 0, and silently skipped any buffer not starting with a ZIP signature JSZip (used by mammoth and the Word document helpers) takes the last EOCD signature anywhere in the buffer and rebases past prepended data, so a few junk bytes in front of an archive turned off every size and inflation check while the parser still inflated it in full Guard now rejects any buffer JSZip would read from a different EOCD or base offset than the one it inspected, with ArchiveIntegrityError (same path as other unverifiable archives) Non-ZIP files that just contain the EOCD bytes still no-op: they're only flagged when JSZip would actually find central-directory records Fixes every JSZip consumer behind the guard at once (Word tool read/append/replace, the generic DOCX/ODF upload parsers), so no per-call-site changes ZIP64 is now triggered by any saturated EOCD field (as JSZip and the spec do), not just the count/offset, in the shared locateCentralDirectory, and one readZip64EocdRecord serves both the guard and the JSZip-view check readZipCentralDirectoryStats applies the same check, so the workspace unzip path fails closed alongside the guard Type of Change Bug fix Testing Reproduced on staging: a ~380 KB docx whose word/document.xml expands to 69 MB is rejected plain, passes the guard with an 8-byte prefix, and JSZip/mammoth still read it. With the fix the prefixed copy is rejected New tests in zip-guard.test.ts: prefixed and prefixed + trailing (real JSZip opens them, the guard rejects them; both fail on staging), the ZIP64 trigger (fails on staging and on the first commit), and non-ZIP controls with plain and saturated EOCD-like bytes (the saturated one fails on the first commit) Ran 851 real files (repo fixtures, Office/PDF/JAR/ZIP from dependencies, local Office/PDF docs) through the old and new guard: zero verdict changes for the guard and readZipCentralDirectoryStats bun run test on lib/file-parsers/zip-guard.test.ts and lib/microsoft-word/; earlier run of all lib/file-parsers, lib/microsoft-word, lib/mothership/vfs, lib/uploads, lib/sim-search/live suites green; biome on changed files. Full type-check/audits in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary assertOoxmlArchiveWithinLimits anchored on the tail EOCD, assumed the archive starts at offset 0, and silently skipped any buffer not starting with a ZIP signature JSZip (used by mammoth a...
X Description: Summary assertOoxmlArchiveWithinLimits anchored on the tail EOCD, assumed the archive starts at offset 0, and silently skipped any buffer not starting with a ZIP signature JSZip (used by mammoth a...
Opengraph URL: https://github.com/simstudioai/sim/pull/9773
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e133d66f-da43-fc50-6a51-634e95a0fcf9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ED8A:2E7BAB:1BA81F6:25ADD7C:6AFB99A9 |
| html-safe-nonce | 692683b1b93670269ed8d55dab1aeb26b1f8f7985bf01685a2d74c3f3ab36064 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDhBOjJFN0JBQjoxQkE4MUY2OjI1QUREN0M6NkFGQjk5QTkiLCJ2aXNpdG9yX2lkIjoiNzI0NTczMDg3MDkxNTIwOTY0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 149721c844449b390a6e9a0a5c7ad0f81e8e3da64310d7993761cebda5483ac3 |
| hovercard-subject-tag | pull_request:5205302206 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9773/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary assertOoxmlArchiveWithinLimits anchored on the tail EOCD, assumed the archive starts at offset 0, and silently skipped any buffer not starting with a ZIP signature JSZip (used by mammoth a... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3cefd19a936819d82cfb5279d50fb56fe79cb9ec30f0f807e04e89b0c58ffae1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 606800bdb1b81d125fc845bdcc262c9fe063fc8f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width