René's URL Explorer Experiment


Title: fix(file-parsers): reject ZIP archives JSZip reads from outside the guarded region by waleedlatif1 · Pull Request #9773 · simstudioai/sim · GitHub

Open Graph Title: fix(file-parsers): reject ZIP archives JSZip reads from outside the guarded region by waleedlatif1 · Pull Request #9773 · simstudioai/sim

X Title: fix(file-parsers): reject ZIP archives JSZip reads from outside the guarded region by waleedlatif1 · Pull Request #9773 · simstudioai/sim

Description: Summary assertOoxmlArchiveWithinLimits anchored on the tail EOCD, assumed the archive starts at offset 0, and silently skipped any buffer not starting with a ZIP signature JSZip (used by mammoth and the Word document helpers) takes the last EOCD signature anywhere in the buffer and rebases past prepended data, so a few junk bytes in front of an archive turned off every size and inflation check while the parser still inflated it in full Guard now rejects any buffer JSZip would read from a different EOCD or base offset than the one it inspected, with ArchiveIntegrityError (same path as other unverifiable archives) Non-ZIP files that just contain the EOCD bytes still no-op: they're only flagged when JSZip would actually find central-directory records Fixes every JSZip consumer behind the guard at once (Word tool read/append/replace, the generic DOCX/ODF upload parsers), so no per-call-site changes ZIP64 is now triggered by any saturated EOCD field (as JSZip and the spec do), not just the count/offset, in the shared locateCentralDirectory, and one readZip64EocdRecord serves both the guard and the JSZip-view check readZipCentralDirectoryStats applies the same check, so the workspace unzip path fails closed alongside the guard Type of Change Bug fix Testing Reproduced on staging: a ~380 KB docx whose word/document.xml expands to 69 MB is rejected plain, passes the guard with an 8-byte prefix, and JSZip/mammoth still read it. With the fix the prefixed copy is rejected New tests in zip-guard.test.ts: prefixed and prefixed + trailing (real JSZip opens them, the guard rejects them; both fail on staging), the ZIP64 trigger (fails on staging and on the first commit), and non-ZIP controls with plain and saturated EOCD-like bytes (the saturated one fails on the first commit) Ran 851 real files (repo fixtures, Office/PDF/JAR/ZIP from dependencies, local Office/PDF docs) through the old and new guard: zero verdict changes for the guard and readZipCentralDirectoryStats bun run test on lib/file-parsers/zip-guard.test.ts and lib/microsoft-word/; earlier run of all lib/file-parsers, lib/microsoft-word, lib/mothership/vfs, lib/uploads, lib/sim-search/live suites green; biome on changed files. Full type-check/audits in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary assertOoxmlArchiveWithinLimits anchored on the tail EOCD, assumed the archive starts at offset 0, and silently skipped any buffer not starting with a ZIP signature JSZip (used by mammoth a...

X Description: Summary assertOoxmlArchiveWithinLimits anchored on the tail EOCD, assumed the archive starts at offset 0, and silently skipped any buffer not starting with a ZIP signature JSZip (used by mammoth a...

Opengraph URL: https://github.com/simstudioai/sim/pull/9773

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e133d66f-da43-fc50-6a51-634e95a0fcf9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED8A:2E7BAB:1BA81F6:25ADD7C:6AFB99A9
html-safe-nonce692683b1b93670269ed8d55dab1aeb26b1f8f7985bf01685a2d74c3f3ab36064
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDhBOjJFN0JBQjoxQkE4MUY2OjI1QUREN0M6NkFGQjk5QTkiLCJ2aXNpdG9yX2lkIjoiNzI0NTczMDg3MDkxNTIwOTY0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac149721c844449b390a6e9a0a5c7ad0f81e8e3da64310d7993761cebda5483ac3
hovercard-subject-tagpull_request:5205302206
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9773/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary assertOoxmlArchiveWithinLimits anchored on the tail EOCD, assumed the archive starts at offset 0, and silently skipped any buffer not starting with a ZIP signature JSZip (used by mammoth a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3cefd19a936819d82cfb5279d50fb56fe79cb9ec30f0f807e04e89b0c58ffae1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release606800bdb1b81d125fc845bdcc262c9fe063fc8f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9773/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9773%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9773%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9773/files
Reloadhttps://github.com/simstudioai/sim/pull/9773/files
Reloadhttps://github.com/simstudioai/sim/pull/9773/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/zip-guard-prepended-archivehttps://github.com/simstudioai/sim/tree/fix/zip-guard-prepended-archive
Conversation 21 https://github.com/simstudioai/sim/pull/9773
Commits 3 https://github.com/simstudioai/sim/pull/9773/commits
Checks 80 https://github.com/simstudioai/sim/pull/9773/checks
Files changed https://github.com/simstudioai/sim/pull/9773/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9773/files
fix(file-parsers): reject ZIP archives JSZip reads from outside the guarded region https://github.com/simstudioai/sim/pull/9773/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9773/files
0ecfabc fix(file-parsers): reject ZIP archives JSZip reads from outside the g… waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9773/commits/0ecfabc22a5c77f2b4af5f18a1e8c448c45fede4
556c786 fix(file-parsers): match JSZip's ZIP64 trigger and keep non-ZIP input… waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9773/commits/556c7866d32ef261c4a460390b89b13e272282b5
8065d3c fix(file-parsers): read the JSZip view with JSZip's 32-bit integer se… waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9773/commits/8065d3c43fe2a67bcd55e94965e25e01fb0a1542
Clear filters https://github.com/simstudioai/sim/pull/9773/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9773/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9773/files
zip-guard.test.ts https://github.com/simstudioai/sim/pull/9773/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
zip-guard.ts https://github.com/simstudioai/sim/pull/9773/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
apps/sim/lib/file-parsers/zip-guard.test.tshttps://github.com/simstudioai/sim/pull/9773/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
View file https://github.com/simstudioai/sim/blob/8065d3c43fe2a67bcd55e94965e25e01fb0a1542/apps/sim/lib/file-parsers/zip-guard.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9773/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9773/files#diff-b8a14e85c6ff70831de6efe4b18e53eb3dd16020b3eed3d7139e6b37fa9a4f51
apps/sim/lib/file-parsers/zip-guard.tshttps://github.com/simstudioai/sim/pull/9773/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
View file https://github.com/simstudioai/sim/blob/8065d3c43fe2a67bcd55e94965e25e01fb0a1542/apps/sim/lib/file-parsers/zip-guard.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9773/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9773/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
Please reload this pagehttps://github.com/simstudioai/sim/pull/9773/files
https://github.com/simstudioai/sim/pull/9773/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/9773/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/9773/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/9773/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/9773/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
https://github.com/simstudioai/sim/pull/9773/files#diff-82ff22d430d10a3c394c674c4b75b7ba2ce0b74c14e84fdc08ff7b489015b767
Please reload this pagehttps://github.com/simstudioai/sim/pull/9773/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.