René's URL Explorer Experiment


Title: fix(oauth): reject cross-site workspace OAuth launches by waleedlatif1 · Pull Request #9772 · simstudioai/sim · GitHub

Open Graph Title: fix(oauth): reject cross-site workspace OAuth launches by waleedlatif1 · Pull Request #9772 · simstudioai/sim

X Title: fix(oauth): reject cross-site workspace OAuth launches by waleedlatif1 · Pull Request #9772 · simstudioai/sim

Description: Summary GET /api/auth/oauth2/authorize?providerId=…&workspaceId=…[&credentialId=…] picked the workspace (and, on reconnect, the credential) from the query alone and created a connect draft on the viewer's session. Session cookies are SameSite=Lax, so a cross-site page could navigate a signed-in user there and link their provider account as a credential in a workspace the attacker shares with them, or rebind an existing credential to the victim's account (CSRF on a state-changing GET) Reject that branch when Sec-Fetch-Site is cross-site, before any draft is created, using the existing isCrossSiteSessionRequest helper (same gate as workflow execute) draftId launches are unchanged: drafts are bound to the user who created them, and v2 API callers hand those authorization URLs to users from their own origin In-app (same-origin), www ↔ apex (same-site), and desktop/CLI/address-bar (none) launches still work. A server-side redirect such as /desktop/connect keeps the attacker's page as the initiator, so the browser still sends cross-site The proxy showed the login form to signed-in users for any /api/auth/oauth2/authorize callback, so /login?callbackUrl= turned the launch into a same-origin request after sign-in. That exception now applies only to OAuth client requests (client_id present); a workspace launch callback sends a signed-in user to the app entry Shrinks the check-test-types baseline for the authorize route test (its GET calls now pass createRouteContext({})) Type of Change Bug fix Testing proxy.test.ts: signed-in /login with a workspace-launch callback redirects to the app entry (red before the change); an OAuth client callback still shows the form route.test.ts: cross-site workspace launch is refused with no draft or link call (red on the pre-fix code, confirmed by reverting the guard); a cross-site launch of the user's own draft still reaches the provider (the same-site/none header matrix is owned by same-origin.test.ts) bun run --cwd apps/sim test on authorize/route.test.ts + same-origin.test.ts + proxy.test.ts + app/(auth) suites (107 passed), bun run lint, Phase A generators (no drift); type-check, check:audits and the full suite run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary GET /api/auth/oauth2/authorize?providerId=…&workspaceId=…[&credentialId=…] picked the workspace (and, on reconnect, the credential) from the query alone and created a connect draft...

X Description: Summary GET /api/auth/oauth2/authorize?providerId=…&workspaceId=…[&credentialId=…] picked the workspace (and, on reconnect, the credential) from the query alone and created a conne...

Opengraph URL: https://github.com/simstudioai/sim/pull/9772

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:847d86b7-9797-e4ec-cdb2-bc934d0c9706
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD42:FBC06:1C12BE2:2638468:6AFB9B54
html-safe-nonce46651f60de421b491c51911e66fb85051cbc484d01a408586a8404daf72ca345
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDQyOkZCQzA2OjFDMTJCRTI6MjYzODQ2ODo2QUZCOUI1NCIsInZpc2l0b3JfaWQiOiI3Nzk1Nzc1OTc2NjIwMzk5NDQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac098d0d9b93cdcd0e6f3ecc1656e92627fc2662e22dafe746936bba426140fa8d
hovercard-subject-tagpull_request:5205281181
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9772/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary GET /api/auth/oauth2/authorize?providerId=…&workspaceId=…[&credentialId=…] picked the workspace (and, on reconnect, the credential) from the query alone and created a connect draft...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3cefd19a936819d82cfb5279d50fb56fe79cb9ec30f0f807e04e89b0c58ffae1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release606800bdb1b81d125fc845bdcc262c9fe063fc8f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9772/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9772%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9772%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9772/files
Reloadhttps://github.com/simstudioai/sim/pull/9772/files
Reloadhttps://github.com/simstudioai/sim/pull/9772/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/oauth-authorize-csrfhttps://github.com/simstudioai/sim/tree/fix/oauth-authorize-csrf
Conversation 15 https://github.com/simstudioai/sim/pull/9772
Commits 2 https://github.com/simstudioai/sim/pull/9772/commits
Checks 85 https://github.com/simstudioai/sim/pull/9772/checks
Files changed https://github.com/simstudioai/sim/pull/9772/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9772/files
fix(oauth): reject cross-site workspace OAuth launches https://github.com/simstudioai/sim/pull/9772/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9772/files
170d442 fix(oauth): reject cross-site workspace OAuth launches waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9772/commits/170d4425090eebef713753b665f27607f5bc81fa
0fa99ea fix(oauth): keep workspace launches out of the signed-in login exception waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9772/commits/0fa99ea26f4c363fd5aa8e35216292a31ea6f9b6
Clear filters https://github.com/simstudioai/sim/pull/9772/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9772/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9772/files
auth-redirect.ts https://github.com/simstudioai/sim/pull/9772/files#diff-1dc3d272ca93026bf14d82421a5e2b9d8fc797dae991b503a34a5aef6510c5bc
route.test.ts https://github.com/simstudioai/sim/pull/9772/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
route.ts https://github.com/simstudioai/sim/pull/9772/files#diff-690aef508a6cd9bcc0f70231e76cf03086632ee1cb21c3ab0cc75ac8bc984504
proxy.test.ts https://github.com/simstudioai/sim/pull/9772/files#diff-85921dbeaec3aa778a756f3c9366a482c82f303630a95dd650ab91c5f446b8e3
check-test-types.baseline.json https://github.com/simstudioai/sim/pull/9772/files#diff-3f0e52298332b82e821be5c9210ddb89bb43ab248c2db79c27e6a783dbfe9e36
apps/sim/app/(auth)/auth-redirect.tshttps://github.com/simstudioai/sim/pull/9772/files#diff-1dc3d272ca93026bf14d82421a5e2b9d8fc797dae991b503a34a5aef6510c5bc
View file https://github.com/simstudioai/sim/blob/0fa99ea26f4c363fd5aa8e35216292a31ea6f9b6/apps/sim/app/(auth)/auth-redirect.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9772/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9772/files#diff-1dc3d272ca93026bf14d82421a5e2b9d8fc797dae991b503a34a5aef6510c5bc
https://github.com/simstudioai/sim/pull/9772/files#diff-1dc3d272ca93026bf14d82421a5e2b9d8fc797dae991b503a34a5aef6510c5bc
apps/sim/app/api/auth/oauth2/authorize/route.test.tshttps://github.com/simstudioai/sim/pull/9772/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
View file https://github.com/simstudioai/sim/blob/0fa99ea26f4c363fd5aa8e35216292a31ea6f9b6/apps/sim/app/api/auth/oauth2/authorize/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9772/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9772/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
https://github.com/simstudioai/sim/pull/9772/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
https://github.com/simstudioai/sim/pull/9772/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
Please reload this pagehttps://github.com/simstudioai/sim/pull/9772/files
https://github.com/simstudioai/sim/pull/9772/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
https://github.com/simstudioai/sim/pull/9772/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
https://github.com/simstudioai/sim/pull/9772/files#diff-7902ae6327394a83c03253ad7a55391639c7567083cc5cae1fecaaa00f974746
apps/sim/app/api/auth/oauth2/authorize/route.tshttps://github.com/simstudioai/sim/pull/9772/files#diff-690aef508a6cd9bcc0f70231e76cf03086632ee1cb21c3ab0cc75ac8bc984504
View file https://github.com/simstudioai/sim/blob/0fa99ea26f4c363fd5aa8e35216292a31ea6f9b6/apps/sim/app/api/auth/oauth2/authorize/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9772/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9772/files#diff-690aef508a6cd9bcc0f70231e76cf03086632ee1cb21c3ab0cc75ac8bc984504
https://github.com/simstudioai/sim/pull/9772/files#diff-690aef508a6cd9bcc0f70231e76cf03086632ee1cb21c3ab0cc75ac8bc984504
https://github.com/simstudioai/sim/pull/9772/files#diff-690aef508a6cd9bcc0f70231e76cf03086632ee1cb21c3ab0cc75ac8bc984504
Please reload this pagehttps://github.com/simstudioai/sim/pull/9772/files
https://github.com/simstudioai/sim/pull/9772/files#diff-690aef508a6cd9bcc0f70231e76cf03086632ee1cb21c3ab0cc75ac8bc984504
apps/sim/proxy.test.tshttps://github.com/simstudioai/sim/pull/9772/files#diff-85921dbeaec3aa778a756f3c9366a482c82f303630a95dd650ab91c5f446b8e3
View file https://github.com/simstudioai/sim/blob/0fa99ea26f4c363fd5aa8e35216292a31ea6f9b6/apps/sim/proxy.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9772/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9772/files#diff-85921dbeaec3aa778a756f3c9366a482c82f303630a95dd650ab91c5f446b8e3
scripts/check-test-types.baseline.jsonhttps://github.com/simstudioai/sim/pull/9772/files#diff-3f0e52298332b82e821be5c9210ddb89bb43ab248c2db79c27e6a783dbfe9e36
View file https://github.com/simstudioai/sim/blob/0fa99ea26f4c363fd5aa8e35216292a31ea6f9b6/scripts/check-test-types.baseline.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9772/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9772/files#diff-3f0e52298332b82e821be5c9210ddb89bb43ab248c2db79c27e6a783dbfe9e36
https://github.com/simstudioai/sim/pull/9772/files#diff-3f0e52298332b82e821be5c9210ddb89bb43ab248c2db79c27e6a783dbfe9e36
Please reload this pagehttps://github.com/simstudioai/sim/pull/9772/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.