René's URL Explorer Experiment


Title: fix(execute): derive credential actor from auth type, not body isClientSession by waleedlatif1 · Pull Request #9771 · simstudioai/sim · GitHub

Open Graph Title: fix(execute): derive credential actor from auth type, not body isClientSession by waleedlatif1 · Pull Request #9771 · simstudioai/sim

X Title: fix(execute): derive credential actor from auth type, not body isClientSession by waleedlatif1 · Pull Request #9771 · simstudioai/sim

Description: Summary POST /api/workflows/[id]/execute picked the credential actor from the body's isClientSession. A session caller that omitted it ran as the workspace billing account: OAuth tokens resolved as that account (a derived admin of every shared credential) and personal env vars came from the workflow owner, while the run still executed the caller-editable draft A write member could get tokens for shared credentials they aren't a member of by running their own draft without the flag. The logs Retry button already hit this path, since it doesn't send isClientSession Actor now follows the auth type: session, personal API key, and trusted MCP bridge run as the authenticated user. Workspace API key, public API, and internal JWT keep the billing-account actor (no change) isClientSession stays for streaming/live-trace/Copilot binding only The write-access check now uses the effective draft decision. A session run with no useDraftState runs the draft by default, so it now needs write like other draft runs (matches workflows.manual.execute minimumRole). The Retry UI is already gated on canEdit, so UI users see no change Type of Change Bug fix (security) Testing New route tests: actor + enforceCredentialAccess for all five caller types, and write-vs-read authorization for draft vs deployed session runs Red on pre-fix code: exactly the session-actor and draft-write cases fail, and the other caller cases pass (pins their behavior). Green after the fix app/api/workflows/ vitest: 11 files, 118 tests pass biome, check:test-patterns, check:comment-hygiene locally; full type-check/audits/test in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary POST /api/workflows/[id]/execute picked the credential actor from the body's isClientSession. A session caller that omitted it ran as the workspace billing account: OAuth tokens resolv...

X Description: Summary POST /api/workflows/[id]/execute picked the credential actor from the body's isClientSession. A session caller that omitted it ran as the workspace billing account: OAuth tokens re...

Opengraph URL: https://github.com/simstudioai/sim/pull/9771

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c6204c2a-4c60-4d1b-00e1-2ff2701eb19c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD0DA:1D33A1:1B5C2BC:252F3E4:6AFB90C3
html-safe-nonceeb91853f08c3bab0b043fd6fff39df85ca46793b927e056ec74771e8ede4892a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMERBOjFEMzNBMToxQjVDMkJDOjI1MkYzRTQ6NkFGQjkwQzMiLCJ2aXNpdG9yX2lkIjoiMzUyNjk2ODA2Nzk5NDkxNTAxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd899cce104d334c99cfdc41d772c384793b7d41c9d40a88967c592b0030c79cd
hovercard-subject-tagpull_request:5205277228
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9771/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary POST /api/workflows/[id]/execute picked the credential actor from the body's isClientSession. A session caller that omitted it ran as the workspace billing account: OAuth tokens resolv...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4f01efe06174a5ba6342fd58e42d02295e0675bedbb465d6bef2dbaec8e46556
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea52db8866b6543b4e83730cd6a6b1360f1a9e4dc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9771/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9771%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9771%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9771/files
Reloadhttps://github.com/simstudioai/sim/pull/9771/files
Reloadhttps://github.com/simstudioai/sim/pull/9771/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/execute-actor-from-principalhttps://github.com/simstudioai/sim/tree/fix/execute-actor-from-principal
Conversation 2 https://github.com/simstudioai/sim/pull/9771
Commits 1 https://github.com/simstudioai/sim/pull/9771/commits
Checks 80 https://github.com/simstudioai/sim/pull/9771/checks
Files changed https://github.com/simstudioai/sim/pull/9771/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9771/files
fix(execute): derive credential actor from auth type, not body isClientSession https://github.com/simstudioai/sim/pull/9771/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9771/files
815417a fix(execute): derive credential actor from auth type, not body isClie… waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9771/commits/815417adf5a82be838c7c4bf61395b19eb72025a
Clear filters https://github.com/simstudioai/sim/pull/9771/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9771/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9771/files
route.test.ts https://github.com/simstudioai/sim/pull/9771/files#diff-0de39cc2f188cd7076e0fcd44c964c59166e8b00cfba3cfa16c6ffc1e3a4a177
route.ts https://github.com/simstudioai/sim/pull/9771/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
apps/sim/app/api/workflows/[id]/execute/route.test.tshttps://github.com/simstudioai/sim/pull/9771/files#diff-0de39cc2f188cd7076e0fcd44c964c59166e8b00cfba3cfa16c6ffc1e3a4a177
View file https://github.com/simstudioai/sim/blob/815417adf5a82be838c7c4bf61395b19eb72025a/apps/sim/app/api/workflows/%5Bid%5D/execute/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9771/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9771/files#diff-0de39cc2f188cd7076e0fcd44c964c59166e8b00cfba3cfa16c6ffc1e3a4a177
https://github.com/simstudioai/sim/pull/9771/files#diff-0de39cc2f188cd7076e0fcd44c964c59166e8b00cfba3cfa16c6ffc1e3a4a177
apps/sim/app/api/workflows/[id]/execute/route.tshttps://github.com/simstudioai/sim/pull/9771/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
View file https://github.com/simstudioai/sim/blob/815417adf5a82be838c7c4bf61395b19eb72025a/apps/sim/app/api/workflows/%5Bid%5D/execute/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9771/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9771/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/9771/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/9771/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/9771/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
Please reload this pagehttps://github.com/simstudioai/sim/pull/9771/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.