René's URL Explorer Experiment


Title: fix(oauth): add Atlassian sites and Notion workspaces on the same login by waleedlatif1 · Pull Request #9760 · simstudioai/sim · GitHub

Open Graph Title: fix(oauth): add Atlassian sites and Notion workspaces on the same login by waleedlatif1 · Pull Request #9760 · simstudioai/sim

X Title: fix(oauth): add Atlassian sites and Notion workspaces on the same login by waleedlatif1 · Pull Request #9760 · simstudioai/sim

Description: Summary Atlassian keeps one grant per login and adds each site the person consents to into that grant, and Search already reads every site the token reaches through accessible-resources Connecting the same Atlassian login again to add a Confluence or Jira site was refused with "This account is already connected", which discarded the fresh tokens even though the site was granted Confluence and Jira now mark grantSpansSites, and resolveAccountWrite treats that same-login connect as a refresh of the existing account. Every other provider still refuses a duplicate, and a different Atlassian login is still its own account Notion is the opposite case: a Notion token reaches one workspace, but accounts were keyed on the person alone, so a second workspace on the same login was refused too. Notion now records bot.workspace_id from /v1/users/me as the tenant A Notion connection saved before this has no workspace. It takes on its workspace when the person reconnects or follows an invitation link, as before, and an Add account is refused until then, so a second workspace can never overwrite it. This is scoped to providers that declare tenantRecordedLater; everywhere else a missing tenant still never matches another Docs say how to add another site or workspace Type of Change Bug fix Testing multiple-provider-accounts.integration.ts on real Postgres: adding a site to the same Atlassian login refreshes that account's tokens instead of failing; a different login is still a second account. The first case failed before the fix with the reported error. Ran on both the push and the SQL migration provisioning paths, together with tool-permissions.integration.ts Existing duplicate-refusal cases for other providers unchanged and passing Notion workspace tenant and older tenantless connections: reconnect and invitation link fill the workspace, Add account waits for that, and a provider that always recorded its tenant still refuses a tenantless match. Existing tool-permissions.integration.ts case for Salesforce null tenants unchanged and passing lib/credential-groups and personal search integration unit suites, biome on changed files, check:comment-hygiene, check:utils, check:test-patterns, check:source-conventions, check:file-names, check:explicit-any, check:boundaries, check:api-validation:strict; type-check on pre-push check:audits and the full suite run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Atlassian keeps one grant per login and adds each site the person consents to into that grant, and Search already reads every site the token reaches through accessible-resources Connecting...

X Description: Summary Atlassian keeps one grant per login and adds each site the person consents to into that grant, and Search already reads every site the token reaches through accessible-resources Connecting...

Opengraph URL: https://github.com/simstudioai/sim/pull/9760

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fddbeb4c-8b98-80b2-129e-f2a4d5b17316
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE09C:32C90F:3C5D10:52C8EA:6AFB994E
html-safe-noncee1f8e181739c47877193dcef84ded7f4cb07832adbc07fafc6f14745251962a8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDlDOjMyQzkwRjozQzVEMTA6NTJDOEVBOjZBRkI5OTRFIiwidmlzaXRvcl9pZCI6IjY4ODgzODkyNTU4NTQ1NTQzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac71c3722d54be709fec005ba5d5d2f5797e734662230565f2438607da221a8416
hovercard-subject-tagpull_request:5196995490
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9760/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Atlassian keeps one grant per login and adds each site the person consents to into that grant, and Search already reads every site the token reaches through accessible-resources Connecting...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3cefd19a936819d82cfb5279d50fb56fe79cb9ec30f0f807e04e89b0c58ffae1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release606800bdb1b81d125fc845bdcc262c9fe063fc8f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9760/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9760%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9760%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9760/files
Reloadhttps://github.com/simstudioai/sim/pull/9760/files
Reloadhttps://github.com/simstudioai/sim/pull/9760/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/atlassian-add-site-same-loginhttps://github.com/simstudioai/sim/tree/fix/atlassian-add-site-same-login
Conversation 13 https://github.com/simstudioai/sim/pull/9760
Commits 3 https://github.com/simstudioai/sim/pull/9760/commits
Checks 83 https://github.com/simstudioai/sim/pull/9760/checks
Files changed https://github.com/simstudioai/sim/pull/9760/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9760/files
fix(oauth): add Atlassian sites and Notion workspaces on the same login https://github.com/simstudioai/sim/pull/9760/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9760/files
8fb0c9a fix(search): add an Atlassian site to the login that already holds it waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9760/commits/8fb0c9a8977160c03c60c5e4f81fbb4866286536
fab9bc7 fix(oauth): key Notion connections on their workspace waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9760/commits/fab9bc75231e59e30fc28b28449416a388f0d99a
9e4e5f2 fix(oauth): prove the new Atlassian grant is saved and note the site … waleedlatif1 Nov 7, 2026 https://github.com/simstudioai/sim/pull/9760/commits/9e4e5f2074257828f84550c26553b33af955e0f6
Clear filters https://github.com/simstudioai/sim/pull/9760/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9760/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9760/files
connect-your-account.mdx https://github.com/simstudioai/sim/pull/9760/files#diff-0b8d07b5c74b2098c422106129c6c310f397144a5cd5049ffaae54ff49bf25e0
managed-oauth.test.ts https://github.com/simstudioai/sim/pull/9760/files#diff-f4cbee9815cf3a5c1465deab8fd7ade4e8c1dac571c29aa82798e8b9da6ad03e
managed-oauth.ts https://github.com/simstudioai/sim/pull/9760/files#diff-385b9e39502c08c041ca4b333f19770f43c425bca3a303ccb8a46543d8b6ace3
multiple-provider-accounts.integration.ts https://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
account-rules.ts https://github.com/simstudioai/sim/pull/9760/files#diff-ab3a9c8a9b9290ff1917091ebf45b91319fc7f8881b1c0aeecb4ec8d546bcd7a
oauth.ts https://github.com/simstudioai/sim/pull/9760/files#diff-e5c54844cc43c554d3ea28fc138ccfaa9d12e43bcd06ea556c703c3749cf42b6
providers.ts https://github.com/simstudioai/sim/pull/9760/files#diff-327f06b7f5c27f863e76cf59035b4fd8f20ba803c9ea4fb99e2a6df50e7d9de7
apps/docs/content/docs/search/connect-your-account.mdxhttps://github.com/simstudioai/sim/pull/9760/files#diff-0b8d07b5c74b2098c422106129c6c310f397144a5cd5049ffaae54ff49bf25e0
View file https://github.com/simstudioai/sim/blob/9e4e5f2074257828f84550c26553b33af955e0f6/apps/docs/content/docs/search/connect-your-account.mdx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9760/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9760/files#diff-0b8d07b5c74b2098c422106129c6c310f397144a5cd5049ffaae54ff49bf25e0
https://github.com/simstudioai/sim/pull/9760/files#diff-0b8d07b5c74b2098c422106129c6c310f397144a5cd5049ffaae54ff49bf25e0
apps/sim/lib/auth/connectors/managed-oauth.test.tshttps://github.com/simstudioai/sim/pull/9760/files#diff-f4cbee9815cf3a5c1465deab8fd7ade4e8c1dac571c29aa82798e8b9da6ad03e
View file https://github.com/simstudioai/sim/blob/9e4e5f2074257828f84550c26553b33af955e0f6/apps/sim/lib/auth/connectors/managed-oauth.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9760/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9760/files#diff-f4cbee9815cf3a5c1465deab8fd7ade4e8c1dac571c29aa82798e8b9da6ad03e
https://github.com/simstudioai/sim/pull/9760/files#diff-f4cbee9815cf3a5c1465deab8fd7ade4e8c1dac571c29aa82798e8b9da6ad03e
https://github.com/simstudioai/sim/pull/9760/files#diff-f4cbee9815cf3a5c1465deab8fd7ade4e8c1dac571c29aa82798e8b9da6ad03e
apps/sim/lib/auth/connectors/managed-oauth.tshttps://github.com/simstudioai/sim/pull/9760/files#diff-385b9e39502c08c041ca4b333f19770f43c425bca3a303ccb8a46543d8b6ace3
View file https://github.com/simstudioai/sim/blob/9e4e5f2074257828f84550c26553b33af955e0f6/apps/sim/lib/auth/connectors/managed-oauth.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9760/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9760/files#diff-385b9e39502c08c041ca4b333f19770f43c425bca3a303ccb8a46543d8b6ace3
https://github.com/simstudioai/sim/pull/9760/files#diff-385b9e39502c08c041ca4b333f19770f43c425bca3a303ccb8a46543d8b6ace3
apps/sim/lib/credential-groups/__integration__/multiple-provider-accounts.integration.tshttps://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
View file https://github.com/simstudioai/sim/blob/9e4e5f2074257828f84550c26553b33af955e0f6/apps/sim/lib/credential-groups/__integration__/multiple-provider-accounts.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9760/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
https://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
https://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
https://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
https://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
https://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
https://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
https://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
https://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
https://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
https://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
https://github.com/simstudioai/sim/pull/9760/files#diff-5ff807e545794132f1709fce7f0d96736f057d7c4a54f7d1015c695da760e50d
apps/sim/lib/credential-groups/account-rules.tshttps://github.com/simstudioai/sim/pull/9760/files#diff-ab3a9c8a9b9290ff1917091ebf45b91319fc7f8881b1c0aeecb4ec8d546bcd7a
View file https://github.com/simstudioai/sim/blob/9e4e5f2074257828f84550c26553b33af955e0f6/apps/sim/lib/credential-groups/account-rules.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9760/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9760/files#diff-ab3a9c8a9b9290ff1917091ebf45b91319fc7f8881b1c0aeecb4ec8d546bcd7a
https://github.com/simstudioai/sim/pull/9760/files#diff-ab3a9c8a9b9290ff1917091ebf45b91319fc7f8881b1c0aeecb4ec8d546bcd7a
https://github.com/simstudioai/sim/pull/9760/files#diff-ab3a9c8a9b9290ff1917091ebf45b91319fc7f8881b1c0aeecb4ec8d546bcd7a
https://github.com/simstudioai/sim/pull/9760/files#diff-ab3a9c8a9b9290ff1917091ebf45b91319fc7f8881b1c0aeecb4ec8d546bcd7a
https://github.com/simstudioai/sim/pull/9760/files#diff-ab3a9c8a9b9290ff1917091ebf45b91319fc7f8881b1c0aeecb4ec8d546bcd7a
apps/sim/lib/credential-groups/oauth.tshttps://github.com/simstudioai/sim/pull/9760/files#diff-e5c54844cc43c554d3ea28fc138ccfaa9d12e43bcd06ea556c703c3749cf42b6
View file https://github.com/simstudioai/sim/blob/9e4e5f2074257828f84550c26553b33af955e0f6/apps/sim/lib/credential-groups/oauth.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9760/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9760/files#diff-e5c54844cc43c554d3ea28fc138ccfaa9d12e43bcd06ea556c703c3749cf42b6
https://github.com/simstudioai/sim/pull/9760/files#diff-e5c54844cc43c554d3ea28fc138ccfaa9d12e43bcd06ea556c703c3749cf42b6
https://github.com/simstudioai/sim/pull/9760/files#diff-e5c54844cc43c554d3ea28fc138ccfaa9d12e43bcd06ea556c703c3749cf42b6
https://github.com/simstudioai/sim/pull/9760/files#diff-e5c54844cc43c554d3ea28fc138ccfaa9d12e43bcd06ea556c703c3749cf42b6
apps/sim/lib/credential-groups/providers.tshttps://github.com/simstudioai/sim/pull/9760/files#diff-327f06b7f5c27f863e76cf59035b4fd8f20ba803c9ea4fb99e2a6df50e7d9de7
View file https://github.com/simstudioai/sim/blob/9e4e5f2074257828f84550c26553b33af955e0f6/apps/sim/lib/credential-groups/providers.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9760/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9760/files#diff-327f06b7f5c27f863e76cf59035b4fd8f20ba803c9ea4fb99e2a6df50e7d9de7
https://github.com/simstudioai/sim/pull/9760/files#diff-327f06b7f5c27f863e76cf59035b4fd8f20ba803c9ea4fb99e2a6df50e7d9de7
https://github.com/simstudioai/sim/pull/9760/files#diff-327f06b7f5c27f863e76cf59035b4fd8f20ba803c9ea4fb99e2a6df50e7d9de7
https://github.com/simstudioai/sim/pull/9760/files#diff-327f06b7f5c27f863e76cf59035b4fd8f20ba803c9ea4fb99e2a6df50e7d9de7
https://github.com/simstudioai/sim/pull/9760/files#diff-327f06b7f5c27f863e76cf59035b4fd8f20ba803c9ea4fb99e2a6df50e7d9de7
https://github.com/simstudioai/sim/pull/9760/files#diff-327f06b7f5c27f863e76cf59035b4fd8f20ba803c9ea4fb99e2a6df50e7d9de7
https://github.com/simstudioai/sim/pull/9760/files#diff-327f06b7f5c27f863e76cf59035b4fd8f20ba803c9ea4fb99e2a6df50e7d9de7
Please reload this pagehttps://github.com/simstudioai/sim/pull/9760/files
https://github.com/simstudioai/sim/pull/9760/files#diff-327f06b7f5c27f863e76cf59035b4fd8f20ba803c9ea4fb99e2a6df50e7d9de7
Please reload this pagehttps://github.com/simstudioai/sim/pull/9760/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.