René's URL Explorer Experiment


Title: fix(files): let Mothership tool runs write workspace files by waleedlatif1 · Pull Request #9685 · simstudioai/sim · GitHub

Open Graph Title: fix(files): let Mothership tool runs write workspace files by waleedlatif1 · Pull Request #9685 · simstudioai/sim

X Title: fix(files): let Mothership tool runs write workspace files by waleedlatif1 · Pull Request #9685 · simstudioai/sim

Description: Summary Every File tool run from a Mothership chat returned 403. executeToolForCaller hands the chat's delegated principal (audience sim:tool-execution) to in-process tools unchanged, and workspace-file use cases admit only sim:workspace-files. executeFileTool now rebinds a delegated caller with rebindWorkspaceFileDelegatedPrincipal, the same helper function-execute and payload materialization use. Subject, workspace, expiry ceiling and resource scope are kept, and the file use cases still check the subject's current role. A delegation for another workspace is left unchanged so they refuse it with their normal 403. File tools are the only consumer of callerPrincipal, and its TSDoc now says consumers must rebind. image_generate outside a workflow run stored every image twice. The chat-path fallback returned only a URL, so FileToolProcessor downloaded and re-uploaded it under a second key. imageUrl/content and image then pointed at different objects, and only image was content-sniffed. storeGeneratedImage now sniffs once with resolveStoredFileMetadata before storing and returns the stored file as imageFile on both paths. The processor keeps it as is, so there is one object, one sniff, and consistent output fields. Storage stays inside the image operation rather than moving to storeInternalToolFileResult. That keeps storage failures inside its fal "completed but delivery failed" metering reconciliation. Type of Change Bug fix Testing New lib/internal/file/delegated-caller-write.integration.ts drives the real executeFileTool against Postgres with the principal tools execute mints: Saving a chat-generated image into Workspace Files: red on staging (expected 403 to be 200), green with the fix. Re-proved after the cleanup round. A read-only member gets 403, and a delegation for another workspace gets 403. Both guard against the rebind widening access. lib/internal/file/execute-tool.test.ts, lib/internal/image, tools/image unit tests and bun run lint pass. Full bun run test, check:audits and type-check are left to CI. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Every File tool run from a Mothership chat returned 403. executeToolForCaller hands the chat's delegated principal (audience sim:tool-execution) to in-process tools unchanged, and work...

X Description: Summary Every File tool run from a Mothership chat returned 403. executeToolForCaller hands the chat's delegated principal (audience sim:tool-execution) to in-process tools unchanged, and ...

Opengraph URL: https://github.com/simstudioai/sim/pull/9685

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:161d1c81-2c76-7622-e679-4fcbb50e072b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE8FA:3032E:107D0A:1784EE:6AFB2AEE
html-safe-nonce4b47f89d06c59fce5c99469923bdca1d77ed28b8e544d9954e09af6a5cc50c50
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEZBOjMwMzJFOjEwN0QwQToxNzg0RUU6NkFGQjJBRUUiLCJ2aXNpdG9yX2lkIjoiMTA1MjA2MjI3ODI4ODYxNjE3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace1470258161e001c64c79a59fa829b5021bec2ef4a45cd49d19bca0bb6ea8383
hovercard-subject-tagpull_request:5161910267
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9685/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Every File tool run from a Mothership chat returned 403. executeToolForCaller hands the chat's delegated principal (audience sim:tool-execution) to in-process tools unchanged, and work...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None40c7ffe00e8bbb3ca8403c83d7ef110379c9eba2cbc7a7c333b037ffd940d4e4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef494d77c37809e03e18d49c6e9945c57e0b64070
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9685/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9685%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9685%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9685/files
Reloadhttps://github.com/simstudioai/sim/pull/9685/files
Reloadhttps://github.com/simstudioai/sim/pull/9685/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/file-tools-tool-execution-delegationhttps://github.com/simstudioai/sim/tree/fix/file-tools-tool-execution-delegation
Conversation 12 https://github.com/simstudioai/sim/pull/9685
Commits 3 https://github.com/simstudioai/sim/pull/9685/commits
Checks 80 https://github.com/simstudioai/sim/pull/9685/checks
Files changed https://github.com/simstudioai/sim/pull/9685/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9685/files
fix(files): let Mothership tool runs write workspace files https://github.com/simstudioai/sim/pull/9685/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9685/files
8783ba8 fix(files): let Mothership tool runs write workspace files waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9685/commits/8783ba841db33672b271af6e15cb52b1adca4c22
74c4281 improvement(files): sniff generated images once and refuse foreign de… waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9685/commits/74c4281f4c9abce5549dd5d41b8dce0237ad2b21
aa7c133 chore(files): import the principal factory directly in the delegated … waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9685/commits/aa7c133ec0a9a2603d29abc3792fdf6e29822c65
Clear filters https://github.com/simstudioai/sim/pull/9685/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9685/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9685/files
delegated-caller-write.integration.ts https://github.com/simstudioai/sim/pull/9685/files#diff-76d9944ab4971d761a7034e7071e19ca1408a8e23abeb2cc31c788a707f0611b
execute-tool.ts https://github.com/simstudioai/sim/pull/9685/files#diff-d1c9ba62e3a0f5cec5bba99c5412de8a80b9fb3b813e772f42f706167f7353cb
operations.ts https://github.com/simstudioai/sim/pull/9685/files#diff-f10c96f7effea4006757f20d486736e8b9b686634af446e108c96eae323de09a
types.ts https://github.com/simstudioai/sim/pull/9685/files#diff-334ece0bc59829ca18483d2252cf7565de29da33c9312346cdfe7518cb372915
apps/sim/lib/internal/file/delegated-caller-write.integration.tshttps://github.com/simstudioai/sim/pull/9685/files#diff-76d9944ab4971d761a7034e7071e19ca1408a8e23abeb2cc31c788a707f0611b
View file https://github.com/simstudioai/sim/blob/aa7c133ec0a9a2603d29abc3792fdf6e29822c65/apps/sim/lib/internal/file/delegated-caller-write.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9685/{{ revealButtonHref }}
apps/sim/lib/internal/file/execute-tool.tshttps://github.com/simstudioai/sim/pull/9685/files#diff-d1c9ba62e3a0f5cec5bba99c5412de8a80b9fb3b813e772f42f706167f7353cb
View file https://github.com/simstudioai/sim/blob/aa7c133ec0a9a2603d29abc3792fdf6e29822c65/apps/sim/lib/internal/file/execute-tool.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9685/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9685/files#diff-d1c9ba62e3a0f5cec5bba99c5412de8a80b9fb3b813e772f42f706167f7353cb
https://github.com/simstudioai/sim/pull/9685/files#diff-d1c9ba62e3a0f5cec5bba99c5412de8a80b9fb3b813e772f42f706167f7353cb
https://github.com/simstudioai/sim/pull/9685/files#diff-d1c9ba62e3a0f5cec5bba99c5412de8a80b9fb3b813e772f42f706167f7353cb
https://github.com/simstudioai/sim/pull/9685/files#diff-d1c9ba62e3a0f5cec5bba99c5412de8a80b9fb3b813e772f42f706167f7353cb
https://github.com/simstudioai/sim/pull/9685/files#diff-d1c9ba62e3a0f5cec5bba99c5412de8a80b9fb3b813e772f42f706167f7353cb
https://github.com/simstudioai/sim/pull/9685/files#diff-d1c9ba62e3a0f5cec5bba99c5412de8a80b9fb3b813e772f42f706167f7353cb
apps/sim/lib/internal/image/operations.tshttps://github.com/simstudioai/sim/pull/9685/files#diff-f10c96f7effea4006757f20d486736e8b9b686634af446e108c96eae323de09a
View file https://github.com/simstudioai/sim/blob/aa7c133ec0a9a2603d29abc3792fdf6e29822c65/apps/sim/lib/internal/image/operations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9685/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9685/files#diff-f10c96f7effea4006757f20d486736e8b9b686634af446e108c96eae323de09a
https://github.com/simstudioai/sim/pull/9685/files#diff-f10c96f7effea4006757f20d486736e8b9b686634af446e108c96eae323de09a
https://github.com/simstudioai/sim/pull/9685/files#diff-f10c96f7effea4006757f20d486736e8b9b686634af446e108c96eae323de09a
https://github.com/simstudioai/sim/pull/9685/files#diff-f10c96f7effea4006757f20d486736e8b9b686634af446e108c96eae323de09a
https://github.com/simstudioai/sim/pull/9685/files#diff-f10c96f7effea4006757f20d486736e8b9b686634af446e108c96eae323de09a
https://github.com/simstudioai/sim/pull/9685/files#diff-f10c96f7effea4006757f20d486736e8b9b686634af446e108c96eae323de09a
apps/sim/lib/internal/tool-operations/types.tshttps://github.com/simstudioai/sim/pull/9685/files#diff-334ece0bc59829ca18483d2252cf7565de29da33c9312346cdfe7518cb372915
View file https://github.com/simstudioai/sim/blob/aa7c133ec0a9a2603d29abc3792fdf6e29822c65/apps/sim/lib/internal/tool-operations/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9685/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9685/files#diff-334ece0bc59829ca18483d2252cf7565de29da33c9312346cdfe7518cb372915
https://github.com/simstudioai/sim/pull/9685/files#diff-334ece0bc59829ca18483d2252cf7565de29da33c9312346cdfe7518cb372915
Please reload this pagehttps://github.com/simstudioai/sim/pull/9685/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.