René's URL Explorer Experiment


Title: fix(logs): keep checked trace content when the display projection budget runs out by waleedlatif1 · Pull Request #9682 · simstudioai/sim · GitHub

Open Graph Title: fix(logs): keep checked trace content when the display projection budget runs out by waleedlatif1 · Pull Request #9682 · simstudioai/sim

X Title: fix(logs): keep checked trace content when the display projection budget runs out by waleedlatif1 · Pull Request #9682 · simstudioai/sim

Description: Summary Log display projected the whole envelope (finalOutput, workflowInput, blockInput, blockExecutions, error, errorDetails, completionFailure, message) as one field, so a single oversized or ref-backed value dropped all of them — including the run's error and message. Each value now projects on its own span and withholds only itself The read-path whole-trace check shares one content node budget across the envelope and every span. Crossing it reduced the entire trace to structure, even though each span had already been sanitized and checked. Now the spans that passed the check keep their content and only the span that crossed the budget, plus the ones after it, are withheld. The walk still stops at the same budget Only the budget overrun degrades partially (new TraceContentBudgetError); every other projection failure still withholds the whole trace The bulky block dumps (blockInput, blockExecutions) now project after the trace spans, so budget pressure drops them before the error or the trace Projection warnings now carry executionId, workflowId, workspaceId, phase (read or write), and for per-field omissions the spanId, spanType and field. Before, they named no execution, so they could not be traced back to a run Secret handling is unchanged: every returned value is still sanitized and re-checked against the same registry, and read-only projection still refuses large-value refs Type of Change Bug fix Testing New tests in trace-secret-projection.test.ts cover: budget crossing mid-trace, where earlier spans keep redacted content and later ones are withheld with no secret leaked budget crossing inside a child, where the whole top-level span is withheld a non-budget failure in a later span, which still withholds every span New tests in trace-store.test.ts cover: a ref-backed blockExecutions, which withholds only itself while error, message and the spans survive an oversized blockExecutions with a large trace, where the spans keep their content Red proof: all five new tests fail on the pre-fix source. Widening the budget filter to every projection error turns the fail-closed test red vitest run lib/logs/: 343 tests passed. Six files didn't load locally because of a worktree dependency resolution issue unrelated to this change; CI runs them biome on the changed files Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Log display projected the whole envelope (finalOutput, workflowInput, blockInput, blockExecutions, error, errorDetails, completionFailure, message) as one field, so a single oversized or r...

X Description: Summary Log display projected the whole envelope (finalOutput, workflowInput, blockInput, blockExecutions, error, errorDetails, completionFailure, message) as one field, so a single oversized or r...

Opengraph URL: https://github.com/simstudioai/sim/pull/9682

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5465551c-0f21-9f80-677a-603e6df4f43a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB0A:1B0C9:955C:D7F1:6AFB2680
html-safe-nonce6eb786d1ebd55d8f10dccca41bd6094562cb50701155693a15b7022a56bfa136
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjBBOjFCMEM5Ojk1NUM6RDdGMTo2QUZCMjY4MCIsInZpc2l0b3JfaWQiOiI0NTUxMDY4MDgwMTY3MTM0ODQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1f9418d6447ac5297a1ab2d3d754ca1f315ddc93db5f02d992982b77c0008859
hovercard-subject-tagpull_request:5160457443
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9682/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Log display projected the whole envelope (finalOutput, workflowInput, blockInput, blockExecutions, error, errorDetails, completionFailure, message) as one field, so a single oversized or r...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9219899e0d0ce0b87aeba2c640c955f83631457e5baff5df7a36ce599d2635b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd3b60f1fd9c5f10a3dcde41ae35682f53e85cee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9682/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9682%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9682%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9682/files
Reloadhttps://github.com/simstudioai/sim/pull/9682/files
Reloadhttps://github.com/simstudioai/sim/pull/9682/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/trace-projection-envelope-scopehttps://github.com/simstudioai/sim/tree/fix/trace-projection-envelope-scope
Conversation 24 https://github.com/simstudioai/sim/pull/9682
Commits 4 https://github.com/simstudioai/sim/pull/9682/commits
Checks 81 https://github.com/simstudioai/sim/pull/9682/checks
Files changed https://github.com/simstudioai/sim/pull/9682/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9682/files
fix(logs): keep checked trace content when the display projection budget runs out https://github.com/simstudioai/sim/pull/9682/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/9682/files
128c6aa fix(logs): keep checked trace content when the display projection bud… waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9682/commits/128c6aafbc4209c4cdf32af3036aa6cf1f6fd186
304d093 fix(logs): bound the withheld-span fallback by the trace's structure … waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9682/commits/304d0930fcdda5a4e7810029f77e569739919875
01384b5 fix(logs): resume the withheld-span fallback from the retained spans'… waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9682/commits/01384b5ef492212dd2ec60fb4ec3f43da4cfc333
90ae19b improvement(logs): name the projection warning's read/write phase exp… waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9682/commits/90ae19b838ee19d07eb42fe0373964643ff7d119
Clear filters https://github.com/simstudioai/sim/pull/9682/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9682/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9682/files
trace-secret-projection.test.ts https://github.com/simstudioai/sim/pull/9682/files#diff-d685a127b7054d2a90c57b539b3e51556d9c5b81828f2ae30b5dc12f8b380357
trace-secret-projection.ts https://github.com/simstudioai/sim/pull/9682/files#diff-ce82991a770f73aafcf2aaf915136f82d13830d6ace29a0ed6e50ae0d159b620
trace-store.test.ts https://github.com/simstudioai/sim/pull/9682/files#diff-84299c26f744b3f769762ddf719bf25215a8be08de0b293acf0853dbb5d50e2b
trace-store.ts https://github.com/simstudioai/sim/pull/9682/files#diff-fe3d0a8f11d559b284e0858ee61cbe42773223d4637adb2ddcb1a8b56a85c06f
apps/sim/lib/logs/execution/trace-secret-projection.test.tshttps://github.com/simstudioai/sim/pull/9682/files#diff-d685a127b7054d2a90c57b539b3e51556d9c5b81828f2ae30b5dc12f8b380357
View file https://github.com/simstudioai/sim/blob/90ae19b838ee19d07eb42fe0373964643ff7d119/apps/sim/lib/logs/execution/trace-secret-projection.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9682/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9682/files#diff-d685a127b7054d2a90c57b539b3e51556d9c5b81828f2ae30b5dc12f8b380357
https://github.com/simstudioai/sim/pull/9682/files#diff-d685a127b7054d2a90c57b539b3e51556d9c5b81828f2ae30b5dc12f8b380357
https://github.com/simstudioai/sim/pull/9682/files#diff-d685a127b7054d2a90c57b539b3e51556d9c5b81828f2ae30b5dc12f8b380357
Please reload this pagehttps://github.com/simstudioai/sim/pull/9682/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9682/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.