Title: fix(logs): keep checked trace content when the display projection budget runs out by waleedlatif1 · Pull Request #9682 · simstudioai/sim · GitHub
Open Graph Title: fix(logs): keep checked trace content when the display projection budget runs out by waleedlatif1 · Pull Request #9682 · simstudioai/sim
X Title: fix(logs): keep checked trace content when the display projection budget runs out by waleedlatif1 · Pull Request #9682 · simstudioai/sim
Description: Summary Log display projected the whole envelope (finalOutput, workflowInput, blockInput, blockExecutions, error, errorDetails, completionFailure, message) as one field, so a single oversized or ref-backed value dropped all of them — including the run's error and message. Each value now projects on its own span and withholds only itself The read-path whole-trace check shares one content node budget across the envelope and every span. Crossing it reduced the entire trace to structure, even though each span had already been sanitized and checked. Now the spans that passed the check keep their content and only the span that crossed the budget, plus the ones after it, are withheld. The walk still stops at the same budget Only the budget overrun degrades partially (new TraceContentBudgetError); every other projection failure still withholds the whole trace The bulky block dumps (blockInput, blockExecutions) now project after the trace spans, so budget pressure drops them before the error or the trace Projection warnings now carry executionId, workflowId, workspaceId, phase (read or write), and for per-field omissions the spanId, spanType and field. Before, they named no execution, so they could not be traced back to a run Secret handling is unchanged: every returned value is still sanitized and re-checked against the same registry, and read-only projection still refuses large-value refs Type of Change Bug fix Testing New tests in trace-secret-projection.test.ts cover: budget crossing mid-trace, where earlier spans keep redacted content and later ones are withheld with no secret leaked budget crossing inside a child, where the whole top-level span is withheld a non-budget failure in a later span, which still withholds every span New tests in trace-store.test.ts cover: a ref-backed blockExecutions, which withholds only itself while error, message and the spans survive an oversized blockExecutions with a large trace, where the spans keep their content Red proof: all five new tests fail on the pre-fix source. Widening the budget filter to every projection error turns the fail-closed test red vitest run lib/logs/: 343 tests passed. Six files didn't load locally because of a worktree dependency resolution issue unrelated to this change; CI runs them biome on the changed files Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Log display projected the whole envelope (finalOutput, workflowInput, blockInput, blockExecutions, error, errorDetails, completionFailure, message) as one field, so a single oversized or r...
X Description: Summary Log display projected the whole envelope (finalOutput, workflowInput, blockInput, blockExecutions, error, errorDetails, completionFailure, message) as one field, so a single oversized or r...
Opengraph URL: https://github.com/simstudioai/sim/pull/9682
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5465551c-0f21-9f80-677a-603e6df4f43a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB0A:1B0C9:955C:D7F1:6AFB2680 |
| html-safe-nonce | 6eb786d1ebd55d8f10dccca41bd6094562cb50701155693a15b7022a56bfa136 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjBBOjFCMEM5Ojk1NUM6RDdGMTo2QUZCMjY4MCIsInZpc2l0b3JfaWQiOiI0NTUxMDY4MDgwMTY3MTM0ODQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1f9418d6447ac5297a1ab2d3d754ca1f315ddc93db5f02d992982b77c0008859 |
| hovercard-subject-tag | pull_request:5160457443 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9682/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Log display projected the whole envelope (finalOutput, workflowInput, blockInput, blockExecutions, error, errorDetails, completionFailure, message) as one field, so a single oversized or r... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9219899e0d0ce0b87aeba2c640c955f83631457e5baff5df7a36ce599d2635b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd3b60f1fd9c5f10a3dcde41ae35682f53e85cee |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width