René's URL Explorer Experiment


Title: fix(trigger): keep secret text out of env sync errors and refuse an unknown sync target by waleedlatif1 · Pull Request #9672 · simstudioai/sim · GitHub

Open Graph Title: fix(trigger): keep secret text out of env sync errors and refuse an unknown sync target by waleedlatif1 · Pull Request #9672 · simstudioai/sim

X Title: fix(trigger): keep secret text out of env sync errors and refuse an unknown sync target by waleedlatif1 · Pull Request #9672 · simstudioai/sim

Description: Summary Follow-ups to #9632 (Trigger.dev env sync from the app's Secrets Manager secret), from a final review of the release branch. Keep secret text out of the error. A malformed env-vars secret failed with the JSON parser's message, which quotes the text around the fault (part of a value), and the Trigger.dev deploy prints that error to a public CI log. The error now names only the failure. Refuse a malformed sync-target list. TRIGGER_ENV_SYNC_TARGETS was split on commas with no validation, so Staging or a typo silently kept the environment on the old path. parseTriggerEnvSyncTargets (next to APP_ENV_SECRET_IDS) accepts only the exact comma list the deploy workflows' credential checks match, and refuses a padded, empty, or unknown entry (checked by own key, so constructor cannot pass); the deploy exits on it (syncEnvVars swallows throws) and logs which path it took. resolveTriggerEnvFromAppSecret uses the same own-key lookup. Accurate docs. The sync TSDoc now says the CLI applies variables when it uploads the version (before promotion) and that the sync only adds or updates; fetchRuntimeSecrets retries every failed request (not only transient ones); the worker-marker comments point at TRIGGER_CONSTANT_VARS; FUNCTION_EXECUTION_ENV notes it applies only outside the sync list. Type of Change Bug fix Testing packages/runtime-secrets: keeps the secret text out of a malformed-JSON error (red on the old code: the message contained the value); parseTriggerEnvSyncTargets reads the exact list, treats an unset gate as none, and refuses padded, empty, and unknown entries (red with trimming restored, or with in instead of an own-key check). 13/13. type-check for packages/runtime-secrets and apps/sim; lint and type-check (pre-push hooks); remaining audits in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-ups to #9632 (Trigger.dev env sync from the app's Secrets Manager secret), from a final review of the release branch. Keep secret text out of the error. A malformed env-vars sec...

X Description: Summary Follow-ups to #9632 (Trigger.dev env sync from the app's Secrets Manager secret), from a final review of the release branch. Keep secret text out of the error. A malformed env-vars...

Opengraph URL: https://github.com/simstudioai/sim/pull/9672

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f89e9971-91b0-c35f-63c9-427835d4e724
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC266:7E68C:1655BF:2107BA:6AFB1D58
html-safe-nonce5f664edf5c27527a18795269d9f439b1f66f34162be762aa014fc1baf55e109a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjY2OjdFNjhDOjE2NTVCRjoyMTA3QkE6NkFGQjFENTgiLCJ2aXNpdG9yX2lkIjoiMzc5MDU2NjE1Mzg2OTAwODIxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0a632b8157ea75fa7ff21037c34640d1acdc92b3aca688cd623817ac516be098
hovercard-subject-tagpull_request:5152871707
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9672/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-ups to #9632 (Trigger.dev env sync from the app's Secrets Manager secret), from a final review of the release branch. Keep secret text out of the error. A malformed env-vars sec...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9672/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9672%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9672%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9672/files
Reloadhttps://github.com/simstudioai/sim/pull/9672/files
Reloadhttps://github.com/simstudioai/sim/pull/9672/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/trigger-env-sync-hardeninghttps://github.com/simstudioai/sim/tree/fix/trigger-env-sync-hardening
Conversation 8 https://github.com/simstudioai/sim/pull/9672
Commits 2 https://github.com/simstudioai/sim/pull/9672/commits
Checks 81 https://github.com/simstudioai/sim/pull/9672/checks
Files changed https://github.com/simstudioai/sim/pull/9672/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9672/files
fix(trigger): keep secret text out of env sync errors and refuse an unknown sync target https://github.com/simstudioai/sim/pull/9672/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9672/files
2e814eb fix(trigger): keep secret text out of env sync errors and refuse an u… waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9672/commits/2e814eb10f042608b5b9d02eeffa5b09e179570e
44bb5dc fix(trigger): accept only the exact sync-target list the deploy workf… waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9672/commits/44bb5dc2e93097f272b97c520da453576acd724b
Clear filters https://github.com/simstudioai/sim/pull/9672/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9672/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9672/files
urls.ts https://github.com/simstudioai/sim/pull/9672/files#diff-61a77ed2b5f1f3a5f3555781240f9bcac5010a54c4535397b4f37f82fbeb127a
trigger.config.ts https://github.com/simstudioai/sim/pull/9672/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
index.test.ts https://github.com/simstudioai/sim/pull/9672/files#diff-5893db731b6c6496a625b1eb715aa6cafca73afe3fd8bb0d9986002c36b82185
index.ts https://github.com/simstudioai/sim/pull/9672/files#diff-d4bcec1271718686c463be3258b23056fc35001035b20ae38f5cd8146419deb5
trigger-env.test.ts https://github.com/simstudioai/sim/pull/9672/files#diff-0cd58bd8b2472edfe39ec34a510e88f84509e9419a3287d42396f547d5ca2cb2
trigger-env.ts https://github.com/simstudioai/sim/pull/9672/files#diff-45d140cf7f73f71ad60850dd24ad43c51485233aeca6a66f87ed4c999ef8e313
urls.mock.ts https://github.com/simstudioai/sim/pull/9672/files#diff-01254f6a64bc85bbbe0e2a2dc9d37071f68508644aa7dbc8f5764cce418d27ab
apps/sim/lib/core/utils/urls.tshttps://github.com/simstudioai/sim/pull/9672/files#diff-61a77ed2b5f1f3a5f3555781240f9bcac5010a54c4535397b4f37f82fbeb127a
View file https://github.com/simstudioai/sim/blob/44bb5dc2e93097f272b97c520da453576acd724b/apps/sim/lib/core/utils/urls.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9672/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9672/files#diff-61a77ed2b5f1f3a5f3555781240f9bcac5010a54c4535397b4f37f82fbeb127a
https://github.com/simstudioai/sim/pull/9672/files#diff-61a77ed2b5f1f3a5f3555781240f9bcac5010a54c4535397b4f37f82fbeb127a
apps/sim/trigger.config.tshttps://github.com/simstudioai/sim/pull/9672/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
View file https://github.com/simstudioai/sim/blob/44bb5dc2e93097f272b97c520da453576acd724b/apps/sim/trigger.config.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9672/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9672/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
https://github.com/simstudioai/sim/pull/9672/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
https://github.com/simstudioai/sim/pull/9672/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
https://github.com/simstudioai/sim/pull/9672/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
https://github.com/simstudioai/sim/pull/9672/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
https://github.com/simstudioai/sim/pull/9672/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
https://github.com/simstudioai/sim/pull/9672/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
https://github.com/simstudioai/sim/pull/9672/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
packages/runtime-secrets/src/index.test.tshttps://github.com/simstudioai/sim/pull/9672/files#diff-5893db731b6c6496a625b1eb715aa6cafca73afe3fd8bb0d9986002c36b82185
View file https://github.com/simstudioai/sim/blob/44bb5dc2e93097f272b97c520da453576acd724b/packages/runtime-secrets/src/index.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9672/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9672/files#diff-5893db731b6c6496a625b1eb715aa6cafca73afe3fd8bb0d9986002c36b82185
packages/runtime-secrets/src/index.tshttps://github.com/simstudioai/sim/pull/9672/files#diff-d4bcec1271718686c463be3258b23056fc35001035b20ae38f5cd8146419deb5
View file https://github.com/simstudioai/sim/blob/44bb5dc2e93097f272b97c520da453576acd724b/packages/runtime-secrets/src/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9672/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9672/files#diff-d4bcec1271718686c463be3258b23056fc35001035b20ae38f5cd8146419deb5
https://github.com/simstudioai/sim/pull/9672/files#diff-d4bcec1271718686c463be3258b23056fc35001035b20ae38f5cd8146419deb5
https://github.com/simstudioai/sim/pull/9672/files#diff-d4bcec1271718686c463be3258b23056fc35001035b20ae38f5cd8146419deb5
https://github.com/simstudioai/sim/pull/9672/files#diff-d4bcec1271718686c463be3258b23056fc35001035b20ae38f5cd8146419deb5
packages/runtime-secrets/src/trigger-env.test.tshttps://github.com/simstudioai/sim/pull/9672/files#diff-0cd58bd8b2472edfe39ec34a510e88f84509e9419a3287d42396f547d5ca2cb2
View file https://github.com/simstudioai/sim/blob/44bb5dc2e93097f272b97c520da453576acd724b/packages/runtime-secrets/src/trigger-env.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9672/{{ revealButtonHref }}
packages/runtime-secrets/src/trigger-env.tshttps://github.com/simstudioai/sim/pull/9672/files#diff-45d140cf7f73f71ad60850dd24ad43c51485233aeca6a66f87ed4c999ef8e313
View file https://github.com/simstudioai/sim/blob/44bb5dc2e93097f272b97c520da453576acd724b/packages/runtime-secrets/src/trigger-env.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9672/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9672/files#diff-45d140cf7f73f71ad60850dd24ad43c51485233aeca6a66f87ed4c999ef8e313
https://github.com/simstudioai/sim/pull/9672/files#diff-45d140cf7f73f71ad60850dd24ad43c51485233aeca6a66f87ed4c999ef8e313
packages/testing/src/mocks/urls.mock.tshttps://github.com/simstudioai/sim/pull/9672/files#diff-01254f6a64bc85bbbe0e2a2dc9d37071f68508644aa7dbc8f5764cce418d27ab
View file https://github.com/simstudioai/sim/blob/44bb5dc2e93097f272b97c520da453576acd724b/packages/testing/src/mocks/urls.mock.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9672/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9672/files#diff-01254f6a64bc85bbbe0e2a2dc9d37071f68508644aa7dbc8f5764cce418d27ab
https://github.com/simstudioai/sim/pull/9672/files#diff-01254f6a64bc85bbbe0e2a2dc9d37071f68508644aa7dbc8f5764cce418d27ab
Please reload this pagehttps://github.com/simstudioai/sim/pull/9672/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.