René's URL Explorer Experiment


Title: fix(file-search): fill dispatch capacity in selection order and keep reaped claims ahead of the rotation by waleedlatif1 · Pull Request #9671 · simstudioai/sim · GitHub

Open Graph Title: fix(file-search): fill dispatch capacity in selection order and keep reaped claims ahead of the rotation by waleedlatif1 · Pull Request #9671 · simstudioai/sim

X Title: fix(file-search): fill dispatch capacity in selection order and keep reaped claims ahead of the rotation by waleedlatif1 · Pull Request #9671 · simstudioai/sim

Description: Summary Follow-up to #9655 and #9666, from a final review of the release branch. Fill capacity in selection order. The claim cut ranked every selected owner's candidates by revision age, so with less free capacity than candidates (any loaded pass) a woken owner selected first could lose every slot to an older backlog selected after it. The claim then stamped it, filing it behind the rotation. Claims now fill capacity owner by owner in the pass's selection order, each still up to its free slots; ties within an owner keep revision age. lockFileSearchOwners sorts by key for lock order, so the selection order is restored from the candidates before claiming. Wake a reaped owner the backfill just queued. Both phases run in one transaction, backfill first, so an owner the page queued as a reconciliation wake-up (stamped last_dispatched_at = now()) absorbed the reaper's wake-up (updated_at = now(), so updated_at > last_dispatched_at was false) and the released claim waited behind the rotation. A wake that conflicts with a row stamped by this same transaction now clears the stamp, exactly as if the wake had queued the owner first; a stamp from an earlier transaction is always older than now(), so nothing else changes. The phase order stays backfill → reap, which keeps the pass's lock order file → queue row, the same order a file save's trigger takes. TSDoc on wokenSinceDispatch now lists the artifact-ready requeue and states the write-overlapping-a-claim window accurately; README describes the free-slot condition and the fill order; one stale test comment. Not changed (noted for later): owner selection no longer walks file_search_dispatch_schedule_idx since #9666 (a top-N sort over the queue each pass); a partial index on woken rows plus a two-statement select would restore index order but needs a migration and buys nothing at current queue sizes. Using clock_timestamp() in the file trigger would close the write-overlapping-a-claim window; also a migration. Type of Change Bug fix Testing dispatcher.integration.ts (real PostgreSQL): fills the free capacity in selection order, so a woken owner is not outbid by an older backlog — red on the previous code and with the revision-age cut restored keeps a reaped claim woken when the backfill queues its owner in the same pass — red on the previous code and with the stamp reset removed leaveSlots now deletes its filler owner's files so the backfill never re-queues it (removes a tie-break dependence on owner ids) Suite 42/42; owners.integration 18/18, chunks.integration 49/49 (1 opt-in skip), index-plan.integration 9/9, content-rendered.integration 31/31, lib/workspace-files/search unit tests 178/178 lint and type-check (pre-push hooks); remaining audits in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #9655 and #9666, from a final review of the release branch. Fill capacity in selection order. The claim cut ranked every selected owner's candidates by revision age, so wi...

X Description: Summary Follow-up to #9655 and #9666, from a final review of the release branch. Fill capacity in selection order. The claim cut ranked every selected owner's candidates by revision age, s...

Opengraph URL: https://github.com/simstudioai/sim/pull/9671

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0c506fc3-2efe-e1e3-142f-e7b1573d71be
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8CE4:2C03:19BD68:260215:6AFB1D66
html-safe-nonce6d258054d76867b7bbddc1b9fe04d59bc689a82e7cda2286dff807fbe7352e7c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0U0OjJDMDM6MTlCRDY4OjI2MDIxNTo2QUZCMUQ2NiIsInZpc2l0b3JfaWQiOiI1ODIzNzQwMzMzOTEyNjk0MTE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac61e3511b18837a1965c679cf53cb2b35b3d7c25e9b0f44b1c7321b4398a2c7b5
hovercard-subject-tagpull_request:5152806745
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9671/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #9655 and #9666, from a final review of the release branch. Fill capacity in selection order. The claim cut ranked every selected owner's candidates by revision age, so wi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9671/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9671%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9671%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9671/files
Reloadhttps://github.com/simstudioai/sim/pull/9671/files
Reloadhttps://github.com/simstudioai/sim/pull/9671/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/file-search-claim-selection-orderhttps://github.com/simstudioai/sim/tree/fix/file-search-claim-selection-order
Conversation 8 https://github.com/simstudioai/sim/pull/9671
Commits 2 https://github.com/simstudioai/sim/pull/9671/commits
Checks 81 https://github.com/simstudioai/sim/pull/9671/checks
Files changed https://github.com/simstudioai/sim/pull/9671/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9671/files
fix(file-search): fill dispatch capacity in selection order and keep reaped claims ahead of the rotation https://github.com/simstudioai/sim/pull/9671/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9671/files
ebb550c fix(file-search): fill dispatch capacity in selection order and reap … waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9671/commits/ebb550ca23b1f047049c34fbca8e4377c21d42ac
5516764 fix(file-search): keep the dispatch pass's file-then-queue lock order waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9671/commits/55167644241840f9724da7bf6320384f45b1c8f6
Clear filters https://github.com/simstudioai/sim/pull/9671/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9671/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9671/files
README.md https://github.com/simstudioai/sim/pull/9671/files#diff-625b017042a1d9a671673d8b7077f6f7e4513b30970b08b008bf9fb670f641c4
dispatcher.integration.ts https://github.com/simstudioai/sim/pull/9671/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
dispatcher.ts https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
apps/sim/lib/workspace-files/search/README.mdhttps://github.com/simstudioai/sim/pull/9671/files#diff-625b017042a1d9a671673d8b7077f6f7e4513b30970b08b008bf9fb670f641c4
View file https://github.com/simstudioai/sim/blob/55167644241840f9724da7bf6320384f45b1c8f6/apps/sim/lib/workspace-files/search/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9671/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9671/files#diff-625b017042a1d9a671673d8b7077f6f7e4513b30970b08b008bf9fb670f641c4
apps/sim/lib/workspace-files/search/dispatcher.integration.tshttps://github.com/simstudioai/sim/pull/9671/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
View file https://github.com/simstudioai/sim/blob/55167644241840f9724da7bf6320384f45b1c8f6/apps/sim/lib/workspace-files/search/dispatcher.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9671/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9671/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/9671/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/9671/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/9671/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/9671/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
apps/sim/lib/workspace-files/search/dispatcher.tshttps://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
View file https://github.com/simstudioai/sim/blob/55167644241840f9724da7bf6320384f45b1c8f6/apps/sim/lib/workspace-files/search/dispatcher.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9671/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9671/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
Please reload this pagehttps://github.com/simstudioai/sim/pull/9671/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.