René's URL Explorer Experiment


Title: fix(cli): match a dash-led id in linear time by waleedlatif1 · Pull Request #9668 · simstudioai/sim · GitHub

Open Graph Title: fix(cli): match a dash-led id in linear time by waleedlatif1 · Pull Request #9668 · simstudioai/sim

X Title: fix(cli): match a dash-led id in linear time by waleedlatif1 · Pull Request #9668 · simstudioai/sim

Description: Summary CodeQL flagged js/polynomial-redos (high) on the v0.9.43 release PR (#9660) at packages/sim-cli/src/runtime/build.ts: looksLikeAnId tested an unknown-option token with /^-[A-Za-z0-9_-]*[A-Z0-9][A-Za-z0-9_-]*$/, whose two stars around the required character backtrack quadratically on a long token that fails at its end (-000…0!). The regex predates #9646/#9650 (#7176); CodeQL raised it now because those PRs rewrote the parse-error guidance around it. Replaces it with two linear checks of the same meaning: /^-[\w-]+$/ (a dash then only id characters) and /[A-Z0-9]/ (at least one uppercase letter or digit). \w without the u flag is exactly [A-Za-z0-9_]. Input is the caller's own argv, so this was never a remote risk, but it was a real local stall (100k chars: ~6.5 s) and it fails the release's CodeQL gate. Testing build.test.ts, three new cases in the parse-error guidance suite: a dash-led id with an uppercase letter or digit gets Example: sim move -- -Ab3xYz; a lowercase dash token stays a misspelt flag (option list, no -- example); a 100,000-character -0…0! token is answered in under 1 s. Red → green: on the old regex the timing case fails (6,566 ms); the two behavior cases pass on both, pinning that the meaning did not change. Equivalence also checked over edge cases (-a, -ab, -A1, -ab-c, -_-_9, -9, -x!, --Foo, -é9). Whole build.test.ts: 64/64. tsc --noEmit -p packages/sim-cli: clean. biome check: clean.

Open Graph Description: Summary CodeQL flagged js/polynomial-redos (high) on the v0.9.43 release PR (#9660) at packages/sim-cli/src/runtime/build.ts: looksLikeAnId tested an unknown-option token with /^-[A-Za-z0-9_-]*[A-Z...

X Description: Summary CodeQL flagged js/polynomial-redos (high) on the v0.9.43 release PR (#9660) at packages/sim-cli/src/runtime/build.ts: looksLikeAnId tested an unknown-option token with /^-[A-Za-z0-9_-]*[A-Z...

Opengraph URL: https://github.com/simstudioai/sim/pull/9668

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9e4d06f5-da42-6fd1-7a7b-d5ed77f1bd78
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE484:1BCEEC:149AE1:1D8D7A:6AFB1EDB
html-safe-nonce3aa3b2fa087c7617d09faf53c87e6000b67dd6f984e01b344527cf5cc75c5d68
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDg0OjFCQ0VFQzoxNDlBRTE6MUQ4RDdBOjZBRkIxRURCIiwidmlzaXRvcl9pZCI6IjEzMDIzMTk2NTQ1NzU0ODA1MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaceaacd3d77536011a85787c01e0c5c1516de862a333b44f874c0752dfc1bbbd7a
hovercard-subject-tagpull_request:5152389018
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9668/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary CodeQL flagged js/polynomial-redos (high) on the v0.9.43 release PR (#9660) at packages/sim-cli/src/runtime/build.ts: looksLikeAnId tested an unknown-option token with /^-[A-Za-z0-9_-]*[A-Z...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9219899e0d0ce0b87aeba2c640c955f83631457e5baff5df7a36ce599d2635b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd3b60f1fd9c5f10a3dcde41ae35682f53e85cee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9668/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9668%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9668%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9668/files
Reloadhttps://github.com/simstudioai/sim/pull/9668/files
Reloadhttps://github.com/simstudioai/sim/pull/9668/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/cli-id-heuristic-linearhttps://github.com/simstudioai/sim/tree/fix/cli-id-heuristic-linear
Conversation 2 https://github.com/simstudioai/sim/pull/9668
Commits 1 https://github.com/simstudioai/sim/pull/9668/commits
Checks 80 https://github.com/simstudioai/sim/pull/9668/checks
Files changed https://github.com/simstudioai/sim/pull/9668/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9668/files
fix(cli): match a dash-led id in linear time https://github.com/simstudioai/sim/pull/9668/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9668/files
75d0f91 fix(cli): match a dash-led id in linear time waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9668/commits/75d0f91749f9565ae196cc3fa0bea0fa8c5a7a33
Clear filters https://github.com/simstudioai/sim/pull/9668/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9668/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9668/files
build.test.ts https://github.com/simstudioai/sim/pull/9668/files#diff-c1aa74884cdfb76fe156f398f9f85fba86fcf0bb03da882e52c8cc8c484d5b84
build.ts https://github.com/simstudioai/sim/pull/9668/files#diff-2dcc36bb95cb8081c7362c6d89b012e02c163c705032eb2dc421623691135bcd
packages/sim-cli/src/runtime/build.test.tshttps://github.com/simstudioai/sim/pull/9668/files#diff-c1aa74884cdfb76fe156f398f9f85fba86fcf0bb03da882e52c8cc8c484d5b84
View file https://github.com/simstudioai/sim/blob/75d0f91749f9565ae196cc3fa0bea0fa8c5a7a33/packages/sim-cli/src/runtime/build.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9668/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9668/files#diff-c1aa74884cdfb76fe156f398f9f85fba86fcf0bb03da882e52c8cc8c484d5b84
https://github.com/simstudioai/sim/pull/9668/files#diff-c1aa74884cdfb76fe156f398f9f85fba86fcf0bb03da882e52c8cc8c484d5b84
packages/sim-cli/src/runtime/build.tshttps://github.com/simstudioai/sim/pull/9668/files#diff-2dcc36bb95cb8081c7362c6d89b012e02c163c705032eb2dc421623691135bcd
View file https://github.com/simstudioai/sim/blob/75d0f91749f9565ae196cc3fa0bea0fa8c5a7a33/packages/sim-cli/src/runtime/build.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9668/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9668/files#diff-2dcc36bb95cb8081c7362c6d89b012e02c163c705032eb2dc421623691135bcd
https://github.com/simstudioai/sim/pull/9668/files#diff-2dcc36bb95cb8081c7362c6d89b012e02c163c705032eb2dc421623691135bcd
Please reload this pagehttps://github.com/simstudioai/sim/pull/9668/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.