René's URL Explorer Experiment


Title: fix(file-search): claim a file write that lands on an owner the backfill already queued by waleedlatif1 · Pull Request #9666 · simstudioai/sim · GitHub

Open Graph Title: fix(file-search): claim a file write that lands on an owner the backfill already queued by waleedlatif1 · Pull Request #9666 · simstudioai/sim

X Title: fix(file-search): claim a file write that lands on an owner the backfill already queued by waleedlatif1 · Pull Request #9666 · simstudioai/sim

Description: Summary Follow-up to #9655, from review on the release PR. Backfill reconciliation wake-ups enter the owner queue as if just dispatched, so they rotate in behind owners woken for a write. A file write that landed while such a row was still queued only advanced its updated_at (the file trigger's ON CONFLICT upsert), so it kept the reconciliation stamp and waited behind every older-stamped owner — during a long walk, several passes. The same held for an owner that was served, left queued with work, and then woken again. Claims now take owners woken since their last dispatch first: never dispatched, or updated_at > last_dispatched_at (wokenSinceDispatch). Every real wake-up advances updated_at (file write, released claim, reaped claim, artifact-ready requeue); a reconciliation wake-up never does — it now uses ON CONFLICT DO NOTHING, so it leaves an already queued owner untouched. Within each group the dispatch-age rotation is unchanged, so fairness is unchanged. The two compared columns come from one clock: the dispatcher and artifact-ready write them with the transaction's now(), as the trigger does. The remaining window is a write whose transaction began before the claim that stamped its owner; it waits one rotation by dispatch age (documented on wokenSinceDispatch). No migration, no trigger change, caps unchanged. The claim's queue select no longer follows file_search_dispatch_schedule_idx and sorts the queue instead (hundreds to low thousands of narrow rows, once a minute, row locks still only on returned rows). Type of Change Bug fix Testing dispatcher.integration.ts (real PostgreSQL, writes through the real workspace_file_search_mark_pending trigger): serves a file write to %s ahead of a backfill page of reconciliation wake-ups — now table-driven; the new "owner the page left queued" case is red on the old code and without the wokenSinceDispatch ordering keeps a queued reconciliation wake-up behind woken work when the backfill passes it again — red on the old code, without the ordering, and on a mutant whose reconciliation upsert bumps updated_at leaveSlots helper replaces three copies of the capacity setup Suite 39/39; also owners.integration 18/18, chunks.integration 49/49 (1 opt-in skip), index-plan.integration 9/9, content-rendered.integration 31/31, lib/workspace-files/search unit tests 178/178 lint and type-check (pre-push hooks); remaining audits in CI Note: dispatch work check > reports work for a backfill reconcile that is due compares a DB-clock completed_at against a JS Date exactly at the reconcile threshold and can flake by milliseconds; untouched here Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #9655, from review on the release PR. Backfill reconciliation wake-ups enter the owner queue as if just dispatched, so they rotate in behind owners woken for a write. A file w...

X Description: Summary Follow-up to #9655, from review on the release PR. Backfill reconciliation wake-ups enter the owner queue as if just dispatched, so they rotate in behind owners woken for a write. A file w...

Opengraph URL: https://github.com/simstudioai/sim/pull/9666

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:592e820a-e52f-b3a5-1266-1150a524aeca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD9C:1172E:1645EB:1FC6EA:6AFB1ED1
html-safe-noncecd1b9b5ea9414fa4ed87093805d38ce59977c69d0c0c24141ad7599a854a8dca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDlDOjExNzJFOjE2NDVFQjoxRkM2RUE6NkFGQjFFRDEiLCJ2aXNpdG9yX2lkIjoiMzQ0NjMyMzA5MDU3NTUzMTczMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2517407a0c912d9aa035f1b73544dfc2ee4fcac4d1eedc2d753415574612eab0
hovercard-subject-tagpull_request:5152272724
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9666/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #9655, from review on the release PR. Backfill reconciliation wake-ups enter the owner queue as if just dispatched, so they rotate in behind owners woken for a write. A file w...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9219899e0d0ce0b87aeba2c640c955f83631457e5baff5df7a36ce599d2635b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd3b60f1fd9c5f10a3dcde41ae35682f53e85cee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9666/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9666%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9666%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9666/files
Reloadhttps://github.com/simstudioai/sim/pull/9666/files
Reloadhttps://github.com/simstudioai/sim/pull/9666/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/file-search-write-after-reconciliationhttps://github.com/simstudioai/sim/tree/fix/file-search-write-after-reconciliation
Conversation 9 https://github.com/simstudioai/sim/pull/9666
Commits 2 https://github.com/simstudioai/sim/pull/9666/commits
Checks 80 https://github.com/simstudioai/sim/pull/9666/checks
Files changed https://github.com/simstudioai/sim/pull/9666/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9666/files
fix(file-search): claim a file write that lands on an owner the backfill already queued https://github.com/simstudioai/sim/pull/9666/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9666/files
3a57638 fix(file-search): claim a file write that lands on an owner the backf… waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9666/commits/3a57638c906a95776a6fa8602cd208d177efea33
c548150 fix(file-search): rotate a woken owner whose slots are full by dispat… waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9666/commits/c548150b595dcf0fbeea79074679bed59afa8f2e
Clear filters https://github.com/simstudioai/sim/pull/9666/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9666/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9666/files
README.md https://github.com/simstudioai/sim/pull/9666/files#diff-625b017042a1d9a671673d8b7077f6f7e4513b30970b08b008bf9fb670f641c4
artifact-ready.ts https://github.com/simstudioai/sim/pull/9666/files#diff-733f0be20894a7e9403d000d38a09d0a433dbc058b7d751620742f836db48c5d
dispatcher.integration.ts https://github.com/simstudioai/sim/pull/9666/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
dispatcher.ts https://github.com/simstudioai/sim/pull/9666/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
apps/sim/lib/workspace-files/search/README.mdhttps://github.com/simstudioai/sim/pull/9666/files#diff-625b017042a1d9a671673d8b7077f6f7e4513b30970b08b008bf9fb670f641c4
View file https://github.com/simstudioai/sim/blob/c548150b595dcf0fbeea79074679bed59afa8f2e/apps/sim/lib/workspace-files/search/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9666/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9666/files#diff-625b017042a1d9a671673d8b7077f6f7e4513b30970b08b008bf9fb670f641c4
apps/sim/lib/workspace-files/search/artifact-ready.tshttps://github.com/simstudioai/sim/pull/9666/files#diff-733f0be20894a7e9403d000d38a09d0a433dbc058b7d751620742f836db48c5d
View file https://github.com/simstudioai/sim/blob/c548150b595dcf0fbeea79074679bed59afa8f2e/apps/sim/lib/workspace-files/search/artifact-ready.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9666/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9666/files#diff-733f0be20894a7e9403d000d38a09d0a433dbc058b7d751620742f836db48c5d
apps/sim/lib/workspace-files/search/dispatcher.integration.tshttps://github.com/simstudioai/sim/pull/9666/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
View file https://github.com/simstudioai/sim/blob/c548150b595dcf0fbeea79074679bed59afa8f2e/apps/sim/lib/workspace-files/search/dispatcher.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9666/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9666/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/9666/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/9666/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/9666/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/9666/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/9666/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/9666/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
apps/sim/lib/workspace-files/search/dispatcher.tshttps://github.com/simstudioai/sim/pull/9666/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
View file https://github.com/simstudioai/sim/blob/c548150b595dcf0fbeea79074679bed59afa8f2e/apps/sim/lib/workspace-files/search/dispatcher.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9666/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9666/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9666/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9666/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9666/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9666/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9666/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
Please reload this pagehttps://github.com/simstudioai/sim/pull/9666/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.