René's URL Explorer Experiment


Title: fix(workflows): charge an operation whose new edge the final scope check drops by waleedlatif1 · Pull Request #9664 · simstudioai/sim · GitHub

Open Graph Title: fix(workflows): charge an operation whose new edge the final scope check drops by waleedlatif1 · Pull Request #9664 · simstudioai/sim

X Title: fix(workflows): charge an operation whose new edge the final scope check drops by waleedlatif1 · Pull Request #9664 · simstudioai/sim

Description: Summary The edit engine now remembers which operation's deferred connection created each edge, and when the end-of-batch scope check drops one of those edges (cross-subflow, trigger target, note endpoint), it charges that operation as declined. Before, a batch like add A with connections into a block inside a loop reported applied: 1 even though its only edge was removed and listed under skipped. Existing edges a move leaves crossing scopes (extract_from_subflow, insert_into_subflow) are still not charged. Losing them is the move's documented effect, not a refusal. Charging them is how the old skip-subtraction count could go negative. removeInvalidScopeEdges now returns the ids of the edges it dropped. Edge creation only appends, so each connection's new edges are the tail of edges after addConnectionsAsEdges. Follow-up to a release-review finding on #9639's declinedOperationCount. Type of Change Bug fix Testing lib/workflows/editing/operations.test.ts: added a regression test where an add whose connection crosses into a loop counts as one declined operation. It failed before the fix (0 vs 1). Also added a guard test: extracting a block that leaves an existing edge crossing scopes counts as zero declined. operations.test.ts + apply-workflow-operations.test.ts: 71/71 pass Biome on the changed files. Type-check and audits are left to CI. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The edit engine now remembers which operation's deferred connection created each edge, and when the end-of-batch scope check drops one of those edges (cross-subflow, trigger target, no...

X Description: Summary The edit engine now remembers which operation's deferred connection created each edge, and when the end-of-batch scope check drops one of those edges (cross-subflow, trigger target...

Opengraph URL: https://github.com/simstudioai/sim/pull/9664

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0791a4d3-06b8-ebcd-e503-f00e64679300
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE5DA:21A9F:E2AAF:14ED32:6AFB1AF8
html-safe-nonce3a8ab75cd0a4ed95d02941a846490ad8fdf132f0556b116468162b77541e9857
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNURBOjIxQTlGOkUyQUFGOjE0RUQzMjo2QUZCMUFGOCIsInZpc2l0b3JfaWQiOiIyMjIyNzA4MTU5NDQzMzExMzUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0dcb0f65a65dc8a787e2cd843bfdeb749000c9c93a2357649e8a709ad1c48fd0
hovercard-subject-tagpull_request:5152144993
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9664/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The edit engine now remembers which operation's deferred connection created each edge, and when the end-of-batch scope check drops one of those edges (cross-subflow, trigger target, no...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9664/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9664%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9664%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9664/files
Reloadhttps://github.com/simstudioai/sim/pull/9664/files
Reloadhttps://github.com/simstudioai/sim/pull/9664/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/applied-count-scope-edgeshttps://github.com/simstudioai/sim/tree/fix/applied-count-scope-edges
Conversation 2 https://github.com/simstudioai/sim/pull/9664
Commits 1 https://github.com/simstudioai/sim/pull/9664/commits
Checks 80 https://github.com/simstudioai/sim/pull/9664/checks
Files changed https://github.com/simstudioai/sim/pull/9664/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9664/files
fix(workflows): charge an operation whose new edge the final scope check drops https://github.com/simstudioai/sim/pull/9664/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9664/files
6cedc9c fix(workflows): charge an operation whose new edge the final scope ch… waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9664/commits/6cedc9c1822822d875ebcf6bbd5e16deae630d0a
Clear filters https://github.com/simstudioai/sim/pull/9664/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9664/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9664/files
engine.ts https://github.com/simstudioai/sim/pull/9664/files#diff-edcfe5af5b1850957818b19d0fc5feff46cae6acc1ddbb2a85eeb1610ae37eba
operations.test.ts https://github.com/simstudioai/sim/pull/9664/files#diff-6bb2b130cdc72cb4252605227c02134b7c8d196515f6426379ca6d41a2d7f1cc
apps/sim/lib/workflows/editing/engine.tshttps://github.com/simstudioai/sim/pull/9664/files#diff-edcfe5af5b1850957818b19d0fc5feff46cae6acc1ddbb2a85eeb1610ae37eba
View file https://github.com/simstudioai/sim/blob/6cedc9c1822822d875ebcf6bbd5e16deae630d0a/apps/sim/lib/workflows/editing/engine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9664/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9664/files#diff-edcfe5af5b1850957818b19d0fc5feff46cae6acc1ddbb2a85eeb1610ae37eba
https://github.com/simstudioai/sim/pull/9664/files#diff-edcfe5af5b1850957818b19d0fc5feff46cae6acc1ddbb2a85eeb1610ae37eba
https://github.com/simstudioai/sim/pull/9664/files#diff-edcfe5af5b1850957818b19d0fc5feff46cae6acc1ddbb2a85eeb1610ae37eba
https://github.com/simstudioai/sim/pull/9664/files#diff-edcfe5af5b1850957818b19d0fc5feff46cae6acc1ddbb2a85eeb1610ae37eba
https://github.com/simstudioai/sim/pull/9664/files#diff-edcfe5af5b1850957818b19d0fc5feff46cae6acc1ddbb2a85eeb1610ae37eba
https://github.com/simstudioai/sim/pull/9664/files#diff-edcfe5af5b1850957818b19d0fc5feff46cae6acc1ddbb2a85eeb1610ae37eba
https://github.com/simstudioai/sim/pull/9664/files#diff-edcfe5af5b1850957818b19d0fc5feff46cae6acc1ddbb2a85eeb1610ae37eba
https://github.com/simstudioai/sim/pull/9664/files#diff-edcfe5af5b1850957818b19d0fc5feff46cae6acc1ddbb2a85eeb1610ae37eba
https://github.com/simstudioai/sim/pull/9664/files#diff-edcfe5af5b1850957818b19d0fc5feff46cae6acc1ddbb2a85eeb1610ae37eba
apps/sim/lib/workflows/editing/operations.test.tshttps://github.com/simstudioai/sim/pull/9664/files#diff-6bb2b130cdc72cb4252605227c02134b7c8d196515f6426379ca6d41a2d7f1cc
View file https://github.com/simstudioai/sim/blob/6cedc9c1822822d875ebcf6bbd5e16deae630d0a/apps/sim/lib/workflows/editing/operations.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9664/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9664/files#diff-6bb2b130cdc72cb4252605227c02134b7c8d196515f6426379ca6d41a2d7f1cc
https://github.com/simstudioai/sim/pull/9664/files#diff-6bb2b130cdc72cb4252605227c02134b7c8d196515f6426379ca6d41a2d7f1cc
Please reload this pagehttps://github.com/simstudioai/sim/pull/9664/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.