Title: fix(resume): carry the admitted resume run's ID on outer resume failure logs by waleedlatif1 · Pull Request #9663 · simstudioai/sim · GitHub
Open Graph Title: fix(resume): carry the admitted resume run's ID on outer resume failure logs by waleedlatif1 · Pull Request #9663 · simstudioai/sim
X Title: fix(resume): carry the admitted resume run's ID on outer resume failure logs by waleedlatif1 · Pull Request #9663 · simstudioai/sim
Description: Summary The outer catch in executeResumeWorkflow now includes the admitted resume run's resumeExecutionId when it logs a failure. Failures after enqueueOrStartResume admits the resume can reach that catch without another boundary logging them with the child run's ID, for example the streaming request guard or a markResumeFailed/markResumeAttemptFailed fault on the synchronous path. Those can now be tied to the resumed run. The ID comes from enqueueResult, not the local preprocessing resumeExecutionId, which is never the admitted run. A failure before admission logs without it, as before. Deduplication is unchanged: logFailureOnce still keys on the paused run's executionId, so failures the manager already logged are still skipped. Type of Change Bug fix Testing biome check on the changed file Confirmed both logger paths drop an undefined field: the JSON line (JSON.stringify) and the OTel attributes (filterUndefined). A pre-admission failure therefore logs exactly what it did before. Type-check, audits and the Vitest suites run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary The outer catch in executeResumeWorkflow now includes the admitted resume run's resumeExecutionId when it logs a failure. Failures after enqueueOrStartResume admits the resume can reac...
X Description: Summary The outer catch in executeResumeWorkflow now includes the admitted resume run's resumeExecutionId when it logs a failure. Failures after enqueueOrStartResume admits the resume can ...
Opengraph URL: https://github.com/simstudioai/sim/pull/9663
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:67a34c6d-a8f1-d39d-727a-e7f4c4113dc9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 82EA:3CDE1A:181807:23ADF2:6AFB1DB6 |
| html-safe-nonce | 75a324605f212d7ec489ce436e0ba01b2fe9ffa03b42c4f0b9721acdaceba92d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkVBOjNDREUxQToxODE4MDc6MjNBREYyOjZBRkIxREI2IiwidmlzaXRvcl9pZCI6IjEyNzA4Mzg3MDgyMzE5Mzc0NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f26de91dbdcdb9edd896d4c73701719e5c834dbdca0e7d44b15cd458559503e3 |
| hovercard-subject-tag | pull_request:5152093766 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9663/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary The outer catch in executeResumeWorkflow now includes the admitted resume run's resumeExecutionId when it logs a failure. Failures after enqueueOrStartResume admits the resume can reac... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9219899e0d0ce0b87aeba2c640c955f83631457e5baff5df7a36ce599d2635b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd3b60f1fd9c5f10a3dcde41ae35682f53e85cee |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width