René's URL Explorer Experiment


Title: fix(resume): carry the admitted resume run's ID on outer resume failure logs by waleedlatif1 · Pull Request #9663 · simstudioai/sim · GitHub

Open Graph Title: fix(resume): carry the admitted resume run's ID on outer resume failure logs by waleedlatif1 · Pull Request #9663 · simstudioai/sim

X Title: fix(resume): carry the admitted resume run's ID on outer resume failure logs by waleedlatif1 · Pull Request #9663 · simstudioai/sim

Description: Summary The outer catch in executeResumeWorkflow now includes the admitted resume run's resumeExecutionId when it logs a failure. Failures after enqueueOrStartResume admits the resume can reach that catch without another boundary logging them with the child run's ID, for example the streaming request guard or a markResumeFailed/markResumeAttemptFailed fault on the synchronous path. Those can now be tied to the resumed run. The ID comes from enqueueResult, not the local preprocessing resumeExecutionId, which is never the admitted run. A failure before admission logs without it, as before. Deduplication is unchanged: logFailureOnce still keys on the paused run's executionId, so failures the manager already logged are still skipped. Type of Change Bug fix Testing biome check on the changed file Confirmed both logger paths drop an undefined field: the JSON line (JSON.stringify) and the OTel attributes (filterUndefined). A pre-admission failure therefore logs exactly what it did before. Type-check, audits and the Vitest suites run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The outer catch in executeResumeWorkflow now includes the admitted resume run's resumeExecutionId when it logs a failure. Failures after enqueueOrStartResume admits the resume can reac...

X Description: Summary The outer catch in executeResumeWorkflow now includes the admitted resume run's resumeExecutionId when it logs a failure. Failures after enqueueOrStartResume admits the resume can ...

Opengraph URL: https://github.com/simstudioai/sim/pull/9663

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:67a34c6d-a8f1-d39d-727a-e7f4c4113dc9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id82EA:3CDE1A:181807:23ADF2:6AFB1DB6
html-safe-nonce75a324605f212d7ec489ce436e0ba01b2fe9ffa03b42c4f0b9721acdaceba92d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkVBOjNDREUxQToxODE4MDc6MjNBREYyOjZBRkIxREI2IiwidmlzaXRvcl9pZCI6IjEyNzA4Mzg3MDgyMzE5Mzc0NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf26de91dbdcdb9edd896d4c73701719e5c834dbdca0e7d44b15cd458559503e3
hovercard-subject-tagpull_request:5152093766
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9663/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The outer catch in executeResumeWorkflow now includes the admitted resume run's resumeExecutionId when it logs a failure. Failures after enqueueOrStartResume admits the resume can reac...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9219899e0d0ce0b87aeba2c640c955f83631457e5baff5df7a36ce599d2635b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd3b60f1fd9c5f10a3dcde41ae35682f53e85cee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9663/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9663%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9663%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9663/files
Reloadhttps://github.com/simstudioai/sim/pull/9663/files
Reloadhttps://github.com/simstudioai/sim/pull/9663/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/resume-log-admitted-run-idhttps://github.com/simstudioai/sim/tree/fix/resume-log-admitted-run-id
Conversation 2 https://github.com/simstudioai/sim/pull/9663
Commits 1 https://github.com/simstudioai/sim/pull/9663/commits
Checks 80 https://github.com/simstudioai/sim/pull/9663/checks
Files changed https://github.com/simstudioai/sim/pull/9663/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9663/files
fix(resume): carry the admitted resume run's ID on outer resume failure logs https://github.com/simstudioai/sim/pull/9663/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9663/files
3a1a50f fix(resume): carry the admitted resume run's ID on outer resume failu… waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9663/commits/3a1a50fc4caccdb1f5db718ae8f2cbc380360b0e
Clear filters https://github.com/simstudioai/sim/pull/9663/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9663/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9663/files
apps/sim/lib/workflows/executor/resume-execution.tshttps://github.com/simstudioai/sim/pull/9663/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
View file https://github.com/simstudioai/sim/blob/3a1a50fc4caccdb1f5db718ae8f2cbc380360b0e/apps/sim/lib/workflows/executor/resume-execution.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9663/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9663/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
https://github.com/simstudioai/sim/pull/9663/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
https://github.com/simstudioai/sim/pull/9663/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
https://github.com/simstudioai/sim/pull/9663/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
https://github.com/simstudioai/sim/pull/9663/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
Please reload this pagehttps://github.com/simstudioai/sim/pull/9663/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.