René's URL Explorer Experiment


Title: test(files): prove files/ VFS path downloads over real HTTP instead of a mocked route call by waleedlatif1 · Pull Request #9662 · simstudioai/sim · GitHub

Open Graph Title: test(files): prove files/ VFS path downloads over real HTTP instead of a mocked route call by waleedlatif1 · Pull Request #9662 · simstudioai/sim

X Title: test(files): prove files/ VFS path downloads over real HTTP instead of a mocked route call by waleedlatif1 · Pull Request #9662 · simstudioai/sim

Description: Summary Greptile flagged on the v0.9.43 release PR (#9660) that the v2 file download case added in #9637 mocked the download use case, passed the already-decoded route parameter straight to the handler, and asserted toHaveBeenCalledWith on the mock. CLAUDE.md forbids that pattern, and it could not catch the one thing the integration test does not reach: Next.js routing a /-encoded files/... path into the single [fileId] segment, which is exactly how sim files get files/... calls the route (encodeURIComponent on path params). Removes the mocked route case. Every mock and import it used is still used by the other cases. Adds one check to apps/sim/scripts/test-file-delivery-e2e.ts (CI: project-files http e2e group, via test-project-files-e2e.ts): it creates a VfsDocs folder, a root vfs-report.csv and a same-named copy in the folder, then downloads files/VfsDocs/vfs-report.csv and files/vfs-report.csv through /api/v2/files/ with an API key over real HTTP. Each must return its own bytes, and a missing path returns 404. A routing bug that truncated the segment at / would land on the root copy or 404. Service-level resolution, scoping and refusals stay covered by lib/workspace-files/delivery.integration.ts (unchanged). No product code changes. Testing Red proof: tmp/vfs-download-red is this test plus the route with acceptVfsPath: true removed; the checks workflow dispatched on it must fail the project-files e2e group on this check (run linked in a comment below once it finishes). Green: this PR's CI e2e (project-files). biome check on both files.

Open Graph Description: Summary Greptile flagged on the v0.9.43 release PR (#9660) that the v2 file download case added in #9637 mocked the download use case, passed the already-decoded route parameter straight to the han...

X Description: Summary Greptile flagged on the v0.9.43 release PR (#9660) that the v2 file download case added in #9637 mocked the download use case, passed the already-decoded route parameter straight to the han...

Opengraph URL: https://github.com/simstudioai/sim/pull/9662

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:05a8fb80-bb70-d954-9264-a825a5048a78
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD0E2:AF351:18AA95:2388CD:6AFB1F91
html-safe-nonceb850357d1fe02799b60fb4553cd27f93722dc600ecf4be57bf20e76ae822be4e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMEUyOkFGMzUxOjE4QUE5NToyMzg4Q0Q6NkFGQjFGOTEiLCJ2aXNpdG9yX2lkIjoiNTEwNTQ3NDk1NzA4OTY0NDQzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8b40971a3bbab60d6f5758c9dd08faabd15ab05f24efc8a3b1f36d9aca774ffd
hovercard-subject-tagpull_request:5152058820
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9662/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Greptile flagged on the v0.9.43 release PR (#9660) that the v2 file download case added in #9637 mocked the download use case, passed the already-decoded route parameter straight to the han...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9219899e0d0ce0b87aeba2c640c955f83631457e5baff5df7a36ce599d2635b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd3b60f1fd9c5f10a3dcde41ae35682f53e85cee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9662/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9662%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9662%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9662/files
Reloadhttps://github.com/simstudioai/sim/pull/9662/files
Reloadhttps://github.com/simstudioai/sim/pull/9662/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/vfs-download-http-proofhttps://github.com/simstudioai/sim/tree/fix/vfs-download-http-proof
Conversation 3 https://github.com/simstudioai/sim/pull/9662
Commits 2 https://github.com/simstudioai/sim/pull/9662/commits
Checks 49 https://github.com/simstudioai/sim/pull/9662/checks
Files changed https://github.com/simstudioai/sim/pull/9662/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9662/files
test(files): prove files/ VFS path downloads over real HTTP instead of a mocked route call https://github.com/simstudioai/sim/pull/9662/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9662/files
81b2ebe test(files): prove files/ VFS path downloads over real HTTP instead o… waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9662/commits/81b2ebe125adf698d2dfd7008f3e79b0a903cc35
267e8e8 test(files): keep the HTTP check to the routing it proves waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9662/commits/267e8e801598b0abb25dad8623a966900490d169
Clear filters https://github.com/simstudioai/sim/pull/9662/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9662/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9662/files
route.test.ts https://github.com/simstudioai/sim/pull/9662/files#diff-b4052196c356f11a02557754378b84a52b53866d0de6b8ac4491c39c5abbb353
test-file-delivery-e2e.ts https://github.com/simstudioai/sim/pull/9662/files#diff-466dc0d745128a370a37704461a3a592c9469a6e38880906b194a7dc7bb5142d
apps/sim/app/api/v2/files/[fileId]/route.test.tshttps://github.com/simstudioai/sim/pull/9662/files#diff-b4052196c356f11a02557754378b84a52b53866d0de6b8ac4491c39c5abbb353
View file https://github.com/simstudioai/sim/blob/267e8e801598b0abb25dad8623a966900490d169/apps/sim/app/api/v2/files/%5BfileId%5D/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9662/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9662/files#diff-b4052196c356f11a02557754378b84a52b53866d0de6b8ac4491c39c5abbb353
https://github.com/simstudioai/sim/pull/9662/files#diff-b4052196c356f11a02557754378b84a52b53866d0de6b8ac4491c39c5abbb353
apps/sim/scripts/test-file-delivery-e2e.tshttps://github.com/simstudioai/sim/pull/9662/files#diff-466dc0d745128a370a37704461a3a592c9469a6e38880906b194a7dc7bb5142d
View file https://github.com/simstudioai/sim/blob/267e8e801598b0abb25dad8623a966900490d169/apps/sim/scripts/test-file-delivery-e2e.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9662/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9662/files#diff-466dc0d745128a370a37704461a3a592c9469a6e38880906b194a7dc7bb5142d
https://github.com/simstudioai/sim/pull/9662/files#diff-466dc0d745128a370a37704461a3a592c9469a6e38880906b194a7dc7bb5142d
https://github.com/simstudioai/sim/pull/9662/files#diff-466dc0d745128a370a37704461a3a592c9469a6e38880906b194a7dc7bb5142d
https://github.com/simstudioai/sim/pull/9662/files#diff-466dc0d745128a370a37704461a3a592c9469a6e38880906b194a7dc7bb5142d
Please reload this pagehttps://github.com/simstudioai/sim/pull/9662/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.