René's URL Explorer Experiment


Title: fix(sim-links): open the new-link form above the sources popover and suggest hyphenated names by waleedlatif1 · Pull Request #9654 · simstudioai/sim · GitHub

Open Graph Title: fix(sim-links): open the new-link form above the sources popover and suggest hyphenated names by waleedlatif1 · Pull Request #9654 · simstudioai/sim

X Title: fix(sim-links): open the new-link form above the sources popover and suggest hyphenated names by waleedlatif1 · Pull Request #9654 · simstudioai/sim

Description: Summary Creating a Sim link from the answer's sources popover opened the form beneath the popover. Popovers stack above modals by design (--z-popover > --z-modal) so they can open inside dialogs, and the form was mounted inside the popover's row. SimLinkOrganizationProvider now hosts the new-link form at the layout root: the row's menu calls useOpenSimLinkForm, the form mounts outside the popover, takes focus, and the popover dismisses itself. The z-index scale is unchanged The file share dialog keeps its nested form (a dialog inside a dialog already stacks and keeps its focus trap) Name suggestions keep only letters and digits, joined by single hyphens: "Sim: Build and govern…" now suggests sim-build-and-govern… instead of sim:-build-and-govern… Type of Change Bug fix Testing message-sources.test.tsx drives the real path (open sources popover → row actions → Create Sim link, lookup stubbed empty) and asserts the form opens prefilled while the popover is gone; it fails on the previous code with the popover still showing validation.test.ts: colons, dots and other name punctuation become single hyphens Affected suites green (247 tests: sim-links, links page, share modal, message content, search results) Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Creating a Sim link from the answer's sources popover opened the form beneath the popover. Popovers stack above modals by design (--z-popover > --z-modal) so they can open inside di...

X Description: Summary Creating a Sim link from the answer's sources popover opened the form beneath the popover. Popovers stack above modals by design (--z-popover > --z-modal) so they can open i...

Opengraph URL: https://github.com/simstudioai/sim/pull/9654

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:93eb544a-7bb6-6d14-2d06-946eb685641b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA43A:1B993:1BF643:29192C:6AFB1E4B
html-safe-nonce92d6e5970c59d3819de4c77139d17efc5ae7f10f90367fbd4fcd0b11d2e8d5c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDNBOjFCOTkzOjFCRjY0MzoyOTE5MkM6NkFGQjFFNEIiLCJ2aXNpdG9yX2lkIjoiNDgzMzcwOTg1MzQ2MzIyMzg4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbf617c24a81badbfe9c4da47a51ccb62fa08657e7c154479881a81c98ae3718c
hovercard-subject-tagpull_request:5147622478
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9654/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Creating a Sim link from the answer's sources popover opened the form beneath the popover. Popovers stack above modals by design (--z-popover > --z-modal) so they can open inside di...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9219899e0d0ce0b87aeba2c640c955f83631457e5baff5df7a36ce599d2635b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd3b60f1fd9c5f10a3dcde41ae35682f53e85cee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9654/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9654%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9654%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9654/files
Reloadhttps://github.com/simstudioai/sim/pull/9654/files
Reloadhttps://github.com/simstudioai/sim/pull/9654/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/sim-link-modal-over-popoverhttps://github.com/simstudioai/sim/tree/fix/sim-link-modal-over-popover
Conversation 14 https://github.com/simstudioai/sim/pull/9654
Commits 3 https://github.com/simstudioai/sim/pull/9654/commits
Checks 81 https://github.com/simstudioai/sim/pull/9654/checks
Files changed https://github.com/simstudioai/sim/pull/9654/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9654/files
fix(sim-links): open the new-link form above the sources popover and suggest hyphenated names https://github.com/simstudioai/sim/pull/9654/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9654/files
c51a624 fix(sim-links): open the new-link form above the sources popover and … waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9654/commits/c51a62407719040c5e3882ff3f7ddc3ccd6783fd
0ec3bda test(sim-links): use the shared macrotask flush in the sources popove… waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9654/commits/0ec3bdaf027047dfd0e0924449c0f5692e9e72e6
be65087 test(sim-links): import the macrotask helper from its own module waleedlatif1 Nov 4, 2026 https://github.com/simstudioai/sim/pull/9654/commits/be65087ab76bea34c19be0973f1de74e10196da0
Clear filters https://github.com/simstudioai/sim/pull/9654/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9654/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9654/files
sim-link-organization-provider.tsx https://github.com/simstudioai/sim/pull/9654/files#diff-ff07d975436293dfbf6da53453d7b5eee11b1b6c8e4d6b46f23bbff17247c0ea
sim-link-shortcut.tsx https://github.com/simstudioai/sim/pull/9654/files#diff-72423e4fc4ddbb5f106b09011dfd023fa2b13542e4685278e8cc92002fae9849
message-sources.test.tsx https://github.com/simstudioai/sim/pull/9654/files#diff-2daf9a0ee8c8a01b6fc99bd883cabfd4fd2c851961a1909be1e4a6c5a067cd9e
source-card.tsx https://github.com/simstudioai/sim/pull/9654/files#diff-e4b8a579fbf132c25ec2956dc1ea0d99a457941ba58ffe26c01c4c25a3f04033
validation.test.ts https://github.com/simstudioai/sim/pull/9654/files#diff-0635634f1921f6e21110b45c56b881392e07d154d9849f1f9723a01bdf357429
validation.ts https://github.com/simstudioai/sim/pull/9654/files#diff-d4659128a93a51c87c6ddc3d1d2b70bb77560782d678ee7d3f6c8de4d7bae391
apps/sim/app/o/[organizationId]/links/sim-link-organization-provider.tsxhttps://github.com/simstudioai/sim/pull/9654/files#diff-ff07d975436293dfbf6da53453d7b5eee11b1b6c8e4d6b46f23bbff17247c0ea
View file https://github.com/simstudioai/sim/blob/be65087ab76bea34c19be0973f1de74e10196da0/apps/sim/app/o/%5BorganizationId%5D/links/sim-link-organization-provider.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9654/{{ revealButtonHref }}
apps/sim/app/o/[organizationId]/links/sim-link-shortcut.tsxhttps://github.com/simstudioai/sim/pull/9654/files#diff-72423e4fc4ddbb5f106b09011dfd023fa2b13542e4685278e8cc92002fae9849
View file https://github.com/simstudioai/sim/blob/be65087ab76bea34c19be0973f1de74e10196da0/apps/sim/app/o/%5BorganizationId%5D/links/sim-link-shortcut.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9654/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9654/files#diff-72423e4fc4ddbb5f106b09011dfd023fa2b13542e4685278e8cc92002fae9849
https://github.com/simstudioai/sim/pull/9654/files#diff-72423e4fc4ddbb5f106b09011dfd023fa2b13542e4685278e8cc92002fae9849
https://github.com/simstudioai/sim/pull/9654/files#diff-72423e4fc4ddbb5f106b09011dfd023fa2b13542e4685278e8cc92002fae9849
https://github.com/simstudioai/sim/pull/9654/files#diff-72423e4fc4ddbb5f106b09011dfd023fa2b13542e4685278e8cc92002fae9849
...ceId]/home/components/message-content/components/message-sources/message-sources.test.tsxhttps://github.com/simstudioai/sim/pull/9654/files#diff-2daf9a0ee8c8a01b6fc99bd883cabfd4fd2c851961a1909be1e4a6c5a067cd9e
View file https://github.com/simstudioai/sim/blob/be65087ab76bea34c19be0973f1de74e10196da0/apps/sim/app/workspace/%5BworkspaceId%5D/home/components/message-content/components/message-sources/message-sources.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9654/{{ revealButtonHref }}
...pace/[workspaceId]/home/components/message-content/components/source-card/source-card.tsxhttps://github.com/simstudioai/sim/pull/9654/files#diff-e4b8a579fbf132c25ec2956dc1ea0d99a457941ba58ffe26c01c4c25a3f04033
View file https://github.com/simstudioai/sim/blob/be65087ab76bea34c19be0973f1de74e10196da0/apps/sim/app/workspace/%5BworkspaceId%5D/home/components/message-content/components/source-card/source-card.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9654/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9654/files#diff-e4b8a579fbf132c25ec2956dc1ea0d99a457941ba58ffe26c01c4c25a3f04033
https://github.com/simstudioai/sim/pull/9654/files#diff-e4b8a579fbf132c25ec2956dc1ea0d99a457941ba58ffe26c01c4c25a3f04033
https://github.com/simstudioai/sim/pull/9654/files#diff-e4b8a579fbf132c25ec2956dc1ea0d99a457941ba58ffe26c01c4c25a3f04033
https://github.com/simstudioai/sim/pull/9654/files#diff-e4b8a579fbf132c25ec2956dc1ea0d99a457941ba58ffe26c01c4c25a3f04033
https://github.com/simstudioai/sim/pull/9654/files#diff-e4b8a579fbf132c25ec2956dc1ea0d99a457941ba58ffe26c01c4c25a3f04033
apps/sim/lib/sim-links/validation.test.tshttps://github.com/simstudioai/sim/pull/9654/files#diff-0635634f1921f6e21110b45c56b881392e07d154d9849f1f9723a01bdf357429
View file https://github.com/simstudioai/sim/blob/be65087ab76bea34c19be0973f1de74e10196da0/apps/sim/lib/sim-links/validation.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9654/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9654/files#diff-0635634f1921f6e21110b45c56b881392e07d154d9849f1f9723a01bdf357429
https://github.com/simstudioai/sim/pull/9654/files#diff-0635634f1921f6e21110b45c56b881392e07d154d9849f1f9723a01bdf357429
apps/sim/lib/sim-links/validation.tshttps://github.com/simstudioai/sim/pull/9654/files#diff-d4659128a93a51c87c6ddc3d1d2b70bb77560782d678ee7d3f6c8de4d7bae391
View file https://github.com/simstudioai/sim/blob/be65087ab76bea34c19be0973f1de74e10196da0/apps/sim/lib/sim-links/validation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9654/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9654/files#diff-d4659128a93a51c87c6ddc3d1d2b70bb77560782d678ee7d3f6c8de4d7bae391
https://github.com/simstudioai/sim/pull/9654/files#diff-d4659128a93a51c87c6ddc3d1d2b70bb77560782d678ee7d3f6c8de4d7bae391
Please reload this pagehttps://github.com/simstudioai/sim/pull/9654/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.