René's URL Explorer Experiment


Title: fix(workflows): keep the Run-button lint finding advisory and point at lint from apply warnings by waleedlatif1 · Pull Request #9645 · simstudioai/sim · GitHub

Open Graph Title: fix(workflows): keep the Run-button lint finding advisory and point at lint from apply warnings by waleedlatif1 · Pull Request #9645 · simstudioai/sim

X Title: fix(workflows): keep the Run-button lint finding advisory and point at lint from apply warnings by waleedlatif1 · Pull Request #9645 · simstudioai/sim

Description: Summary Lint's manualRunIssue (what the editor's Run button would refuse) is now worded as advice, kept out of "Fix these before continuing". Agent and v2 runs never apply the Run button's checks: when a workflow has more than one trigger they require an explicit trigger. So a stray unconnected Start next to a connected webhook or schedule trigger used to read as a blocker, which pushed agents to wire the Start into the graph. For an unconnected trigger, the advice names the block and gives both fixes: connect it, or delete it if the workflow starts from another trigger. It also says that runs which name their trigger are not affected. Apply-operations warnings now carry a one-line pointer that counts the findings by category ("… The findings are in lint.") instead of a second full copy of the lint message. The full findings stay in lint. A caller that reads only warnings still learns that issues exist. The formatter is refactored into one table-driven list of sections, which feeds both the full message (sim workflows lint) and the pointer. The editor's Run button selection is unchanged: an unconnected Start still wins over a connected trigger, and that stays a separate UX decision. Type of Change Bug fix Testing lint.test.ts and apply-workflow-operations.test.ts: the new and updated cases failed on the pre-fix code. They pass now. Ran the lib/workflows/editing, lib/mothership/agent-cli, lib/api/contracts/v2 and app/api/v2/workflows suites. Ran bun run lint and check:openapi, and regenerated the OpenAPI, CLI and MCP artifacts. CI runs the full gate. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Lint's manualRunIssue (what the editor's Run button would refuse) is now worded as advice, kept out of "Fix these before continuing". Agent and v2 runs never apply the Ru...

X Description: Summary Lint's manualRunIssue (what the editor's Run button would refuse) is now worded as advice, kept out of "Fix these before continuing". Agent and v2 runs ne...

Opengraph URL: https://github.com/simstudioai/sim/pull/9645

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6e2e6053-45ac-1abf-83e2-edc281cc9a5a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC5C6:1A50D7:399803:53D625:6AFB183D
html-safe-nonced573375ccd2987b65924ff7ba783b9fe713d2b3edafd9cf414d9de7665eb9a83
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUM2OjFBNTBENzozOTk4MDM6NTNENjI1OjZBRkIxODNEIiwidmlzaXRvcl9pZCI6IjE4Nzc4OTk5ODE1MzI4OTUyOTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3f2194978d35d6328a5a5e74c8f8f62694ec655803bb4321bf1dd78feedf4edc
hovercard-subject-tagpull_request:5146177870
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9645/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Lint's manualRunIssue (what the editor's Run button would refuse) is now worded as advice, kept out of "Fix these before continuing". Agent and v2 runs never apply the Ru...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9645/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9645%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9645%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9645/files
Reloadhttps://github.com/simstudioai/sim/pull/9645/files
Reloadhttps://github.com/simstudioai/sim/pull/9645/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/lint-manual-run-followupshttps://github.com/simstudioai/sim/tree/fix/lint-manual-run-followups
Conversation 2 https://github.com/simstudioai/sim/pull/9645
Commits 1 https://github.com/simstudioai/sim/pull/9645/commits
Checks 83 https://github.com/simstudioai/sim/pull/9645/checks
Files changed https://github.com/simstudioai/sim/pull/9645/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9645/files
fix(workflows): keep the Run-button lint finding advisory and point at lint from apply warnings https://github.com/simstudioai/sim/pull/9645/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9645/files
3ecef5c fix(workflows): keep the Run-button lint finding advisory and point a… waleedlatif1 Nov 3, 2026 https://github.com/simstudioai/sim/pull/9645/commits/3ecef5c70c8a51ebdfdcd10f6c4b1d4e9bae2c40
Clear filters https://github.com/simstudioai/sim/pull/9645/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9645/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9645/files
openapi-v2-workflows.json https://github.com/simstudioai/sim/pull/9645/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
workflows.ts https://github.com/simstudioai/sim/pull/9645/files#diff-8a92f40b0f57e6ef31cfc1af32cf15d24dcb56fdc7159594695a8db4f9761c91
workflows.ts https://github.com/simstudioai/sim/pull/9645/files#diff-7c1b6e587b506ea981d107bc7496349fd5020fd823e34f9c13d70f6845829728
apply-workflow-operations.test.ts https://github.com/simstudioai/sim/pull/9645/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
apply-workflow-operations.ts https://github.com/simstudioai/sim/pull/9645/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
lint.test.ts https://github.com/simstudioai/sim/pull/9645/files#diff-a8497f67cb545e069ca1b357223dd25d235493f3abbe3e464f02f052d5a5ad6e
lint.ts https://github.com/simstudioai/sim/pull/9645/files#diff-a76ac58fcebbbf0dfc7828f8ccbfdeb7c39ed49d21dca6ab2cf9174d24465bdd
apps/docs/openapi-v2-workflows.jsonhttps://github.com/simstudioai/sim/pull/9645/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
View file https://github.com/simstudioai/sim/blob/3ecef5c70c8a51ebdfdcd10f6c4b1d4e9bae2c40/apps/docs/openapi-v2-workflows.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9645/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9645/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/9645/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/9645/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/9645/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/9645/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/9645/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/9645/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/9645/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
apps/sim/lib/api/contracts/v2/openapi/workflows.tshttps://github.com/simstudioai/sim/pull/9645/files#diff-8a92f40b0f57e6ef31cfc1af32cf15d24dcb56fdc7159594695a8db4f9761c91
View file https://github.com/simstudioai/sim/blob/3ecef5c70c8a51ebdfdcd10f6c4b1d4e9bae2c40/apps/sim/lib/api/contracts/v2/openapi/workflows.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9645/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9645/files#diff-8a92f40b0f57e6ef31cfc1af32cf15d24dcb56fdc7159594695a8db4f9761c91
https://github.com/simstudioai/sim/pull/9645/files#diff-8a92f40b0f57e6ef31cfc1af32cf15d24dcb56fdc7159594695a8db4f9761c91
apps/sim/lib/api/contracts/v2/workflows.tshttps://github.com/simstudioai/sim/pull/9645/files#diff-7c1b6e587b506ea981d107bc7496349fd5020fd823e34f9c13d70f6845829728
View file https://github.com/simstudioai/sim/blob/3ecef5c70c8a51ebdfdcd10f6c4b1d4e9bae2c40/apps/sim/lib/api/contracts/v2/workflows.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9645/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9645/files#diff-7c1b6e587b506ea981d107bc7496349fd5020fd823e34f9c13d70f6845829728
https://github.com/simstudioai/sim/pull/9645/files#diff-7c1b6e587b506ea981d107bc7496349fd5020fd823e34f9c13d70f6845829728
https://github.com/simstudioai/sim/pull/9645/files#diff-7c1b6e587b506ea981d107bc7496349fd5020fd823e34f9c13d70f6845829728
https://github.com/simstudioai/sim/pull/9645/files#diff-7c1b6e587b506ea981d107bc7496349fd5020fd823e34f9c13d70f6845829728
apps/sim/lib/workflows/application/apply-workflow-operations.test.tshttps://github.com/simstudioai/sim/pull/9645/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
View file https://github.com/simstudioai/sim/blob/3ecef5c70c8a51ebdfdcd10f6c4b1d4e9bae2c40/apps/sim/lib/workflows/application/apply-workflow-operations.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9645/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9645/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
https://github.com/simstudioai/sim/pull/9645/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
apps/sim/lib/workflows/application/apply-workflow-operations.tshttps://github.com/simstudioai/sim/pull/9645/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
View file https://github.com/simstudioai/sim/blob/3ecef5c70c8a51ebdfdcd10f6c4b1d4e9bae2c40/apps/sim/lib/workflows/application/apply-workflow-operations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9645/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9645/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9645/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9645/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9645/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
apps/sim/lib/workflows/editing/lint.test.tshttps://github.com/simstudioai/sim/pull/9645/files#diff-a8497f67cb545e069ca1b357223dd25d235493f3abbe3e464f02f052d5a5ad6e
View file https://github.com/simstudioai/sim/blob/3ecef5c70c8a51ebdfdcd10f6c4b1d4e9bae2c40/apps/sim/lib/workflows/editing/lint.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9645/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9645/files#diff-a8497f67cb545e069ca1b357223dd25d235493f3abbe3e464f02f052d5a5ad6e
https://github.com/simstudioai/sim/pull/9645/files#diff-a8497f67cb545e069ca1b357223dd25d235493f3abbe3e464f02f052d5a5ad6e
https://github.com/simstudioai/sim/pull/9645/files#diff-a8497f67cb545e069ca1b357223dd25d235493f3abbe3e464f02f052d5a5ad6e
Please reload this pagehttps://github.com/simstudioai/sim/pull/9645/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9645/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.