René's URL Explorer Experiment


Title: fix(mothership): surface the real run error for browser-settled workflow tools by waleedlatif1 · Pull Request #9634 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): surface the real run error for browser-settled workflow tools by waleedlatif1 · Pull Request #9634 · simstudioai/sim

X Title: fix(mothership): surface the real run error for browser-settled workflow tools by waleedlatif1 · Pull Request #9634 · simstudioai/sim

Description: Summary When run_block, run_from_block, run_workflow, or run_workflow_until_block ran in the browser and the workflow failed, the tool error the agent read was always the generic Workflow execution failed.. The real message (: ) only showed up nested in output.output.error. Cause: getTrustedWorkflowToolExecution read only the top-level executionData.error. Error finalization (completeWithError and its cost-only fallback, finalizationPath: 'force_failed') never writes that field. It stores the message as finalOutput: { error }. Fix: the trusted read now takes finalOutput.error when the run was error-finalized (force_failed). This string has already gone through filterForDisplay and PII redaction, and the agent already sees it nested in output, so nothing new is exposed. A run that failed only through its block spans keeps its workflow output, so its finalOutput.error is workflow data. That case is not read. Cancelled runs are unchanged. Effect on consumers: in client.ts the message now becomes the top-level tool error and the persisted tool-call row error, and it is added to the trusted provenance import. It still passes through boundRunResultForModel and the secret-provenance projection unchanged. /api/copilot/confirm reads only status and executionId, so it is not affected. Type of Change Bug fix Testing New trusted-tool-failure.integration.ts runs against real Postgres. It finalizes runs through a real LoggingSession and reads them back through getTrustedWorkflowToolExecution. Thrown run returns its message. This test fails on the pre-fix code. Run that failed through its block spans with a workflow { error } output returns no message. This test fails when the force_failed gate is removed. execution-state.test.ts, mothership/request/tools/client.test.ts, and copilot/confirm/route.test.ts pass (118 tests). bun run lint passes. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary When run_block, run_from_block, run_workflow, or run_workflow_until_block ran in the browser and the workflow failed, the tool error the agent read was always the generic Workflow executio...

X Description: Summary When run_block, run_from_block, run_workflow, or run_workflow_until_block ran in the browser and the workflow failed, the tool error the agent read was always the generic Workflow executio...

Opengraph URL: https://github.com/simstudioai/sim/pull/9634

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ef9ffeb8-6d75-74c2-42a5-dbaf335527fc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2FE:1DD0F8:193E21:25169C:6AFB1D5D
html-safe-nonce8432f1d00619fa35b4b1d8ccdbbc3389de9034b67c8f1d1e4902c85cd62d4285
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkZFOjFERDBGODoxOTNFMjE6MjUxNjlDOjZBRkIxRDVEIiwidmlzaXRvcl9pZCI6IjY1NTAwMTY1ODkyNDY5NjMwMzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac698a734de95bca72e4bde85915b27a5eddeb66338f8f716615b04c1df946692a
hovercard-subject-tagpull_request:5144206261
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9634/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary When run_block, run_from_block, run_workflow, or run_workflow_until_block ran in the browser and the workflow failed, the tool error the agent read was always the generic Workflow executio...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9634/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9634%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9634%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9634/files
Reloadhttps://github.com/simstudioai/sim/pull/9634/files
Reloadhttps://github.com/simstudioai/sim/pull/9634/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/run-tool-failure-errorhttps://github.com/simstudioai/sim/tree/fix/run-tool-failure-error
Conversation 10 https://github.com/simstudioai/sim/pull/9634
Commits 2 https://github.com/simstudioai/sim/pull/9634/commits
Checks 81 https://github.com/simstudioai/sim/pull/9634/checks
Files changed https://github.com/simstudioai/sim/pull/9634/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9634/files
fix(mothership): surface the real run error for browser-settled workflow tools https://github.com/simstudioai/sim/pull/9634/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9634/files
95282c9 fix(mothership): surface the real run error for browser-settled workf… waleedlatif1 Nov 3, 2026 https://github.com/simstudioai/sim/pull/9634/commits/95282c9cc3de2db32d568bdde2bb469a5f68f5de
55c2f52 fix(mothership): clean up run logs and snapshots before the workspace… waleedlatif1 Nov 3, 2026 https://github.com/simstudioai/sim/pull/9634/commits/55c2f52823bb4be0d85f03af673e90c8f461032c
Clear filters https://github.com/simstudioai/sim/pull/9634/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9634/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9634/files
execution-state.ts https://github.com/simstudioai/sim/pull/9634/files#diff-6509a75d061f5abaa1ad68145ab01392ac3f2b8415fe25505bea7a8268de8a39
trusted-tool-failure.integration.ts https://github.com/simstudioai/sim/pull/9634/files#diff-686f5b6a46fd919d27b6b8e1219a26b690efcd9137d461a2af79ecb94f46377b
apps/sim/lib/workflows/executor/execution-state.tshttps://github.com/simstudioai/sim/pull/9634/files#diff-6509a75d061f5abaa1ad68145ab01392ac3f2b8415fe25505bea7a8268de8a39
View file https://github.com/simstudioai/sim/blob/55c2f52823bb4be0d85f03af673e90c8f461032c/apps/sim/lib/workflows/executor/execution-state.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9634/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9634/files#diff-6509a75d061f5abaa1ad68145ab01392ac3f2b8415fe25505bea7a8268de8a39
https://github.com/simstudioai/sim/pull/9634/files#diff-6509a75d061f5abaa1ad68145ab01392ac3f2b8415fe25505bea7a8268de8a39
https://github.com/simstudioai/sim/pull/9634/files#diff-6509a75d061f5abaa1ad68145ab01392ac3f2b8415fe25505bea7a8268de8a39
https://github.com/simstudioai/sim/pull/9634/files#diff-6509a75d061f5abaa1ad68145ab01392ac3f2b8415fe25505bea7a8268de8a39
https://github.com/simstudioai/sim/pull/9634/files#diff-6509a75d061f5abaa1ad68145ab01392ac3f2b8415fe25505bea7a8268de8a39
apps/sim/lib/workflows/executor/trusted-tool-failure.integration.tshttps://github.com/simstudioai/sim/pull/9634/files#diff-686f5b6a46fd919d27b6b8e1219a26b690efcd9137d461a2af79ecb94f46377b
View file https://github.com/simstudioai/sim/blob/55c2f52823bb4be0d85f03af673e90c8f461032c/apps/sim/lib/workflows/executor/trusted-tool-failure.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9634/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/9634/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.