René's URL Explorer Experiment


Title: chore(trigger): sync Trigger.dev env vars from the app's Secrets Manager secret, gated per environment by waleedlatif1 · Pull Request #9632 · simstudioai/sim · GitHub

Open Graph Title: chore(trigger): sync Trigger.dev env vars from the app's Secrets Manager secret, gated per environment by waleedlatif1 · Pull Request #9632 · simstudioai/sim

X Title: chore(trigger): sync Trigger.dev env vars from the app's Secrets Manager secret, gated per environment by waleedlatif1 · Pull Request #9632 · simstudioai/sim

Description: Summary Trigger.dev deploys can now sync the target environment from the app's env-vars secret in Secrets Manager instead of relying on hand-copied variables Off by default: a deploy syncs only when its environment slug (prod, staging, preview) is listed in the TRIGGER_ENV_SYNC_TARGETS repo variable, and only then does the job assume the deploy role for Secrets Manager. Nothing changes until that variable is set Each slug maps to exactly one app secret in code, so a deploy can't sync one environment's config into another Trigger-owned keys are never synced, so whatever value Trigger already holds stays: AWS_* (runs use workload identity, so static keys never go back in), REDIS_URL/REDIS_TLS_SERVERNAME (workers reach Redis through their own endpoint), INTERNAL_API_BASE_URL, MIGRATION_DATABASE_URL, OTEL_EXPORTER_OTLP_*, TRIGGER_*, GITHUB_TOKEN. DB_APP_NAME/SIM_DB_ROLE are code constants Synced app values are stored as secrets, except NEXT_PUBLIC_* The sync only upserts. Variables it doesn't return are left alone, and it never deletes anything A failure reading the secret exits the deploy. syncEnvVars (4.8.3) catches callback errors and deploys without syncing, so throwing isn't enough. The CI log shows counts only, never names or values With sync disabled, the deploy sends the shared constants (DB_APP_NAME, now also SIM_DB_ROLE=trigger, which every environment already holds, so the CLI's unchanged-value check skips it) plus the function-execution vars as before. The TRIGGER_DEV_ENABLED entry is dropped: syncEnvVars strips every TRIGGER_* key, so it never synced Adds plan-trigger-env-sync.ts, a names-only dry run of what enabling an environment would add or change. --apply-secret-flags marks unchanged plain-text variables as secrets, re-reading before each batch so a value rotated mid-run is skipped rather than overwritten: the CLI skips unchanged values, so isSecret alone never converts an existing variable Extracts fetchRuntimeSecrets from loadRuntimeSecrets so the boot path and the deploy read the secret the same way Type of Change Chore / infrastructure Testing Read the pinned @trigger.dev/build/trigger.dev 4.8.3 source and the webapp import route to confirm the semantics: upsert-only, isSecret flips only on changed values, sync runs before deployment init, callback errors are swallowed Ran the dry-run script against all three environments, comparing values by hash only Exercised the callback's success path, unmapped-environment exit, and missing-credentials exit packages/runtime-secrets tests; biome; check-source-conventions, check-file-names, check-import-specifiers, check-monorepo-boundaries, check-comment-hygiene, check-utils-enforcement, check-explicit-any. Full type-check and audits run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Trigger.dev deploys can now sync the target environment from the app's env-vars secret in Secrets Manager instead of relying on hand-copied variables Off by default: a deploy syncs onl...

X Description: Summary Trigger.dev deploys can now sync the target environment from the app's env-vars secret in Secrets Manager instead of relying on hand-copied variables Off by default: a deploy syncs...

Opengraph URL: https://github.com/simstudioai/sim/pull/9632

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b44c1b33-e283-9183-a0eb-a177d6c7594e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9552:2C7986:FD21D:175D81:6AFB1AF5
html-safe-nonce19c348489d98e429a8c352d04b2b099bfb6f67c535bf17d050dea50d32ff25a6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTUyOjJDNzk4NjpGRDIxRDoxNzVEODE6NkFGQjFBRjUiLCJ2aXNpdG9yX2lkIjoiMzE0MjcxNDY1MjczOTk2NzczMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceec5e7915d27d82e498319d22e909918727c09762e0edb1c36a317ebb93e1309
hovercard-subject-tagpull_request:5144041577
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9632/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Trigger.dev deploys can now sync the target environment from the app's env-vars secret in Secrets Manager instead of relying on hand-copied variables Off by default: a deploy syncs onl...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9632/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9632%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9632%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9632/files
Reloadhttps://github.com/simstudioai/sim/pull/9632/files
Reloadhttps://github.com/simstudioai/sim/pull/9632/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
chore/trigger-env-from-secrets-managerhttps://github.com/simstudioai/sim/tree/chore/trigger-env-from-secrets-manager
Conversation 16 https://github.com/simstudioai/sim/pull/9632
Commits 2 https://github.com/simstudioai/sim/pull/9632/commits
Checks 82 https://github.com/simstudioai/sim/pull/9632/checks
Files changed https://github.com/simstudioai/sim/pull/9632/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9632/files
chore(trigger): sync Trigger.dev env vars from the app's Secrets Manager secret, gated per environment https://github.com/simstudioai/sim/pull/9632/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9632/files
c8353c0 chore(trigger): sync Trigger.dev env vars from the app's Secrets Mana… waleedlatif1 Nov 3, 2026 https://github.com/simstudioai/sim/pull/9632/commits/c8353c052586f1beb8cc3c68c94d546be87fd6f1
904b8a4 fix(trigger): re-read values before flagging secrets so a rotation is… waleedlatif1 Nov 3, 2026 https://github.com/simstudioai/sim/pull/9632/commits/904b8a41068f45cc6a4a96194d7969a354d92970
Clear filters https://github.com/simstudioai/sim/pull/9632/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9632/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9632/files
ci.yml https://github.com/simstudioai/sim/pull/9632/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f
trigger-dev.yml https://github.com/simstudioai/sim/pull/9632/files#diff-09538562b725fb10f77871cd29ce85d6cb66980e020527c7860a1a20798e7d78
env.ts https://github.com/simstudioai/sim/pull/9632/files#diff-7db3fc610ff89cf819c4eb69b43ec37ae18530e1861f6c322faeb62f8f48f298
plan-trigger-env-sync.ts https://github.com/simstudioai/sim/pull/9632/files#diff-78818f8013a7f964710b0544886eb3c361fb5a42c8b20177f8abb9f4c7c4b66a
trigger.config.ts https://github.com/simstudioai/sim/pull/9632/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
package.json https://github.com/simstudioai/sim/pull/9632/files#diff-892153a4b361a9bc5abdeb1519cc8e0443e366bb19644a34eadb2bf37ae5b363
index.ts https://github.com/simstudioai/sim/pull/9632/files#diff-d4bcec1271718686c463be3258b23056fc35001035b20ae38f5cd8146419deb5
trigger-env.ts https://github.com/simstudioai/sim/pull/9632/files#diff-45d140cf7f73f71ad60850dd24ad43c51485233aeca6a66f87ed4c999ef8e313
.github/workflows/ci.ymlhttps://github.com/simstudioai/sim/pull/9632/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f
View file https://github.com/simstudioai/sim/blob/904b8a41068f45cc6a4a96194d7969a354d92970/.github/workflows/ci.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9632/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9632/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f
https://github.com/simstudioai/sim/pull/9632/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f
https://github.com/simstudioai/sim/pull/9632/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f
https://github.com/simstudioai/sim/pull/9632/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f
.github/workflows/trigger-dev.ymlhttps://github.com/simstudioai/sim/pull/9632/files#diff-09538562b725fb10f77871cd29ce85d6cb66980e020527c7860a1a20798e7d78
View file https://github.com/simstudioai/sim/blob/904b8a41068f45cc6a4a96194d7969a354d92970/.github/workflows/trigger-dev.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9632/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9632/files#diff-09538562b725fb10f77871cd29ce85d6cb66980e020527c7860a1a20798e7d78
Please reload this pagehttps://github.com/simstudioai/sim/pull/9632/files
https://github.com/simstudioai/sim/pull/9632/files#diff-09538562b725fb10f77871cd29ce85d6cb66980e020527c7860a1a20798e7d78
https://github.com/simstudioai/sim/pull/9632/files#diff-09538562b725fb10f77871cd29ce85d6cb66980e020527c7860a1a20798e7d78
apps/sim/lib/core/config/env.tshttps://github.com/simstudioai/sim/pull/9632/files#diff-7db3fc610ff89cf819c4eb69b43ec37ae18530e1861f6c322faeb62f8f48f298
View file https://github.com/simstudioai/sim/blob/904b8a41068f45cc6a4a96194d7969a354d92970/apps/sim/lib/core/config/env.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9632/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9632/files#diff-7db3fc610ff89cf819c4eb69b43ec37ae18530e1861f6c322faeb62f8f48f298
https://github.com/simstudioai/sim/pull/9632/files#diff-7db3fc610ff89cf819c4eb69b43ec37ae18530e1861f6c322faeb62f8f48f298
apps/sim/scripts/plan-trigger-env-sync.tshttps://github.com/simstudioai/sim/pull/9632/files#diff-78818f8013a7f964710b0544886eb3c361fb5a42c8b20177f8abb9f4c7c4b66a
View file https://github.com/simstudioai/sim/blob/904b8a41068f45cc6a4a96194d7969a354d92970/apps/sim/scripts/plan-trigger-env-sync.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9632/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/9632/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9632/files
apps/sim/trigger.config.tshttps://github.com/simstudioai/sim/pull/9632/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
View file https://github.com/simstudioai/sim/blob/904b8a41068f45cc6a4a96194d7969a354d92970/apps/sim/trigger.config.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9632/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9632/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
https://github.com/simstudioai/sim/pull/9632/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
https://github.com/simstudioai/sim/pull/9632/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
https://github.com/simstudioai/sim/pull/9632/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
https://github.com/simstudioai/sim/pull/9632/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
Please reload this pagehttps://github.com/simstudioai/sim/pull/9632/files
https://github.com/simstudioai/sim/pull/9632/files#diff-3e89ed60c3946e67cfc357495159a4bf5e261ea848b2fa28ddb351aa9e7a877c
https://github.com/simstudioai/sim/blob/staging/.github/CODEOWNERS#L36
packages/runtime-secrets/package.jsonhttps://github.com/simstudioai/sim/pull/9632/files#diff-892153a4b361a9bc5abdeb1519cc8e0443e366bb19644a34eadb2bf37ae5b363
View file https://github.com/simstudioai/sim/blob/904b8a41068f45cc6a4a96194d7969a354d92970/packages/runtime-secrets/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9632/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9632/files#diff-892153a4b361a9bc5abdeb1519cc8e0443e366bb19644a34eadb2bf37ae5b363
https://github.com/simstudioai/sim/pull/9632/files#diff-892153a4b361a9bc5abdeb1519cc8e0443e366bb19644a34eadb2bf37ae5b363
packages/runtime-secrets/src/index.tshttps://github.com/simstudioai/sim/pull/9632/files#diff-d4bcec1271718686c463be3258b23056fc35001035b20ae38f5cd8146419deb5
View file https://github.com/simstudioai/sim/blob/904b8a41068f45cc6a4a96194d7969a354d92970/packages/runtime-secrets/src/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9632/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9632/files#diff-d4bcec1271718686c463be3258b23056fc35001035b20ae38f5cd8146419deb5
https://github.com/simstudioai/sim/pull/9632/files#diff-d4bcec1271718686c463be3258b23056fc35001035b20ae38f5cd8146419deb5
https://github.com/simstudioai/sim/pull/9632/files#diff-d4bcec1271718686c463be3258b23056fc35001035b20ae38f5cd8146419deb5
Please reload this pagehttps://github.com/simstudioai/sim/pull/9632/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9632/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.