René's URL Explorer Experiment


Title: fix(pii): bound custom-pattern matching time per request by waleedlatif1 · Pull Request #9584 · simstudioai/sim · GitHub

Open Graph Title: fix(pii): bound custom-pattern matching time per request by waleedlatif1 · Pull Request #9584 · simstudioai/sim

X Title: fix(pii): bound custom-pattern matching time per request by waleedlatif1 · Pull Request #9584 · simstudioai/sim

Description: Summary Presidio's REGEX_TIMEOUT_SECONDS (2s) bounds one custom pattern on one text, so a single batch request could cost texts x patterns x 2s (2,000 texts x 20 patterns = ~22h on one handler thread). A pathological pattern like (a|aa)+$ hits the per-match cap on every text, and the sync handler thread keeps running after the client gives up, so each retry ties up another thread Custom-pattern recognizers now charge their matching time to a shared per-request 60s budget and reject the request with a 400 once it's spent. The cost of one request is now at most budget + one match The budget counts only custom-pattern time, not spaCy NER or built-in recognizers, so slow legitimate batches can't trip it. Benign patterns use well under 1s per 256 KB chunk, and a single text with 20 timed-out patterns stays under the budget, so single-text behavior is unchanged A 400 maps to PiiServiceRejectedError → route 422 → no retry in mask-client, and it isn't treated as an outage, so the chunk fails closed without retry amplification Updated the validate-regex.ts TSDoc that named Presidio's timeout as the only bound Type of Change Bug fix Testing Drove apps/pii/server.py with the pinned Presidio 2.2.362 / spaCy 3.8.14 / FastAPI stack through FastAPI TestClient (en_core_web_sm in place of the 5 large models), pre-fix vs post-fix: Report shape (2,000 texts x 20 (a|aa)+$ patterns, timeout 2s): post-fix /redact_batch (regex-only and full NLP paths) and /analyze_batch all return 400 in 60.4-63.0s Across the budget line (120 texts x 1 pattern, timeout 1s): pre-fix 200 after 121-165s, post-fix 400 after 60.2-60.3s Single text with a pathological pattern: /redact and /analyze still return 200 after one ~2s timeout, same as before Benign regression (2,000 realistic texts x 20 benign patterns + built-ins, all 6 endpoints incl. invalid-regex 400): pre vs post outputs are identical under a pinned PYTHONHASHSEED on 6 seeds. The only run-to-run variation is the winner of exact equal-score span ties, which varies by seed on the unmodified server too (Presidio dedups via set()) biome check on the TS file; JS gates otherwise left to CI (the diff is Python + one TSDoc sentence) Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Presidio's REGEX_TIMEOUT_SECONDS (2s) bounds one custom pattern on one text, so a single batch request could cost texts x patterns x 2s (2,000 texts x 20 patterns = ~22h on one handler...

X Description: Summary Presidio's REGEX_TIMEOUT_SECONDS (2s) bounds one custom pattern on one text, so a single batch request could cost texts x patterns x 2s (2,000 texts x 20 patterns = ~22h on one han...

Opengraph URL: https://github.com/simstudioai/sim/pull/9584

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:eb166635-a1d4-f611-e83e-0574573e04a2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC06A:2EC0A1:B278D:106E7C:6AFB0BC0
html-safe-nonce6fd355ef50f51e61123c0d803139b2a1cb4f3d38840feb2555845c073f32a034
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDZBOjJFQzBBMTpCMjc4RDoxMDZFN0M6NkFGQjBCQzAiLCJ2aXNpdG9yX2lkIjoiNTE1OTgxMTY1MzUwMzIyNDc2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2d9357c2100befbf198d17513edc0d67112b4edc8b70f3dec45fd432821fb586
hovercard-subject-tagpull_request:5127195388
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9584/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Presidio's REGEX_TIMEOUT_SECONDS (2s) bounds one custom pattern on one text, so a single batch request could cost texts x patterns x 2s (2,000 texts x 20 patterns = ~22h on one handler...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4275ec98d19a530a209480d02854be81de24ad5a05b648333242fc516bfb573c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseba13208acc32a4e7a4a3b54cb2f0dea6001ba5f8
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9584/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9584%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9584%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9584/files
Reloadhttps://github.com/simstudioai/sim/pull/9584/files
Reloadhttps://github.com/simstudioai/sim/pull/9584/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/pii-request-boundshttps://github.com/simstudioai/sim/tree/fix/pii-request-bounds
Conversation 2 https://github.com/simstudioai/sim/pull/9584
Commits 1 https://github.com/simstudioai/sim/pull/9584/commits
Checks 71 https://github.com/simstudioai/sim/pull/9584/checks
Files changed https://github.com/simstudioai/sim/pull/9584/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9584/files
fix(pii): bound custom-pattern matching time per request https://github.com/simstudioai/sim/pull/9584/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9584/files
58ba01c fix(pii): bound custom-pattern matching time per request waleedlatif1 Nov 2, 2026 https://github.com/simstudioai/sim/pull/9584/commits/58ba01c35862012d7dfd1fff454b876a268d0a99
Clear filters https://github.com/simstudioai/sim/pull/9584/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9584/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9584/files
server.py https://github.com/simstudioai/sim/pull/9584/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
validate-regex.ts https://github.com/simstudioai/sim/pull/9584/files#diff-f2295ec9999c9dd6b5c0f282d2f40f1d2b3f0a4aea577487c16d36c739220b58
apps/pii/server.pyhttps://github.com/simstudioai/sim/pull/9584/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
View file https://github.com/simstudioai/sim/blob/58ba01c35862012d7dfd1fff454b876a268d0a99/apps/pii/server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9584/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9584/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/9584/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/9584/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
apps/sim/lib/guardrails/validate-regex.tshttps://github.com/simstudioai/sim/pull/9584/files#diff-f2295ec9999c9dd6b5c0f282d2f40f1d2b3f0a4aea577487c16d36c739220b58
View file https://github.com/simstudioai/sim/blob/58ba01c35862012d7dfd1fff454b876a268d0a99/apps/sim/lib/guardrails/validate-regex.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9584/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9584/files#diff-f2295ec9999c9dd6b5c0f282d2f40f1d2b3f0a4aea577487c16d36c739220b58
https://github.com/simstudioai/sim/pull/9584/files#diff-f2295ec9999c9dd6b5c0f282d2f40f1d2b3f0a4aea577487c16d36c739220b58
Please reload this pagehttps://github.com/simstudioai/sim/pull/9584/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.