René's URL Explorer Experiment


Title: fix(copilot): hold sim_cli commands that perform approval-gated capabilities by waleedlatif1 · Pull Request #9582 · simstudioai/sim · GitHub

Open Graph Title: fix(copilot): hold sim_cli commands that perform approval-gated capabilities by waleedlatif1 · Pull Request #9582 · simstudioai/sim

X Title: fix(copilot): hold sim_cli commands that perform approval-gated capabilities by waleedlatif1 · Pull Request #9582 · simstudioai/sim

Description: Summary The copilot permission gate decided by catalog lookup alone. sim_cli has no catalog entry, so no CLI command was ever held for approval, and the CLI's own confirmation is answered by --yes in model-supplied argv The worker exposes deploy, promote, run, cancel, and MCP deploy/delete only through sim_cli, so the requiresApproval flags on promote_to_live, deploy_as_*, run_workflow, cancel_workflow_run, delete_workspace_mcp_server, and call_integration_tool guarded nothing Added resolveEmbeddedCliCommand to sim/embed: resolves argv with the CLI's real commander tree and parser (stopped at preAction, nothing runs) to the dispatched command's path and the v2 operations it declares. connect/OperationClient already refuse undeclared operations, so this bounds what the call can do cliRequestRequiresApproval holds a CLI call when any declared operation is the capability of an approval-gated catalog tool (activate + rollback, deploy/undeploy, chat publish/unpublish, MCP tool deploy/undeploy, MCP server delete, execute/resume, cancel run, tool execute). Read commands stay ungated. Argv the parser cannot follow is held Both lanes ask the same predicate: the dispatch gate (by execName) and the in-band route (with params) Always-allow is still keyed by the row's display name, but covers a CLI call only when that name matches the command the parser resolves, so a row named for another command (or generic sim_cli) never carries consent across commands Type of Change Bug fix Testing New handler tests run the real router + CLI parser through prePersistClientExecutableToolCall: a workflows activate create … --yes frame is stamped awaiting_approval; always-allow on a sibling command or sim_cli does not cover it Router lane rows for activate, rollback (gated) and list (ungated) resolveEmbeddedCliCommand tests: global flags before/between path segments, aliases; help/unknown/usage-error/--dry-run argv resolve to no command and running each through runEmbeddedCli makes zero HTTP calls Reverted each guard and confirmed its test goes red (catalog-only gate, display-name always-allow, missing rollback mapping) handlers.test.ts, router.test.ts, permission.test.ts, embed.test.ts, lint, sim-cli type-check, and the comment-hygiene/file-names/utils/explicit-any/boundaries audits locally; full suite, check:audits and type-check in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The copilot permission gate decided by catalog lookup alone. sim_cli has no catalog entry, so no CLI command was ever held for approval, and the CLI's own confirmation is answered by -...

X Description: Summary The copilot permission gate decided by catalog lookup alone. sim_cli has no catalog entry, so no CLI command was ever held for approval, and the CLI's own confirmation is answered ...

Opengraph URL: https://github.com/simstudioai/sim/pull/9582

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2b15e756-dec4-9d24-585e-5af0356d292c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB0A6:B44D2:BF8C4:118E52:6AFB0C00
html-safe-nonce0bfb1ca80fd959d0b01cda5dc19e90f05c5ac9f4372cfe7751ba8dc6b4c4a328
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEE2OkI0NEQyOkJGOEM0OjExOEU1Mjo2QUZCMEMwMCIsInZpc2l0b3JfaWQiOiI0NzY5NjY0NzMxMzY5Mzc2NzY4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3fd465a4cc16144d6a7e2f811ba61a71a179ab56c3ef1e0d4b8937b1055c949d
hovercard-subject-tagpull_request:5127087248
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9582/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The copilot permission gate decided by catalog lookup alone. sim_cli has no catalog entry, so no CLI command was ever held for approval, and the CLI's own confirmation is answered by -...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4275ec98d19a530a209480d02854be81de24ad5a05b648333242fc516bfb573c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseba13208acc32a4e7a4a3b54cb2f0dea6001ba5f8
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9582/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9582%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9582%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9582/files
Reloadhttps://github.com/simstudioai/sim/pull/9582/files
Reloadhttps://github.com/simstudioai/sim/pull/9582/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/sim-cli-approval-gatehttps://github.com/simstudioai/sim/tree/fix/sim-cli-approval-gate
Conversation 8 https://github.com/simstudioai/sim/pull/9582
Commits 2 https://github.com/simstudioai/sim/pull/9582/commits
Checks 78 https://github.com/simstudioai/sim/pull/9582/checks
Files changed https://github.com/simstudioai/sim/pull/9582/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9582/files
fix(copilot): hold sim_cli commands that perform approval-gated capabilities https://github.com/simstudioai/sim/pull/9582/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9582/files
23fed10 fix(copilot): hold sim_cli commands that perform approval-gated capab… waleedlatif1 Nov 2, 2026 https://github.com/simstudioai/sim/pull/9582/commits/23fed10a6e60c110174b2122e975b2a5a1dd2d87
1f0cab1 fix(copilot): type the sim_cli test frame as a tool call waleedlatif1 Nov 2, 2026 https://github.com/simstudioai/sim/pull/9582/commits/1f0cab170696047571deecaaa3a385e0e1391f86
Clear filters https://github.com/simstudioai/sim/pull/9582/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9582/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9582/files
route.ts https://github.com/simstudioai/sim/pull/9582/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
approval.ts https://github.com/simstudioai/sim/pull/9582/files#diff-26628b5ac4a991a0e2b0072a3c0424f23582ddf4f5e137ac57a92d35ef9fa987
handlers.test.ts https://github.com/simstudioai/sim/pull/9582/files#diff-f0cea1f1a04f5cbc9494e9a7047c476a612feb78c3d54e67f6c8cd1b967da796
tool.ts https://github.com/simstudioai/sim/pull/9582/files#diff-47a3a73474ab6d2584224561f1bffcfa95ba11f16716887b3230099298041540
permission.ts https://github.com/simstudioai/sim/pull/9582/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
router.test.ts https://github.com/simstudioai/sim/pull/9582/files#diff-5292df0417b52e26bef8e056f302fde9bbe6bd030651d36ed379e3304d630847
router.ts https://github.com/simstudioai/sim/pull/9582/files#diff-52f282abd5f8dbb1c7b9d85e1a0a18c3c41938cd929bfe76da9b206fd3026df4
embed.test.ts https://github.com/simstudioai/sim/pull/9582/files#diff-d376751b5a131e777db6866118246a930897dc9633a27fdb24ddcc7a989406c9
embed.ts https://github.com/simstudioai/sim/pull/9582/files#diff-b529d2a35d8e00b69ae4c44c43553d53785a20821e5d47abfea015cc6fcd3583
apps/sim/app/api/copilot/tools/execute/route.tshttps://github.com/simstudioai/sim/pull/9582/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
View file https://github.com/simstudioai/sim/blob/1f0cab170696047571deecaaa3a385e0e1391f86/apps/sim/app/api/copilot/tools/execute/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9582/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9582/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
https://github.com/simstudioai/sim/pull/9582/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
apps/sim/lib/mothership/agent-cli/approval.tshttps://github.com/simstudioai/sim/pull/9582/files#diff-26628b5ac4a991a0e2b0072a3c0424f23582ddf4f5e137ac57a92d35ef9fa987
View file https://github.com/simstudioai/sim/blob/1f0cab170696047571deecaaa3a385e0e1391f86/apps/sim/lib/mothership/agent-cli/approval.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9582/{{ revealButtonHref }}
apps/sim/lib/mothership/request/handlers/handlers.test.tshttps://github.com/simstudioai/sim/pull/9582/files#diff-f0cea1f1a04f5cbc9494e9a7047c476a612feb78c3d54e67f6c8cd1b967da796
View file https://github.com/simstudioai/sim/blob/1f0cab170696047571deecaaa3a385e0e1391f86/apps/sim/lib/mothership/request/handlers/handlers.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9582/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9582/files#diff-f0cea1f1a04f5cbc9494e9a7047c476a612feb78c3d54e67f6c8cd1b967da796
https://github.com/simstudioai/sim/pull/9582/files#diff-f0cea1f1a04f5cbc9494e9a7047c476a612feb78c3d54e67f6c8cd1b967da796
https://github.com/simstudioai/sim/pull/9582/files#diff-f0cea1f1a04f5cbc9494e9a7047c476a612feb78c3d54e67f6c8cd1b967da796
https://github.com/simstudioai/sim/pull/9582/files#diff-f0cea1f1a04f5cbc9494e9a7047c476a612feb78c3d54e67f6c8cd1b967da796
https://github.com/simstudioai/sim/pull/9582/files#diff-f0cea1f1a04f5cbc9494e9a7047c476a612feb78c3d54e67f6c8cd1b967da796
https://github.com/simstudioai/sim/pull/9582/files#diff-f0cea1f1a04f5cbc9494e9a7047c476a612feb78c3d54e67f6c8cd1b967da796
apps/sim/lib/mothership/request/handlers/tool.tshttps://github.com/simstudioai/sim/pull/9582/files#diff-47a3a73474ab6d2584224561f1bffcfa95ba11f16716887b3230099298041540
View file https://github.com/simstudioai/sim/blob/1f0cab170696047571deecaaa3a385e0e1391f86/apps/sim/lib/mothership/request/handlers/tool.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9582/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9582/files#diff-47a3a73474ab6d2584224561f1bffcfa95ba11f16716887b3230099298041540
https://github.com/simstudioai/sim/pull/9582/files#diff-47a3a73474ab6d2584224561f1bffcfa95ba11f16716887b3230099298041540
https://github.com/simstudioai/sim/pull/9582/files#diff-47a3a73474ab6d2584224561f1bffcfa95ba11f16716887b3230099298041540
https://github.com/simstudioai/sim/pull/9582/files#diff-47a3a73474ab6d2584224561f1bffcfa95ba11f16716887b3230099298041540
apps/sim/lib/mothership/request/tools/permission.tshttps://github.com/simstudioai/sim/pull/9582/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
View file https://github.com/simstudioai/sim/blob/1f0cab170696047571deecaaa3a385e0e1391f86/apps/sim/lib/mothership/request/tools/permission.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9582/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9582/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
https://github.com/simstudioai/sim/pull/9582/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
https://github.com/simstudioai/sim/pull/9582/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
https://github.com/simstudioai/sim/pull/9582/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
apps/sim/lib/mothership/tool-executor/router.test.tshttps://github.com/simstudioai/sim/pull/9582/files#diff-5292df0417b52e26bef8e056f302fde9bbe6bd030651d36ed379e3304d630847
View file https://github.com/simstudioai/sim/blob/1f0cab170696047571deecaaa3a385e0e1391f86/apps/sim/lib/mothership/tool-executor/router.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9582/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9582/files#diff-5292df0417b52e26bef8e056f302fde9bbe6bd030651d36ed379e3304d630847
apps/sim/lib/mothership/tool-executor/router.tshttps://github.com/simstudioai/sim/pull/9582/files#diff-52f282abd5f8dbb1c7b9d85e1a0a18c3c41938cd929bfe76da9b206fd3026df4
View file https://github.com/simstudioai/sim/blob/1f0cab170696047571deecaaa3a385e0e1391f86/apps/sim/lib/mothership/tool-executor/router.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9582/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9582/files#diff-52f282abd5f8dbb1c7b9d85e1a0a18c3c41938cd929bfe76da9b206fd3026df4
https://github.com/simstudioai/sim/pull/9582/files#diff-52f282abd5f8dbb1c7b9d85e1a0a18c3c41938cd929bfe76da9b206fd3026df4
https://github.com/simstudioai/sim/pull/9582/files#diff-52f282abd5f8dbb1c7b9d85e1a0a18c3c41938cd929bfe76da9b206fd3026df4
https://github.com/simstudioai/sim/pull/9582/files#diff-52f282abd5f8dbb1c7b9d85e1a0a18c3c41938cd929bfe76da9b206fd3026df4
packages/sim-cli/src/embed.test.tshttps://github.com/simstudioai/sim/pull/9582/files#diff-d376751b5a131e777db6866118246a930897dc9633a27fdb24ddcc7a989406c9
View file https://github.com/simstudioai/sim/blob/1f0cab170696047571deecaaa3a385e0e1391f86/packages/sim-cli/src/embed.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9582/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9582/files#diff-d376751b5a131e777db6866118246a930897dc9633a27fdb24ddcc7a989406c9
https://github.com/simstudioai/sim/pull/9582/files#diff-d376751b5a131e777db6866118246a930897dc9633a27fdb24ddcc7a989406c9
Please reload this pagehttps://github.com/simstudioai/sim/pull/9582/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.