René's URL Explorer Experiment


Title: fix(mothership): require approval before browser tools act on a page by waleedlatif1 · Pull Request #9581 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): require approval before browser tools act on a page by waleedlatif1 · Pull Request #9581 · simstudioai/sim

X Title: fix(mothership): require approval before browser tools act on a page by waleedlatif1 · Pull Request #9581 · simstudioai/sim

Description: Summary The approval gate read only the catalog's requiresApproval flag, which no browser_* tool declares, so browser actions that act on a page (navigate, click, type, fill and submit forms, upload files) ran as the user in their signed-in browser without an approval card, even with tool permissions enabled toolRequiresApproval now gates every browser tool that BROWSER_TOOL_OBSERVES_ONLY does not mark observe-only; reads (snapshot, read_text, screenshot, find, list_*, wait_for) stay ungated, the same act/observe split the terminal gate makes between run and read Derived from the Sim-owned map rather than the generated catalog, so a browser tool added later is gated by default, and the dispatch gate and the in-band lane read one answer "Don't ask again" answers for browser tools are stored under one shared key (browser_*), so one answer covers the browser instead of one prompt per kind of action; the card's menu says "Browser actions in this chat" / "in every chat" for browser tools No behavior change while COPILOT_TOOL_PERMISSIONS_ENABLED is off: the gate returns before reading any of this Type of Change Bug fix Testing desktop-tool-authorization.integration.ts (real Postgres + Redis, production pre-persist, authorize, and tool-permission routes): new browser cases; the gating case fails on the pre-fix code (desktop claims browser_click with no approval) and passes after; 16/16 passing locally permission.test.ts: new allow-for-this-chat case fails when the shared key is neutralized, passes after handlers, permission, router, run, tool-permission route, and tools/execute route suites: 256/256 passing bun run lint clean; check:file-names, check:test-patterns, check:boundaries, check:source-conventions, check:comment-hygiene, check:explicit-any, check:utils passing Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The approval gate read only the catalog's requiresApproval flag, which no browser_* tool declares, so browser actions that act on a page (navigate, click, type, fill and submit forms, ...

X Description: Summary The approval gate read only the catalog's requiresApproval flag, which no browser_* tool declares, so browser actions that act on a page (navigate, click, type, fill and submit for...

Opengraph URL: https://github.com/simstudioai/sim/pull/9581

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:23044f5e-86e2-908e-e76e-4ff3bbfc31a4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD700:3EF2E1:21A1:304C:6AFB086A
html-safe-noncec2432df90c57be8d3f945a31c75b1a831f034c70d78376173d06da5cb04f2780
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzAwOjNFRjJFMToyMUExOjMwNEM6NkFGQjA4NkEiLCJ2aXNpdG9yX2lkIjoiMjM1MDQyMTg0MjM3MzMxNDY2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd69a9a91949fba790ca4ddc7556a25f1132aaa166ff18d331a1b61973666243e
hovercard-subject-tagpull_request:5127042096
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9581/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The approval gate read only the catalog's requiresApproval flag, which no browser_* tool declares, so browser actions that act on a page (navigate, click, type, fill and submit forms, ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None76fb13cb43f1834708971f45a9cfcab5df3177a7582086613d7cdc6e98c4bfde
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseafc998826cdd963c8f91a96ae5372809ab5e296b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9581/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9581%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9581%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9581/files
Reloadhttps://github.com/simstudioai/sim/pull/9581/files
Reloadhttps://github.com/simstudioai/sim/pull/9581/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/browser-tool-approval-gatehttps://github.com/simstudioai/sim/tree/fix/browser-tool-approval-gate
Conversation 5 https://github.com/simstudioai/sim/pull/9581
Commits 1 https://github.com/simstudioai/sim/pull/9581/commits
Checks 72 https://github.com/simstudioai/sim/pull/9581/checks
Files changed https://github.com/simstudioai/sim/pull/9581/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9581/files
fix(mothership): require approval before browser tools act on a page https://github.com/simstudioai/sim/pull/9581/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9581/files
6c6c83c fix(mothership): require approval before browser tools act on a page waleedlatif1 Nov 2, 2026 https://github.com/simstudioai/sim/pull/9581/commits/6c6c83cbb4ba8c6240193dfbd4c9f1d9004116c7
Clear filters https://github.com/simstudioai/sim/pull/9581/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9581/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9581/files
route.ts https://github.com/simstudioai/sim/pull/9581/files#diff-f70845c007e33e50c0f4ea549929f7508cd0108437350712ef1173cd6a692696
tool-permission-card.tsx https://github.com/simstudioai/sim/pull/9581/files#diff-727e3d51ccf2ba7b718a7291835d30a57e083814c71057751f6155564fc0964f
approval-key.ts https://github.com/simstudioai/sim/pull/9581/files#diff-1deb28201d3b013c071f3d51a67d04d246c5e488c058872df8b8f8d212b07bae
permission.test.ts https://github.com/simstudioai/sim/pull/9581/files#diff-704c1f6c3e5c90de1c7ef6d18f516fff324c5f539b26585bb0a26df2de1cf1d4
permission.ts https://github.com/simstudioai/sim/pull/9581/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
router.ts https://github.com/simstudioai/sim/pull/9581/files#diff-52f282abd5f8dbb1c7b9d85e1a0a18c3c41938cd929bfe76da9b206fd3026df4
desktop-tool-authorization.integration.ts https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
apps/sim/app/api/copilot/tool-permission/route.tshttps://github.com/simstudioai/sim/pull/9581/files#diff-f70845c007e33e50c0f4ea549929f7508cd0108437350712ef1173cd6a692696
View file https://github.com/simstudioai/sim/blob/6c6c83cbb4ba8c6240193dfbd4c9f1d9004116c7/apps/sim/app/api/copilot/tool-permission/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9581/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9581/files#diff-f70845c007e33e50c0f4ea549929f7508cd0108437350712ef1173cd6a692696
https://github.com/simstudioai/sim/pull/9581/files#diff-f70845c007e33e50c0f4ea549929f7508cd0108437350712ef1173cd6a692696
https://github.com/simstudioai/sim/pull/9581/files#diff-f70845c007e33e50c0f4ea549929f7508cd0108437350712ef1173cd6a692696
https://github.com/simstudioai/sim/pull/9581/files#diff-f70845c007e33e50c0f4ea549929f7508cd0108437350712ef1173cd6a692696
...kspaceId]/home/components/message-content/components/agent-group/tool-permission-card.tsxhttps://github.com/simstudioai/sim/pull/9581/files#diff-727e3d51ccf2ba7b718a7291835d30a57e083814c71057751f6155564fc0964f
View file https://github.com/simstudioai/sim/blob/6c6c83cbb4ba8c6240193dfbd4c9f1d9004116c7/apps/sim/app/workspace/%5BworkspaceId%5D/home/components/message-content/components/agent-group/tool-permission-card.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9581/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9581/files#diff-727e3d51ccf2ba7b718a7291835d30a57e083814c71057751f6155564fc0964f
https://github.com/simstudioai/sim/pull/9581/files#diff-727e3d51ccf2ba7b718a7291835d30a57e083814c71057751f6155564fc0964f
https://github.com/simstudioai/sim/pull/9581/files#diff-727e3d51ccf2ba7b718a7291835d30a57e083814c71057751f6155564fc0964f
https://github.com/simstudioai/sim/pull/9581/files#diff-727e3d51ccf2ba7b718a7291835d30a57e083814c71057751f6155564fc0964f
https://github.com/simstudioai/sim/pull/9581/files#diff-727e3d51ccf2ba7b718a7291835d30a57e083814c71057751f6155564fc0964f
apps/sim/lib/mothership/persistence/tool-permission/approval-key.tshttps://github.com/simstudioai/sim/pull/9581/files#diff-1deb28201d3b013c071f3d51a67d04d246c5e488c058872df8b8f8d212b07bae
View file https://github.com/simstudioai/sim/blob/6c6c83cbb4ba8c6240193dfbd4c9f1d9004116c7/apps/sim/lib/mothership/persistence/tool-permission/approval-key.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9581/{{ revealButtonHref }}
apps/sim/lib/mothership/request/tools/permission.test.tshttps://github.com/simstudioai/sim/pull/9581/files#diff-704c1f6c3e5c90de1c7ef6d18f516fff324c5f539b26585bb0a26df2de1cf1d4
View file https://github.com/simstudioai/sim/blob/6c6c83cbb4ba8c6240193dfbd4c9f1d9004116c7/apps/sim/lib/mothership/request/tools/permission.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9581/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9581/files#diff-704c1f6c3e5c90de1c7ef6d18f516fff324c5f539b26585bb0a26df2de1cf1d4
https://github.com/simstudioai/sim/pull/9581/files#diff-704c1f6c3e5c90de1c7ef6d18f516fff324c5f539b26585bb0a26df2de1cf1d4
apps/sim/lib/mothership/request/tools/permission.tshttps://github.com/simstudioai/sim/pull/9581/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
View file https://github.com/simstudioai/sim/blob/6c6c83cbb4ba8c6240193dfbd4c9f1d9004116c7/apps/sim/lib/mothership/request/tools/permission.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9581/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9581/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
https://github.com/simstudioai/sim/pull/9581/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
https://github.com/simstudioai/sim/pull/9581/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
https://github.com/simstudioai/sim/pull/9581/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
https://github.com/simstudioai/sim/pull/9581/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
https://github.com/simstudioai/sim/pull/9581/files#diff-8e6376c674c2288d67bafcd70487b757ffc749b1d2873a0936838b6289904c62
apps/sim/lib/mothership/tool-executor/router.tshttps://github.com/simstudioai/sim/pull/9581/files#diff-52f282abd5f8dbb1c7b9d85e1a0a18c3c41938cd929bfe76da9b206fd3026df4
View file https://github.com/simstudioai/sim/blob/6c6c83cbb4ba8c6240193dfbd4c9f1d9004116c7/apps/sim/lib/mothership/tool-executor/router.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9581/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9581/files#diff-52f282abd5f8dbb1c7b9d85e1a0a18c3c41938cd929bfe76da9b206fd3026df4
https://github.com/simstudioai/sim/pull/9581/files#diff-52f282abd5f8dbb1c7b9d85e1a0a18c3c41938cd929bfe76da9b206fd3026df4
apps/sim/lib/mothership/tools/client/desktop-tool-authorization.integration.tshttps://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
View file https://github.com/simstudioai/sim/blob/6c6c83cbb4ba8c6240193dfbd4c9f1d9004116c7/apps/sim/lib/mothership/tools/client/desktop-tool-authorization.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9581/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
https://github.com/simstudioai/sim/pull/9581/files#diff-61f75ff366cf2f7f8a45d7ffc3ee7ce604077b3b2d3785f14249a1a8e1aa70eb
Please reload this pagehttps://github.com/simstudioai/sim/pull/9581/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.