René's URL Explorer Experiment


Title: fix(media): restrict ffmpeg inputs to media demuxers by waleedlatif1 · Pull Request #9577 · simstudioai/sim · GitHub

Open Graph Title: fix(media): restrict ffmpeg inputs to media demuxers by waleedlatif1 · Pull Request #9577 · simstudioai/sim

X Title: fix(media): restrict ffmpeg inputs to media demuxers by waleedlatif1 · Pull Request #9577 · simstudioai/sim

Description: Summary FFmpeg picks an input's demuxer from its bytes, not its filename. An uploaded DASH manifest declared as video/mp4 was demuxed as DASH and pulled media from a path outside the operation's temp dir into the output (reproduced against the shipped ffmpeg 7.1 via convert, probe, and the STT video path) Every ffmpeg/ffprobe input now carries -format_whitelist limited to media containers (mov/mp4, matroska/webm, avi, flv, asf, mpegts, mpeg, mp3, wav, ogg, flac, aac, aiff, amr, caf, png/jpeg/webp/gif), so concat, hls, dash, and imf can no longer be selected by content A demuxer the code forces with -f (our own concat list, the lavfi silence source) is added to that input's whitelist rather than exempting it, so nothing opened through it escapes the media list The posture no longer depends on upstream per-demuxer defaults (concat safe, hls/dash extension allowlists, mov enable_drefs). Pinning -safe 1 etc. per input was rejected: ffmpeg fails any input whose demuxer doesn't own that option Type of Change Bug fix Testing E2E against the prod image's ffmpeg 7.1.5 (non-root app user), running the real runFfmpegOperation / extractAudioFromVideo before and after: 38 legitimate cases — every operation (incl. concat with silent-audio synthesis, add_text, overlay png/jpg/webp/gif), 22 container/codec types, both STT paths — succeed with byte-identical outputs pre/post DASH manifest: pre-fix read an outside-temp-dir media file through convert/probe/STT; post-fix rejected with "Format not on whitelist". ffconcat, HLS (.m3u8 via declared MIME), and IMF also rejected at the format gate Same matrix natively on ffmpeg 9.0: identical pre/post results for all legitimate cases lib/media + lib/audio vitest (67 passing); pinned-argv expectations updated for the new flag biome on changed files; full audits/type-check/tests via CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary FFmpeg picks an input's demuxer from its bytes, not its filename. An uploaded DASH manifest declared as video/mp4 was demuxed as DASH and pulled media from a path outside the operation...

X Description: Summary FFmpeg picks an input's demuxer from its bytes, not its filename. An uploaded DASH manifest declared as video/mp4 was demuxed as DASH and pulled media from a path outside the opera...

Opengraph URL: https://github.com/simstudioai/sim/pull/9577

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:80058481-bf98-bd55-6344-220db2389f2d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA66:228216:5290E9:752565:6AFB07A4
html-safe-noncee49618adb8e8d476dbabbff6c9ee14b28711ab0f7aac2a805c00afe660fe1c0d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTY2OjIyODIxNjo1MjkwRTk6NzUyNTY1OjZBRkIwN0E0IiwidmlzaXRvcl9pZCI6IjExMzk2MjAxMDg2NTAwODgzNTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5ba17c74964813614a1f689b9040dc664e69e00e1390cf6fc0dd7e620acc131e
hovercard-subject-tagpull_request:5126860706
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9577/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary FFmpeg picks an input's demuxer from its bytes, not its filename. An uploaded DASH manifest declared as video/mp4 was demuxed as DASH and pulled media from a path outside the operation...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None76fb13cb43f1834708971f45a9cfcab5df3177a7582086613d7cdc6e98c4bfde
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseafc998826cdd963c8f91a96ae5372809ab5e296b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9577/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9577%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9577%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9577/files
Reloadhttps://github.com/simstudioai/sim/pull/9577/files
Reloadhttps://github.com/simstudioai/sim/pull/9577/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/ffmpeg-input-format-whitelisthttps://github.com/simstudioai/sim/tree/fix/ffmpeg-input-format-whitelist
Conversation 14 https://github.com/simstudioai/sim/pull/9577
Commits 3 https://github.com/simstudioai/sim/pull/9577/commits
Checks 71 https://github.com/simstudioai/sim/pull/9577/checks
Files changed https://github.com/simstudioai/sim/pull/9577/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9577/files
fix(media): restrict ffmpeg inputs to media demuxers https://github.com/simstudioai/sim/pull/9577/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9577/files
743a91e fix(media): restrict ffmpeg inputs to media demuxers waleedlatif1 Nov 2, 2026 https://github.com/simstudioai/sim/pull/9577/commits/743a91e38a2e8e931bdad4dafa8a3ac3dd692f78
2889e3d fix(media): allow bmp, tiff, and ico image demuxers waleedlatif1 Nov 2, 2026 https://github.com/simstudioai/sim/pull/9577/commits/2889e3df82c599460dd499a451d00920432151c8
fe45621 fix(media): allow apng demuxer waleedlatif1 Nov 2, 2026 https://github.com/simstudioai/sim/pull/9577/commits/fe45621604bfca77d385e5e189ceae53425e05fb
Clear filters https://github.com/simstudioai/sim/pull/9577/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9577/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9577/files
extractor.test.ts https://github.com/simstudioai/sim/pull/9577/files#diff-98b75cac9fd96da475d11feb1157ae9f9c4149cfaa7b61022d986e3502f06bb9
ffmpeg-process.ts https://github.com/simstudioai/sim/pull/9577/files#diff-e011003449d7169aa594d23b9a013b8d45ee83d558a5fbdd2b9587c18caaecb7
ffmpeg.test.ts https://github.com/simstudioai/sim/pull/9577/files#diff-84d6454b1747ffe231fb651f9c2f250ca9c9ffca1b44c177c5c5930d7f68bc1e
apps/sim/lib/audio/extractor.test.tshttps://github.com/simstudioai/sim/pull/9577/files#diff-98b75cac9fd96da475d11feb1157ae9f9c4149cfaa7b61022d986e3502f06bb9
View file https://github.com/simstudioai/sim/blob/fe45621604bfca77d385e5e189ceae53425e05fb/apps/sim/lib/audio/extractor.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9577/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9577/files#diff-98b75cac9fd96da475d11feb1157ae9f9c4149cfaa7b61022d986e3502f06bb9
https://github.com/simstudioai/sim/pull/9577/files#diff-98b75cac9fd96da475d11feb1157ae9f9c4149cfaa7b61022d986e3502f06bb9
apps/sim/lib/media/ffmpeg-process.tshttps://github.com/simstudioai/sim/pull/9577/files#diff-e011003449d7169aa594d23b9a013b8d45ee83d558a5fbdd2b9587c18caaecb7
View file https://github.com/simstudioai/sim/blob/fe45621604bfca77d385e5e189ceae53425e05fb/apps/sim/lib/media/ffmpeg-process.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9577/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9577/files#diff-e011003449d7169aa594d23b9a013b8d45ee83d558a5fbdd2b9587c18caaecb7
Please reload this pagehttps://github.com/simstudioai/sim/pull/9577/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9577/files
https://github.com/simstudioai/sim/pull/9577/files#diff-e011003449d7169aa594d23b9a013b8d45ee83d558a5fbdd2b9587c18caaecb7
apps/sim/lib/media/ffmpeg.test.tshttps://github.com/simstudioai/sim/pull/9577/files#diff-84d6454b1747ffe231fb651f9c2f250ca9c9ffca1b44c177c5c5930d7f68bc1e
View file https://github.com/simstudioai/sim/blob/fe45621604bfca77d385e5e189ceae53425e05fb/apps/sim/lib/media/ffmpeg.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9577/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9577/files#diff-84d6454b1747ffe231fb651f9c2f250ca9c9ffca1b44c177c5c5930d7f68bc1e
https://github.com/simstudioai/sim/pull/9577/files#diff-84d6454b1747ffe231fb651f9c2f250ca9c9ffca1b44c177c5c5930d7f68bc1e
https://github.com/simstudioai/sim/pull/9577/files#diff-84d6454b1747ffe231fb651f9c2f250ca9c9ffca1b44c177c5c5930d7f68bc1e
https://github.com/simstudioai/sim/pull/9577/files#diff-84d6454b1747ffe231fb651f9c2f250ca9c9ffca1b44c177c5c5930d7f68bc1e
Please reload this pagehttps://github.com/simstudioai/sim/pull/9577/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.