René's URL Explorer Experiment


Title: fix(mcp): answer workflow MCP JSON-RPC errors over HTTP 200 instead of session-loss statuses by waleedlatif1 · Pull Request #9561 · simstudioai/sim · GitHub

Open Graph Title: fix(mcp): answer workflow MCP JSON-RPC errors over HTTP 200 instead of session-loss statuses by waleedlatif1 · Pull Request #9561 · simstudioai/sim

X Title: fix(mcp): answer workflow MCP JSON-RPC errors over HTTP 200 instead of session-loss statuses by waleedlatif1 · Pull Request #9561 · simstudioai/sim

Description: Summary Workflow MCP servers answered some JSON-RPC errors to well-formed requests with HTTP 404 (unknown method, unknown tool) or 400 (invalid tools/call params, undeployed workflow, and workflow-service 400/404 failures passed through). In Streamable HTTP those statuses mean a lost or bad session: the MCP SDK client turns any non-2xx into a StreamableHTTPError and drops the JSON-RPC body, and Sim's own MCP client treats 400/404 as a dead session, retires the pooled connection, and retries a call that can never succeed New jsonRpcErrorResponse decides the status for every request-scoped JSON-RPC error in one place: 400/401/404 go out at 200 (as the SDK's reference server sends protocol errors); 408/409/413/429/499/500/503 keep their retry, limit, and alarm meaning. data.httpStatus still records the workflow service's status Malformed messages (parse error, invalid JSON-RPC envelope) keep their 400, matching the SDK server Clients that accept text/event-stream already received every tools/call error at 200 inside the stream; this makes the JSON path agree Removes an unreachable Tool name required branch (the params schema already requires a non-empty name) Type of Change Bug fix Testing route.test.ts: drives the route with the real SDK Client + StreamableHTTPClientTransport (MethodNotFound now arrives as McpError), plus a table over the JSON path for invalid params, unknown tool, undeployed workflow, and workflow-service 404/400 failures All 6 new cases fail against the current staging route; the 39 existing cases (which pin the 408/409/413/429/499/403 statuses) pass both before and after — 45/45 green bun run lint, check:test-patterns, check:comment-hygiene, check:source-conventions, check:explicit-any; full type-check and audits left to CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Workflow MCP servers answered some JSON-RPC errors to well-formed requests with HTTP 404 (unknown method, unknown tool) or 400 (invalid tools/call params, undeployed workflow, and workflow...

X Description: Summary Workflow MCP servers answered some JSON-RPC errors to well-formed requests with HTTP 404 (unknown method, unknown tool) or 400 (invalid tools/call params, undeployed workflow, and workflow...

Opengraph URL: https://github.com/simstudioai/sim/pull/9561

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:188ceaa4-3f38-c15b-a1e3-55160ac9f552
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id93D4:E3FF6:4A7B8:6A9E1:6AFB09E0
html-safe-noncecb2e653eeab2da05e4b336651f752e716d097114416a82809245d8d704e61f59
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0Q0OkUzRkY2OjRBN0I4OjZBOUUxOjZBRkIwOUUwIiwidmlzaXRvcl9pZCI6IjMwNTA1NDM3NjU1MDk1NzMwODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5b605ce2d8e3846003e6f459ab74735f366925438430816c884a8098579b32f8
hovercard-subject-tagpull_request:5116800724
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9561/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Workflow MCP servers answered some JSON-RPC errors to well-formed requests with HTTP 404 (unknown method, unknown tool) or 400 (invalid tools/call params, undeployed workflow, and workflow...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None76fb13cb43f1834708971f45a9cfcab5df3177a7582086613d7cdc6e98c4bfde
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseafc998826cdd963c8f91a96ae5372809ab5e296b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9561/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9561%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9561%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9561/files
Reloadhttps://github.com/simstudioai/sim/pull/9561/files
Reloadhttps://github.com/simstudioai/sim/pull/9561/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/mcp-serve-method-not-foundhttps://github.com/simstudioai/sim/tree/fix/mcp-serve-method-not-found
Conversation 6 https://github.com/simstudioai/sim/pull/9561
Commits 2 https://github.com/simstudioai/sim/pull/9561/commits
Checks 71 https://github.com/simstudioai/sim/pull/9561/checks
Files changed https://github.com/simstudioai/sim/pull/9561/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9561/files
fix(mcp): answer workflow MCP JSON-RPC errors over HTTP 200 instead of session-loss statuses https://github.com/simstudioai/sim/pull/9561/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9561/files
769e6a6 fix(mcp): answer workflow MCP JSON-RPC errors over HTTP 200 instead o… waleedlatif1 Nov 2, 2026 https://github.com/simstudioai/sim/pull/9561/commits/769e6a6c6e6b64db842d612d365cb747c4ff73fa
e685368 fix(mcp): build the routed test request from a standard Request waleedlatif1 Nov 2, 2026 https://github.com/simstudioai/sim/pull/9561/commits/e6853688815e4d4f9ce6f9a2e390bccf811c432b
Clear filters https://github.com/simstudioai/sim/pull/9561/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9561/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9561/files
route.test.ts https://github.com/simstudioai/sim/pull/9561/files#diff-640b70d1a89956b78bee61dbe58795cb6ea2ea7ca0d1feb513d4347b842c165f
route.ts https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
apps/sim/app/api/mcp/serve/[serverId]/route.test.tshttps://github.com/simstudioai/sim/pull/9561/files#diff-640b70d1a89956b78bee61dbe58795cb6ea2ea7ca0d1feb513d4347b842c165f
View file https://github.com/simstudioai/sim/blob/e6853688815e4d4f9ce6f9a2e390bccf811c432b/apps/sim/app/api/mcp/serve/%5BserverId%5D/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9561/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9561/files#diff-640b70d1a89956b78bee61dbe58795cb6ea2ea7ca0d1feb513d4347b842c165f
https://github.com/simstudioai/sim/pull/9561/files#diff-640b70d1a89956b78bee61dbe58795cb6ea2ea7ca0d1feb513d4347b842c165f
https://github.com/simstudioai/sim/pull/9561/files#diff-640b70d1a89956b78bee61dbe58795cb6ea2ea7ca0d1feb513d4347b842c165f
https://github.com/simstudioai/sim/pull/9561/files#diff-640b70d1a89956b78bee61dbe58795cb6ea2ea7ca0d1feb513d4347b842c165f
https://github.com/simstudioai/sim/pull/9561/files#diff-640b70d1a89956b78bee61dbe58795cb6ea2ea7ca0d1feb513d4347b842c165f
https://github.com/simstudioai/sim/pull/9561/files#diff-640b70d1a89956b78bee61dbe58795cb6ea2ea7ca0d1feb513d4347b842c165f
https://github.com/simstudioai/sim/pull/9561/files#diff-640b70d1a89956b78bee61dbe58795cb6ea2ea7ca0d1feb513d4347b842c165f
apps/sim/app/api/mcp/serve/[serverId]/route.tshttps://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
View file https://github.com/simstudioai/sim/blob/e6853688815e4d4f9ce6f9a2e390bccf811c432b/apps/sim/app/api/mcp/serve/%5BserverId%5D/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9561/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/9561/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.