René's URL Explorer Experiment


Title: fix(desktop): address release review — count app downloads and unchecked terminals before an update restart, send the page referrer on Save Image, and tighten sign-in and people edge cases by waleedlatif1 · Pull Request #9547 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop): address release review — count app downloads and unchecked terminals before an update restart, send the page referrer on Save Image, and tighten sign-in and people edge cases by waleedlatif1 · Pull Request #9547 · simstudioai/sim

X Title: fix(desktop): address release review — count app downloads and unchecked terminals before an update restart, send the page referrer on Save Image, and tighten sign-in and people edge cases by waleedlatif1 · Pull Request #9547 · simstudioai/sim

Description: Summary Verified review findings from the v0.9.39 release PR (#9544) on this session's desktop and people work: Update restart counts app-window downloads. Large Files-page downloads start a native download from the app window that the in-flight check didn't see, so "Restart to update" could cut one off with no warning. App-window DownloadItems are now tracked in downloads.ts and summed with agent-browser downloads Unreadable terminals are no longer treated as idle. readForegroundProcessGroup returns shell | group | unknown instead of null for both "the shell owns the foreground" and "the probe failed". unknown now prompts ("A terminal couldn't be checked and may still be running a command."); a dead shell pid reads as idle; Windows skips ps; stopCommand still never escalates without a confirmed group. Results fold in stable session order, and unnamed commands read "N terminal commands are still running." instead of "a command and a command" A failing in-flight check asks instead of restarting silently ("Sim couldn't check whether restarting would interrupt any work.") Consumed relaunch routes are flushed immediately, so a crash right after an update relaunch can't reopen the same windows again Save Image sends the page's referrer. Referrer-protected images failed to save while Open Image worked. A small W3C Referrer-Policy function (new browser-agent/referrer.ts, with the existing menu referrer helpers moved there) computes the header Electron's downloadURL maps into Chromium's download referrer: no-referrer, origin-only cross-origin by default, none on an https→http downgrade, credentials and fragment stripped, oversize → origin Sign-in: the passkey hint waits for the pending-sign-in query to resolve instead of reading "loading" as "no handoff"; continuablePage refuses URLs carrying credentials, matching the shell's isSafeExternalUrl; the notice's TSDoc no longer claims one line (it wraps on purpose) People: a profile whose manager is suspended shows "Manager is suspended." instead of "No manager recorded." Type of Change Bug fix Testing downloads.test.ts, in-flight-work.test.ts, updater.test.ts, terminal/service.test.ts, new terminal/process-group.test.ts (real exited pid → idle), new browser-agent/referrer.test.ts, sign-in-hosts.test.ts — new cases red on the pre-fix code e2e/browser-page-parity.spec.ts: the image fixture now refuses requests without a Referer and records it; Save Image asserts the full page URL was sent (fails with the bare downloadURL) desktop tsc --noEmit, targeted apps/sim type-check, biome; full gate in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Verified review findings from the v0.9.39 release PR (#9544) on this session's desktop and people work: Update restart counts app-window downloads. Large Files-page downloads start a n...

X Description: Summary Verified review findings from the v0.9.39 release PR (#9544) on this session's desktop and people work: Update restart counts app-window downloads. Large Files-page downloads start...

Opengraph URL: https://github.com/simstudioai/sim/pull/9547

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1f29b4bc-e2ac-cb30-b947-efb564b38d09
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB354:1BB7A8:7FC76:B7E1A:6AFB1937
html-safe-noncea67d102170bf2db50470c055f70b0554ab8aa252dd4fec0d68ad2d6e50103c9e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzU0OjFCQjdBODo3RkM3NjpCN0UxQTo2QUZCMTkzNyIsInZpc2l0b3JfaWQiOiI3MTE0MDc0MTUwMzA5NDAyOTM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd7929f2e19b15b4fae01824b400fcbd9aa14ac5aaaa75120429aa6057b131677
hovercard-subject-tagpull_request:5104712964
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9547/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Verified review findings from the v0.9.39 release PR (#9544) on this session's desktop and people work: Update restart counts app-window downloads. Large Files-page downloads start a n...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9547/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9547%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9547%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9547/files
Reloadhttps://github.com/simstudioai/sim/pull/9547/files
Reloadhttps://github.com/simstudioai/sim/pull/9547/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/release-review-comment-fixeshttps://github.com/simstudioai/sim/tree/fix/release-review-comment-fixes
Conversation 5 https://github.com/simstudioai/sim/pull/9547
Commits 1 https://github.com/simstudioai/sim/pull/9547/commits
Checks 74 https://github.com/simstudioai/sim/pull/9547/checks
Files changed https://github.com/simstudioai/sim/pull/9547/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9547/files
fix(desktop): address release review — count app downloads and unchecked terminals before an update restart, send the page referrer on Save Image, and tighten sign-in and people edge cases https://github.com/simstudioai/sim/pull/9547/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9547/files
eee4a69 fix(desktop): address release review — count app downloads and unchec… waleedlatif1 Nov 1, 2026 https://github.com/simstudioai/sim/pull/9547/commits/eee4a69e098f7a7cae39f3bd1b2d80a84066d651
Clear filters https://github.com/simstudioai/sim/pull/9547/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9547/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9547/files
browser-page-parity.spec.ts https://github.com/simstudioai/sim/pull/9547/files#diff-a0baec9e103b79f161bc1c052facc91ad5c13188ec9f9e7a374779ed5d960a34
updater.ts https://github.com/simstudioai/sim/pull/9547/files#diff-d05ad2cd4b4acef40a64a505660ea88f497f44d4a4ca4311916d9a51dab5e03e
context-menu.ts https://github.com/simstudioai/sim/pull/9547/files#diff-051edc65e5f7f175926dbf968bdbc77638e5830820b1903740f3592173e79583
referrer.test.ts https://github.com/simstudioai/sim/pull/9547/files#diff-6ca2c528318dbe5983b3e7b8f5942e9c75580c9abc394f525296ebdd0d8d7a52
referrer.ts https://github.com/simstudioai/sim/pull/9547/files#diff-9b8fc5bd91f4570dfc48c7dadea390c802e030cd9aebf52a9c7d63c4e9035cd8
downloads.test.ts https://github.com/simstudioai/sim/pull/9547/files#diff-71f498c6afe97c3e8bb69bb36b7720bc8e210658892af409d369233c8c9d3b22
downloads.ts https://github.com/simstudioai/sim/pull/9547/files#diff-e429d90e8210e26701a99ef22153a8333df59b7d7078eacb4b1fd67dbb6f2d37
in-flight-work.test.ts https://github.com/simstudioai/sim/pull/9547/files#diff-8c3bb3222c17aa3dc5611911e5a2ebe2bb3852428626854532674c75694b7427
in-flight-work.ts https://github.com/simstudioai/sim/pull/9547/files#diff-3b963e75a5adb465a72fc9e6094fdd73d0fb14ded12927779140b971e191a3fa
index.ts https://github.com/simstudioai/sim/pull/9547/files#diff-5bf7db7b15749c034541a4a70a0cacf9816b4e214fd11cb5735c5ddb7ca4b1d8
index.ts https://github.com/simstudioai/sim/pull/9547/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
process-group.test.ts https://github.com/simstudioai/sim/pull/9547/files#diff-b6036d460605e159e6227a04b5ff141dcb3f746acb4ee3aa7af8fda33cdef1da
process-group.ts https://github.com/simstudioai/sim/pull/9547/files#diff-e549f171320c07acba40114c20da64aa99586dfa4543f0c95bc05cac3221f8dd
registry.ts https://github.com/simstudioai/sim/pull/9547/files#diff-d30cc33e9e00dd9009a54bd75a24dbf056890b72571f5101186e11fd9291f199
service.test.ts https://github.com/simstudioai/sim/pull/9547/files#diff-ccf1a39e658c6d2cc7398268ef30d8d5da1a8ac78f2c13fdc808e54926c575cb
updater.test.ts https://github.com/simstudioai/sim/pull/9547/files#diff-0d46817435dcd69c44c58e6a04c3da617de298f35f971d036fab402a9e89f501
updater.ts https://github.com/simstudioai/sim/pull/9547/files#diff-2c6665d35565a24497c27ea0f07e85853958beada9e7889bd1f81068ef1fe76a
person.tsx https://github.com/simstudioai/sim/pull/9547/files#diff-d35fed7f0631ad830e8123bd01c1f46f7d8a77cdab60cb50bea493bc4f4a03ee
browser-notice.tsx https://github.com/simstudioai/sim/pull/9547/files#diff-3aee5ce240c9b64d6c621e8c180cc440cd857d053a2de71373f2123d85d23aec
sign-in-hosts.test.ts https://github.com/simstudioai/sim/pull/9547/files#diff-b463eae7befff932b9ecc88107cf101f2e7bf008cef62bc5f2c9ab9fd99e0b36
sign-in-hosts.ts https://github.com/simstudioai/sim/pull/9547/files#diff-edc59f8b710397eff59564f9e599372278cdec95f055e6d52dfe66ae93b96eb0
use-continue-sign-in.ts https://github.com/simstudioai/sim/pull/9547/files#diff-117efba114eef4e930bc76befd1ee5f24bc6070e377250d20a55ff144a589d8a
apps/desktop/e2e/browser-page-parity.spec.tshttps://github.com/simstudioai/sim/pull/9547/files#diff-a0baec9e103b79f161bc1c052facc91ad5c13188ec9f9e7a374779ed5d960a34
View file https://github.com/simstudioai/sim/blob/eee4a69e098f7a7cae39f3bd1b2d80a84066d651/apps/desktop/e2e/browser-page-parity.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9547/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9547/files#diff-a0baec9e103b79f161bc1c052facc91ad5c13188ec9f9e7a374779ed5d960a34
https://github.com/simstudioai/sim/pull/9547/files#diff-a0baec9e103b79f161bc1c052facc91ad5c13188ec9f9e7a374779ed5d960a34
https://github.com/simstudioai/sim/pull/9547/files#diff-a0baec9e103b79f161bc1c052facc91ad5c13188ec9f9e7a374779ed5d960a34
https://github.com/simstudioai/sim/pull/9547/files#diff-a0baec9e103b79f161bc1c052facc91ad5c13188ec9f9e7a374779ed5d960a34
https://github.com/simstudioai/sim/pull/9547/files#diff-a0baec9e103b79f161bc1c052facc91ad5c13188ec9f9e7a374779ed5d960a34
apps/desktop/e2e/fixtures/updater.tshttps://github.com/simstudioai/sim/pull/9547/files#diff-d05ad2cd4b4acef40a64a505660ea88f497f44d4a4ca4311916d9a51dab5e03e
View file https://github.com/simstudioai/sim/blob/eee4a69e098f7a7cae39f3bd1b2d80a84066d651/apps/desktop/e2e/fixtures/updater.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9547/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9547/files#diff-d05ad2cd4b4acef40a64a505660ea88f497f44d4a4ca4311916d9a51dab5e03e
https://github.com/simstudioai/sim/pull/9547/files#diff-d05ad2cd4b4acef40a64a505660ea88f497f44d4a4ca4311916d9a51dab5e03e
apps/desktop/src/main/browser-agent/context-menu.tshttps://github.com/simstudioai/sim/pull/9547/files#diff-051edc65e5f7f175926dbf968bdbc77638e5830820b1903740f3592173e79583
View file https://github.com/simstudioai/sim/blob/eee4a69e098f7a7cae39f3bd1b2d80a84066d651/apps/desktop/src/main/browser-agent/context-menu.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9547/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9547/files#diff-051edc65e5f7f175926dbf968bdbc77638e5830820b1903740f3592173e79583
https://github.com/simstudioai/sim/pull/9547/files#diff-051edc65e5f7f175926dbf968bdbc77638e5830820b1903740f3592173e79583
https://github.com/simstudioai/sim/pull/9547/files#diff-051edc65e5f7f175926dbf968bdbc77638e5830820b1903740f3592173e79583
https://github.com/simstudioai/sim/pull/9547/files#diff-051edc65e5f7f175926dbf968bdbc77638e5830820b1903740f3592173e79583
https://github.com/simstudioai/sim/pull/9547/files#diff-051edc65e5f7f175926dbf968bdbc77638e5830820b1903740f3592173e79583
https://github.com/simstudioai/sim/pull/9547/files#diff-051edc65e5f7f175926dbf968bdbc77638e5830820b1903740f3592173e79583
apps/desktop/src/main/browser-agent/referrer.test.tshttps://github.com/simstudioai/sim/pull/9547/files#diff-6ca2c528318dbe5983b3e7b8f5942e9c75580c9abc394f525296ebdd0d8d7a52
View file https://github.com/simstudioai/sim/blob/eee4a69e098f7a7cae39f3bd1b2d80a84066d651/apps/desktop/src/main/browser-agent/referrer.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9547/{{ revealButtonHref }}
apps/desktop/src/main/browser-agent/referrer.tshttps://github.com/simstudioai/sim/pull/9547/files#diff-9b8fc5bd91f4570dfc48c7dadea390c802e030cd9aebf52a9c7d63c4e9035cd8
View file https://github.com/simstudioai/sim/blob/eee4a69e098f7a7cae39f3bd1b2d80a84066d651/apps/desktop/src/main/browser-agent/referrer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9547/{{ revealButtonHref }}
apps/desktop/src/main/downloads.test.tshttps://github.com/simstudioai/sim/pull/9547/files#diff-71f498c6afe97c3e8bb69bb36b7720bc8e210658892af409d369233c8c9d3b22
View file https://github.com/simstudioai/sim/blob/eee4a69e098f7a7cae39f3bd1b2d80a84066d651/apps/desktop/src/main/downloads.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9547/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9547/files#diff-71f498c6afe97c3e8bb69bb36b7720bc8e210658892af409d369233c8c9d3b22
https://github.com/simstudioai/sim/pull/9547/files#diff-71f498c6afe97c3e8bb69bb36b7720bc8e210658892af409d369233c8c9d3b22
apps/desktop/src/main/downloads.tshttps://github.com/simstudioai/sim/pull/9547/files#diff-e429d90e8210e26701a99ef22153a8333df59b7d7078eacb4b1fd67dbb6f2d37
View file https://github.com/simstudioai/sim/blob/eee4a69e098f7a7cae39f3bd1b2d80a84066d651/apps/desktop/src/main/downloads.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9547/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9547/files#diff-e429d90e8210e26701a99ef22153a8333df59b7d7078eacb4b1fd67dbb6f2d37
https://github.com/simstudioai/sim/pull/9547/files#diff-e429d90e8210e26701a99ef22153a8333df59b7d7078eacb4b1fd67dbb6f2d37
https://github.com/simstudioai/sim/pull/9547/files#diff-e429d90e8210e26701a99ef22153a8333df59b7d7078eacb4b1fd67dbb6f2d37
https://github.com/simstudioai/sim/pull/9547/files#diff-e429d90e8210e26701a99ef22153a8333df59b7d7078eacb4b1fd67dbb6f2d37
https://github.com/simstudioai/sim/pull/9547/files#diff-e429d90e8210e26701a99ef22153a8333df59b7d7078eacb4b1fd67dbb6f2d37
Please reload this pagehttps://github.com/simstudioai/sim/pull/9547/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9547/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.