René's URL Explorer Experiment


Title: fix(release): read Excel start dates, refuse impossible times and repeated columns, keep typed escapes, no suggestions for punctuation by waleedlatif1 · Pull Request #9545 · simstudioai/sim · GitHub

Open Graph Title: fix(release): read Excel start dates, refuse impossible times and repeated columns, keep typed escapes, no suggestions for punctuation by waleedlatif1 · Pull Request #9545 · simstudioai/sim

X Title: fix(release): read Excel start dates, refuse impossible times and repeated columns, keep typed escapes, no suggestions for punctuation by waleedlatif1 · Pull Request #9545 · simstudioai/sim

Description: Summary Fixes from the v0.9.39 release review for People, Sim Links and the extension: People import, Excel dates: the workbook is read with cellNF: true, so a date cell keeps its number format and is converted from its stored value. Without it, dates formatted 1/31/24 or 31/01/2024 reached the server as display text and their whole row was skipped People start dates: a time of day and offset must be real (T99:99, T24:00, +99:99 are refused) and a date uses one separator throughout (2024-01/31 is refused), instead of being accepted and dropped People import columns: two headers that spell the same recognized column (Email and e-mail) are refused, instead of one being silently ignored Sim Links suggestions: a typed name that is only punctuation suggests nothing (it used to fall through to the most-visited links); the prefix logic moved into a pure typedSimLinkPrefix in lib/sim-links/validation.ts Extension sim keyword: an escape already typed (a/b) is kept rather than encoded again, so the keyword resolves a value the same way the typed sim/ address does Type of Change Bug fix Testing lib/people/import.test.ts and lib/sim-links/destination.test.ts: 107 passing, with new cases that fail on the previous code (impossible times and mixed separators, repeated columns, punctuation-only prefixes) Excel date handling verified by reading back generated workbooks with and without cellNF Extension type-check; lint, check:api-validation:strict, check:boundaries, check:client-boundary, check:source-conventions, check:utils, check:comment-hygiene, check:test-patterns, check:unused-exports Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Fixes from the v0.9.39 release review for People, Sim Links and the extension: People import, Excel dates: the workbook is read with cellNF: true, so a date cell keeps its number format an...

X Description: Summary Fixes from the v0.9.39 release review for People, Sim Links and the extension: People import, Excel dates: the workbook is read with cellNF: true, so a date cell keeps its number format an...

Opengraph URL: https://github.com/simstudioai/sim/pull/9545

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:809cd911-af34-37d0-299a-cd1f64996a44
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D9C:62CE4:B480F:108777:6AFB197C
html-safe-nonce626d860d745e15aa5b6dacbfb171638e419b10c136dc85706fff74018153add2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDlDOjYyQ0U0OkI0ODBGOjEwODc3Nzo2QUZCMTk3QyIsInZpc2l0b3JfaWQiOiIyNjkwNzAyNzI5NjE2NzU5MTY0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac96efcc26adcacc07b0c41d48926d0cd128df824ea9f0997d120179c5c3414cce
hovercard-subject-tagpull_request:5104631606
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9545/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Fixes from the v0.9.39 release review for People, Sim Links and the extension: People import, Excel dates: the workbook is read with cellNF: true, so a date cell keeps its number format an...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9545/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9545%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9545%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9545/files
Reloadhttps://github.com/simstudioai/sim/pull/9545/files
Reloadhttps://github.com/simstudioai/sim/pull/9545/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/release-review-our-threadshttps://github.com/simstudioai/sim/tree/fix/release-review-our-threads
Conversation 18 https://github.com/simstudioai/sim/pull/9545
Commits 3 https://github.com/simstudioai/sim/pull/9545/commits
Checks 69 https://github.com/simstudioai/sim/pull/9545/checks
Files changed https://github.com/simstudioai/sim/pull/9545/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9545/files
fix(release): read Excel start dates, refuse impossible times and repeated columns, keep typed escapes, no suggestions for punctuation https://github.com/simstudioai/sim/pull/9545/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9545/files
3ff0517 fix(release): read Excel start dates, refuse impossible times and rep… waleedlatif1 Nov 1, 2026 https://github.com/simstudioai/sim/pull/9545/commits/3ff0517f4d79da5973a5dd34601eef069d6f8078
2d50d6a fix(people): honor the 1904 date system and cover the sheet reader wi… waleedlatif1 Nov 1, 2026 https://github.com/simstudioai/sim/pull/9545/commits/2d50d6abd32dfd1e5d2311e4d1be9e6c73e94ad5
1f1dbcb fix(people): pass an out-of-range date serial through instead of fail… waleedlatif1 Nov 1, 2026 https://github.com/simstudioai/sim/pull/9545/commits/1f1dbcbe7d2eddba69770f0b99de780282cbe90b
Clear filters https://github.com/simstudioai/sim/pull/9545/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9545/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9545/files
omnibox.ts https://github.com/simstudioai/sim/pull/9545/files#diff-01df94bab7468559dde7721050536db4ebe05c4fd0f6a8dc17aa58b1a47c771f
people-import-modal.tsx https://github.com/simstudioai/sim/pull/9545/files#diff-1e0e132778825cc36dfd701e00177e675b3082b8d1d85c410df1ce4b5fdf68d9
read-people-sheet.test.ts https://github.com/simstudioai/sim/pull/9545/files#diff-0f2784e6f1a28c6e777c87889e48504c5fe014621f8f197b8f05733e2f66d366
read-people-sheet.ts https://github.com/simstudioai/sim/pull/9545/files#diff-a2976fec4745b08bc0b341512775522ae8eb571946899aa7c90176f30977edf7
import.test.ts https://github.com/simstudioai/sim/pull/9545/files#diff-c7b9583d9a2e75b00a4becdbc3481ba1a224d3a087253f81fc01415c495e367a
import.ts https://github.com/simstudioai/sim/pull/9545/files#diff-afec7ac84b3a1a4633dddcb83eaa829ce263542d404bb31eb471b11a44cf5d5b
validation.ts https://github.com/simstudioai/sim/pull/9545/files#diff-5860aae8006c62a186db2911511f746532054af663cad54f79374e92c9e2ac60
use-cases.ts https://github.com/simstudioai/sim/pull/9545/files#diff-7a0d4cbabcc6e145251c2bca1b84e4ea96104d376b00d3a175143c75376b0907
destination.test.ts https://github.com/simstudioai/sim/pull/9545/files#diff-6dda5130c2fc19b4b5c8883eddd56cc6aa6bc23fab2d6d342c2fb7ea27d67a6a
validation.ts https://github.com/simstudioai/sim/pull/9545/files#diff-d4659128a93a51c87c6ddc3d1d2b70bb77560782d678ee7d3f6c8de4d7bae391
apps/extension/src/omnibox.tshttps://github.com/simstudioai/sim/pull/9545/files#diff-01df94bab7468559dde7721050536db4ebe05c4fd0f6a8dc17aa58b1a47c771f
View file https://github.com/simstudioai/sim/blob/1f1dbcbe7d2eddba69770f0b99de780282cbe90b/apps/extension/src/omnibox.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9545/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9545/files#diff-01df94bab7468559dde7721050536db4ebe05c4fd0f6a8dc17aa58b1a47c771f
https://github.com/simstudioai/sim/pull/9545/files#diff-01df94bab7468559dde7721050536db4ebe05c4fd0f6a8dc17aa58b1a47c771f
apps/sim/app/o/[organizationId]/people/people-import-modal.tsxhttps://github.com/simstudioai/sim/pull/9545/files#diff-1e0e132778825cc36dfd701e00177e675b3082b8d1d85c410df1ce4b5fdf68d9
View file https://github.com/simstudioai/sim/blob/1f1dbcbe7d2eddba69770f0b99de780282cbe90b/apps/sim/app/o/%5BorganizationId%5D/people/people-import-modal.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9545/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9545/files#diff-1e0e132778825cc36dfd701e00177e675b3082b8d1d85c410df1ce4b5fdf68d9
https://github.com/simstudioai/sim/pull/9545/files#diff-1e0e132778825cc36dfd701e00177e675b3082b8d1d85c410df1ce4b5fdf68d9
apps/sim/app/o/[organizationId]/people/read-people-sheet.test.tshttps://github.com/simstudioai/sim/pull/9545/files#diff-0f2784e6f1a28c6e777c87889e48504c5fe014621f8f197b8f05733e2f66d366
View file https://github.com/simstudioai/sim/blob/1f1dbcbe7d2eddba69770f0b99de780282cbe90b/apps/sim/app/o/%5BorganizationId%5D/people/read-people-sheet.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9545/{{ revealButtonHref }}
apps/sim/app/o/[organizationId]/people/read-people-sheet.tshttps://github.com/simstudioai/sim/pull/9545/files#diff-a2976fec4745b08bc0b341512775522ae8eb571946899aa7c90176f30977edf7
View file https://github.com/simstudioai/sim/blob/1f1dbcbe7d2eddba69770f0b99de780282cbe90b/apps/sim/app/o/%5BorganizationId%5D/people/read-people-sheet.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9545/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/9545/files
apps/sim/lib/people/import.test.tshttps://github.com/simstudioai/sim/pull/9545/files#diff-c7b9583d9a2e75b00a4becdbc3481ba1a224d3a087253f81fc01415c495e367a
View file https://github.com/simstudioai/sim/blob/1f1dbcbe7d2eddba69770f0b99de780282cbe90b/apps/sim/lib/people/import.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9545/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9545/files#diff-c7b9583d9a2e75b00a4becdbc3481ba1a224d3a087253f81fc01415c495e367a
https://github.com/simstudioai/sim/pull/9545/files#diff-c7b9583d9a2e75b00a4becdbc3481ba1a224d3a087253f81fc01415c495e367a
https://github.com/simstudioai/sim/pull/9545/files#diff-c7b9583d9a2e75b00a4becdbc3481ba1a224d3a087253f81fc01415c495e367a
https://github.com/simstudioai/sim/pull/9545/files#diff-c7b9583d9a2e75b00a4becdbc3481ba1a224d3a087253f81fc01415c495e367a
https://github.com/simstudioai/sim/pull/9545/files#diff-c7b9583d9a2e75b00a4becdbc3481ba1a224d3a087253f81fc01415c495e367a
apps/sim/lib/people/import.tshttps://github.com/simstudioai/sim/pull/9545/files#diff-afec7ac84b3a1a4633dddcb83eaa829ce263542d404bb31eb471b11a44cf5d5b
View file https://github.com/simstudioai/sim/blob/1f1dbcbe7d2eddba69770f0b99de780282cbe90b/apps/sim/lib/people/import.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9545/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9545/files#diff-afec7ac84b3a1a4633dddcb83eaa829ce263542d404bb31eb471b11a44cf5d5b
Please reload this pagehttps://github.com/simstudioai/sim/pull/9545/files
https://github.com/simstudioai/sim/pull/9545/files#diff-afec7ac84b3a1a4633dddcb83eaa829ce263542d404bb31eb471b11a44cf5d5b
apps/sim/lib/people/validation.tshttps://github.com/simstudioai/sim/pull/9545/files#diff-5860aae8006c62a186db2911511f746532054af663cad54f79374e92c9e2ac60
View file https://github.com/simstudioai/sim/blob/1f1dbcbe7d2eddba69770f0b99de780282cbe90b/apps/sim/lib/people/validation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9545/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9545/files#diff-5860aae8006c62a186db2911511f746532054af663cad54f79374e92c9e2ac60
https://github.com/simstudioai/sim/pull/9545/files#diff-5860aae8006c62a186db2911511f746532054af663cad54f79374e92c9e2ac60
https://github.com/simstudioai/sim/pull/9545/files#diff-5860aae8006c62a186db2911511f746532054af663cad54f79374e92c9e2ac60
Please reload this pagehttps://github.com/simstudioai/sim/pull/9545/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9545/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.