René's URL Explorer Experiment


Title: fix(auth): check a workspace's personal-key switch after membership by waleedlatif1 · Pull Request #9540 · simstudioai/sim · GitHub

Open Graph Title: fix(auth): check a workspace's personal-key switch after membership by waleedlatif1 · Pull Request #9540 · simstudioai/sim

X Title: fix(auth): check a workspace's personal-key switch after membership by waleedlatif1 · Pull Request #9540 · simstudioai/sim

Description: Summary authorizeWorkspaceOperation refused a personal API key or OAuth token on a workspace with personal keys switched off before checking membership. Workspace use cases load their canonical context before authorizing, so a non-member got 403 PERSONAL_API_KEYS_DISABLED for a resource that exists and 404 for one that doesn't. With v2 file routes accepting guessable files/… paths, that is a practical file-existence oracle for those workspaces. The column check now runs right after the role check, like the permission-group key beside it already did, for the same reason. A non-member gets the concealed NoWorkspaceAccessError (404 on v2). A member still gets PERSONAL_API_KEYS_DISABLED. The only visible change for members: one whose role is also too low gets the insufficient-role 403 first (still a 403). Costs one permission lookup, and only for a key hitting a workspace that disabled them. Same ordering exists in project-file authorization, audit-log and billing reads, and the v2 chat route; left for a follow-up so this change stays one shared site. Type of Change Bug fix Testing workspace-authorization.test.ts: the case that pinned column-before-role is inverted ("conceals the workspace before refusing the workspace personal-key column"); it fails on the old order Table and workspace-file authorization cases that pinned "no permission lookup" now assert a member's refusal All 39 suites touching disabled personal keys: 908 tests pass biome, check:comment-hygiene, check:test-patterns; rest in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary authorizeWorkspaceOperation refused a personal API key or OAuth token on a workspace with personal keys switched off before checking membership. Workspace use cases load their canonical co...

X Description: Summary authorizeWorkspaceOperation refused a personal API key or OAuth token on a workspace with personal keys switched off before checking membership. Workspace use cases load their canonical co...

Opengraph URL: https://github.com/simstudioai/sim/pull/9540

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ac9344f3-4baa-d367-9e74-3aedd994b3e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF62:259FF9:724A3:A4E69:6AFB18D3
html-safe-nonceccf5299110c96f65b788ef8a87d90503c112891445a75cb15b64f8ce3cc5d9fe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjYyOjI1OUZGOTo3MjRBMzpBNEU2OTo2QUZCMThEMyIsInZpc2l0b3JfaWQiOiI3ODIwOTAxODcwMzA5NDE1MTIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacec43dca52c8761afbe56beb14f331fd0a6e8d80b0d4b94a25d7b545f782deea1
hovercard-subject-tagpull_request:5100467904
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9540/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary authorizeWorkspaceOperation refused a personal API key or OAuth token on a workspace with personal keys switched off before checking membership. Workspace use cases load their canonical co...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9540/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9540%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9540%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9540/files
Reloadhttps://github.com/simstudioai/sim/pull/9540/files
Reloadhttps://github.com/simstudioai/sim/pull/9540/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/personal-key-switch-after-membershiphttps://github.com/simstudioai/sim/tree/fix/personal-key-switch-after-membership
Conversation 8 https://github.com/simstudioai/sim/pull/9540
Commits 2 https://github.com/simstudioai/sim/pull/9540/commits
Checks 68 https://github.com/simstudioai/sim/pull/9540/checks
Files changed https://github.com/simstudioai/sim/pull/9540/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9540/files
fix(auth): check a workspace's personal-key switch after membership https://github.com/simstudioai/sim/pull/9540/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9540/files
04fbded fix(auth): check a workspace's personal-key switch after membership, … waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9540/commits/04fbded1cfa061cbb1ff3f8f0041cfd82709007a
27acfa3 test(auth): import the key-switch error from the application barrel waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9540/commits/27acfa3a24728c77542f4a2afacbfd4d7fa8b3de
Clear filters https://github.com/simstudioai/sim/pull/9540/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9540/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9540/files
workspace-authorization.test.ts https://github.com/simstudioai/sim/pull/9540/files#diff-c8aa1a3ae25679e2b4a7eeacbc5f4665eaff4dbbe2acfaf66596d2af984cd30a
workspace-authorization.ts https://github.com/simstudioai/sim/pull/9540/files#diff-2b4e149b3b521774f2b4633161c35fda329616f502a23d1bacd8a46e67850f14
authorization.test.ts https://github.com/simstudioai/sim/pull/9540/files#diff-77c6044bb82bd20dce139ab58b27204a281e5ee40ada3c0cef67ba6a54650762
authorization.test.ts https://github.com/simstudioai/sim/pull/9540/files#diff-b8410c1d9141028d6e1bca2f86d95936a97f33c42518c8671d365655892f1e31
apps/sim/lib/core/application/workspace-authorization.test.tshttps://github.com/simstudioai/sim/pull/9540/files#diff-c8aa1a3ae25679e2b4a7eeacbc5f4665eaff4dbbe2acfaf66596d2af984cd30a
View file https://github.com/simstudioai/sim/blob/27acfa3a24728c77542f4a2afacbfd4d7fa8b3de/apps/sim/lib/core/application/workspace-authorization.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9540/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9540/files#diff-c8aa1a3ae25679e2b4a7eeacbc5f4665eaff4dbbe2acfaf66596d2af984cd30a
https://github.com/simstudioai/sim/pull/9540/files#diff-c8aa1a3ae25679e2b4a7eeacbc5f4665eaff4dbbe2acfaf66596d2af984cd30a
apps/sim/lib/core/application/workspace-authorization.tshttps://github.com/simstudioai/sim/pull/9540/files#diff-2b4e149b3b521774f2b4633161c35fda329616f502a23d1bacd8a46e67850f14
View file https://github.com/simstudioai/sim/blob/27acfa3a24728c77542f4a2afacbfd4d7fa8b3de/apps/sim/lib/core/application/workspace-authorization.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9540/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9540/files#diff-2b4e149b3b521774f2b4633161c35fda329616f502a23d1bacd8a46e67850f14
https://github.com/simstudioai/sim/pull/9540/files#diff-2b4e149b3b521774f2b4633161c35fda329616f502a23d1bacd8a46e67850f14
apps/sim/lib/table/application/authorization.test.tshttps://github.com/simstudioai/sim/pull/9540/files#diff-77c6044bb82bd20dce139ab58b27204a281e5ee40ada3c0cef67ba6a54650762
View file https://github.com/simstudioai/sim/blob/27acfa3a24728c77542f4a2afacbfd4d7fa8b3de/apps/sim/lib/table/application/authorization.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9540/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9540/files#diff-77c6044bb82bd20dce139ab58b27204a281e5ee40ada3c0cef67ba6a54650762
https://github.com/simstudioai/sim/pull/9540/files#diff-77c6044bb82bd20dce139ab58b27204a281e5ee40ada3c0cef67ba6a54650762
https://github.com/simstudioai/sim/pull/9540/files#diff-77c6044bb82bd20dce139ab58b27204a281e5ee40ada3c0cef67ba6a54650762
https://github.com/simstudioai/sim/pull/9540/files#diff-77c6044bb82bd20dce139ab58b27204a281e5ee40ada3c0cef67ba6a54650762
apps/sim/lib/workspace-files/application/authorization.test.tshttps://github.com/simstudioai/sim/pull/9540/files#diff-b8410c1d9141028d6e1bca2f86d95936a97f33c42518c8671d365655892f1e31
View file https://github.com/simstudioai/sim/blob/27acfa3a24728c77542f4a2afacbfd4d7fa8b3de/apps/sim/lib/workspace-files/application/authorization.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9540/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9540/files#diff-b8410c1d9141028d6e1bca2f86d95936a97f33c42518c8671d365655892f1e31
https://github.com/simstudioai/sim/pull/9540/files#diff-b8410c1d9141028d6e1bca2f86d95936a97f33c42518c8671d365655892f1e31
https://github.com/simstudioai/sim/pull/9540/files#diff-b8410c1d9141028d6e1bca2f86d95936a97f33c42518c8671d365655892f1e31
https://github.com/simstudioai/sim/pull/9540/files#diff-b8410c1d9141028d6e1bca2f86d95936a97f33c42518c8671d365655892f1e31
Please reload this pagehttps://github.com/simstudioai/sim/pull/9540/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.