René's URL Explorer Experiment


Title: fix(mothership): Stop only cancels detached runs still running, and a held workflow run never blocks the next turn's workbench by waleedlatif1 · Pull Request #9532 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): Stop only cancels detached runs still running, and a held workflow run never blocks the next turn's workbench by waleedlatif1 · Pull Request #9532 · simstudioai/sim

X Title: fix(mothership): Stop only cancels detached runs still running, and a held workflow run never blocks the next turn's workbench by waleedlatif1 · Pull Request #9532 · simstudioai/sim

Description: Summary Follow-ups to #9507 found in the release audit: Stop cancelled settled and paused runs. getDetachedWorkflowExecutions returned every execution a call in the stream ever detached, and Stop wrote the durable 14-day cancel flag for each. A run paused at a human-in-the-loop block resumes under the same execution id, read the flag, and was cancelled. Stop now cancels only runs whose log reads running (or that have no log yet, i.e. still starting); paused runs are left alone, matching the pre-#9507 behaviour where a paused browser run was already settled A held workflow run blocked the next turn's workbench. answerWithinWait retains the run so the call's executionSettledAt stays null while it runs; prepareWorkbenchAccess counted that as handlersPending, so every run_code/sandbox call in the next turn failed for up to 95 minutes. Workflow-tool rows (which never touch the chat's workbench) no longer count; their unsettled sandbox processes still feed recovery Stop read full JSONB payloads inside transactions. The status/exit-code filters now run in SQL and only the argv and status fields are selected, so member/workspace/chat/account deletion no longer materializes every sim_cli stdout of a stopped turn Reuse WORKFLOW_TOOL_NAMES instead of a duplicate list; explicit settled-state tracking in answerWithinWait instead of a Promise.race ordering trick; the admission log poll is capped at 60 s past the wait Type of Change Bug fix Testing workflow-client-settlement.integration.ts (real Postgres + Redis): detached CLI and tool runs whose log is pending/completed/failed/cancelled are not cancelled; a run answered still running with no log yet still is; a later turn's workbench access isn't blocked by an earlier still-running run_workflow, while an earlier function_execute still blocks (control). Ran locally: 21/21; with the pre-fix repository 5 fail Unit tests in tools/handlers/workflow, async-runs, request/application, request/handlers (209 pass); biome; full gate in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-ups to #9507 found in the release audit: Stop cancelled settled and paused runs. getDetachedWorkflowExecutions returned every execution a call in the stream ever detached, and Stop ...

X Description: Summary Follow-ups to #9507 found in the release audit: Stop cancelled settled and paused runs. getDetachedWorkflowExecutions returned every execution a call in the stream ever detached, and Stop ...

Opengraph URL: https://github.com/simstudioai/sim/pull/9532

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:199e0dc3-dbca-da91-94ba-662484cbc670
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA66C:13E0E8:65BF8:938BF:6AFB18C8
html-safe-noncebc8f51de483f519f740ef0f099f373397d9ebdc609bf2f37049a3e4145deb069
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjZDOjEzRTBFODo2NUJGODo5MzhCRjo2QUZCMThDOCIsInZpc2l0b3JfaWQiOiI1NjA2MjgyNjQzNjEyODMzOTkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc0f5abad008a01f3e4c3282302c0b039c581d1f2b2a1cb8a3fa5c2ee2fc738aa
hovercard-subject-tagpull_request:5100210615
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9532/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-ups to #9507 found in the release audit: Stop cancelled settled and paused runs. getDetachedWorkflowExecutions returned every execution a call in the stream ever detached, and Stop ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9532/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9532%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9532%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9532/files
Reloadhttps://github.com/simstudioai/sim/pull/9532/files
Reloadhttps://github.com/simstudioai/sim/pull/9532/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/mothership-detached-run-stophttps://github.com/simstudioai/sim/tree/fix/mothership-detached-run-stop
Conversation 8 https://github.com/simstudioai/sim/pull/9532
Commits 3 https://github.com/simstudioai/sim/pull/9532/commits
Checks 68 https://github.com/simstudioai/sim/pull/9532/checks
Files changed https://github.com/simstudioai/sim/pull/9532/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9532/files
fix(mothership): Stop only cancels detached runs still running, and a held workflow run never blocks the next turn's workbench https://github.com/simstudioai/sim/pull/9532/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9532/files
9b9dd8c fix(mothership): Stop only cancels detached runs still running, and a… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9532/commits/9b9dd8c395b3e0f216c93f37d791468c3417efe0
b5d6485 improvement(mothership): read a detached run's call as flat columns, … waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9532/commits/b5d6485654138026ca7a3fc261cbbc3c266b4383
335ad5c fix(mothership): answer a workflow tool run that settles as its log i… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9532/commits/335ad5c17c907f393ab46f509a9203c72731f426
Clear filters https://github.com/simstudioai/sim/pull/9532/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9532/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9532/files
repository.test.ts https://github.com/simstudioai/sim/pull/9532/files#diff-65477a5dab5147750f9ad486598f69bba7a3a0a4060444ba54d248bbd5e4e2b0
repository.ts https://github.com/simstudioai/sim/pull/9532/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
workflow-client-settlement.integration.ts https://github.com/simstudioai/sim/pull/9532/files#diff-6a39db06a36dd0cf836f92d639e1440aa1478de64363b8da264c8d45cee948bb
client-executed-tools.ts https://github.com/simstudioai/sim/pull/9532/files#diff-4343b663eafafff43034464e945d663b80afe14691fff01de4848e82281e7513
mutations.test.ts https://github.com/simstudioai/sim/pull/9532/files#diff-89abbe76d1d93218e8039c94bfa8eb68def5aa2764193f4da62be00e202b1b33
mutations.ts https://github.com/simstudioai/sim/pull/9532/files#diff-81377dbd502454dc8ea8a1c4ba13ad1674ca34c2db52803f696df53ecfbeae31
apps/sim/lib/mothership/async-runs/repository.test.tshttps://github.com/simstudioai/sim/pull/9532/files#diff-65477a5dab5147750f9ad486598f69bba7a3a0a4060444ba54d248bbd5e4e2b0
View file https://github.com/simstudioai/sim/blob/335ad5c17c907f393ab46f509a9203c72731f426/apps/sim/lib/mothership/async-runs/repository.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9532/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9532/files#diff-65477a5dab5147750f9ad486598f69bba7a3a0a4060444ba54d248bbd5e4e2b0
https://github.com/simstudioai/sim/pull/9532/files#diff-65477a5dab5147750f9ad486598f69bba7a3a0a4060444ba54d248bbd5e4e2b0
https://github.com/simstudioai/sim/pull/9532/files#diff-65477a5dab5147750f9ad486598f69bba7a3a0a4060444ba54d248bbd5e4e2b0
https://github.com/simstudioai/sim/pull/9532/files#diff-65477a5dab5147750f9ad486598f69bba7a3a0a4060444ba54d248bbd5e4e2b0
apps/sim/lib/mothership/async-runs/repository.tshttps://github.com/simstudioai/sim/pull/9532/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
View file https://github.com/simstudioai/sim/blob/335ad5c17c907f393ab46f509a9203c72731f426/apps/sim/lib/mothership/async-runs/repository.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9532/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9532/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9532/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9532/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9532/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9532/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9532/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9532/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9532/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9532/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9532/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9532/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
Please reload this pagehttps://github.com/simstudioai/sim/pull/9532/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9532/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.