René's URL Explorer Experiment


Title: fix(auth): block only curated disposable domains, and never gate SSO or SCIM provisioning by waleedlatif1 · Pull Request #9529 · simstudioai/sim · GitHub

Open Graph Title: fix(auth): block only curated disposable domains, and never gate SSO or SCIM provisioning by waleedlatif1 · Pull Request #9529 · simstudioai/sim

X Title: fix(auth): block only curated disposable domains, and never gate SSO or SCIM provisioning by waleedlatif1 · Pull Request #9529 · simstudioai/sim

Description: Summary #9516 vendored the union of the auto-generated disposable/disposable-email-domains list (~98.5k) and the curated CC0 disposable-email-domains blocklist. The auto-generated list includes real companies and ISP mail (railway.com, namecheap.com, q.com, yandex.net, cafe24.com, domain.com…) and public suffixes (msk.ru, it.com, pp.ua, dyndns.org, ddns.net…) which, with parent-domain matching, refused every *.msk.ru company Ship only the curated CC0 list (the one PyPI uses), generated by bun run vendor:disposable-email-domains from the same pinned commit: entries that aren't a registrable domain under tldts (ICANN or private suffixes) are dropped, relays moved out of runtime, and a commented list of real providers removed (21cn.com, hola.org, sify.com). 10,079 domains (was 98,687); the Tranco top-20k intersection is 7, all genuinely disposable/dynamic-DNS Never gate org-controlled provisioning: SCIM (/admin/create-user, whose 403 made IdPs retry forever) and SSO callbacks (domain-verified providers) skip the check; email signup, social OAuth and generic OAuth stay gated Domain is taken after the last @ with a trailing dot stripped; fail-open on load error kept Email/password signup now shows the disposable-email message on the email field instead of "Failed to create account" Type of Change Bug fix Testing disposable.test.ts: listed/subdomain/case/trailing-dot/quoted-@ refused; company.msk.ru, acme.it.com, railway.com, relays and gmail allowed; invariant that the JSON contains no public suffix. 8 cases fail on the old code and list disposable-email-gate.test.ts (real betterAuth + memory adapter + admin plugin): disposable email signup refused with DISPOSABLE_EMAIL, company.msk.ru signup succeeds, SCIM createUser succeeds, SSO callback paths skip, social/generic OAuth gated; disabling the skip turns SCIM and SSO red Targeted type-check of changed files, biome; full gate in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary #9516 vendored the union of the auto-generated disposable/disposable-email-domains list (~98.5k) and the curated CC0 disposable-email-domains blocklist. The auto-generated list includes re...

X Description: Summary #9516 vendored the union of the auto-generated disposable/disposable-email-domains list (~98.5k) and the curated CC0 disposable-email-domains blocklist. The auto-generated list includes re...

Opengraph URL: https://github.com/simstudioai/sim/pull/9529

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:99251805-a379-085c-b969-dd23b4831102
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9574:272A6F:81D01:B99A4:6AFB1B9B
html-safe-noncef0b8cf5b55099bcee01ecc03177cf1f356de65952529683686d27711319e2bab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTc0OjI3MkE2Rjo4MUQwMTpCOTlBNDo2QUZCMUI5QiIsInZpc2l0b3JfaWQiOiIzMzk2ODcyNDA0NzkyNDQ5OTQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3315088f59b9c29e91bafd296a2463ceb19aadd8a1525b40e129c0598ee453b6
hovercard-subject-tagpull_request:5100190369
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9529/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary #9516 vendored the union of the auto-generated disposable/disposable-email-domains list (~98.5k) and the curated CC0 disposable-email-domains blocklist. The auto-generated list includes re...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9529/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9529%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9529%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9529/files
Reloadhttps://github.com/simstudioai/sim/pull/9529/files
Reloadhttps://github.com/simstudioai/sim/pull/9529/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/disposable-email-false-positiveshttps://github.com/simstudioai/sim/tree/fix/disposable-email-false-positives
Conversation 5 https://github.com/simstudioai/sim/pull/9529
Commits 2 https://github.com/simstudioai/sim/pull/9529/commits
Checks 68 https://github.com/simstudioai/sim/pull/9529/checks
Files changed https://github.com/simstudioai/sim/pull/9529/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9529/files
fix(auth): block only curated disposable domains, and never gate SSO or SCIM provisioning https://github.com/simstudioai/sim/pull/9529/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9529/files
1a9ce1b fix(auth): block only curated disposable domains, and never gate SSO … waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9529/commits/1a9ce1b55fd059a00ceeabb74f92fa78e9fd0a2d
726a69b chore(auth): rename disposable list script to generate:, read SSO cal… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9529/commits/726a69bc7cea7bb816dc0720969cfb5c3da436ee
Clear filters https://github.com/simstudioai/sim/pull/9529/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9529/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9529/files
signup-form.tsx https://github.com/simstudioai/sim/pull/9529/files#diff-90e65a3217ad66bfba43f265a92bfd109d75ce4337450e5433fa2090160360d4
auth.ts https://github.com/simstudioai/sim/pull/9529/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
disposable-email-gate.test.ts https://github.com/simstudioai/sim/pull/9529/files#diff-4649067f0d93649328e8aab861738f8f919d23d50f86e792796e1040ea9bb3d5
disposable-email-gate.ts https://github.com/simstudioai/sim/pull/9529/files#diff-40ae2feed609133ed4e920d2114b4c9b38dadfefd722c0d514009629c0a21faf
disposable-email-domains.json https://github.com/simstudioai/sim/pull/9529/files#diff-c13e3c9a3be3838ca2c9287754f3c41d60ed6a27b63ceb68e3c6023bb0cd145a
disposable.test.ts https://github.com/simstudioai/sim/pull/9529/files#diff-8e1f2cbe0c3033c9d9154758f0a30359f04c7a1e9d89ca7abd58d710e28e12e1
disposable.ts https://github.com/simstudioai/sim/pull/9529/files#diff-3a87ef35e095e74af0e687607e69f892dd98e1551299316d1f2197db4b72e940
validation.ts https://github.com/simstudioai/sim/pull/9529/files#diff-71e2b65b878fe7b732e12a18d7447451d01fb954ca49a113b5a4d7eb428a0b70
package.json https://github.com/simstudioai/sim/pull/9529/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
generate-disposable-email-domains.ts https://github.com/simstudioai/sim/pull/9529/files#diff-bda3557e431ec2bae81410c79f833e3aaa96d036d4c9806d81c4c5280b3d7545
apps/sim/app/(auth)/signup/signup-form.tsxhttps://github.com/simstudioai/sim/pull/9529/files#diff-90e65a3217ad66bfba43f265a92bfd109d75ce4337450e5433fa2090160360d4
View file https://github.com/simstudioai/sim/blob/726a69bc7cea7bb816dc0720969cfb5c3da436ee/apps/sim/app/(auth)/signup/signup-form.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9529/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9529/files#diff-90e65a3217ad66bfba43f265a92bfd109d75ce4337450e5433fa2090160360d4
https://github.com/simstudioai/sim/pull/9529/files#diff-90e65a3217ad66bfba43f265a92bfd109d75ce4337450e5433fa2090160360d4
https://github.com/simstudioai/sim/pull/9529/files#diff-90e65a3217ad66bfba43f265a92bfd109d75ce4337450e5433fa2090160360d4
https://github.com/simstudioai/sim/pull/9529/files#diff-90e65a3217ad66bfba43f265a92bfd109d75ce4337450e5433fa2090160360d4
apps/sim/lib/auth/auth.tshttps://github.com/simstudioai/sim/pull/9529/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
View file https://github.com/simstudioai/sim/blob/726a69bc7cea7bb816dc0720969cfb5c3da436ee/apps/sim/lib/auth/auth.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9529/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9529/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/9529/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/9529/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/9529/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/9529/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
Please reload this pagehttps://github.com/simstudioai/sim/pull/9529/files
https://github.com/simstudioai/sim/pull/9529/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
apps/sim/lib/auth/disposable-email-gate.test.tshttps://github.com/simstudioai/sim/pull/9529/files#diff-4649067f0d93649328e8aab861738f8f919d23d50f86e792796e1040ea9bb3d5
View file https://github.com/simstudioai/sim/blob/726a69bc7cea7bb816dc0720969cfb5c3da436ee/apps/sim/lib/auth/disposable-email-gate.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9529/{{ revealButtonHref }}
apps/sim/lib/auth/disposable-email-gate.tshttps://github.com/simstudioai/sim/pull/9529/files#diff-40ae2feed609133ed4e920d2114b4c9b38dadfefd722c0d514009629c0a21faf
View file https://github.com/simstudioai/sim/blob/726a69bc7cea7bb816dc0720969cfb5c3da436ee/apps/sim/lib/auth/disposable-email-gate.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9529/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/9529/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9529/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.