René's URL Explorer Experiment


Title: fix(oauth): keep a five-minute floor on served tokens and refresh ahead earlier by waleedlatif1 · Pull Request #9528 · simstudioai/sim · GitHub

Open Graph Title: fix(oauth): keep a five-minute floor on served tokens and refresh ahead earlier by waleedlatif1 · Pull Request #9528 · simstudioai/sim

X Title: fix(oauth): keep a five-minute floor on served tokens and refresh ahead earlier by waleedlatif1 · Pull Request #9528 · simstudioai/sim

Description: Summary #9509 served Google/Microsoft tokens with as little as 2 minutes left while refreshing in the background. Callers that resolve once and reuse the token through a long batch (Gmail/Outlook/Drive/Calendar/Sheets pollers: fetch → attachment downloads → mark read) could 401 mid-batch. Before #9509 a served token always had ≥5 minutes Every provider now waits at ≤5 minutes left again; refresh-ahead moves to the 5–10 minute band (minus the existing 0–60 s per-account jitter, so every account starts 9–10 minutes before expiry and gets ≥4 minutes of background headroom) Closes an untested gap where an allowlisted token between (5 min − jitter) and 5 min was served with no refresh at all Logs "Refreshing ahead of expiry" once per background refresh instead of on every call in the window The lock leader skips the provider call when another writer already stored a newer usable token after the caller's snapshot (refresh-ahead made those redundant refreshes more frequent) Unchanged: the Google/Microsoft allowlist, single-flight + Redis leader lock, rotation write guard, fail-closed at expiry Type of Change Bug fix Testing credential-service.test.ts (95 pass): remaining-time table across all three readers (≤5 min waits, 5–10 min refreshes ahead, >10 min none, non-allowlisted unchanged), deferred-provider wait cases at 4 and 5 minutes, one shared background refresh across callers, leader re-read skip Red→green: the original #9509 source fails 23 of these; reverting each sub-change alone fails its own cases credential-service-cancellation, token-resolution, microsoft tests; biome; full gate in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary #9509 served Google/Microsoft tokens with as little as 2 minutes left while refreshing in the background. Callers that resolve once and reuse the token through a long batch (Gmail/Outlook/...

X Description: Summary #9509 served Google/Microsoft tokens with as little as 2 minutes left while refreshing in the background. Callers that resolve once and reuse the token through a long batch (Gmail/Outlook/...

Opengraph URL: https://github.com/simstudioai/sim/pull/9528

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:25ee6b87-d065-263c-6efe-f65524940697
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id834C:8F72D:7CD69:B5C24:6AFB1920
html-safe-nonce2d5df67551381a1dbe6239bdc3f5cbda0ecc79eb559322464d794c8a67f5decc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzRDOjhGNzJEOjdDRDY5OkI1QzI0OjZBRkIxOTIwIiwidmlzaXRvcl9pZCI6IjUwMjAwOTI3NTEwMDE4ODQ5NjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccce1b97e2faa04b869eabb1dcf7ca544ccc6f8ecdaa8dd68f81a63ebe6334108
hovercard-subject-tagpull_request:5100177376
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9528/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary #9509 served Google/Microsoft tokens with as little as 2 minutes left while refreshing in the background. Callers that resolve once and reuse the token through a long batch (Gmail/Outlook/...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9528/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9528%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9528%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9528/files
Reloadhttps://github.com/simstudioai/sim/pull/9528/files
Reloadhttps://github.com/simstudioai/sim/pull/9528/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
improvement/oauth-refresh-ahead-floorhttps://github.com/simstudioai/sim/tree/improvement/oauth-refresh-ahead-floor
Conversation 8 https://github.com/simstudioai/sim/pull/9528
Commits 2 https://github.com/simstudioai/sim/pull/9528/commits
Checks 68 https://github.com/simstudioai/sim/pull/9528/checks
Files changed https://github.com/simstudioai/sim/pull/9528/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9528/files
fix(oauth): keep a five-minute floor on served tokens and refresh ahead earlier https://github.com/simstudioai/sim/pull/9528/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9528/files
717edcb fix(oauth): keep a five-minute floor on served tokens and refresh ahe… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9528/commits/717edcb78bed4b584cdc01b2d759ed3766110e3c
dbae1e5 improvement(oauth): share refresh-ahead through the refresh single-fl… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9528/commits/dbae1e5f74fc31826c31d7fe63cbdcc9f1560dae
Clear filters https://github.com/simstudioai/sim/pull/9528/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9528/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9528/files
credential-service.test.ts https://github.com/simstudioai/sim/pull/9528/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
credential-service.ts https://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
apps/sim/lib/oauth/credential-service.test.tshttps://github.com/simstudioai/sim/pull/9528/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
View file https://github.com/simstudioai/sim/blob/dbae1e5f74fc31826c31d7fe63cbdcc9f1560dae/apps/sim/lib/oauth/credential-service.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9528/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9528/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
https://github.com/simstudioai/sim/pull/9528/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
https://github.com/simstudioai/sim/pull/9528/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
https://github.com/simstudioai/sim/pull/9528/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
https://github.com/simstudioai/sim/pull/9528/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
https://github.com/simstudioai/sim/pull/9528/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
https://github.com/simstudioai/sim/pull/9528/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
apps/sim/lib/oauth/credential-service.tshttps://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
View file https://github.com/simstudioai/sim/blob/dbae1e5f74fc31826c31d7fe63cbdcc9f1560dae/apps/sim/lib/oauth/credential-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9528/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
https://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
https://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
https://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
https://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
Please reload this pagehttps://github.com/simstudioai/sim/pull/9528/files
https://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
https://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
https://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
https://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
https://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
https://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
https://github.com/simstudioai/sim/pull/9528/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.