René's URL Explorer Experiment


Title: improvement(desktop): sign-in prompts for the agent browser — site passwords, passkey accounts, client certificates, and app links by waleedlatif1 · Pull Request #9521 · simstudioai/sim · GitHub

Open Graph Title: improvement(desktop): sign-in prompts for the agent browser — site passwords, passkey accounts, client certificates, and app links by waleedlatif1 · Pull Request #9521 · simstudioai/sim

X Title: improvement(desktop): sign-in prompts for the agent browser — site passwords, passkey accounts, client certificates, and app links by waleedlatif1 · Pull Request #9521 · simstudioai/sim

Description: Summary Site passwords (HTTP basic/digest + proxy): there was no login handler, so these silently cancelled and sites showed a bare 401. Agent tabs now get a Chrome-style prompt — only for the tab's own top-level navigation (or a proxy), origin shown, no server-chosen realm text, "not private" warning on http, re-prompt on a wrong password, capped per tab+origin across reloads. Credentials are never logged or persisted; the agent can't answer it and is told to wait Passkey account picker: registers select-webauthn-account; without it Electron cancelled every usernameless (discoverable) security-key sign-in even with one account Client certificates: Electron silently sent the first certificate to any agent-browser site that asked. Now nothing is sent unless the user picks one (subject, issuer, expiry); choices are remembered per session+host until restart. The main app window is unchanged App links (Zoom, Teams, Slack, Okta Verify, mailto…): were silently cancelled. Now: a user click shows "Open ?" naming the origin (Open armed after 500 ms); a page that launches on load gets a passive notice; agent input never launches; iframe-initiated launches are refused; hard denylist (file, smb, ms-msdt, search-ms, ms-officecmd, jnlp, …), registered handler required, rebuilt URL only, rate-limited; all launches go through openExternalSafe Keyjacking-safe: picker prompts have no preselection, Enter dismisses, Continue is armed after a delay, and they never steal focus Sign-out clears the HTTP auth cache and remembered certificate/always-allow decisions Removes the unused Bluetooth entitlement and usage string (Electron never starts the WebAuthn phone flow) Version skew: the renderer opts in via enable-page-dialogs { pagePrompts: true }; an older renderer gets today's behaviour (everything refused), an older shell ignores the flag Type of Change Improvement Testing New apps/desktop/e2e/browser-sign-in-prompts.spec.ts (10 checks, JSON report): older renderer still refuses; basic auth prompt/retry/sign-in; cross-origin subresource never prompts; agent navigation waits for the user; agent clicks never launch; user click prompts and opens only on Open; on-load launch gets the passive notice; rate limit; denied schemes never open; passkey picker via CDP virtual authenticator (stray Enter refuses) page-prompts.test.ts: URL validation/denylist, auth decision, certificate flow, frame attribution, reset on sign-out, single-launch-per-prompt Red→green for every guard by reverting it session/ipc/driver/security-guards/navigation/context-menu suites, browser-tools popup tests, browser-page-parity; desktop tsc, targeted apps/sim type-check, biome; full gate in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Site passwords (HTTP basic/digest + proxy): there was no login handler, so these silently cancelled and sites showed a bare 401. Agent tabs now get a Chrome-style prompt — only for the tab...

X Description: Summary Site passwords (HTTP basic/digest + proxy): there was no login handler, so these silently cancelled and sites showed a bare 401. Agent tabs now get a Chrome-style prompt — only for the tab...

Opengraph URL: https://github.com/simstudioai/sim/pull/9521

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d86e3c77-25c1-c8db-0524-79cb44458123
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD220:10FF70:69B58:98D99:6AFB18C2
html-safe-nonce557072c5b4f65a5bc7003a994fb88bfb910196011e13a782ea369f59491b14af
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjIwOjEwRkY3MDo2OUI1ODo5OEQ5OTo2QUZCMThDMiIsInZpc2l0b3JfaWQiOiIyODc4MjY2MTMzMjc2NDY1MzQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca448173fcc530c0c29869dfdb4a658592cfc8fdc22ac16f790b3bf2b6d362060
hovercard-subject-tagpull_request:5096193712
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9521/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Site passwords (HTTP basic/digest + proxy): there was no login handler, so these silently cancelled and sites showed a bare 401. Agent tabs now get a Chrome-style prompt — only for the tab...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9521/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9521%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9521%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9521/files
Reloadhttps://github.com/simstudioai/sim/pull/9521/files
Reloadhttps://github.com/simstudioai/sim/pull/9521/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
improvement/desktop-browser-signinhttps://github.com/simstudioai/sim/tree/improvement/desktop-browser-signin
Conversation 39 https://github.com/simstudioai/sim/pull/9521
Commits 4 https://github.com/simstudioai/sim/pull/9521/commits
Checks 73 https://github.com/simstudioai/sim/pull/9521/checks
Files changed https://github.com/simstudioai/sim/pull/9521/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9521/files
improvement(desktop): sign-in prompts for the agent browser — site passwords, passkey accounts, client certificates, and app links https://github.com/simstudioai/sim/pull/9521/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/9521/files
3e86697 improvement(desktop): sign-in prompts for the agent browser — site pa… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9521/commits/3e866977bedd20db30b6c646bbac1706b85893f0
501128a fix(desktop): require an explicit accept for every sign-in prompt ans… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9521/commits/501128a78bc472a53a4128c586ff3d14d003df93
1939def fix(desktop): refuse window.open app links, gate every launch on a pr… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9521/commits/1939defddae513aabaa1584e383f07aa25269b87
06f20c6 fix(desktop): clearing browsing data forgets the agent browser's cert… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9521/commits/06f20c630990668a70ee7fdc25522643453a8b06
Clear filters https://github.com/simstudioai/sim/pull/9521/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9521/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9521/files
entitlements.mac.plist https://github.com/simstudioai/sim/pull/9521/files#diff-e2413903232f3a13dafca2d85a185d9ba64878181a4ac7b303e6f269902fbf95
browser-sign-in-prompts.spec.ts https://github.com/simstudioai/sim/pull/9521/files#diff-28f34fbd3073991d908424d5bf51ad76604c959377f40a5bab48ab526d3d9af4
electron-builder.yml https://github.com/simstudioai/sim/pull/9521/files#diff-9305ac46655ea99b9632c577386db8b56bdca4ee70c63de1b8fabd5e0e78dbb6
driver.ts https://github.com/simstudioai/sim/pull/9521/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
page-prompts.test.ts https://github.com/simstudioai/sim/pull/9521/files#diff-9a570f307e7894f1675b51d6a2b68104039cd30ed22af09ae2c717a954cabb4c
page-prompts.ts https://github.com/simstudioai/sim/pull/9521/files#diff-471fc3f3dd703c8180f36f06efc387ccbfefef7d9b344baa846c8287e4731bc0
session.test.ts https://github.com/simstudioai/sim/pull/9521/files#diff-5385678f548f38e14b9373e2b3554215c3e668a54628a4d635111ce80035b19c
session.ts https://github.com/simstudioai/sim/pull/9521/files#diff-4950875424919c3217a0b1f974e08ec2f97fe2cd318916f610158e3cf09db3c7
ipc.ts https://github.com/simstudioai/sim/pull/9521/files#diff-a471b27e653d39114f9a737b0741f68dc1a6f36f3830e9454fd4e00704e24727
navigation.test.ts https://github.com/simstudioai/sim/pull/9521/files#diff-d3809d9799923111c71bb5dfb832fe4a8e9ef209f7dc14d15515912616e77862
navigation.ts https://github.com/simstudioai/sim/pull/9521/files#diff-88dec879862a4f1d0f296fa215f7175f30d72814197486343588ae34e978434b
security-guards.ts https://github.com/simstudioai/sim/pull/9521/files#diff-fec72813b6675de4777f1019915c3e00c4ab96de4f2a21471fed65e6444bb1dd
electron-mock.ts https://github.com/simstudioai/sim/pull/9521/files#diff-27ebaddd30812fedc9725b0b888a6d27edc61735a2c872050a6235ccd741dc1f
browser-page-prompt.tsx https://github.com/simstudioai/sim/pull/9521/files#diff-1c4143c3ccc32098d86f72cf1175a8e0bd386f20e1fc80ccd4b5ce483d5aa43d
browser-session.tsx https://github.com/simstudioai/sim/pull/9521/files#diff-dc77efde736e424d320cd580e8aa6877a1618db528f899e81f2331a6daf162a2
store.ts https://github.com/simstudioai/sim/pull/9521/files#diff-0ea4d102398b9f8662c131093d08a7b5ebdb31d87e4e7e159347266cc0cbdcbc
index.ts https://github.com/simstudioai/sim/pull/9521/files#diff-7bf024cc51a5498c6b4d087358740c2011c9d5ea86c03391bd1d4623026224d3
chip-modal.tsx https://github.com/simstudioai/sim/pull/9521/files#diff-5a9b4f39d866e7b9c8f3be78802e723f27cc7f87c964fbe55e19d16a69b91f54
apps/desktop/build/entitlements.mac.plisthttps://github.com/simstudioai/sim/pull/9521/files#diff-e2413903232f3a13dafca2d85a185d9ba64878181a4ac7b303e6f269902fbf95
View file https://github.com/simstudioai/sim/blob/06f20c630990668a70ee7fdc25522643453a8b06/apps/desktop/build/entitlements.mac.plist
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9521/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9521/files#diff-e2413903232f3a13dafca2d85a185d9ba64878181a4ac7b303e6f269902fbf95
apps/desktop/e2e/browser-sign-in-prompts.spec.tshttps://github.com/simstudioai/sim/pull/9521/files#diff-28f34fbd3073991d908424d5bf51ad76604c959377f40a5bab48ab526d3d9af4
View file https://github.com/simstudioai/sim/blob/06f20c630990668a70ee7fdc25522643453a8b06/apps/desktop/e2e/browser-sign-in-prompts.spec.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/simstudioai/sim/pull/9521/files
apps/desktop/electron-builder.ymlhttps://github.com/simstudioai/sim/pull/9521/files#diff-9305ac46655ea99b9632c577386db8b56bdca4ee70c63de1b8fabd5e0e78dbb6
View file https://github.com/simstudioai/sim/blob/06f20c630990668a70ee7fdc25522643453a8b06/apps/desktop/electron-builder.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9521/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9521/files#diff-9305ac46655ea99b9632c577386db8b56bdca4ee70c63de1b8fabd5e0e78dbb6
Please reload this pagehttps://github.com/simstudioai/sim/pull/9521/files
https://github.com/simstudioai/sim/pull/9521/files#diff-9305ac46655ea99b9632c577386db8b56bdca4ee70c63de1b8fabd5e0e78dbb6
apps/desktop/src/main/browser-agent/driver.tshttps://github.com/simstudioai/sim/pull/9521/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
View file https://github.com/simstudioai/sim/blob/06f20c630990668a70ee7fdc25522643453a8b06/apps/desktop/src/main/browser-agent/driver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9521/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9521/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9521/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9521/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9521/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9521/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9521/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9521/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9521/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9521/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
Please reload this pagehttps://github.com/simstudioai/sim/pull/9521/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9521/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.