René's URL Explorer Experiment


Title: improvement(oauth): serve still-valid tokens while refreshing ahead of expiry by waleedlatif1 · Pull Request #9509 · simstudioai/sim · GitHub

Open Graph Title: improvement(oauth): serve still-valid tokens while refreshing ahead of expiry by waleedlatif1 · Pull Request #9509 · simstudioai/sim

X Title: improvement(oauth): serve still-valid tokens while refreshing ahead of expiry by waleedlatif1 · Pull Request #9509 · simstudioai/sim

Description: Summary Every caller inside the 5-minute OAuth refresh window blocked on the provider refresh, even though its access token was still valid for minutes. Polls, workflow tools, selectors and live search all paid that wait, and a stalled refresh held them for up to 30s One decision, planAccessTokenRefresh, replaces the three copies in getOAuthToken, resolveCredentialTokenBundle and refreshTokenIfNeeded: For Google and Microsoft providers with more than 2 minutes left, the caller gets the still-valid token now and the existing coalesced refresh runs in the background. These providers keep a refreshed-away access token valid and the old refresh token usable, so an abandoned refresh loses nothing The start of the window is jittered per account, so credentials that expire together don't refresh together Every other provider, and any token with 2 minutes or less left, waits exactly as before. Rotation guards, revocation-against-version, dead flags, the leader lock, Microsoft refresh-token aging and Instagram renewal are unchanged resolveCredentialTokenBundle's existing signal now also stops a caller waiting on a shared OAuth refresh (via waitWithAbort), without cancelling the refresh for anyone else Live search passes its deadline signal into account resolution, so a hung token resolution can no longer hold a 20s search past its deadline. Document reads now start their 15s deadline before resolving the account Type of Change Bug fix Testing New tests, each failing on staging: A Google token with 4 minutes left returns at once while the provider is still pending, and the background refresh then rotates the row The headroom table runs per reader A cancelled caller stops waiting while a concurrent caller still gets the refreshed token, with one provider call Live search settles by its 20s deadline, and reads by 15s, when token resolution never settles Guards proven by breaking the code: providers outside Google/Microsoft and tokens under the 2-minute floor still wait lib/oauth, lib/sim-search/live, lib/concurrency and app/api/auth/oauth all pass (827 tests). bun run lint, block registry check, type-check and check:audits pass, except check:unused-exports, which flags an apps/docs generated import not built in a local checkout Integration suites (credential-revocation, shopify, managed-mcp, provider-discovery) and the full test suite run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Every caller inside the 5-minute OAuth refresh window blocked on the provider refresh, even though its access token was still valid for minutes. Polls, workflow tools, selectors and live s...

X Description: Summary Every caller inside the 5-minute OAuth refresh window blocked on the provider refresh, even though its access token was still valid for minutes. Polls, workflow tools, selectors and live s...

Opengraph URL: https://github.com/simstudioai/sim/pull/9509

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8ced47dc-492b-0ccd-1dcc-8485caa01aa4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CEC:13FAB0:1215DD:1AEB9D:6AFB1C16
html-safe-nonce35462898fd5b478dec13e2a75a4ad5e0159c121810aad6f02108bbaf36a53918
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0VDOjEzRkFCMDoxMjE1REQ6MUFFQjlEOjZBRkIxQzE2IiwidmlzaXRvcl9pZCI6IjExNjQwMjMyMDIyOTI4OTg4MzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd14147fccddf1d177f194b2065789b79edd7b72d1d4636c85a35d286011f20c9
hovercard-subject-tagpull_request:5095830250
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9509/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Every caller inside the 5-minute OAuth refresh window blocked on the provider refresh, even though its access token was still valid for minutes. Polls, workflow tools, selectors and live s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9509/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9509%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9509%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9509/files
Reloadhttps://github.com/simstudioai/sim/pull/9509/files
Reloadhttps://github.com/simstudioai/sim/pull/9509/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
improvement/oauth-refresh-aheadhttps://github.com/simstudioai/sim/tree/improvement/oauth-refresh-ahead
Conversation 2 https://github.com/simstudioai/sim/pull/9509
Commits 1 https://github.com/simstudioai/sim/pull/9509/commits
Checks 68 https://github.com/simstudioai/sim/pull/9509/checks
Files changed https://github.com/simstudioai/sim/pull/9509/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9509/files
improvement(oauth): serve still-valid tokens while refreshing ahead of expiry https://github.com/simstudioai/sim/pull/9509/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9509/files
eb55d0b improvement(oauth): serve still-valid tokens while refreshing ahead o… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9509/commits/eb55d0b5b2038e0e957844ae6c959999c2616488
Clear filters https://github.com/simstudioai/sim/pull/9509/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9509/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9509/files
credential-service.test.ts https://github.com/simstudioai/sim/pull/9509/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
credential-service.ts https://github.com/simstudioai/sim/pull/9509/files#diff-effb7c3ce97c223dad84239d969592e6300167d635dab9fdfc4bb30120ec3c47
accounts.ts https://github.com/simstudioai/sim/pull/9509/files#diff-6beb346c27c639ad7d9f73ccfb1531784021cbd174b9a894114e63c2e8439db8
application.test.ts https://github.com/simstudioai/sim/pull/9509/files#diff-af2d21accc00823b671d6bf1cb0dda2f0f273ebdb911e7ec9cdd52ea034a5c20
application.ts https://github.com/simstudioai/sim/pull/9509/files#diff-151e464c65b5447415809287c8c227355b3d21309f26c9399b2e49c0cdd59608
check-explicit-any.baseline.json https://github.com/simstudioai/sim/pull/9509/files#diff-780d04116ec981737479435cdb0364b49047711f2dfb93b671a9be50a1b0bb27
apps/sim/lib/oauth/credential-service.test.tshttps://github.com/simstudioai/sim/pull/9509/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
View file https://github.com/simstudioai/sim/blob/eb55d0b5b2038e0e957844ae6c959999c2616488/apps/sim/lib/oauth/credential-service.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9509/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9509/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
https://github.com/simstudioai/sim/pull/9509/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
https://github.com/simstudioai/sim/pull/9509/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
https://github.com/simstudioai/sim/pull/9509/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
https://github.com/simstudioai/sim/pull/9509/files#diff-436d1bec92f572ebd755e550bcec174f860c4c8be1dc751e1dd6498685c7bf55
Please reload this pagehttps://github.com/simstudioai/sim/pull/9509/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9509/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.