René's URL Explorer Experiment


Title: fix(desktop): keep sign-in popups working in the agent browser by waleedlatif1 · Pull Request #9506 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop): keep sign-in popups working in the agent browser by waleedlatif1 · Pull Request #9506 · simstudioai/sim

X Title: fix(desktop): keep sign-in popups working in the agent browser by waleedlatif1 · Pull Request #9506 · simstudioai/sim

Description: Summary window.open('') / about:blank popups returned null in agent browser tabs, breaking blank-then-navigate sign-in and payment flows (e.g. MSAL's default popup). They are now adopted as tabs that keep window.opener, matching Electron's docs and Min; their first real navigation still passes the http-only and network guards An adopted popup's session is read from the contents Chromium created, not its URL — a blank popup from a Sim page would otherwise have registered the app session as the agent partition A target=_blank form POST that we would have to reissue (cross-session or background) is refused instead of silently resent as a GET with no body; reissued links keep their referrer Closing a popup returns to its opener instead of the neighbouring tab, unless the user switched tabs since it opened (Chrome's ForgetAllOpeners rule) mailto: links in the app window (chat links, the offline page's Contact support) open the mail client; attach=, unknown headers, and malformed addresses are refused Type of Change Bug fix Testing apps/desktop/e2e/browser-tools.spec.ts: blank popup keeps opener + postMessage round-trip + close returns to opener; opener forgotten after a manual tab switch; data: popup still denied; same-session form POST arrives as POST, cross-session POST opens nothing; Sim-origin blank popup keeps its opener Red→green for each guard (blank adoption, opener activation, forget-on-switch, POST refusal, popup session) navigation.test.ts + session.test.ts (90 pass), desktop tsc --noEmit, biome on changed files; full gate in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary window.open('') / about:blank popups returned null in agent browser tabs, breaking blank-then-navigate sign-in and payment flows (e.g. MSAL's default popup). They are now adopt...

X Description: Summary window.open('') / about:blank popups returned null in agent browser tabs, breaking blank-then-navigate sign-in and payment flows (e.g. MSAL's default popup). They a...

Opengraph URL: https://github.com/simstudioai/sim/pull/9506

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7d5772bf-c5e1-82cc-efc8-23f11ff05e93
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id86D2:1AA805:5C4EE:8753B:6AFB18A0
html-safe-noncea3e13aaa3c0c725e1763b7fb67b8c6f99fb333e4fbfe554a3f18e0aefd1e14f1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkQyOjFBQTgwNTo1QzRFRTo4NzUzQjo2QUZCMThBMCIsInZpc2l0b3JfaWQiOiIyMjc2MDE4NjAzNDg2Mjg4MDMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac866c1530f05a146c05ad902882e2a3ff6ed61ba8d8513144ea455988177ea73f
hovercard-subject-tagpull_request:5095712449
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9506/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary window.open('') / about:blank popups returned null in agent browser tabs, breaking blank-then-navigate sign-in and payment flows (e.g. MSAL's default popup). They are now adopt...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9506/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9506%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9506%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9506/files
Reloadhttps://github.com/simstudioai/sim/pull/9506/files
Reloadhttps://github.com/simstudioai/sim/pull/9506/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/desktop-browser-popupshttps://github.com/simstudioai/sim/tree/fix/desktop-browser-popups
Conversation 7 https://github.com/simstudioai/sim/pull/9506
Commits 2 https://github.com/simstudioai/sim/pull/9506/commits
Checks 45 https://github.com/simstudioai/sim/pull/9506/checks
Files changed https://github.com/simstudioai/sim/pull/9506/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9506/files
fix(desktop): keep sign-in popups working in the agent browser https://github.com/simstudioai/sim/pull/9506/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9506/files
ddf4e2f fix(desktop): keep sign-in popups working in the agent browser waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9506/commits/ddf4e2fba3d96e8381465921b342b74e40ccff77
245d363 fix(desktop): keep deferred popups in their opener's session waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9506/commits/245d363f8653d028d36b40de7b1b125e29f85ade
Clear filters https://github.com/simstudioai/sim/pull/9506/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9506/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9506/files
browser-tools.spec.ts https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
driver.test.ts https://github.com/simstudioai/sim/pull/9506/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
session.test.ts https://github.com/simstudioai/sim/pull/9506/files#diff-5385678f548f38e14b9373e2b3554215c3e668a54628a4d635111ce80035b19c
session.ts https://github.com/simstudioai/sim/pull/9506/files#diff-4950875424919c3217a0b1f974e08ec2f97fe2cd318916f610158e3cf09db3c7
navigation.test.ts https://github.com/simstudioai/sim/pull/9506/files#diff-d3809d9799923111c71bb5dfb832fe4a8e9ef209f7dc14d15515912616e77862
navigation.ts https://github.com/simstudioai/sim/pull/9506/files#diff-88dec879862a4f1d0f296fa215f7175f30d72814197486343588ae34e978434b
apps/desktop/e2e/browser-tools.spec.tshttps://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
View file https://github.com/simstudioai/sim/blob/245d363f8653d028d36b40de7b1b125e29f85ade/apps/desktop/e2e/browser-tools.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9506/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/9506/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
apps/desktop/src/main/browser-agent/driver.test.tshttps://github.com/simstudioai/sim/pull/9506/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
View file https://github.com/simstudioai/sim/blob/245d363f8653d028d36b40de7b1b125e29f85ade/apps/desktop/src/main/browser-agent/driver.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9506/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9506/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
https://github.com/simstudioai/sim/pull/9506/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
https://github.com/simstudioai/sim/pull/9506/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
apps/desktop/src/main/browser-agent/session.test.tshttps://github.com/simstudioai/sim/pull/9506/files#diff-5385678f548f38e14b9373e2b3554215c3e668a54628a4d635111ce80035b19c
View file https://github.com/simstudioai/sim/blob/245d363f8653d028d36b40de7b1b125e29f85ade/apps/desktop/src/main/browser-agent/session.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9506/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9506/files#diff-5385678f548f38e14b9373e2b3554215c3e668a54628a4d635111ce80035b19c
https://github.com/simstudioai/sim/pull/9506/files#diff-5385678f548f38e14b9373e2b3554215c3e668a54628a4d635111ce80035b19c
https://github.com/simstudioai/sim/pull/9506/files#diff-5385678f548f38e14b9373e2b3554215c3e668a54628a4d635111ce80035b19c
https://github.com/simstudioai/sim/pull/9506/files#diff-5385678f548f38e14b9373e2b3554215c3e668a54628a4d635111ce80035b19c
https://github.com/simstudioai/sim/pull/9506/files#diff-5385678f548f38e14b9373e2b3554215c3e668a54628a4d635111ce80035b19c
https://github.com/simstudioai/sim/pull/9506/files#diff-5385678f548f38e14b9373e2b3554215c3e668a54628a4d635111ce80035b19c
Please reload this pagehttps://github.com/simstudioai/sim/pull/9506/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9506/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.