René's URL Explorer Experiment


Title: improvement(desktop): install updates on one click, asking only about real in-flight work by waleedlatif1 · Pull Request #9505 · simstudioai/sim · GitHub

Open Graph Title: improvement(desktop): install updates on one click, asking only about real in-flight work by waleedlatif1 · Pull Request #9505 · simstudioai/sim

X Title: improvement(desktop): install updates on one click, asking only about real in-flight work by waleedlatif1 · Pull Request #9505 · simstudioai/sim

Description: Summary "Restart to update" (toast, sidebar, menu) now installs immediately — the generic "Restart to install? Later / Restart and update" dialog (default: Later) is gone Asks only when a restart would interrupt real work, and names it: a running terminal command, an agent action, computer use, or a window with unsaved edits (probed through each page's own beforeunload guards). Restart is the default; Not Now keeps the update ready and it still installs on quit Previously, confirming the old dialog bypassed every unsaved-edits guard and dropped edits silently; those edits now block with a specific prompt The minimum-version gate passes { mandatory: true } and never offers to wait (older shells ignore the option) An update relaunch reopens every app window, not only the main one Fixes the menu's "you will be prompted to restart" copy, which promised a prompt that never came Type of Change Improvement Testing apps/desktop/src/main/updater.test.ts (37 pass): one click installs with no dialog; running work prompts once with restart as default; Not Now keeps ready + install-on-quit; mandatory never prompts apps/desktop/e2e/updater.spec.ts (real MacUpdater + real renderer beforeunload): terminal-only prompt, unsaved-edits prompt, a non-cancelling listener does not count as unsaved, and a clean install shows no dialog Red→green: pre-fix updater.ts fails 8 unit tests and the e2e; forcing the unsaved-edits probe either way fails the e2e tsc --noEmit (desktop), biome on changed files; full gate in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary "Restart to update" (toast, sidebar, menu) now installs immediately — the generic "Restart to install? Later / Restart and update" dialog (default: Later) is gone Asks ...

X Description: Summary "Restart to update" (toast, sidebar, menu) now installs immediately — the generic "Restart to install? Later / Restart and update" dialog (default: Late...

Opengraph URL: https://github.com/simstudioai/sim/pull/9505

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1b771d7a-cbb3-3dcf-7861-b62d1d8e1c41
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85E8:3F822D:6EFC6:A2501:6AFB1889
html-safe-nonce8d3af64d4ca2cfc3024b15cbbad34ef4a13179d9715b15d667b2af622c16cf8f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUU4OjNGODIyRDo2RUZDNjpBMjUwMTo2QUZCMTg4OSIsInZpc2l0b3JfaWQiOiIxMDQwODY3ODYxNjE3MTEyNDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7662c0c7462d4f5ab029504b770a3434bd32936e2b8a45e0896f3c6099bfb352
hovercard-subject-tagpull_request:5095710708
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9505/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary "Restart to update" (toast, sidebar, menu) now installs immediately — the generic "Restart to install? Later / Restart and update" dialog (default: Later) is gone Asks ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9505/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9505%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9505%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9505/files
Reloadhttps://github.com/simstudioai/sim/pull/9505/files
Reloadhttps://github.com/simstudioai/sim/pull/9505/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
improvement/desktop-one-click-updatehttps://github.com/simstudioai/sim/tree/improvement/desktop-one-click-update
Conversation 37 https://github.com/simstudioai/sim/pull/9505
Commits 5 https://github.com/simstudioai/sim/pull/9505/commits
Checks 72 https://github.com/simstudioai/sim/pull/9505/checks
Files changed https://github.com/simstudioai/sim/pull/9505/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9505/files
improvement(desktop): install updates on one click, asking only about real in-flight work https://github.com/simstudioai/sim/pull/9505/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/9505/files
76be4c8 improvement(desktop): install updates on one click, asking only about… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9505/commits/76be4c831ac441e180513acc24d3bfb243a75469
8c46343 fix(desktop): count unresponsive windows and browser actions before a… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9505/commits/8c4634341898337b908c060685f996700fd03c93
eb7c282 fix(desktop): snapshot running work after the window probes and count… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9505/commits/eb7c282d371e79e2128ad73f9d63ab7f6d242a00
da77a69 fix(desktop): ask the OS about terminals without shell integration be… waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9505/commits/da77a697e3ab92cbab63d645b44454f6811c7353
2720423 chore(desktop): drop the unreachable foreground-read catch waleedlatif1 Oct 31, 2026 https://github.com/simstudioai/sim/pull/9505/commits/2720423f382cb3d0ad771edb21b2ee308a2dd119
Clear filters https://github.com/simstudioai/sim/pull/9505/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9505/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9505/files
updater.ts https://github.com/simstudioai/sim/pull/9505/files#diff-d05ad2cd4b4acef40a64a505660ea88f497f44d4a4ca4311916d9a51dab5e03e
updater.spec.ts https://github.com/simstudioai/sim/pull/9505/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
driver.test.ts https://github.com/simstudioai/sim/pull/9505/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
driver.ts https://github.com/simstudioai/sim/pull/9505/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
config.ts https://github.com/simstudioai/sim/pull/9505/files#diff-02e7bf746fb599140284984877377fbcca00ca42a333475a9fb959de43043eae
in-flight-work.test.ts https://github.com/simstudioai/sim/pull/9505/files#diff-8c3bb3222c17aa3dc5611911e5a2ebe2bb3852428626854532674c75694b7427
in-flight-work.ts https://github.com/simstudioai/sim/pull/9505/files#diff-3b963e75a5adb465a72fc9e6094fdd73d0fb14ded12927779140b971e191a3fa
index.ts https://github.com/simstudioai/sim/pull/9505/files#diff-5bf7db7b15749c034541a4a70a0cacf9816b4e214fd11cb5735c5ddb7ca4b1d8
ipc.ts https://github.com/simstudioai/sim/pull/9505/files#diff-a471b27e653d39114f9a737b0741f68dc1a6f36f3830e9454fd4e00704e24727
index.ts https://github.com/simstudioai/sim/pull/9505/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
registry.ts https://github.com/simstudioai/sim/pull/9505/files#diff-d30cc33e9e00dd9009a54bd75a24dbf056890b72571f5101186e11fd9291f199
service.test.ts https://github.com/simstudioai/sim/pull/9505/files#diff-ccf1a39e658c6d2cc7398268ef30d8d5da1a8ac78f2c13fdc808e54926c575cb
updater.test.ts https://github.com/simstudioai/sim/pull/9505/files#diff-0d46817435dcd69c44c58e6a04c3da617de298f35f971d036fab402a9e89f501
updater.ts https://github.com/simstudioai/sim/pull/9505/files#diff-2c6665d35565a24497c27ea0f07e85853958beada9e7889bd1f81068ef1fe76a
index.ts https://github.com/simstudioai/sim/pull/9505/files#diff-fecf2d7e27201df1f0e00156c44faaa274e5dd37dfb485582ce3b2271ce5558c
desktop-update-gate.tsx https://github.com/simstudioai/sim/pull/9505/files#diff-2e18525ddcc2ecf60b5ab0e15a9150378b9fb3a0d267b6575296d2c296ea55a2
use-chat.ts https://github.com/simstudioai/sim/pull/9505/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
index.ts https://github.com/simstudioai/sim/pull/9505/files#diff-f0f54c2e774a675c783c4e7a289d3218ca6d1ef3cdf5158b05acc79cd742afec
apps/desktop/e2e/fixtures/updater.tshttps://github.com/simstudioai/sim/pull/9505/files#diff-d05ad2cd4b4acef40a64a505660ea88f497f44d4a4ca4311916d9a51dab5e03e
View file https://github.com/simstudioai/sim/blob/2720423f382cb3d0ad771edb21b2ee308a2dd119/apps/desktop/e2e/fixtures/updater.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9505/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9505/files#diff-d05ad2cd4b4acef40a64a505660ea88f497f44d4a4ca4311916d9a51dab5e03e
https://github.com/simstudioai/sim/pull/9505/files#diff-d05ad2cd4b4acef40a64a505660ea88f497f44d4a4ca4311916d9a51dab5e03e
https://github.com/simstudioai/sim/pull/9505/files#diff-d05ad2cd4b4acef40a64a505660ea88f497f44d4a4ca4311916d9a51dab5e03e
https://github.com/simstudioai/sim/pull/9505/files#diff-d05ad2cd4b4acef40a64a505660ea88f497f44d4a4ca4311916d9a51dab5e03e
https://github.com/simstudioai/sim/pull/9505/files#diff-d05ad2cd4b4acef40a64a505660ea88f497f44d4a4ca4311916d9a51dab5e03e
apps/desktop/e2e/updater.spec.tshttps://github.com/simstudioai/sim/pull/9505/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
View file https://github.com/simstudioai/sim/blob/2720423f382cb3d0ad771edb21b2ee308a2dd119/apps/desktop/e2e/updater.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9505/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9505/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
https://github.com/simstudioai/sim/pull/9505/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
https://github.com/simstudioai/sim/pull/9505/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
https://github.com/simstudioai/sim/pull/9505/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
https://github.com/simstudioai/sim/pull/9505/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
https://github.com/simstudioai/sim/pull/9505/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
https://github.com/simstudioai/sim/pull/9505/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
https://github.com/simstudioai/sim/pull/9505/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
https://github.com/simstudioai/sim/pull/9505/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
https://github.com/simstudioai/sim/pull/9505/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
https://github.com/simstudioai/sim/pull/9505/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
apps/desktop/src/main/browser-agent/driver.test.tshttps://github.com/simstudioai/sim/pull/9505/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
View file https://github.com/simstudioai/sim/blob/2720423f382cb3d0ad771edb21b2ee308a2dd119/apps/desktop/src/main/browser-agent/driver.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9505/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9505/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
https://github.com/simstudioai/sim/pull/9505/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
apps/desktop/src/main/browser-agent/driver.tshttps://github.com/simstudioai/sim/pull/9505/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
View file https://github.com/simstudioai/sim/blob/2720423f382cb3d0ad771edb21b2ee308a2dd119/apps/desktop/src/main/browser-agent/driver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9505/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9505/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9505/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
apps/desktop/src/main/config.tshttps://github.com/simstudioai/sim/pull/9505/files#diff-02e7bf746fb599140284984877377fbcca00ca42a333475a9fb959de43043eae
View file https://github.com/simstudioai/sim/blob/2720423f382cb3d0ad771edb21b2ee308a2dd119/apps/desktop/src/main/config.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9505/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9505/files#diff-02e7bf746fb599140284984877377fbcca00ca42a333475a9fb959de43043eae
https://github.com/simstudioai/sim/pull/9505/files#diff-02e7bf746fb599140284984877377fbcca00ca42a333475a9fb959de43043eae
apps/desktop/src/main/in-flight-work.test.tshttps://github.com/simstudioai/sim/pull/9505/files#diff-8c3bb3222c17aa3dc5611911e5a2ebe2bb3852428626854532674c75694b7427
View file https://github.com/simstudioai/sim/blob/2720423f382cb3d0ad771edb21b2ee308a2dd119/apps/desktop/src/main/in-flight-work.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9505/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/9505/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9505/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.