Title: test(mothership): drive a draft run past a wait slice through the real controller by waleedlatif1 · Pull Request #9475 · simstudioai/sim · GitHub
Open Graph Title: test(mothership): drive a draft run past a wait slice through the real controller by waleedlatif1 · Pull Request #9475 · simstudioai/sim
X Title: test(mothership): drive a draft run past a wait slice through the real controller by waleedlatif1 · Pull Request #9475 · simstudioai/sim
Description: Summary Adds a live acceptance case to saved-run-read.live.test.ts: a long draft test run goes through the real controller against the worker's sliced synchronous workflows run. It builds on #9464 (workflows run --wait-timeout and the workflow-run-wait-timeout capability) and #9469 (a still-running slice settles as done). The draft is Start → Wait 300 s → Wait 200 s → Function returning {invoice: 42, settled: "after-waits"}. It runs through runCopilotLifecycle, the sim_cli handler, the embedded CLI, and the v2 execute and runs routes, against the worker's scripted probe (tools/probes/src/draft-run-slices.ts). The case has three variants: declared: the run detaches after 240 s with exit 4, continues as two workflows runs wait slices, and is read back with workflows runs get --include-output. No call holds the run (each under 250 s), no slice row is failed, and the model receives the run's real output. undeclared: one held workflows run --manual with no --wait-timeout, exit 0, with the output. own-budget: the model's own --wait-timeout 5 reaches it as exit 4, with the running receipt and the "Keep waiting" hint. Two fixture changes make the controller cases runnable on a self-hosted default: The harness pins direct Sim transport. The control fixture answers run control on its direct endpoint; under the checkpoint default, run control went unanswered and the turn timed out. The fixture plan's execution timeout is set per case, so a run can outlast a slice. Opt-in like the other controller cases: SIM_HELPERS_SMOKE=1, MSHIP_TEST_DATABASE_URL, MSHIP_WORKER_ROOT. Optionally MSHIP_PROBE_REDIS_URL, and MSHIP_SLICES_REPORT_PATH for the JSON evidence. It takes about nine minutes. Companion: simstudioai/mothership#872 Type of Change Bug fix New feature Breaking change Documentation Other: live test Testing Ran at this head against the worker branch feat/slice-draft-test-runs (70d213247), 09:55–10:04 PT. All three variants pass: declared: 240.1 s (exit 4) → 240.0 s (exit 4) → 29.3 s (exit 0) → read-back 0.04 s; turn 509.9 s. undeclared: one call, 260.4 s, exit 0. own-budget: one call, 5.1 s, exit 4. The case only adds a test and fixture knobs; no production code changes. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Adds a live acceptance case to saved-run-read.live.test.ts: a long draft test run goes through the real controller against the worker's sliced synchronous workflows run. It builds on #9...
X Description: Summary Adds a live acceptance case to saved-run-read.live.test.ts: a long draft test run goes through the real controller against the worker's sliced synchronous workflows run. It builds o...
Opengraph URL: https://github.com/simstudioai/sim/pull/9475
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ae336370-166d-a59c-d984-a8bb664b7f4a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8368:AFEF4:79E86:AF449:6AFB192A |
| html-safe-nonce | b935827730e0f305575e66b08979e09e16082b48d646d4255872a62e313cda8d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzY4OkFGRUY0Ojc5RTg2OkFGNDQ5OjZBRkIxOTJBIiwidmlzaXRvcl9pZCI6IjYyNDgyOTk1NTE5MjkzNDIyNTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4c35b6022a16751053df1ac014cb1624e91eeaa0c2bafb005b4292a29551cc1d |
| hovercard-subject-tag | pull_request:5088130758 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9475/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Adds a live acceptance case to saved-run-read.live.test.ts: a long draft test run goes through the real controller against the worker's sliced synchronous workflows run. It builds on #9... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 030711cc180b563614a434f4376acf7da5d445fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width