René's URL Explorer Experiment


Title: fix(mothership): settle a sim_cli wait that outlasted --wait-timeout as done, not failed by waleedlatif1 · Pull Request #9469 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): settle a sim_cli wait that outlasted --wait-timeout as done, not failed by waleedlatif1 · Pull Request #9469 · simstudioai/sim

X Title: fix(mothership): settle a sim_cli wait that outlasted --wait-timeout as done, not failed by waleedlatif1 · Pull Request #9469 · simstudioai/sim

Description: Summary A sim_cli wait whose --wait-timeout elapsed while the work keeps going exits 4 and prints the record to continue from. That covers workflows runs wait, a synchronous workflows run that detached (#9464), and a workspace operation wait. The sim_cli handler treated every non-zero exit as a failed call. So when the worker runs a long draft workflow test run in slices, each still-running slice got: recorded in copilot_async_tool_calls as failed, with the "still running" stderr line as its error published to the chat as an errored tool row. Its title stays in the progressive tense ("Running workflow", "Waiting for workflow run") instead of "Ran workflow" / "Waited for workflow run", and the activity header drops the model's completed title (e.g. "Tested the draft workflow") for a summary of the calls that did succeed counted as outcome=error in copilot.tool.calls, with the tool span ended as error The CLI now names that exit status (STILL_RUNNING_EXIT_CODE, exported from sim/embed) at both places that produce it. The handler settles it as a successful call and keeps exitCode: 4 in the output, which is what the worker branches on to issue the next slice. Every other non-zero exit is still a failed call, including 1 (the run failed), 2 (cancelled) and 3 (paused). Type of Change Bug fix New feature Breaking change Documentation Other: ___________ Testing New regression test in sim-cli-bridge.test.ts: an exit-4 wait settles as { success: true, output: { exitCode: 4, … } }. It fails on the pre-fix handler (success: false with the stderr line as error). Before the fix, I traced that pre-fix result through executeToolAndReport with a throwaway probe: async row failed, client tool event status: error, metric outcome: error. The UI helpers gave "Running workflow" and "Waiting for workflow run" for errored rows, and a group header of "Get run" instead of "Tested the draft workflow". bun run lint, type-check (sim, sim-cli), check:audits, and the vitest suites for lib/mothership/agent-cli, the handler and sim-cli commands/protocol all pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A sim_cli wait whose --wait-timeout elapsed while the work keeps going exits 4 and prints the record to continue from. That covers workflows runs wait, a synchronous workflows run that deta...

X Description: Summary A sim_cli wait whose --wait-timeout elapsed while the work keeps going exits 4 and prints the record to continue from. That covers workflows runs wait, a synchronous workflows run that deta...

Opengraph URL: https://github.com/simstudioai/sim/pull/9469

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f2a5158e-35de-047a-8560-be6a08014b39
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC86:355D07:9385E:DC915:6AFB1981
html-safe-nonceb1b6021d52778675cdc866de0e196ed7855b0d8ca8e2eab6130dda3a00ca9e01
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzg2OjM1NUQwNzo5Mzg1RTpEQzkxNTo2QUZCMTk4MSIsInZpc2l0b3JfaWQiOiI3MTYwMDUxODIyNDU3NzIzMjY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2d2b508e1593db144fc634b769ea49238a2eecbdeea5bdd841bd8e12ac686d96
hovercard-subject-tagpull_request:5083175035
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9469/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A sim_cli wait whose --wait-timeout elapsed while the work keeps going exits 4 and prints the record to continue from. That covers workflows runs wait, a synchronous workflows run that deta...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9469/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9469%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9469%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9469/files
Reloadhttps://github.com/simstudioai/sim/pull/9469/files
Reloadhttps://github.com/simstudioai/sim/pull/9469/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/cli-still-running-not-failedhttps://github.com/simstudioai/sim/tree/fix/cli-still-running-not-failed
Conversation 2 https://github.com/simstudioai/sim/pull/9469
Commits 1 https://github.com/simstudioai/sim/pull/9469/commits
Checks 68 https://github.com/simstudioai/sim/pull/9469/checks
Files changed https://github.com/simstudioai/sim/pull/9469/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9469/files
fix(mothership): settle a sim_cli wait that outlasted --wait-timeout as done, not failed https://github.com/simstudioai/sim/pull/9469/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9469/files
1a1cc84 fix(mothership): settle a sim_cli wait that outlasted --wait-timeout … waleedlatif1 Oct 30, 2026 https://github.com/simstudioai/sim/pull/9469/commits/1a1cc84f6bdfde5bdc83bcd324e9090dcd109fb1
Clear filters https://github.com/simstudioai/sim/pull/9469/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9469/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9469/files
sim-cli-bridge.test.ts https://github.com/simstudioai/sim/pull/9469/files#diff-7b74093915ec372e59d4ec3b189b5ca5428aa0023df07d762fae6a1eb3ab1d03
sim-cli.ts https://github.com/simstudioai/sim/pull/9469/files#diff-4c41fc5b509451be5705cf6568aeecb858929c06ad96e91376c57d40ac5604db
workflow-run-wait.ts https://github.com/simstudioai/sim/pull/9469/files#diff-17a7bb1c924fc5ba70ce25dd73b2fcc055d7bac871dd1b987b32319627b3b05a
workspace-operation-wait.ts https://github.com/simstudioai/sim/pull/9469/files#diff-77a5ce9e91a1f89c732fdb580ddaba91909fb60d9e855cd124a2cfb4b7b3965e
embed.ts https://github.com/simstudioai/sim/pull/9469/files#diff-b529d2a35d8e00b69ae4c44c43553d53785a20821e5d47abfea015cc6fcd3583
exit-codes.ts https://github.com/simstudioai/sim/pull/9469/files#diff-683cb5961aad4d028a640ecb9fdbe243e9d0379c3463d7641df7de0e9a8ef6f1
apps/sim/lib/mothership/tools/handlers/sim-cli-bridge.test.tshttps://github.com/simstudioai/sim/pull/9469/files#diff-7b74093915ec372e59d4ec3b189b5ca5428aa0023df07d762fae6a1eb3ab1d03
View file https://github.com/simstudioai/sim/blob/1a1cc84f6bdfde5bdc83bcd324e9090dcd109fb1/apps/sim/lib/mothership/tools/handlers/sim-cli-bridge.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9469/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9469/files#diff-7b74093915ec372e59d4ec3b189b5ca5428aa0023df07d762fae6a1eb3ab1d03
https://github.com/simstudioai/sim/pull/9469/files#diff-7b74093915ec372e59d4ec3b189b5ca5428aa0023df07d762fae6a1eb3ab1d03
https://github.com/simstudioai/sim/pull/9469/files#diff-7b74093915ec372e59d4ec3b189b5ca5428aa0023df07d762fae6a1eb3ab1d03
apps/sim/lib/mothership/tools/handlers/sim-cli.tshttps://github.com/simstudioai/sim/pull/9469/files#diff-4c41fc5b509451be5705cf6568aeecb858929c06ad96e91376c57d40ac5604db
View file https://github.com/simstudioai/sim/blob/1a1cc84f6bdfde5bdc83bcd324e9090dcd109fb1/apps/sim/lib/mothership/tools/handlers/sim-cli.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9469/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9469/files#diff-4c41fc5b509451be5705cf6568aeecb858929c06ad96e91376c57d40ac5604db
https://github.com/simstudioai/sim/pull/9469/files#diff-4c41fc5b509451be5705cf6568aeecb858929c06ad96e91376c57d40ac5604db
https://github.com/simstudioai/sim/pull/9469/files#diff-4c41fc5b509451be5705cf6568aeecb858929c06ad96e91376c57d40ac5604db
https://github.com/simstudioai/sim/pull/9469/files#diff-4c41fc5b509451be5705cf6568aeecb858929c06ad96e91376c57d40ac5604db
packages/sim-cli/src/commands/protocol/workflow-run-wait.tshttps://github.com/simstudioai/sim/pull/9469/files#diff-17a7bb1c924fc5ba70ce25dd73b2fcc055d7bac871dd1b987b32319627b3b05a
View file https://github.com/simstudioai/sim/blob/1a1cc84f6bdfde5bdc83bcd324e9090dcd109fb1/packages/sim-cli/src/commands/protocol/workflow-run-wait.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9469/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9469/files#diff-17a7bb1c924fc5ba70ce25dd73b2fcc055d7bac871dd1b987b32319627b3b05a
https://github.com/simstudioai/sim/pull/9469/files#diff-17a7bb1c924fc5ba70ce25dd73b2fcc055d7bac871dd1b987b32319627b3b05a
https://github.com/simstudioai/sim/pull/9469/files#diff-17a7bb1c924fc5ba70ce25dd73b2fcc055d7bac871dd1b987b32319627b3b05a
https://github.com/simstudioai/sim/pull/9469/files#diff-17a7bb1c924fc5ba70ce25dd73b2fcc055d7bac871dd1b987b32319627b3b05a
packages/sim-cli/src/commands/protocol/workspace-operation-wait.tshttps://github.com/simstudioai/sim/pull/9469/files#diff-77a5ce9e91a1f89c732fdb580ddaba91909fb60d9e855cd124a2cfb4b7b3965e
View file https://github.com/simstudioai/sim/blob/1a1cc84f6bdfde5bdc83bcd324e9090dcd109fb1/packages/sim-cli/src/commands/protocol/workspace-operation-wait.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9469/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9469/files#diff-77a5ce9e91a1f89c732fdb580ddaba91909fb60d9e855cd124a2cfb4b7b3965e
https://github.com/simstudioai/sim/pull/9469/files#diff-77a5ce9e91a1f89c732fdb580ddaba91909fb60d9e855cd124a2cfb4b7b3965e
https://github.com/simstudioai/sim/pull/9469/files#diff-77a5ce9e91a1f89c732fdb580ddaba91909fb60d9e855cd124a2cfb4b7b3965e
packages/sim-cli/src/embed.tshttps://github.com/simstudioai/sim/pull/9469/files#diff-b529d2a35d8e00b69ae4c44c43553d53785a20821e5d47abfea015cc6fcd3583
View file https://github.com/simstudioai/sim/blob/1a1cc84f6bdfde5bdc83bcd324e9090dcd109fb1/packages/sim-cli/src/embed.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9469/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9469/files#diff-b529d2a35d8e00b69ae4c44c43553d53785a20821e5d47abfea015cc6fcd3583
https://github.com/simstudioai/sim/pull/9469/files#diff-b529d2a35d8e00b69ae4c44c43553d53785a20821e5d47abfea015cc6fcd3583
packages/sim-cli/src/exit-codes.tshttps://github.com/simstudioai/sim/pull/9469/files#diff-683cb5961aad4d028a640ecb9fdbe243e9d0379c3463d7641df7de0e9a8ef6f1
View file https://github.com/simstudioai/sim/blob/1a1cc84f6bdfde5bdc83bcd324e9090dcd109fb1/packages/sim-cli/src/exit-codes.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9469/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/9469/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.