René's URL Explorer Experiment


Title: fix(executor): bound condition loops and reject unnamed variable assignments by waleedlatif1 · Pull Request #9463 · simstudioai/sim · GitHub

Open Graph Title: fix(executor): bound condition loops and reject unnamed variable assignments by waleedlatif1 · Pull Request #9463 · simstudioai/sim

X Title: fix(executor): bound condition loops and reject unnamed variable assignments by waleedlatif1 · Pull Request #9463 · simstudioai/sim

Description: Summary Two executor gaps let a workflow loop forever without any error. Condition-driven loops had no bound. A While loop, or a Do While loop given a condition, stopped only when its condition turned false. If the body never changed what the condition checks, the loop repeated until the run's timeout. The original While design relied on that timeout, but billing-disabled (self-hosted) deployments now run untimed, so there the loop repeated until the process was stopped. Hosted runs still used their full timeout. These loops now stop after DEFAULTS.MAX_CONDITION_LOOP_ITERATIONS (10,000) iterations if the condition is still true. The run then fails with an error log on the loop container ("While loop stopped after 10,000 iterations with its condition still true…"). Exiting quietly would pass a truncated results downstream as if the condition had ended the loop. A condition that turns false on the last allowed iteration still exits normally. For, For Each and count-driven Do While loops keep their configured count, and the ceiling does not apply to them. The ceiling is per loop run: nested loops reset their scope on each outer iteration, and scope.iteration already carries over through pause/resume snapshots, so no snapshot shape changes. 10,000 leaves room for realistic polling (a 1 s poll runs about 2.8 h, longer than the default hosted async timeout). A tight loop with a stuck condition now fails in seconds to minutes instead of running until the timeout. Variables assignments without a name were dropped. parseAssignments skipped any row with a blank variableName, so an update meant to advance loop state did nothing and raised no error. This is how a stuck While condition usually happens. The new rule: A row targets the variable it names, or the one its variableId selects. A row with an id but no name previously did nothing, even though the variable existed. A row that targets no variable but carries a value fails the block: Assignment N sets a value but names no variable…. Blank rows, the empty row the editor adds by default, are still ignored. A row that omits type takes its target variable's type, so { variableName: 'count', value: 1 } stays a number. Before, it was stored as the string '1', which breaks + 1 in a loop counter. The block's published input description said "objects with name and value properties". name is not the field the handler reads, so authoring tools that read the catalog were steered to the wrong key. It now names variableName. Type of Change Bug fix New feature Breaking change Documentation Other: ___________ Testing New executor/execution/condition-loop-ceiling.test.ts runs real workflows through DAGExecutor: While and conditional Do While loops with a condition that never turns false fail at exactly 10,000 iterations, with the error on the loop's block log. On the previous code the same tests ran until the test's cancellation guard stopped them at 30,000. A condition that turns false on iteration 10,000 still succeeds. For and count-driven Do While loops configured for 10,005 iterations still run all 10,005. handler.test.ts: A value set through a blank name, through a name key, or through an unknown id with no name now fails. On the previous code all three passed silently. Blank editor rows are still skipped. A row with an id but no name updates its variable. vitest run executor lib/workflows lib/catalog blocks serializer: 335 files, 4607 tests pass. tsc --noEmit is clean for apps/sim, as are biome, check:test-types, check:comment-hygiene, check:utils and check:source-conventions. Reviewers: does the 10,000 ceiling size fit how condition loops are used? Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Two executor gaps let a workflow loop forever without any error. Condition-driven loops had no bound. A While loop, or a Do While loop given a condition, stopped only when its condition tur...

X Description: Summary Two executor gaps let a workflow loop forever without any error. Condition-driven loops had no bound. A While loop, or a Do While loop given a condition, stopped only when its condition tur...

Opengraph URL: https://github.com/simstudioai/sim/pull/9463

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6fdfd514-b03a-0eb5-9ccc-cec7bea32dc2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC28:2A38AD:80CEE:C0B1D:6AFB192B
html-safe-nonce7a591c72d02e93ff8fa812a77f1fb80d115197d061150589ec3cfbd46b8ea388
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzI4OjJBMzhBRDo4MENFRTpDMEIxRDo2QUZCMTkyQiIsInZpc2l0b3JfaWQiOiI2MTUyNTI3NzM4MzQ4MTgxODAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac86f0ba4023788033a55d5a478c38b5aa3916342917fe53365e4092ac55b4d487
hovercard-subject-tagpull_request:5078889802
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9463/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Two executor gaps let a workflow loop forever without any error. Condition-driven loops had no bound. A While loop, or a Do While loop given a condition, stopped only when its condition tur...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9463/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9463%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9463%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9463/files
Reloadhttps://github.com/simstudioai/sim/pull/9463/files
Reloadhttps://github.com/simstudioai/sim/pull/9463/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/loop-iteration-ceilinghttps://github.com/simstudioai/sim/tree/fix/loop-iteration-ceiling
Conversation 18 https://github.com/simstudioai/sim/pull/9463
Commits 3 https://github.com/simstudioai/sim/pull/9463/commits
Checks 67 https://github.com/simstudioai/sim/pull/9463/checks
Files changed https://github.com/simstudioai/sim/pull/9463/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9463/files
fix(executor): bound condition loops and reject unnamed variable assignments https://github.com/simstudioai/sim/pull/9463/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9463/files
2c3cb41 fix(executor): stop condition loops at an iteration ceiling and rejec… waleedlatif1 Oct 30, 2026 https://github.com/simstudioai/sim/pull/9463/commits/2c3cb41129bcadf70ee8032d90c9c51f85c0a075
f85eb7c fix(executor): give untyped variable assignments their target variabl… waleedlatif1 Oct 30, 2026 https://github.com/simstudioai/sim/pull/9463/commits/f85eb7cfb47b44089d4f9318702e47714e206605
2730d8e chore(executor): shrink the explicit-any baseline for the variables h… waleedlatif1 Oct 30, 2026 https://github.com/simstudioai/sim/pull/9463/commits/2730d8e068ccdc3e7f20bd6b21eea0d5c82f235d
Clear filters https://github.com/simstudioai/sim/pull/9463/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9463/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9463/files
loop.mdx https://github.com/simstudioai/sim/pull/9463/files#diff-275771e307d818f378247a36cddb8523004ea44b01e973c1d08267b9b2bca933
variables.mdx https://github.com/simstudioai/sim/pull/9463/files#diff-8297e4671d513ff1f296d2f52af2b09828f691ee927cb3f8c2d08202dfa4378b
variables.ts https://github.com/simstudioai/sim/pull/9463/files#diff-36b7a05c4fde9c9876af543d63e98ca16a113433adf0c2ade726aaf3387628e6
constants.ts https://github.com/simstudioai/sim/pull/9463/files#diff-b566218dab8a8d929381b127c0bcd2608efcb979d70cdbf1c6a6cf214989dac7
condition-loop-ceiling.test.ts https://github.com/simstudioai/sim/pull/9463/files#diff-69b58659caa85d473d10e3f8c081a8fd5bd890c1668dc4c33df5fe3d28154856
handler.test.ts https://github.com/simstudioai/sim/pull/9463/files#diff-98bdc08aff2194b56a20caba12fd16ef94a2d853d1aaebd31d38a4d98763307e
handler.ts https://github.com/simstudioai/sim/pull/9463/files#diff-b526b66610347de3722d04c2c5307120224995b363c46d8d15f90614ef655db9
loop.ts https://github.com/simstudioai/sim/pull/9463/files#diff-112bfce09777d1c73cccd2a5bf9870750f5d7e380332c8af3cdc0fbccc21e98f
check-explicit-any.baseline.json https://github.com/simstudioai/sim/pull/9463/files#diff-780d04116ec981737479435cdb0364b49047711f2dfb93b671a9be50a1b0bb27
apps/docs/content/docs/workflows/blocks/loop.mdxhttps://github.com/simstudioai/sim/pull/9463/files#diff-275771e307d818f378247a36cddb8523004ea44b01e973c1d08267b9b2bca933
View file https://github.com/simstudioai/sim/blob/2730d8e068ccdc3e7f20bd6b21eea0d5c82f235d/apps/docs/content/docs/workflows/blocks/loop.mdx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9463/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9463/files#diff-275771e307d818f378247a36cddb8523004ea44b01e973c1d08267b9b2bca933
https://github.com/simstudioai/sim/pull/9463/files#diff-275771e307d818f378247a36cddb8523004ea44b01e973c1d08267b9b2bca933
apps/docs/content/docs/workflows/blocks/variables.mdxhttps://github.com/simstudioai/sim/pull/9463/files#diff-8297e4671d513ff1f296d2f52af2b09828f691ee927cb3f8c2d08202dfa4378b
View file https://github.com/simstudioai/sim/blob/2730d8e068ccdc3e7f20bd6b21eea0d5c82f235d/apps/docs/content/docs/workflows/blocks/variables.mdx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9463/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9463/files#diff-8297e4671d513ff1f296d2f52af2b09828f691ee927cb3f8c2d08202dfa4378b
https://github.com/simstudioai/sim/pull/9463/files#diff-8297e4671d513ff1f296d2f52af2b09828f691ee927cb3f8c2d08202dfa4378b
apps/sim/blocks/blocks/variables.tshttps://github.com/simstudioai/sim/pull/9463/files#diff-36b7a05c4fde9c9876af543d63e98ca16a113433adf0c2ade726aaf3387628e6
View file https://github.com/simstudioai/sim/blob/2730d8e068ccdc3e7f20bd6b21eea0d5c82f235d/apps/sim/blocks/blocks/variables.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9463/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9463/files#diff-36b7a05c4fde9c9876af543d63e98ca16a113433adf0c2ade726aaf3387628e6
https://github.com/simstudioai/sim/pull/9463/files#diff-36b7a05c4fde9c9876af543d63e98ca16a113433adf0c2ade726aaf3387628e6
apps/sim/executor/constants.tshttps://github.com/simstudioai/sim/pull/9463/files#diff-b566218dab8a8d929381b127c0bcd2608efcb979d70cdbf1c6a6cf214989dac7
View file https://github.com/simstudioai/sim/blob/2730d8e068ccdc3e7f20bd6b21eea0d5c82f235d/apps/sim/executor/constants.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9463/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9463/files#diff-b566218dab8a8d929381b127c0bcd2608efcb979d70cdbf1c6a6cf214989dac7
https://github.com/simstudioai/sim/pull/9463/files#diff-b566218dab8a8d929381b127c0bcd2608efcb979d70cdbf1c6a6cf214989dac7
apps/sim/executor/execution/condition-loop-ceiling.test.tshttps://github.com/simstudioai/sim/pull/9463/files#diff-69b58659caa85d473d10e3f8c081a8fd5bd890c1668dc4c33df5fe3d28154856
View file https://github.com/simstudioai/sim/blob/2730d8e068ccdc3e7f20bd6b21eea0d5c82f235d/apps/sim/executor/execution/condition-loop-ceiling.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9463/{{ revealButtonHref }}
apps/sim/executor/handlers/variables/handler.test.tshttps://github.com/simstudioai/sim/pull/9463/files#diff-98bdc08aff2194b56a20caba12fd16ef94a2d853d1aaebd31d38a4d98763307e
View file https://github.com/simstudioai/sim/blob/2730d8e068ccdc3e7f20bd6b21eea0d5c82f235d/apps/sim/executor/handlers/variables/handler.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9463/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9463/files#diff-98bdc08aff2194b56a20caba12fd16ef94a2d853d1aaebd31d38a4d98763307e
apps/sim/executor/handlers/variables/handler.tshttps://github.com/simstudioai/sim/pull/9463/files#diff-b526b66610347de3722d04c2c5307120224995b363c46d8d15f90614ef655db9
View file https://github.com/simstudioai/sim/blob/2730d8e068ccdc3e7f20bd6b21eea0d5c82f235d/apps/sim/executor/handlers/variables/handler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9463/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9463/files#diff-b526b66610347de3722d04c2c5307120224995b363c46d8d15f90614ef655db9
https://github.com/simstudioai/sim/pull/9463/files#diff-b526b66610347de3722d04c2c5307120224995b363c46d8d15f90614ef655db9
https://github.com/simstudioai/sim/pull/9463/files#diff-b526b66610347de3722d04c2c5307120224995b363c46d8d15f90614ef655db9
https://github.com/simstudioai/sim/pull/9463/files#diff-b526b66610347de3722d04c2c5307120224995b363c46d8d15f90614ef655db9
https://github.com/simstudioai/sim/pull/9463/files#diff-b526b66610347de3722d04c2c5307120224995b363c46d8d15f90614ef655db9
https://github.com/simstudioai/sim/pull/9463/files#diff-b526b66610347de3722d04c2c5307120224995b363c46d8d15f90614ef655db9
https://github.com/simstudioai/sim/pull/9463/files#diff-b526b66610347de3722d04c2c5307120224995b363c46d8d15f90614ef655db9
Please reload this pagehttps://github.com/simstudioai/sim/pull/9463/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9463/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.