René's URL Explorer Experiment


Title: perf(audit-logs): read a listing narrowed only by time through per-workspace keyset scans by waleedlatif1 · Pull Request #9450 · simstudioai/sim · GitHub

Open Graph Title: perf(audit-logs): read a listing narrowed only by time through per-workspace keyset scans by waleedlatif1 · Pull Request #9450 · simstudioai/sim

X Title: perf(audit-logs): read a listing narrowed only by time through per-workspace keyset scans by waleedlatif1 · Pull Request #9450 · simstudioai/sim

Description: Summary An organization's audit listing scopes rows with one OR predicate (the org's workspaces, or workspace-less rows naming the org). With no filter, or only a time range (the audit page's default "Past 30 days" view), no index returns that OR in listing order, so each page collects every in-scope row inside the range and sorts it. For a busy organization that becomes a scan over a large part of audit_log, long enough to hit replica recovery conflicts. This PR changes only those listings, the ones narrowed by nothing but a time range: The page ids come from a disjoint union. Each organization workspace gets one keyset scan of audit_log_workspace_created_at_id_idx, through unnest(...) cross join lateral (... limit page). The metadata-attributed org-level rows are read through audit_log_org_level_created_at_id_idx (0444). The organization-resource rows that don't name the org in metadata get a small resource_idx read. Every part is ordered and limited to one page, so the first page of the union is exactly the first page of the scope, and union all can't produce duplicates because the parts are disjoint. Workspace ids are deduplicated. The time range is kept as written (created_at >= / <=). It is also stated as implied bounds on the sort key (date_trunc('milliseconds', created_at) >= / <= date_trunc(bound)). Because date_trunc never decreases, these bounds drop no row the exact predicate keeps, and each scan starts and stops at the range. The cursor is the same keyset position, written as a row comparison so the scan can seek to it. Any other filter (action, resource type/id, actor, actor email, workspace, search, alone or combined with time) keeps the single predicate unchanged, SQL and parameters byte for byte. Under such a filter a per-workspace scan cannot stop after a page; that is what made #9419's fan-out slow, and #9438 reverted it. The single predicate lets the filter's own index drive. queryAuditLogs now takes the scope and the filters instead of prebuilt SQL so it can make this choice. Callers updated: list and export use cases, /api/v1/audit-logs. buildOrgScopeCondition output is unchanged, so the detail read and the data drain are untouched. No schema change. audit_log_workspace_created_at_id_idx stays: this path depends on it, and workspace-filtered listings already use it today. Type of Change Other: performance Testing list-scope.integration.ts pages through 13 filter shapes (none, start, end inside a millisecond, range, action, action+time, resource type(s), resource, actor, workspace, search). Each runs with current members only and with departed members included, at page sizes 1/3/7/100, with and without the byte budget. Every run must match the single predicate's order exactly. The fixture covers workspace rows, org-level rows of both kinds, another org's rows, departed and null actors, four rows per PostgreSQL millisecond (ties broken by id), a duplicated workspace id, and a workspace the organization no longer holds. list-plans.integration.ts checks the plans. Unfiltered, departed-included, after-cursor, start-date and date-range listings must read each workspace with an Index Scan Backward on the keyset index directly under the limit that stops it, with the range and cursor in its Index Cond. These checks fail on the previous single-predicate listing. Every narrowed shape must keep the single predicate (no fan-out). Mutation checks: dropping the workspace-id dedupe, dropping the exact time predicate, or routing everything back to the single predicate each turns these tests red. A one-off compile of every narrowed filter combination, with and without a cursor, across three scopes produced SQL text and parameters identical to staging. On the production replica, the busiest organization's unfiltered and 30-day listings go from a scan of the whole scope to a few thousand buffer hits. A one-hour window costs about the same as today. Organizations with many workspaces stay bounded at one short scan per workspace. Audit-log and data-drain integration suites, related unit suites, lint, check:audits, type-check, test:scripts. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary An organization's audit listing scopes rows with one OR predicate (the org's workspaces, or workspace-less rows naming the org). With no filter, or only a time range (the audit page...

X Description: Summary An organization&#39;s audit listing scopes rows with one OR predicate (the org&#39;s workspaces, or workspace-less rows naming the org). With no filter, or only a time range (the au...

Opengraph URL: https://github.com/simstudioai/sim/pull/9450

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c216f04b-b48e-c0ea-2761-94bdb6c5a3f8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC01C:2AD8BA:1774E1:228002:6AFB0FAD
html-safe-nonce89114c355709a2c6b1b6020fbd13b0657756fed35798f9d70f6cca01019707b0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDFDOjJBRDhCQToxNzc0RTE6MjI4MDAyOjZBRkIwRkFEIiwidmlzaXRvcl9pZCI6Ijg3OTA2MDAzOTIxOTE0NDY5NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac303e76ccb4aba75f951408c72235f311c45d67613268bb38767173ecc85b0181
hovercard-subject-tagpull_request:5073531632
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9450/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary An organization's audit listing scopes rows with one OR predicate (the org's workspaces, or workspace-less rows naming the org). With no filter, or only a time range (the audit page...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4275ec98d19a530a209480d02854be81de24ad5a05b648333242fc516bfb573c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseba13208acc32a4e7a4a3b54cb2f0dea6001ba5f8
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9450/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9450%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9450%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9450/files
Reloadhttps://github.com/simstudioai/sim/pull/9450/files
Reloadhttps://github.com/simstudioai/sim/pull/9450/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
perf/audit-log-organization-scopehttps://github.com/simstudioai/sim/tree/perf/audit-log-organization-scope
Conversation 7 https://github.com/simstudioai/sim/pull/9450
Commits 2 https://github.com/simstudioai/sim/pull/9450/commits
Checks 67 https://github.com/simstudioai/sim/pull/9450/checks
Files changed https://github.com/simstudioai/sim/pull/9450/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9450/files
perf(audit-logs): read a listing narrowed only by time through per-workspace keyset scans https://github.com/simstudioai/sim/pull/9450/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9450/files
2216fba perf(audit-logs): read a listing narrowed only by time through per-wo… waleedlatif1 Oct 29, 2026 https://github.com/simstudioai/sim/pull/9450/commits/2216fbabdeba3d4993e797f66fcbc9aa28148468
0c1f3e8 test(audit-logs): plan the keyset listing over a workspace written mo… waleedlatif1 Oct 29, 2026 https://github.com/simstudioai/sim/pull/9450/commits/0c1f3e8865e50424fb741b6e548d6bacdb5e008e
Clear filters https://github.com/simstudioai/sim/pull/9450/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9450/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9450/files
route.test.ts https://github.com/simstudioai/sim/pull/9450/files#diff-a22f7996ee7500bf0fdc166a39be1ff40c4561974df7c70e8cf94ded4a80dae0
route.ts https://github.com/simstudioai/sim/pull/9450/files#diff-84bad28ae7d475877f9a7c6f1b58d0455aea329b1502b87285d4966b73b406f5
export-audit-logs.ts https://github.com/simstudioai/sim/pull/9450/files#diff-c2223cc8d1d51821d060888c652c271bc077741e79d8eafbb1e9d375abc3e531
list-audit-logs.ts https://github.com/simstudioai/sim/pull/9450/files#diff-dc4565161762474880ce323e137bca3a2302cf4312756c865f2224a71b0a0d87
use-cases.test.ts https://github.com/simstudioai/sim/pull/9450/files#diff-f8f3791ec094730b839da4e2b7a6498a03a42d617fd941f77ff3b8becf446184
list-plans.integration.ts https://github.com/simstudioai/sim/pull/9450/files#diff-fc9a843d6678cf521118a48f98499ceed85ffd5ace30e7e26134f52bf6d6379b
list-scope.integration.ts https://github.com/simstudioai/sim/pull/9450/files#diff-7bdfdfcda5afd5cb85ffcec8ee6ec19df358afdbcdb3157df6efb690cd99736f
query.integration.ts https://github.com/simstudioai/sim/pull/9450/files#diff-17a8dec1990eed9078d3b4d6c9f37de98f6726c5e8a1b03658c1f274345062a4
query.ts https://github.com/simstudioai/sim/pull/9450/files#diff-aaa2119362c512970c462bfb742bb07aede57d4c2a54911fc17fa26ed4f82800
apps/sim/app/api/v1/audit-logs/route.test.tshttps://github.com/simstudioai/sim/pull/9450/files#diff-a22f7996ee7500bf0fdc166a39be1ff40c4561974df7c70e8cf94ded4a80dae0
View file https://github.com/simstudioai/sim/blob/0c1f3e8865e50424fb741b6e548d6bacdb5e008e/apps/sim/app/api/v1/audit-logs/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9450/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9450/files#diff-a22f7996ee7500bf0fdc166a39be1ff40c4561974df7c70e8cf94ded4a80dae0
https://github.com/simstudioai/sim/pull/9450/files#diff-a22f7996ee7500bf0fdc166a39be1ff40c4561974df7c70e8cf94ded4a80dae0
https://github.com/simstudioai/sim/pull/9450/files#diff-a22f7996ee7500bf0fdc166a39be1ff40c4561974df7c70e8cf94ded4a80dae0
https://github.com/simstudioai/sim/pull/9450/files#diff-a22f7996ee7500bf0fdc166a39be1ff40c4561974df7c70e8cf94ded4a80dae0
https://github.com/simstudioai/sim/pull/9450/files#diff-a22f7996ee7500bf0fdc166a39be1ff40c4561974df7c70e8cf94ded4a80dae0
apps/sim/app/api/v1/audit-logs/route.tshttps://github.com/simstudioai/sim/pull/9450/files#diff-84bad28ae7d475877f9a7c6f1b58d0455aea329b1502b87285d4966b73b406f5
View file https://github.com/simstudioai/sim/blob/0c1f3e8865e50424fb741b6e548d6bacdb5e008e/apps/sim/app/api/v1/audit-logs/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9450/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9450/files#diff-84bad28ae7d475877f9a7c6f1b58d0455aea329b1502b87285d4966b73b406f5
https://github.com/simstudioai/sim/pull/9450/files#diff-84bad28ae7d475877f9a7c6f1b58d0455aea329b1502b87285d4966b73b406f5
https://github.com/simstudioai/sim/pull/9450/files#diff-84bad28ae7d475877f9a7c6f1b58d0455aea329b1502b87285d4966b73b406f5
https://github.com/simstudioai/sim/pull/9450/files#diff-84bad28ae7d475877f9a7c6f1b58d0455aea329b1502b87285d4966b73b406f5
apps/sim/lib/audit-logs/application/export-audit-logs.tshttps://github.com/simstudioai/sim/pull/9450/files#diff-c2223cc8d1d51821d060888c652c271bc077741e79d8eafbb1e9d375abc3e531
View file https://github.com/simstudioai/sim/blob/0c1f3e8865e50424fb741b6e548d6bacdb5e008e/apps/sim/lib/audit-logs/application/export-audit-logs.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9450/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9450/files#diff-c2223cc8d1d51821d060888c652c271bc077741e79d8eafbb1e9d375abc3e531
https://github.com/simstudioai/sim/pull/9450/files#diff-c2223cc8d1d51821d060888c652c271bc077741e79d8eafbb1e9d375abc3e531
https://github.com/simstudioai/sim/pull/9450/files#diff-c2223cc8d1d51821d060888c652c271bc077741e79d8eafbb1e9d375abc3e531
https://github.com/simstudioai/sim/pull/9450/files#diff-c2223cc8d1d51821d060888c652c271bc077741e79d8eafbb1e9d375abc3e531
https://github.com/simstudioai/sim/pull/9450/files#diff-c2223cc8d1d51821d060888c652c271bc077741e79d8eafbb1e9d375abc3e531
apps/sim/lib/audit-logs/application/list-audit-logs.tshttps://github.com/simstudioai/sim/pull/9450/files#diff-dc4565161762474880ce323e137bca3a2302cf4312756c865f2224a71b0a0d87
View file https://github.com/simstudioai/sim/blob/0c1f3e8865e50424fb741b6e548d6bacdb5e008e/apps/sim/lib/audit-logs/application/list-audit-logs.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9450/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9450/files#diff-dc4565161762474880ce323e137bca3a2302cf4312756c865f2224a71b0a0d87
https://github.com/simstudioai/sim/pull/9450/files#diff-dc4565161762474880ce323e137bca3a2302cf4312756c865f2224a71b0a0d87
https://github.com/simstudioai/sim/pull/9450/files#diff-dc4565161762474880ce323e137bca3a2302cf4312756c865f2224a71b0a0d87
apps/sim/lib/audit-logs/application/use-cases.test.tshttps://github.com/simstudioai/sim/pull/9450/files#diff-f8f3791ec094730b839da4e2b7a6498a03a42d617fd941f77ff3b8becf446184
View file https://github.com/simstudioai/sim/blob/0c1f3e8865e50424fb741b6e548d6bacdb5e008e/apps/sim/lib/audit-logs/application/use-cases.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9450/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9450/files#diff-f8f3791ec094730b839da4e2b7a6498a03a42d617fd941f77ff3b8becf446184
https://github.com/simstudioai/sim/pull/9450/files#diff-f8f3791ec094730b839da4e2b7a6498a03a42d617fd941f77ff3b8becf446184
https://github.com/simstudioai/sim/pull/9450/files#diff-f8f3791ec094730b839da4e2b7a6498a03a42d617fd941f77ff3b8becf446184
https://github.com/simstudioai/sim/pull/9450/files#diff-f8f3791ec094730b839da4e2b7a6498a03a42d617fd941f77ff3b8becf446184
https://github.com/simstudioai/sim/pull/9450/files#diff-f8f3791ec094730b839da4e2b7a6498a03a42d617fd941f77ff3b8becf446184
https://github.com/simstudioai/sim/pull/9450/files#diff-f8f3791ec094730b839da4e2b7a6498a03a42d617fd941f77ff3b8becf446184
apps/sim/lib/audit-logs/list-plans.integration.tshttps://github.com/simstudioai/sim/pull/9450/files#diff-fc9a843d6678cf521118a48f98499ceed85ffd5ace30e7e26134f52bf6d6379b
View file https://github.com/simstudioai/sim/blob/0c1f3e8865e50424fb741b6e548d6bacdb5e008e/apps/sim/lib/audit-logs/list-plans.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9450/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/9450/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9450/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.