René's URL Explorer Experiment


Title: perf(file-search): probe each backfill page's revisions by primary key by waleedlatif1 · Pull Request #9445 · simstudioai/sim · GitHub

Open Graph Title: perf(file-search): probe each backfill page's revisions by primary key by waleedlatif1 · Pull Request #9445 · simstudioai/sim

X Title: perf(file-search): probe each backfill page's revisions by primary key by waleedlatif1 · Pull Request #9445 · simstudioai/sim

Description: Summary The file-search backfill walk checked each file for a revision with a correlated EXISTS in its select list. PostgreSQL plans that as an alternative subplan and chooses the hashed form from the scan's row estimate, before the page LIMIT applies, so every page sequentially scanned and hashed the whole workspace_file_search_revision table to answer a thousand lookups The page now LEFT JOINs the revision on its primary key (file_id = workspace_files.id) and reads hasRevision as the joined key being non-null. Under the limit the planner nests the join over the existing ordered keyset scan: one primary-key probe per file returned file_id is the revision's primary key, so the join cannot duplicate a file; the keyset predicate, ORDER BY and LIMIT are byte-for-byte unchanged, as are the lock-and-reread of unindexed files, the insert, the owner wakeups and the cursor update Plain EXPLAIN and replica EXPLAIN (ANALYZE, BUFFERS) of both forms with a real mid-walk cursor: old plan keeps the keyset index scan plus a hashed SubPlan over a Seq Scan of the revision table (~500ms per page); new plan is Limit -> Nested Loop Left Join -> keyset Index Scan + Index Only Scan on workspace_file_search_revision_pkey (~12ms warm), same plan for the first page and a cursor near the end of the walk Type of Change Other: Performance Testing New dispatcher.integration.ts case walks a second backfill page over a settled table (no planner overrides) and asserts the revision table is read only through workspace_file_search_revision_pkey with Index Cond: (file_id = workspace_files.id); it fails on the previous query with exactly the hashed Seq Scan subplan Existing cases still cover hasRevision both ways and the walk semantics: only files missing a revision are seeded and locked, every live file is walked exactly once across pages, and the cursor seeks the keyset index lib/workspace-files/search/ integration (109 passed) and unit (178 passed) suites against Postgres 17, bun run type-check (apps/sim), bun run lint, bun run check:audits, bun run check:test-types, block-registry check Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The file-search backfill walk checked each file for a revision with a correlated EXISTS in its select list. PostgreSQL plans that as an alternative subplan and chooses the hashed form from...

X Description: Summary The file-search backfill walk checked each file for a revision with a correlated EXISTS in its select list. PostgreSQL plans that as an alternative subplan and chooses the hashed form from...

Opengraph URL: https://github.com/simstudioai/sim/pull/9445

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d93fd021-1d15-b001-6c89-32efe04a5bd2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC646:32180C:2787B8:3AA8AD:6AFB217F
html-safe-nonce5c88182194b3f63f199527dac47fa81cf378cfade79d5be9794995d5a2c7c09b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjQ2OjMyMTgwQzoyNzg3Qjg6M0FBOEFEOjZBRkIyMTdGIiwidmlzaXRvcl9pZCI6IjU4ODcyODI3MTI5MDQ2NzE2MTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbe1905be96e80e284a474c3c79f0507f0f2138c1683876ccb33aee1f692051d2
hovercard-subject-tagpull_request:5073238784
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9445/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The file-search backfill walk checked each file for a revision with a correlated EXISTS in its select list. PostgreSQL plans that as an alternative subplan and chooses the hashed form from...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9219899e0d0ce0b87aeba2c640c955f83631457e5baff5df7a36ce599d2635b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd3b60f1fd9c5f10a3dcde41ae35682f53e85cee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9445/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9445%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9445%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9445/files
Reloadhttps://github.com/simstudioai/sim/pull/9445/files
Reloadhttps://github.com/simstudioai/sim/pull/9445/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
perf/file-search-backfill-revision-joinhttps://github.com/simstudioai/sim/tree/perf/file-search-backfill-revision-join
Conversation 2 https://github.com/simstudioai/sim/pull/9445
Commits 1 https://github.com/simstudioai/sim/pull/9445/commits
Checks 67 https://github.com/simstudioai/sim/pull/9445/checks
Files changed https://github.com/simstudioai/sim/pull/9445/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9445/files
perf(file-search): probe each backfill page's revisions by primary key https://github.com/simstudioai/sim/pull/9445/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9445/files
1b91e9b perf(file-search): probe each backfill page's revisions by primary key waleedlatif1 Oct 29, 2026 https://github.com/simstudioai/sim/pull/9445/commits/1b91e9b23152aa5e38ea0dabc0cf217a12e0dbbb
Clear filters https://github.com/simstudioai/sim/pull/9445/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9445/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9445/files
dispatcher.integration.ts https://github.com/simstudioai/sim/pull/9445/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
dispatcher.ts https://github.com/simstudioai/sim/pull/9445/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
apps/sim/lib/workspace-files/search/dispatcher.integration.tshttps://github.com/simstudioai/sim/pull/9445/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
View file https://github.com/simstudioai/sim/blob/1b91e9b23152aa5e38ea0dabc0cf217a12e0dbbb/apps/sim/lib/workspace-files/search/dispatcher.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9445/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9445/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/9445/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/9445/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/9445/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
apps/sim/lib/workspace-files/search/dispatcher.tshttps://github.com/simstudioai/sim/pull/9445/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
View file https://github.com/simstudioai/sim/blob/1b91e9b23152aa5e38ea0dabc0cf217a12e0dbbb/apps/sim/lib/workspace-files/search/dispatcher.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9445/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9445/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9445/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9445/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9445/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/9445/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
Please reload this pagehttps://github.com/simstudioai/sim/pull/9445/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.