René's URL Explorer Experiment


Title: fix(cleanup): keep shared chat files, sweep inline images by prefix, and make room refetches wait by waleedlatif1 · Pull Request #9433 · simstudioai/sim · GitHub

Open Graph Title: fix(cleanup): keep shared chat files, sweep inline images by prefix, and make room refetches wait by waleedlatif1 · Pull Request #9433 · simstudioai/sim

X Title: fix(cleanup): keep shared chat files, sweep inline images by prefix, and make room refetches wait by waleedlatif1 · Pull Request #9433 · simstudioai/sim

Description: Sim is the collaborative workspace to build, deploy, and monitor AI agents and workflows. Used by 100,000+ builders. - fix(cleanup): keep shared chat files, sweep inline images by prefix, and make room refetches wait by waleedlatif1 · Pull Request #9433 · simstudioai/sim

Open Graph Description: Summary Fixes from the v0.9.37 release review that apply to #9419 and #9427. Room deliveries wait for every room's refetch: RoomChangedCallback is now () => Promise<unknown>, so a cal...

X Description: Summary Fixes from the v0.9.37 release review that apply to #9419 and #9427. Room deliveries wait for every room&#39;s refetch: RoomChangedCallback is now () =&gt; Promise&lt;unknown&a...

Opengraph URL: https://github.com/simstudioai/sim/pull/9433

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:7a3ada14-c7d1-f49f-a647-4100a8cea8c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB864:1D4229:8581B:C2A7F:6AFB0ACF
html-safe-nonce468f4a61ab92f0f17eef2bccc15d86c3c17e75a16a7b482bd18cf342ffefba7e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODY0OjFENDIyOTo4NTgxQjpDMkE3Rjo2QUZCMEFDRiIsInZpc2l0b3JfaWQiOiI1Mjg0Mjk1Nzc0NDI5NzExMDU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0d01929bc67292bed0e327e7d5a42ce873781c3da1c5c47ab4fa042f4fb7c1bc
hovercard-subject-tagpull_request:5060844975
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9433/commits
twitter:imagehttps://opengraph.githubassets.com/1b39497cdf81f5f6671ec9b684feddb11ac0b215faf9c15f11a8c86abbba1ba3/simstudioai/sim/pull/9433
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1b39497cdf81f5f6671ec9b684feddb11ac0b215faf9c15f11a8c86abbba1ba3/simstudioai/sim/pull/9433
og:image:altSummary Fixes from the v0.9.37 release review that apply to #9419 and #9427. Room deliveries wait for every room's refetch: RoomChangedCallback is now () => Promise<unknown>, so a cal...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewaleedlatif1
hostnamegithub.com
expected-hostnamegithub.com
None76fb13cb43f1834708971f45a9cfcab5df3177a7582086613d7cdc6e98c4bfde
turbo-cache-controlno-cache
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseafc998826cdd963c8f91a96ae5372809ab5e296b
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9433/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9433%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9433%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9433/commits
Reloadhttps://github.com/simstudioai/sim/pull/9433/commits
Reloadhttps://github.com/simstudioai/sim/pull/9433/commits
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
https://github.com/simstudioai/sim
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/release-review-cleanuphttps://github.com/simstudioai/sim/tree/fix/release-review-cleanup
Conversationhttps://github.com/simstudioai/sim/pull/9433
Commits13 (13)https://github.com/simstudioai/sim/pull/9433/commits
Checkshttps://github.com/simstudioai/sim/pull/9433/checks
Files changedhttps://github.com/simstudioai/sim/pull/9433/files
fix(cleanup): keep shared chat files, sweep inline images by prefix, and make room refetches waithttps://github.com/simstudioai/sim/pull/9433/commits#top
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/release-review-cleanuphttps://github.com/simstudioai/sim/tree/fix/release-review-cleanup
fix(realtime): make room callbacks return their invalidationshttps://github.com/simstudioai/sim/pull/9433/commits/339b3219f1cc56181aeaa6e51f2bc779027a4e7a
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
339b321https://github.com/simstudioai/sim/pull/9433/commits/339b3219f1cc56181aeaa6e51f2bc779027a4e7a
https://github.com/simstudioai/sim/tree/339b3219f1cc56181aeaa6e51f2bc779027a4e7a
fix(workflows): pin the deployed-state hint to the active versionhttps://github.com/simstudioai/sim/pull/9433/commits/099fad85047940b90eebb320106c75ab5fb63382
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
099fad8https://github.com/simstudioai/sim/pull/9433/commits/099fad85047940b90eebb320106c75ab5fb63382
https://github.com/simstudioai/sim/tree/099fad85047940b90eebb320106c75ab5fb63382
fix(cleanup): skip chat attachments whose key is not a stringhttps://github.com/simstudioai/sim/pull/9433/commits/b53b02e11298ddb42423e341196d0945cf5e39ab
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
b53b02ehttps://github.com/simstudioai/sim/pull/9433/commits/b53b02e11298ddb42423e341196d0945cf5e39ab
https://github.com/simstudioai/sim/tree/b53b02e11298ddb42423e341196d0945cf5e39ab
fix(cleanup): purge chat inline images by prefix instead of by transcripthttps://github.com/simstudioai/sim/pull/9433/commits/9e9fac3542ad1363d5088da8e2607ffdd8206e93
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
9e9fac3https://github.com/simstudioai/sim/pull/9433/commits/9e9fac3542ad1363d5088da8e2607ffdd8206e93
https://github.com/simstudioai/sim/tree/9e9fac3542ad1363d5088da8e2607ffdd8206e93
fix(cleanup): keep chat files another chat of their scope still referenceshttps://github.com/simstudioai/sim/pull/9433/commits/a53aadcb2867002fcc90135de6357b4108b3972c
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
a53aadchttps://github.com/simstudioai/sim/pull/9433/commits/a53aadcb2867002fcc90135de6357b4108b3972c
https://github.com/simstudioai/sim/tree/a53aadcb2867002fcc90135de6357b4108b3972c
refactor(uploads): keep sweepStoragePrefix beside the listing it pageshttps://github.com/simstudioai/sim/pull/9433/commits/076136389d809d56afffcc628cc17d9975011973
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
0761363https://github.com/simstudioai/sim/pull/9433/commits/076136389d809d56afffcc628cc17d9975011973
https://github.com/simstudioai/sim/tree/076136389d809d56afffcc628cc17d9975011973
refactor(workflows): resolve the deployed state with one const after the throwhttps://github.com/simstudioai/sim/pull/9433/commits/131f0d34524ddb1c2d2668e1266b35dfe05876be
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
131f0d3https://github.com/simstudioai/sim/pull/9433/commits/131f0d34524ddb1c2d2668e1266b35dfe05876be
https://github.com/simstudioai/sim/tree/131f0d34524ddb1c2d2668e1266b35dfe05876be
improvement(cleanup): sweep chat inline images through their own outbox eventhttps://github.com/simstudioai/sim/pull/9433/commits/5af904001fef7d797a87eafe943e229f1d7010e4
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
5af9040https://github.com/simstudioai/sim/pull/9433/commits/5af904001fef7d797a87eafe943e229f1d7010e4
https://github.com/simstudioai/sim/tree/5af904001fef7d797a87eafe943e229f1d7010e4
chore(cleanup): tighten the cleanup tests and commentshttps://github.com/simstudioai/sim/pull/9433/commits/b54e6a44818083ced5697965d5d489e74d3c546f
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
b54e6a4https://github.com/simstudioai/sim/pull/9433/commits/b54e6a44818083ced5697965d5d489e74d3c546f
https://github.com/simstudioai/sim/tree/b54e6a44818083ced5697965d5d489e74d3c546f
test(cleanup): delete the source chat before checking its files' referenceshttps://github.com/simstudioai/sim/pull/9433/commits/8ca824b118434b091c038c06dd79574af8414cc6
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
8ca824bhttps://github.com/simstudioai/sim/pull/9433/commits/8ca824b118434b091c038c06dd79574af8414cc6
https://github.com/simstudioai/sim/tree/8ca824b118434b091c038c06dd79574af8414cc6
fix(cleanup): spend an attempt when the lowest unfinished image sweep stallshttps://github.com/simstudioai/sim/pull/9433/commits/ec9c9cddb5875102ce8158031e72de5c68b29a7d
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
ec9c9cdhttps://github.com/simstudioai/sim/pull/9433/commits/ec9c9cddb5875102ce8158031e72de5c68b29a7d
https://github.com/simstudioai/sim/tree/ec9c9cddb5875102ce8158031e72de5c68b29a7d
fix(cleanup): collect a forked workspace upload once no file row names ithttps://github.com/simstudioai/sim/pull/9433/commits/972e23522ad16db49416fcb1db13fd9db86ea472
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
972e235https://github.com/simstudioai/sim/pull/9433/commits/972e23522ad16db49416fcb1db13fd9db86ea472
https://github.com/simstudioai/sim/tree/972e23522ad16db49416fcb1db13fd9db86ea472
fix(cleanup): scope a chat's file row by the row's own workspace firsthttps://github.com/simstudioai/sim/pull/9433/commits/b948e2d297ca364ece2332cc1ad362425292308e
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
b948e2dhttps://github.com/simstudioai/sim/pull/9433/commits/b948e2d297ca364ece2332cc1ad362425292308e
https://github.com/simstudioai/sim/tree/b948e2d297ca364ece2332cc1ad362425292308e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.