Title: fix(ci): fail the promote wait on a digest lookup error instead of retrying it by waleedlatif1 · Pull Request #9430 · simstudioai/sim · GitHub
Open Graph Title: fix(ci): fail the promote wait on a digest lookup error instead of retrying it by waleedlatif1 · Pull Request #9430 · simstudioai/sim
X Title: fix(ci): fail the promote wait on a digest lookup error instead of retrying it by waleedlatif1 · Pull Request #9430 · simstudioai/sim
Description: Summary promote-app-image.sh waited for the moved tag with until [ "$(get-ecr-image-digest.sh …)" = "$DIGEST" ]. A failing command substitution inside a test condition doesn't trip set -e, so a real lookup error (an AWS error, or a malformed response) was retried until the 60s deadline and then reported as "did not resolve … within 60s". The lookup now happens in the loop body as an assignment, so a failed lookup stops the script with its own error. A tag that hasn't propagated yet is still retried up to the deadline, and the AWS CLI's own retries still cover transient errors. Raised on the release PR #9426. Type of Change Bug fix Testing Ran the script in a Linux container with stubbed docker/aws: stale read that catches up: changed=true unchanged retag: changed=false tag that never resolves: fails at the deadline first push with no previous tag: changed=true lookup error after the push (new case): fails immediately with exit 1. The previous script swallowed it, retried until the deadline and printed the propagation error. shellcheck, bash -n Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary promote-app-image.sh waited for the moved tag with until [ "$(get-ecr-image-digest.sh …)" = "$DIGEST" ]. A failing command substitution inside a test condition doesn...
X Description: Summary promote-app-image.sh waited for the moved tag with until [ "$(get-ecr-image-digest.sh …)" = "$DIGEST" ]. A failing command substitution inside a test co...
Opengraph URL: https://github.com/simstudioai/sim/pull/9430
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:231420bd-897d-34ce-9e49-f60f97946d4f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8928:218DA9:4E733:74DF9:6AFB09CB |
| html-safe-nonce | 8225ed7c1565a93ea198d59bf6f30239f5579daf4eafc82401ad96360ea7ea98 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTI4OjIxOERBOTo0RTczMzo3NERGOTo2QUZCMDlDQiIsInZpc2l0b3JfaWQiOiI4NjQxMDkwMTA2NzE2NTIyOTU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 65ca54866daa49b0bdded643ec63516baaffc3d9b3d97fb8ee032a783289006b |
| hovercard-subject-tag | pull_request:5060300532 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9430/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary promote-app-image.sh waited for the moved tag with until [ "$(get-ecr-image-digest.sh …)" = "$DIGEST" ]. A failing command substitution inside a test condition doesn... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 76fb13cb43f1834708971f45a9cfcab5df3177a7582086613d7cdc6e98c4bfde |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | afc998826cdd963c8f91a96ae5372809ab5e296b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width