René's URL Explorer Experiment


Title: fix(ci): fail the promote wait on a digest lookup error instead of retrying it by waleedlatif1 · Pull Request #9430 · simstudioai/sim · GitHub

Open Graph Title: fix(ci): fail the promote wait on a digest lookup error instead of retrying it by waleedlatif1 · Pull Request #9430 · simstudioai/sim

X Title: fix(ci): fail the promote wait on a digest lookup error instead of retrying it by waleedlatif1 · Pull Request #9430 · simstudioai/sim

Description: Summary promote-app-image.sh waited for the moved tag with until [ "$(get-ecr-image-digest.sh …)" = "$DIGEST" ]. A failing command substitution inside a test condition doesn't trip set -e, so a real lookup error (an AWS error, or a malformed response) was retried until the 60s deadline and then reported as "did not resolve … within 60s". The lookup now happens in the loop body as an assignment, so a failed lookup stops the script with its own error. A tag that hasn't propagated yet is still retried up to the deadline, and the AWS CLI's own retries still cover transient errors. Raised on the release PR #9426. Type of Change Bug fix Testing Ran the script in a Linux container with stubbed docker/aws: stale read that catches up: changed=true unchanged retag: changed=false tag that never resolves: fails at the deadline first push with no previous tag: changed=true lookup error after the push (new case): fails immediately with exit 1. The previous script swallowed it, retried until the deadline and printed the propagation error. shellcheck, bash -n Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary promote-app-image.sh waited for the moved tag with until [ "$(get-ecr-image-digest.sh …)" = "$DIGEST" ]. A failing command substitution inside a test condition doesn...

X Description: Summary promote-app-image.sh waited for the moved tag with until [ "$(get-ecr-image-digest.sh …)" = "$DIGEST" ]. A failing command substitution inside a test co...

Opengraph URL: https://github.com/simstudioai/sim/pull/9430

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:231420bd-897d-34ce-9e49-f60f97946d4f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8928:218DA9:4E733:74DF9:6AFB09CB
html-safe-nonce8225ed7c1565a93ea198d59bf6f30239f5579daf4eafc82401ad96360ea7ea98
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTI4OjIxOERBOTo0RTczMzo3NERGOTo2QUZCMDlDQiIsInZpc2l0b3JfaWQiOiI4NjQxMDkwMTA2NzE2NTIyOTU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac65ca54866daa49b0bdded643ec63516baaffc3d9b3d97fb8ee032a783289006b
hovercard-subject-tagpull_request:5060300532
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9430/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary promote-app-image.sh waited for the moved tag with until [ "$(get-ecr-image-digest.sh …)" = "$DIGEST" ]. A failing command substitution inside a test condition doesn...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None76fb13cb43f1834708971f45a9cfcab5df3177a7582086613d7cdc6e98c4bfde
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseafc998826cdd963c8f91a96ae5372809ab5e296b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9430/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9430%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9430%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9430/files
Reloadhttps://github.com/simstudioai/sim/pull/9430/files
Reloadhttps://github.com/simstudioai/sim/pull/9430/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/ci-promote-lookup-errors-fatalhttps://github.com/simstudioai/sim/tree/fix/ci-promote-lookup-errors-fatal
Conversation 2 https://github.com/simstudioai/sim/pull/9430
Commits 1 https://github.com/simstudioai/sim/pull/9430/commits
Checks 67 https://github.com/simstudioai/sim/pull/9430/checks
Files changed https://github.com/simstudioai/sim/pull/9430/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9430/files
fix(ci): fail the promote wait on a digest lookup error instead of retrying it https://github.com/simstudioai/sim/pull/9430/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9430/files
0c81d5e fix(ci): fail the promote wait on a digest lookup error instead of re… waleedlatif1 Oct 29, 2026 https://github.com/simstudioai/sim/pull/9430/commits/0c81d5e306ecf93e54b22a52a00d9daa48c7d35c
Clear filters https://github.com/simstudioai/sim/pull/9430/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9430/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9430/files
.github/scripts/promote-app-image.shhttps://github.com/simstudioai/sim/pull/9430/files#diff-88b9bcc9a28e3279ec2bd80b3d7d28d0ce79753a57e3feb46a15d81fb7a68b4e
View file https://github.com/simstudioai/sim/blob/0c81d5e306ecf93e54b22a52a00d9daa48c7d35c/.github/scripts/promote-app-image.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9430/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9430/files#diff-88b9bcc9a28e3279ec2bd80b3d7d28d0ce79753a57e3feb46a15d81fb7a68b4e
https://github.com/simstudioai/sim/pull/9430/files#diff-88b9bcc9a28e3279ec2bd80b3d7d28d0ce79753a57e3feb46a15d81fb7a68b4e
Please reload this pagehttps://github.com/simstudioai/sim/pull/9430/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.