René's URL Explorer Experiment


Title: fix(execution): precheck the default video target and attribute 4xx resume preprocessing refusals to the run by waleedlatif1 · Pull Request #9223 · simstudioai/sim · GitHub

Open Graph Title: fix(execution): precheck the default video target and attribute 4xx resume preprocessing refusals to the run by waleedlatif1 · Pull Request #9223 · simstudioai/sim

X Title: fix(execution): precheck the default video target and attribute 4xx resume preprocessing refusals to the run by waleedlatif1 · Pull Request #9223 · simstudioai/sim

Description: Summary Follow-ups from the v0.9.27 release review, scoped to #9209–#9211: generate_video validates its output target before calling the provider even when no output path is given. The default files/generated-video.mp4 is fixed, so the check is exact; a taken default no longer costs a paid generation that then fails to save. A resume whose preprocessing refuses it with a 4xx (usage limit, rate limit, archived workflow) is attributed to the run, so its one Resume execution failed line logs at info. 5xx refusals and the corrupt paused-run 409s stay internal. Discover route doc comment names the precedent it actually follows (oauth/start answers 422 when an authorization server refuses) and notes v2 keeps its documented 503. Type of Change Bug fix Testing write-target-precheck.integration.ts (real Postgres): new case runs generate_video twice with no output path; the second call is refused without calling the provider or recording a charge. Fails on staging, passes with the fix (7/7). human-in-the-loop-manager.test.ts: drives the real runResumeExecution with 402/404/429/500 preprocessing refusals; the three 4xx cases fail on staging and pass with the fix, 500 stays internal (93/93). model-boundaries.test.ts: resource-writer mock gains the validator, and the abort mock rejects an already-aborted signal the way the real fal queue does (throwIfAborted before submit). Media, image, discover, executor and vfs suites: 326/326. bun run lint, check:test-patterns, check:comment-hygiene. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-ups from the v0.9.27 release review, scoped to #9209–#9211: generate_video validates its output target before calling the provider even when no output path is given. The default fil...

X Description: Summary Follow-ups from the v0.9.27 release review, scoped to #9209–#9211: generate_video validates its output target before calling the provider even when no output path is given. The default fil...

Opengraph URL: https://github.com/simstudioai/sim/pull/9223

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:499c0d92-fa92-165e-5166-d1bfc31b51f9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB78:7C051:1463C85:1C077D6:6AFB7922
html-safe-noncef4df29a6b0eb7b67a36d6254a9179b9ee729f9665490abc682b60d60ecc5e887
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjc4OjdDMDUxOjE0NjNDODU6MUMwNzdENjo2QUZCNzkyMiIsInZpc2l0b3JfaWQiOiI3ODkxNzU5MjIyODUxNTk4NjI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace425a489a2c1c06566726c473df4aa978f43333f1688b99bf3c57f4e22346f9e
hovercard-subject-tagpull_request:4926694780
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9223/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-ups from the v0.9.27 release review, scoped to #9209–#9211: generate_video validates its output target before calling the provider even when no output path is given. The default fil...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9223/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9223%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9223%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9223/files
Reloadhttps://github.com/simstudioai/sim/pull/9223/files
Reloadhttps://github.com/simstudioai/sim/pull/9223/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/v0927-review-followupshttps://github.com/simstudioai/sim/tree/fix/v0927-review-followups
Conversation 10 https://github.com/simstudioai/sim/pull/9223
Commits 2 https://github.com/simstudioai/sim/pull/9223/commits
Checks 52 https://github.com/simstudioai/sim/pull/9223/checks
Files changed https://github.com/simstudioai/sim/pull/9223/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9223/files
fix(execution): precheck the default video target and attribute 4xx resume preprocessing refusals to the run https://github.com/simstudioai/sim/pull/9223/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9223/files
e410fc7 fix(execution): precheck the default video target and attribute 4xx r… waleedlatif1 Oct 19, 2026 https://github.com/simstudioai/sim/pull/9223/commits/e410fc78b09afa07f5ffadef4b01ca7430bc59c8
c2524bb fix(resume): keep retryable preprocessing refusals internal and log a… waleedlatif1 Oct 19, 2026 https://github.com/simstudioai/sim/pull/9223/commits/c2524bb0fa3cb5d5d759a40d1ac73fec768e4cde
Clear filters https://github.com/simstudioai/sim/pull/9223/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9223/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9223/files
route.ts https://github.com/simstudioai/sim/pull/9223/files#diff-996c743d5e8a330e59c381233d961abe818c086daa5c27329e3634a8d46f264b
generate-video.ts https://github.com/simstudioai/sim/pull/9223/files#diff-6b1eba7743f92e8a30c890523faa24ac801e5704df4a11eeca90187b3bdb0afd
model-boundaries.test.ts https://github.com/simstudioai/sim/pull/9223/files#diff-caf0ae31ed7b76089b52cd616aa9e68808c6e195e5099ff7ace57861ad35aae3
write-target-precheck.integration.ts https://github.com/simstudioai/sim/pull/9223/files#diff-e34b3a98a912a2dca661f858e4b48f3903a488bb70913dc98d6cc49d3b16f900
human-in-the-loop-manager.test.ts https://github.com/simstudioai/sim/pull/9223/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
human-in-the-loop-manager.ts https://github.com/simstudioai/sim/pull/9223/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
apps/sim/app/api/mcp/tools/discover/route.tshttps://github.com/simstudioai/sim/pull/9223/files#diff-996c743d5e8a330e59c381233d961abe818c086daa5c27329e3634a8d46f264b
View file https://github.com/simstudioai/sim/blob/c2524bb0fa3cb5d5d759a40d1ac73fec768e4cde/apps/sim/app/api/mcp/tools/discover/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9223/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9223/files#diff-996c743d5e8a330e59c381233d961abe818c086daa5c27329e3634a8d46f264b
https://github.com/simstudioai/sim/pull/9223/files#diff-996c743d5e8a330e59c381233d961abe818c086daa5c27329e3634a8d46f264b
apps/sim/lib/mothership/tools/server/media/generate-video.tshttps://github.com/simstudioai/sim/pull/9223/files#diff-6b1eba7743f92e8a30c890523faa24ac801e5704df4a11eeca90187b3bdb0afd
View file https://github.com/simstudioai/sim/blob/c2524bb0fa3cb5d5d759a40d1ac73fec768e4cde/apps/sim/lib/mothership/tools/server/media/generate-video.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9223/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9223/files#diff-6b1eba7743f92e8a30c890523faa24ac801e5704df4a11eeca90187b3bdb0afd
https://github.com/simstudioai/sim/pull/9223/files#diff-6b1eba7743f92e8a30c890523faa24ac801e5704df4a11eeca90187b3bdb0afd
https://github.com/simstudioai/sim/pull/9223/files#diff-6b1eba7743f92e8a30c890523faa24ac801e5704df4a11eeca90187b3bdb0afd
https://github.com/simstudioai/sim/pull/9223/files#diff-6b1eba7743f92e8a30c890523faa24ac801e5704df4a11eeca90187b3bdb0afd
apps/sim/lib/mothership/tools/server/media/model-boundaries.test.tshttps://github.com/simstudioai/sim/pull/9223/files#diff-caf0ae31ed7b76089b52cd616aa9e68808c6e195e5099ff7ace57861ad35aae3
View file https://github.com/simstudioai/sim/blob/c2524bb0fa3cb5d5d759a40d1ac73fec768e4cde/apps/sim/lib/mothership/tools/server/media/model-boundaries.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9223/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9223/files#diff-caf0ae31ed7b76089b52cd616aa9e68808c6e195e5099ff7ace57861ad35aae3
https://github.com/simstudioai/sim/pull/9223/files#diff-caf0ae31ed7b76089b52cd616aa9e68808c6e195e5099ff7ace57861ad35aae3
https://github.com/simstudioai/sim/pull/9223/files#diff-caf0ae31ed7b76089b52cd616aa9e68808c6e195e5099ff7ace57861ad35aae3
https://github.com/simstudioai/sim/pull/9223/files#diff-caf0ae31ed7b76089b52cd616aa9e68808c6e195e5099ff7ace57861ad35aae3
apps/sim/lib/mothership/tools/server/media/write-target-precheck.integration.tshttps://github.com/simstudioai/sim/pull/9223/files#diff-e34b3a98a912a2dca661f858e4b48f3903a488bb70913dc98d6cc49d3b16f900
View file https://github.com/simstudioai/sim/blob/c2524bb0fa3cb5d5d759a40d1ac73fec768e4cde/apps/sim/lib/mothership/tools/server/media/write-target-precheck.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9223/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9223/files#diff-e34b3a98a912a2dca661f858e4b48f3903a488bb70913dc98d6cc49d3b16f900
apps/sim/lib/workflows/executor/human-in-the-loop-manager.test.tshttps://github.com/simstudioai/sim/pull/9223/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
View file https://github.com/simstudioai/sim/blob/c2524bb0fa3cb5d5d759a40d1ac73fec768e4cde/apps/sim/lib/workflows/executor/human-in-the-loop-manager.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9223/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9223/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/9223/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
apps/sim/lib/workflows/executor/human-in-the-loop-manager.tshttps://github.com/simstudioai/sim/pull/9223/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
View file https://github.com/simstudioai/sim/blob/c2524bb0fa3cb5d5d759a40d1ac73fec768e4cde/apps/sim/lib/workflows/executor/human-in-the-loop-manager.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9223/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9223/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
https://github.com/simstudioai/sim/pull/9223/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
Please reload this pagehttps://github.com/simstudioai/sim/pull/9223/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.