René's URL Explorer Experiment


Title: fix(file): bind copied workspace files to their source by storage key by waleedlatif1 · Pull Request #9209 · simstudioai/sim · GitHub

Open Graph Title: fix(file): bind copied workspace files to their source by storage key by waleedlatif1 · Pull Request #9209 · simstudioai/sim

X Title: fix(file): bind copied workspace files to their source by storage key by waleedlatif1 · Pull Request #9209 · simstudioai/sim

Description: Summary The File operations resolved a selected workspace file's storage key through the VFS reference resolver, which only understands ids, paths, and names. A key never resolved, so a copy (write with fileInput), compress, decompress, or content read of a workspace file passed as a file object lost its source identity. The copy was stored with unknown secret provenance (an ERROR on every such write), and later reads of the copy were refused. Regressed when the operations moved in-process and the key-metadata lookup was replaced by the reference resolver. Adds resolveWorkspaceFileStorageKey to the workspace-file reference application module. It maps the key to its current workspace row, requires the asserted workspace, authorizes that row by id under the caller's operation policy, and returns it only if the row's current key is the key whose bytes are read. Anything else is not_found, which callers already treat as "unbound", so they fail closed. bindSelectedContentFile now gates on the key's storage prefix instead of the optional context field, so a block-reference file that has no context also binds. File picker values were already getting context inferred from the key. manage_sharing had the same bug for picker values ({ name, path, key }) and always failed with "File not found". It now resolves through the same helper under the share policy. Fail-closed cases behave as before: copying another member's file that has recorded secrets stays unknown; a superseded version key and another workspace's key are still refused. Type of Change Bug fix Testing New apps/sim/lib/internal/file/write-copy-provenance.integration.ts (real Postgres plus local storage, run through the real file operation, application authorization, metadata and provenance sidecars): 8/8 pass. Red on pre-fix operations.ts: 5 failures. A clean copy came out unknown instead of exact for block references, block references without a context, and picker values. A copy of the caller's own secret-bearing file was unknown instead of exact with those entries. manage_sharing with a picker key returned 404. Red with only the old context gate restored: the block-reference-without-context case fails. Green on both trees (fail-closed guards): another member's secret-bearing source stays unknown; a superseded version key and a foreign-workspace key are refused (404). Updated the one unit test that mocked the resolver into accepting a raw key. lib/internal/file/, lib/workspace-files/application/, tools/file, lib/execution/payloads, the tool-execution suite, and the suites that use the reference mock all pass (813 tests). bun run lint, check:boundaries, check:comment-hygiene, check:test-patterns, check:explicit-any, check:file-names, check:source-conventions. Full type-check and audits are left to CI. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The File operations resolved a selected workspace file's storage key through the VFS reference resolver, which only understands ids, paths, and names. A key never resolved, so a copy (...

X Description: Summary The File operations resolved a selected workspace file's storage key through the VFS reference resolver, which only understands ids, paths, and names. A key never resolved, so a co...

Opengraph URL: https://github.com/simstudioai/sim/pull/9209

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1cbe827b-5be6-8740-1d98-62b741556d3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEB0:29C55F:15BA11F:1DA0F60:6AFB7A02
html-safe-noncec5873adb6568dd666b1b9cc7ce7342eab1c6dd82f03ccda11564e35e7446635b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUIwOjI5QzU1RjoxNUJBMTFGOjFEQTBGNjA6NkFGQjdBMDIiLCJ2aXNpdG9yX2lkIjoiMjg1NzU3MDE0MTg3MDk3OTU4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca41db07ccd09aaf238718594689c79ff4c95be6f1b4f5cdb9e4a40fa65476273
hovercard-subject-tagpull_request:4913669953
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9209/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The File operations resolved a selected workspace file's storage key through the VFS reference resolver, which only understands ids, paths, and names. A key never resolved, so a copy (...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9209/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9209%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9209%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9209/files
Reloadhttps://github.com/simstudioai/sim/pull/9209/files
Reloadhttps://github.com/simstudioai/sim/pull/9209/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/file-copy-secret-provenancehttps://github.com/simstudioai/sim/tree/fix/file-copy-secret-provenance
Conversation 2 https://github.com/simstudioai/sim/pull/9209
Commits 1 https://github.com/simstudioai/sim/pull/9209/commits
Checks 52 https://github.com/simstudioai/sim/pull/9209/checks
Files changed https://github.com/simstudioai/sim/pull/9209/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9209/files
fix(file): bind copied workspace files to their source by storage key https://github.com/simstudioai/sim/pull/9209/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9209/files
97e7a59 fix(file): bind copied workspace files to their source by storage key waleedlatif1 Oct 18, 2026 https://github.com/simstudioai/sim/pull/9209/commits/97e7a593bed63ed3c280958d24e25b1f20ea0ba0
Clear filters https://github.com/simstudioai/sim/pull/9209/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9209/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9209/files
operations.test.ts https://github.com/simstudioai/sim/pull/9209/files#diff-5b618a3954aee1f8dad948808cf9107f1f42b6a08bcc904adb65d83c19cce192
operations.ts https://github.com/simstudioai/sim/pull/9209/files#diff-8e5b9606c97b1fe1307e2813b58c25851c7ada477f5a6b8805c5f456b11b5138
write-copy-provenance.integration.ts https://github.com/simstudioai/sim/pull/9209/files#diff-83741ce981fcd9e4eae121dc5ded6e8385b2ed86ad4be3800310f0cfbb662f12
resolve-workspace-file-reference.ts https://github.com/simstudioai/sim/pull/9209/files#diff-2bd3b3035a38ca30588d12469ada46bc010039c4d83719a4103ffe55db68b4df
workspace-file-reference.mock.ts https://github.com/simstudioai/sim/pull/9209/files#diff-e24c62dbd787b635e4fe065259aa68699753880a94608a3983f2ccd2f9545d59
apps/sim/lib/internal/file/operations.test.tshttps://github.com/simstudioai/sim/pull/9209/files#diff-5b618a3954aee1f8dad948808cf9107f1f42b6a08bcc904adb65d83c19cce192
View file https://github.com/simstudioai/sim/blob/97e7a593bed63ed3c280958d24e25b1f20ea0ba0/apps/sim/lib/internal/file/operations.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9209/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9209/files#diff-5b618a3954aee1f8dad948808cf9107f1f42b6a08bcc904adb65d83c19cce192
https://github.com/simstudioai/sim/pull/9209/files#diff-5b618a3954aee1f8dad948808cf9107f1f42b6a08bcc904adb65d83c19cce192
apps/sim/lib/internal/file/operations.tshttps://github.com/simstudioai/sim/pull/9209/files#diff-8e5b9606c97b1fe1307e2813b58c25851c7ada477f5a6b8805c5f456b11b5138
View file https://github.com/simstudioai/sim/blob/97e7a593bed63ed3c280958d24e25b1f20ea0ba0/apps/sim/lib/internal/file/operations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9209/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9209/files#diff-8e5b9606c97b1fe1307e2813b58c25851c7ada477f5a6b8805c5f456b11b5138
https://github.com/simstudioai/sim/pull/9209/files#diff-8e5b9606c97b1fe1307e2813b58c25851c7ada477f5a6b8805c5f456b11b5138
https://github.com/simstudioai/sim/pull/9209/files#diff-8e5b9606c97b1fe1307e2813b58c25851c7ada477f5a6b8805c5f456b11b5138
https://github.com/simstudioai/sim/pull/9209/files#diff-8e5b9606c97b1fe1307e2813b58c25851c7ada477f5a6b8805c5f456b11b5138
https://github.com/simstudioai/sim/pull/9209/files#diff-8e5b9606c97b1fe1307e2813b58c25851c7ada477f5a6b8805c5f456b11b5138
https://github.com/simstudioai/sim/pull/9209/files#diff-8e5b9606c97b1fe1307e2813b58c25851c7ada477f5a6b8805c5f456b11b5138
apps/sim/lib/internal/file/write-copy-provenance.integration.tshttps://github.com/simstudioai/sim/pull/9209/files#diff-83741ce981fcd9e4eae121dc5ded6e8385b2ed86ad4be3800310f0cfbb662f12
View file https://github.com/simstudioai/sim/blob/97e7a593bed63ed3c280958d24e25b1f20ea0ba0/apps/sim/lib/internal/file/write-copy-provenance.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9209/{{ revealButtonHref }}
apps/sim/lib/workspace-files/application/resolve-workspace-file-reference.tshttps://github.com/simstudioai/sim/pull/9209/files#diff-2bd3b3035a38ca30588d12469ada46bc010039c4d83719a4103ffe55db68b4df
View file https://github.com/simstudioai/sim/blob/97e7a593bed63ed3c280958d24e25b1f20ea0ba0/apps/sim/lib/workspace-files/application/resolve-workspace-file-reference.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9209/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9209/files#diff-2bd3b3035a38ca30588d12469ada46bc010039c4d83719a4103ffe55db68b4df
https://github.com/simstudioai/sim/pull/9209/files#diff-2bd3b3035a38ca30588d12469ada46bc010039c4d83719a4103ffe55db68b4df
https://github.com/simstudioai/sim/pull/9209/files#diff-2bd3b3035a38ca30588d12469ada46bc010039c4d83719a4103ffe55db68b4df
packages/testing/src/mocks/workspace-file-reference.mock.tshttps://github.com/simstudioai/sim/pull/9209/files#diff-e24c62dbd787b635e4fe065259aa68699753880a94608a3983f2ccd2f9545d59
View file https://github.com/simstudioai/sim/blob/97e7a593bed63ed3c280958d24e25b1f20ea0ba0/packages/testing/src/mocks/workspace-file-reference.mock.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9209/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9209/files#diff-e24c62dbd787b635e4fe065259aa68699753880a94608a3983f2ccd2f9545d59
https://github.com/simstudioai/sim/pull/9209/files#diff-e24c62dbd787b635e4fe065259aa68699753880a94608a3983f2ccd2f9545d59
Please reload this pagehttps://github.com/simstudioai/sim/pull/9209/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.