René's URL Explorer Experiment


Title: improvement(db): name chat uploads in one indexed read and index workspace payer lookups by waleedlatif1 · Pull Request #9208 · simstudioai/sim · GitHub

Open Graph Title: improvement(db): name chat uploads in one indexed read and index workspace payer lookups by waleedlatif1 · Pull Request #9208 · simstudioai/sim

X Title: improvement(db): name chat uploads in one indexed read and index workspace payer lookups by waleedlatif1 · Pull Request #9208 · simstudioai/sim

Description: Summary trackChatUpload probed display names by writing: each candidate (image.png, image (2).png, …) was its own transaction + project lock + UPDATE/INSERT, and a taken name surfaced as a 23505 on workspace_files_chat_display_name_unique. A message with N same-named attachments cost 1+2+…+N writes (20 attachments → 210 writes, ~60ms per failed attempt, multi-second chat POSTs) Now one read per attachment, inside the same transaction after the project lock, collects the chat's taken names (exact name or (%), LIKE-escaped with escapeLikePattern) using the unique index's own predicate (context = 'mothership', chat set, soft-deleted rows included), excludes the row being re-linked, and writes the first free suffixedName. The 23505 retry stays for races, and a lost candidate is never retried Same naming as before: the lowest free slot, soft-deleted siblings keep their slot, and re-linking a row to its own chat keeps its current name. withCopySuffix now shares its stem/extension split with the LIKE pattern so the two cannot drift Add workspace_billed_account_user_id_idx (plain btree, CREATE INDEX CONCURRENTLY with the 0429 invalid-index recovery). workspace.billed_account_user_id had no index, so the GET /api/billing upgrade-target lookup and account deletion seq-scanned workspace, and so did the user FK's (no action) delete check. A plain index serves all of these: the equality lookup, the owner_id OR billed_account_user_id deletion queries (BitmapOr with workspace_owner_id_idx), and the FK check. A user has few workspaces, so a composite or partial index buys nothing Type of Change Improvement (performance) Testing file-names.integration.ts (real Postgres), new cases: 20 same-named attachments (10 re-links + 10 inserts) in one chat, a re-link that keeps its name while a soft-deleted sibling holds image.png, and names with %, _, \, parentheses, no extension, a leading dot, and multiple dots. A trigger counts every display-name write through a sequence, which a rollback does not undo Red on pre-fix code: 210 writes for 20 attachments (expected 20); 2 writes for an idempotent re-link (expected 1); 6 writes for 3 uploads of each special name (expected 3). Names were already correct before the fix Each guard reverted on its own: dropping the LIKE escaping fails the backslash case (4 writes); dropping the re-linked-row exclusion moves the row to image (3).png Green: 26/26, under both push and INTEGRATION_DB_PROVISION=migrate (applies 0435) Plain EXPLAIN of the taken-names read: Index Scan using workspace_files_chat_display_name_unique, Index Cond on chat_id. Payer lookup before the index: Seq Scan on workspace track-chat-upload.test.ts, file-manager.test.ts; bun run lint; check:test-patterns; check:comment-hygiene; check:migrations origin/staging; drizzle-kit generate reports no changes Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary trackChatUpload probed display names by writing: each candidate (image.png, image (2).png, …) was its own transaction + project lock + UPDATE/INSERT, and a taken name surfaced as a 23505 o...

X Description: Summary trackChatUpload probed display names by writing: each candidate (image.png, image (2).png, …) was its own transaction + project lock + UPDATE/INSERT, and a taken name surfaced as a 23505 o...

Opengraph URL: https://github.com/simstudioai/sim/pull/9208

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4b8e43aa-34c8-4388-b43e-18d3f83bd1ff
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84EC:24E4B4:15013B6:1CAF327:6AFB78E6
html-safe-nonce78204082cd20104709f6419fb073e95ca62e5a34c325af36470f81db195c7bd1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEVDOjI0RTRCNDoxNTAxM0I2OjFDQUYzMjc6NkFGQjc4RTYiLCJ2aXNpdG9yX2lkIjoiMjU2ODQ3NTIwMTY4NzQ4NDY0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac74f0f70ff703470db06f8e3642839dbbf9255bf73a6ba4c4b7fffb10c4c4ea69
hovercard-subject-tagpull_request:4913656466
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9208/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary trackChatUpload probed display names by writing: each candidate (image.png, image (2).png, …) was its own transaction + project lock + UPDATE/INSERT, and a taken name surfaced as a 23505 o...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9208/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9208%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9208%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9208/files
Reloadhttps://github.com/simstudioai/sim/pull/9208/files
Reloadhttps://github.com/simstudioai/sim/pull/9208/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests201 (201)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
improvement/chat-upload-names-billing-indexhttps://github.com/simstudioai/sim/tree/improvement/chat-upload-names-billing-index
Conversation 2 https://github.com/simstudioai/sim/pull/9208
Commits 2 https://github.com/simstudioai/sim/pull/9208/commits
Checks 50 https://github.com/simstudioai/sim/pull/9208/checks
Files changed https://github.com/simstudioai/sim/pull/9208/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9208/files
improvement(db): name chat uploads in one indexed read and index workspace payer lookups https://github.com/simstudioai/sim/pull/9208/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9208/files
1f7e3e0 improvement(db): name chat uploads in one indexed read and index work… waleedlatif1 Oct 18, 2026 https://github.com/simstudioai/sim/pull/9208/commits/1f7e3e0f0e29446a0161844f24c1a373e18b237c
4cb3932 fix(db): type the unlinked upload keys in the chat naming test waleedlatif1 Oct 18, 2026 https://github.com/simstudioai/sim/pull/9208/commits/4cb393244ffea76e6fe7a0c6c0afc7741d246749
Clear filters https://github.com/simstudioai/sim/pull/9208/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9208/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9208/files
file-names.integration.ts https://github.com/simstudioai/sim/pull/9208/files#diff-c16eddc45d1cff843259132f8f8d783931fb6f8b9c010b962fec060040c05e8c
file-manager.ts https://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
0435_workspace_billed_account_user_index.sql https://github.com/simstudioai/sim/pull/9208/files#diff-63da40e6e70c4b5af58a21647aa95836e2ad890e574e067cbb438c7cd8897f27
0435_snapshot.json https://github.com/simstudioai/sim/pull/9208/files#diff-9aec6e5b7100b2bc652b253b3c4d9e45d5e0359231a143ab402b487aa74bb612
_journal.json https://github.com/simstudioai/sim/pull/9208/files#diff-37150cc65ad16ee6fbc5fa318fc096be7730e16d63eaf863e3df5521b7030649
schema.ts https://github.com/simstudioai/sim/pull/9208/files#diff-9a959e2ce3cb4c86957bbae021d06eae364f7b0cb18964f5873bab53220af928
apps/sim/lib/uploads/contexts/workspace/__integration__/file-names.integration.tshttps://github.com/simstudioai/sim/pull/9208/files#diff-c16eddc45d1cff843259132f8f8d783931fb6f8b9c010b962fec060040c05e8c
View file https://github.com/simstudioai/sim/blob/4cb393244ffea76e6fe7a0c6c0afc7741d246749/apps/sim/lib/uploads/contexts/workspace/__integration__/file-names.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9208/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9208/files#diff-c16eddc45d1cff843259132f8f8d783931fb6f8b9c010b962fec060040c05e8c
apps/sim/lib/uploads/contexts/workspace/file-manager.tshttps://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
View file https://github.com/simstudioai/sim/blob/4cb393244ffea76e6fe7a0c6c0afc7741d246749/apps/sim/lib/uploads/contexts/workspace/file-manager.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9208/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
https://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
https://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
https://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
https://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
https://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
https://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
https://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
https://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
https://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
https://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
https://github.com/simstudioai/sim/pull/9208/files#diff-8a5fe21cb59e40994be235c3a799fe7cf265576f7480174d6df727af5a7bf644
packages/db/migrations/0435_workspace_billed_account_user_index.sqlhttps://github.com/simstudioai/sim/pull/9208/files#diff-63da40e6e70c4b5af58a21647aa95836e2ad890e574e067cbb438c7cd8897f27
View file https://github.com/simstudioai/sim/blob/4cb393244ffea76e6fe7a0c6c0afc7741d246749/packages/db/migrations/0435_workspace_billed_account_user_index.sql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9208/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/9208/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9208/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.