René's URL Explorer Experiment


Title: fix(memory): read memory records and their provenance in one statement by waleedlatif1 · Pull Request #9202 · simstudioai/sim · GitHub

Open Graph Title: fix(memory): read memory records and their provenance in one statement by waleedlatif1 · Pull Request #9202 · simstudioai/sim

X Title: fix(memory): read memory records and their provenance in one statement by waleedlatif1 · Pull Request #9202 · simstudioai/sim

Description: Summary Memory list, read, and the append readback read each record and then its provenance sidecar in a separate query. An append committing between the two paired the old record with the new sidecar's hash, so the read came back as unknown provenance and the whole tool result was withheld (e.g. memory get all from an Agent block while another run writes memory) Read the record and its sidecar in one LEFT JOIN statement, the way the prefix reader already did, and drop the second query Share one MEMORY_SECRET_PROVENANCE_COLUMNS set (named to match readBoundMemorySecretProvenance) across the list/read reader, the prefix reader and the Agent memory handler, removing the hand-written field mapping Billing scope still resolves before any provenance is classified; no policy, schema, or limit changes Type of Change Bug fix Testing New integration cases commit an append between the reads for list, read, and append readback: all three return unknown on the old reader and exact on this one Memory integration suites, full app unit suite, type-check, lint, and audits pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Memory list, read, and the append readback read each record and then its provenance sidecar in a separate query. An append committing between the two paired the old record with the new sid...

X Description: Summary Memory list, read, and the append readback read each record and then its provenance sidecar in a separate query. An append committing between the two paired the old record with the new sid...

Opengraph URL: https://github.com/simstudioai/sim/pull/9202

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a232807f-69e0-b4ef-1e4a-bc4df15e9b66
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1EA:375283:AC5124:F1FAA7:6AFB79B9
html-safe-nonce273cc6622edaa11747e7f6b03515e5689f2a528aab4f3ebb10b51fc8965df7f8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUVBOjM3NTI4MzpBQzUxMjQ6RjFGQUE3OjZBRkI3OUI5IiwidmlzaXRvcl9pZCI6IjgzMjE1MjAzNjM1MjMyNDI0MjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9910f510fce6e57d3311c383093230e5447183fca422544ace58d2337aded44c
hovercard-subject-tagpull_request:4913133104
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9202/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Memory list, read, and the append readback read each record and then its provenance sidecar in a separate query. An append committing between the two paired the old record with the new sid...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9202/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9202%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9202%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9202/files
Reloadhttps://github.com/simstudioai/sim/pull/9202/files
Reloadhttps://github.com/simstudioai/sim/pull/9202/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/memory-read-provenance-snapshothttps://github.com/simstudioai/sim/tree/fix/memory-read-provenance-snapshot
Conversation 10 https://github.com/simstudioai/sim/pull/9202
Commits 2 https://github.com/simstudioai/sim/pull/9202/commits
Checks 52 https://github.com/simstudioai/sim/pull/9202/checks
Files changed https://github.com/simstudioai/sim/pull/9202/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9202/files
fix(memory): read memory records and their provenance in one statement https://github.com/simstudioai/sim/pull/9202/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9202/files
8f7f8f2 fix(memory): read memory records and their provenance in one statement waleedlatif1 Oct 18, 2026 https://github.com/simstudioai/sim/pull/9202/commits/8f7f8f2c35eae5457d293b739c3b2a8adbde9491
075c4b6 fix(memory): stop cancelled memory reads before tails and provenance waleedlatif1 Oct 18, 2026 https://github.com/simstudioai/sim/pull/9202/commits/075c4b603329caaa6611db4a89727d5bba965ff5
Clear filters https://github.com/simstudioai/sim/pull/9202/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9202/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9202/files
memory.ts https://github.com/simstudioai/sim/pull/9202/files#diff-23c712c43b14d7af7642ab86a5286dfa4eb5a332a0c96c1bcae71f2e22ea1069
memory.use-cases.test.ts https://github.com/simstudioai/sim/pull/9202/files#diff-7b3561003d8b842e8f1921371e7fa490bbddddcdfb5110c44c3c4dcae47cc36a
use-cases.test.ts https://github.com/simstudioai/sim/pull/9202/files#diff-a5f108de9e93e86cde1236ed9866ba30dfc1a358585c4d1c7940d21cbd6ffcb9
use-cases.ts https://github.com/simstudioai/sim/pull/9202/files#diff-3634eebac370d592a12eeec19f9e9a5095389a7459447a2766cb43583b01416e
conversation-store.ts https://github.com/simstudioai/sim/pull/9202/files#diff-a0596ef19f17ffb575f820c6311122b278c4bff1ecea24ff0991230661067025
message-provenance.integration.ts https://github.com/simstudioai/sim/pull/9202/files#diff-9885508c3443db6c804c1e17facdc36537f1d3a36b8a433cdcd1eb64836f1f89
message-provenance.test.ts https://github.com/simstudioai/sim/pull/9202/files#diff-6baa14a90e12382fa22f911beb79c8e0e129804281a01da79d9a0d297dda9566
secret-provenance.ts https://github.com/simstudioai/sim/pull/9202/files#diff-40d0e3ce3fa5b3389ec03583bd8be743328c44d091ceb19c149b7e9876574173
apps/sim/executor/handlers/agent/memory.tshttps://github.com/simstudioai/sim/pull/9202/files#diff-23c712c43b14d7af7642ab86a5286dfa4eb5a332a0c96c1bcae71f2e22ea1069
View file https://github.com/simstudioai/sim/blob/075c4b603329caaa6611db4a89727d5bba965ff5/apps/sim/executor/handlers/agent/memory.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9202/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9202/files#diff-23c712c43b14d7af7642ab86a5286dfa4eb5a332a0c96c1bcae71f2e22ea1069
https://github.com/simstudioai/sim/pull/9202/files#diff-23c712c43b14d7af7642ab86a5286dfa4eb5a332a0c96c1bcae71f2e22ea1069
https://github.com/simstudioai/sim/pull/9202/files#diff-23c712c43b14d7af7642ab86a5286dfa4eb5a332a0c96c1bcae71f2e22ea1069
https://github.com/simstudioai/sim/pull/9202/files#diff-23c712c43b14d7af7642ab86a5286dfa4eb5a332a0c96c1bcae71f2e22ea1069
https://github.com/simstudioai/sim/pull/9202/files#diff-23c712c43b14d7af7642ab86a5286dfa4eb5a332a0c96c1bcae71f2e22ea1069
apps/sim/executor/handlers/agent/memory.use-cases.test.tshttps://github.com/simstudioai/sim/pull/9202/files#diff-7b3561003d8b842e8f1921371e7fa490bbddddcdfb5110c44c3c4dcae47cc36a
View file https://github.com/simstudioai/sim/blob/075c4b603329caaa6611db4a89727d5bba965ff5/apps/sim/executor/handlers/agent/memory.use-cases.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9202/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9202/files#diff-7b3561003d8b842e8f1921371e7fa490bbddddcdfb5110c44c3c4dcae47cc36a
https://github.com/simstudioai/sim/pull/9202/files#diff-7b3561003d8b842e8f1921371e7fa490bbddddcdfb5110c44c3c4dcae47cc36a
https://github.com/simstudioai/sim/pull/9202/files#diff-7b3561003d8b842e8f1921371e7fa490bbddddcdfb5110c44c3c4dcae47cc36a
apps/sim/lib/memory/application/use-cases.test.tshttps://github.com/simstudioai/sim/pull/9202/files#diff-a5f108de9e93e86cde1236ed9866ba30dfc1a358585c4d1c7940d21cbd6ffcb9
View file https://github.com/simstudioai/sim/blob/075c4b603329caaa6611db4a89727d5bba965ff5/apps/sim/lib/memory/application/use-cases.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9202/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9202/files#diff-a5f108de9e93e86cde1236ed9866ba30dfc1a358585c4d1c7940d21cbd6ffcb9
https://github.com/simstudioai/sim/pull/9202/files#diff-a5f108de9e93e86cde1236ed9866ba30dfc1a358585c4d1c7940d21cbd6ffcb9
https://github.com/simstudioai/sim/pull/9202/files#diff-a5f108de9e93e86cde1236ed9866ba30dfc1a358585c4d1c7940d21cbd6ffcb9
https://github.com/simstudioai/sim/pull/9202/files#diff-a5f108de9e93e86cde1236ed9866ba30dfc1a358585c4d1c7940d21cbd6ffcb9
apps/sim/lib/memory/application/use-cases.tshttps://github.com/simstudioai/sim/pull/9202/files#diff-3634eebac370d592a12eeec19f9e9a5095389a7459447a2766cb43583b01416e
View file https://github.com/simstudioai/sim/blob/075c4b603329caaa6611db4a89727d5bba965ff5/apps/sim/lib/memory/application/use-cases.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9202/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9202/files#diff-3634eebac370d592a12eeec19f9e9a5095389a7459447a2766cb43583b01416e
https://github.com/simstudioai/sim/pull/9202/files#diff-3634eebac370d592a12eeec19f9e9a5095389a7459447a2766cb43583b01416e
https://github.com/simstudioai/sim/pull/9202/files#diff-3634eebac370d592a12eeec19f9e9a5095389a7459447a2766cb43583b01416e
Please reload this pagehttps://github.com/simstudioai/sim/pull/9202/files
https://github.com/simstudioai/sim/pull/9202/files#diff-3634eebac370d592a12eeec19f9e9a5095389a7459447a2766cb43583b01416e
https://github.com/simstudioai/sim/pull/9202/files#diff-3634eebac370d592a12eeec19f9e9a5095389a7459447a2766cb43583b01416e
Please reload this pagehttps://github.com/simstudioai/sim/pull/9202/files
https://github.com/simstudioai/sim/pull/9202/files#diff-3634eebac370d592a12eeec19f9e9a5095389a7459447a2766cb43583b01416e
https://github.com/simstudioai/sim/pull/9202/files#diff-3634eebac370d592a12eeec19f9e9a5095389a7459447a2766cb43583b01416e
https://github.com/simstudioai/sim/pull/9202/files#diff-3634eebac370d592a12eeec19f9e9a5095389a7459447a2766cb43583b01416e
https://github.com/simstudioai/sim/pull/9202/files#diff-3634eebac370d592a12eeec19f9e9a5095389a7459447a2766cb43583b01416e
https://github.com/simstudioai/sim/pull/9202/files#diff-3634eebac370d592a12eeec19f9e9a5095389a7459447a2766cb43583b01416e
apps/sim/lib/memory/conversation-store.tshttps://github.com/simstudioai/sim/pull/9202/files#diff-a0596ef19f17ffb575f820c6311122b278c4bff1ecea24ff0991230661067025
View file https://github.com/simstudioai/sim/blob/075c4b603329caaa6611db4a89727d5bba965ff5/apps/sim/lib/memory/conversation-store.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9202/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9202/files#diff-a0596ef19f17ffb575f820c6311122b278c4bff1ecea24ff0991230661067025
https://github.com/simstudioai/sim/pull/9202/files#diff-a0596ef19f17ffb575f820c6311122b278c4bff1ecea24ff0991230661067025
https://github.com/simstudioai/sim/pull/9202/files#diff-a0596ef19f17ffb575f820c6311122b278c4bff1ecea24ff0991230661067025
https://github.com/simstudioai/sim/pull/9202/files#diff-a0596ef19f17ffb575f820c6311122b278c4bff1ecea24ff0991230661067025
Please reload this pagehttps://github.com/simstudioai/sim/pull/9202/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9202/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.