René's URL Explorer Experiment


Title: fix(custom-tools): skip title conflicts when persisting inline tools from a workflow save by waleedlatif1 · Pull Request #9198 · simstudioai/sim · GitHub

Open Graph Title: fix(custom-tools): skip title conflicts when persisting inline tools from a workflow save by waleedlatif1 · Pull Request #9198 · simstudioai/sim

X Title: fix(custom-tools): skip title conflicts when persisting inline tools from a workflow save by waleedlatif1 · Pull Request #9198 · simstudioai/sim

Description: Summary Inline custom tools on an agent block (imported graphs, legacy format) carry no toolId. The first save inserts a workspace row under a generated id that is never written back to the block, so every later save of the same workflow re-offers the tool with no id, hits the workspace title-uniqueness guard on the row that same flow created, and throws. upsertCustomTools runs the batch in one transaction, so every other tool in that save is rolled back too, and the save logs "Some custom tools failed to persist". Split the batch write in operations.ts into a shared loop with a title-conflict policy. upsertCustomTools keeps its signature and runs it with 'error'. The new upsertCustomToolsSkippingTakenTitles runs it with 'skip': the insert uses ON CONFLICT (workspace_id, title) DO NOTHING, so a title that already exists (including one a concurrent save just committed) is left untouched and the rest of the batch persists. It returns the skipped titles. persistCustomToolsToDatabase (the post-commit step of the shared workflow state replace and of workflow import) now calls the skipping variant, and saved counts only the tools actually written. Why skip instead of adopting a same-titled row: adopting is only safe when the row is provably the same tool, and then writing it again changes nothing but updatedAt. When it is not the same tool, it is an unrelated library tool that must not be overwritten. Both cases come down to leaving the row alone, so skip is the smaller change. The block still runs from its inline definition either way. Behaviour that stays the same: the explicit create/update paths (POST /api/tools/custom, the v2 create use case) still call upsertCustomTools, so a duplicate title still throws and the whole batch rolls back (500 on the internal route, 409 on v2, as before). Id-resolved updates and legacy-tool updates are untouched. The only persistence change is that a conflicting title no longer fails the batch. Type of Change Bug fix Testing New custom-tools-persistence.integration.ts against real Postgres: saving the same graph twice (inline tool without toolId) returns no errors on the second save, persists the new tool next to it, and reports only that tool as saved; two concurrent saves of the same new tool both succeed and leave one row; an existing workspace tool with the same title keeps its code; upsertCustomTools without the option still rejects a duplicate title and rolls back the rest of its batch. The first two cases fail on the pre-fix code (the second save returns the title error and the new tool is never written). Existing unit suites for persistence, operations, and the custom-tool use cases pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Inline custom tools on an agent block (imported graphs, legacy format) carry no toolId. The first save inserts a workspace row under a generated id that is never written back to the block,...

X Description: Summary Inline custom tools on an agent block (imported graphs, legacy format) carry no toolId. The first save inserts a workspace row under a generated id that is never written back to the block,...

Opengraph URL: https://github.com/simstudioai/sim/pull/9198

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:14b827b3-4353-8895-90c6-8faaf27138fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7DE:1ACD9:1AF803:25F727:6AFB793D
html-safe-noncec9ba470c49609b902a5b53d07944eb166c8f1b8412515fff7cb6dfba3e676334
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0RFOjFBQ0Q5OjFBRjgwMzoyNUY3Mjc6NkFGQjc5M0QiLCJ2aXNpdG9yX2lkIjoiMTk2MzEwNDU0MjQ1MjI2ODEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc070507a565c714efc23464144d8b0db5729c8ec93891ee8864dcda4b79fa9dd
hovercard-subject-tagpull_request:4912806277
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9198/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Inline custom tools on an agent block (imported graphs, legacy format) carry no toolId. The first save inserts a workspace row under a generated id that is never written back to the block,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneef32892d4269fb87b55e81cc4ba8d86e0f16aa28446ffbf46cba8be5179ab188
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebc3703b4dcbe820d1284ef63c88b001c850be25e
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9198/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9198%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9198%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9198/files
Reloadhttps://github.com/simstudioai/sim/pull/9198/files
Reloadhttps://github.com/simstudioai/sim/pull/9198/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/custom-tools-persist-title-conflicthttps://github.com/simstudioai/sim/tree/fix/custom-tools-persist-title-conflict
Conversation 12 https://github.com/simstudioai/sim/pull/9198
Commits 2 https://github.com/simstudioai/sim/pull/9198/commits
Checks 53 https://github.com/simstudioai/sim/pull/9198/checks
Files changed https://github.com/simstudioai/sim/pull/9198/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9198/files
fix(custom-tools): skip title conflicts when persisting inline tools from a workflow save https://github.com/simstudioai/sim/pull/9198/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9198/files
ab9e2ae fix(custom-tools): skip title conflicts when persisting inline tools … waleedlatif1 Oct 18, 2026 https://github.com/simstudioai/sim/pull/9198/commits/ab9e2ae10056b3ccaa64945f53d6b9422edd9beb
727af41 fix(custom-tools): count skipped titles and skip title conflicts atom… waleedlatif1 Oct 18, 2026 https://github.com/simstudioai/sim/pull/9198/commits/727af4163a67ea7a705ff3ef38b0e3489f5789e6
Clear filters https://github.com/simstudioai/sim/pull/9198/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9198/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9198/files
operations.ts https://github.com/simstudioai/sim/pull/9198/files#diff-1f13cef52843e5e065c4b85b60c2a0ca1260cf5d14827ed276467ac8a02f3804
custom-tools-persistence.integration.ts https://github.com/simstudioai/sim/pull/9198/files#diff-66ceededc4cade31487a10f5846d2c15831eced8c5c02592fdeebee20e73275f
custom-tools-persistence.test.ts https://github.com/simstudioai/sim/pull/9198/files#diff-7cb72940a3a66af00f786286fbec27c93c1aff840a76d6eea133437ebbc38fd0
custom-tools-persistence.ts https://github.com/simstudioai/sim/pull/9198/files#diff-4bf4729a474233ac2d2d2bad3125293bb5c110ab28eadd34ec27b2f473fd857a
apps/sim/lib/workflows/custom-tools/operations.tshttps://github.com/simstudioai/sim/pull/9198/files#diff-1f13cef52843e5e065c4b85b60c2a0ca1260cf5d14827ed276467ac8a02f3804
View file https://github.com/simstudioai/sim/blob/727af4163a67ea7a705ff3ef38b0e3489f5789e6/apps/sim/lib/workflows/custom-tools/operations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9198/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9198/files#diff-1f13cef52843e5e065c4b85b60c2a0ca1260cf5d14827ed276467ac8a02f3804
https://github.com/simstudioai/sim/pull/9198/files#diff-1f13cef52843e5e065c4b85b60c2a0ca1260cf5d14827ed276467ac8a02f3804
https://github.com/simstudioai/sim/pull/9198/files#diff-1f13cef52843e5e065c4b85b60c2a0ca1260cf5d14827ed276467ac8a02f3804
Please reload this pagehttps://github.com/simstudioai/sim/pull/9198/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9198/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.