René's URL Explorer Experiment


Title: fix(streaming): stop writing workflow stream frames after the client cancels by waleedlatif1 · Pull Request #9197 · simstudioai/sim · GitHub

Open Graph Title: fix(streaming): stop writing workflow stream frames after the client cancels by waleedlatif1 · Pull Request #9197 · simstudioai/sim

X Title: fix(streaming): stop writing workflow stream frames after the client cancels by waleedlatif1 · Pull Request #9197 · simstudioai/sim

Description: Summary After a client disconnects, the ReadableStream's cancel() closes the controller, but start() kept enqueueing frames: the "Client cancelled request" error, final, [DONE], chunk/thinking/tool frames, and selected-output frames from onBlockComplete Each of those enqueues threw Invalid state: Controller is already closed. The terminal path logged a spurious "Stream error" (the catch's own enqueue then threw out of start()), and the block-completion path logged "Failed to materialize selected output" and rejected the executor callback. It also finished selected-output materialization and base64 hydration for a client that was already gone cancel() now sets a streamCancelled flag first. Every enqueue in start() goes through one helper that does nothing once the stream is cancelled, controller.close() is skipped after cancel, and onBlockComplete returns early (and stops between descriptors) before any materialization work Everything else cancel() does is unchanged: abort propagation, keepalive stop, base64 cache cleanup, and marking the logging session failed with "Client cancelled request". A client that stays connected gets byte-identical output Type of Change Bug fix Testing New regression test in streaming.test.ts: cancel the reader mid-execution, run the captured onBlockComplete with a selected output, then resolve the execution as cancelled. It asserts the callback resolves and no "Stream error" is logged Red on the pre-fix code: the callback rejects with Controller is already closed. With only that assertion relaxed, the "Stream error" assertion fails on its own streaming.test.ts: 32/32 passing. check:comment-hygiene and check:test-patterns clean Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary After a client disconnects, the ReadableStream's cancel() closes the controller, but start() kept enqueueing frames: the "Client cancelled request" error, final, [DONE], chun...

X Description: Summary After a client disconnects, the ReadableStream's cancel() closes the controller, but start() kept enqueueing frames: the "Client cancelled request" error, final, ...

Opengraph URL: https://github.com/simstudioai/sim/pull/9197

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a442781a-257b-998d-564e-8bfba3d576b7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C68:2441EC:19C093:23EAC5:6AFB792A
html-safe-nonce9f7363cd21527c82860536e78613543b9375bfa424c145bf3605732b2a5309d6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzY4OjI0NDFFQzoxOUMwOTM6MjNFQUM1OjZBRkI3OTJBIiwidmlzaXRvcl9pZCI6IjEwMDAwNzYxOTE3MDYzNDc4MTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5a9092ff683a1c36e54ec57e5f34cb201738bcc01e3b657cb12869f39f25a1b6
hovercard-subject-tagpull_request:4912805576
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9197/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary After a client disconnects, the ReadableStream's cancel() closes the controller, but start() kept enqueueing frames: the "Client cancelled request" error, final, [DONE], chun...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9197/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9197%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9197%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9197/files
Reloadhttps://github.com/simstudioai/sim/pull/9197/files
Reloadhttps://github.com/simstudioai/sim/pull/9197/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/workflow-stream-write-after-cancelhttps://github.com/simstudioai/sim/tree/fix/workflow-stream-write-after-cancel
Conversation 2 https://github.com/simstudioai/sim/pull/9197
Commits 1 https://github.com/simstudioai/sim/pull/9197/commits
Checks 52 https://github.com/simstudioai/sim/pull/9197/checks
Files changed https://github.com/simstudioai/sim/pull/9197/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9197/files
fix(streaming): stop writing workflow stream frames after the client cancels https://github.com/simstudioai/sim/pull/9197/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9197/files
a09fa56 fix(streaming): stop writing workflow stream frames after the client … waleedlatif1 Oct 18, 2026 https://github.com/simstudioai/sim/pull/9197/commits/a09fa5614fa0dd73127f51c1998982dcc930fd90
Clear filters https://github.com/simstudioai/sim/pull/9197/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9197/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9197/files
streaming.test.ts https://github.com/simstudioai/sim/pull/9197/files#diff-c0daf348fb52639cca4433db8b13baf0b85306a1cc2db586b889c2cca09a7799
streaming.ts https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
apps/sim/lib/workflows/streaming/streaming.test.tshttps://github.com/simstudioai/sim/pull/9197/files#diff-c0daf348fb52639cca4433db8b13baf0b85306a1cc2db586b889c2cca09a7799
View file https://github.com/simstudioai/sim/blob/a09fa5614fa0dd73127f51c1998982dcc930fd90/apps/sim/lib/workflows/streaming/streaming.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9197/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9197/files#diff-c0daf348fb52639cca4433db8b13baf0b85306a1cc2db586b889c2cca09a7799
https://github.com/simstudioai/sim/pull/9197/files#diff-c0daf348fb52639cca4433db8b13baf0b85306a1cc2db586b889c2cca09a7799
apps/sim/lib/workflows/streaming/streaming.tshttps://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
View file https://github.com/simstudioai/sim/blob/a09fa5614fa0dd73127f51c1998982dcc930fd90/apps/sim/lib/workflows/streaming/streaming.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9197/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
https://github.com/simstudioai/sim/pull/9197/files#diff-f3b2401e1b7d76c61900537218a4487d4f56435eb7cb4d8d18e502e0ed64ad64
Please reload this pagehttps://github.com/simstudioai/sim/pull/9197/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.